Improved malformed packet detection

RNS/Link.py

@@ -765,7 +765,7 @@ class Link:
             return plaintext
         except Exception as e:
             RNS.log("Decryption failed on link "+str(self)+". The contained exception was: "+str(e), RNS.LOG_ERROR)
-            RNS.log(traceback.format_exc(), RNS.LOG_ERROR)
+            # RNS.log(traceback.format_exc(), RNS.LOG_ERROR)
             # TODO: Think long about implications here
             # self.teardown()
 

RNS/Packet.py

@@ -185,6 +185,7 @@ class Packet:
 
 
     def unpack(self):
+        try:
             self.flags = self.raw[0]
             self.hops  = self.raw[1]
 
@@ -206,6 +207,11 @@ class Packet:
 
             self.packed = False
             self.update_hash()
+            return True
+
+        except Exception as e:
+            RNS.log("Received malformed packet, dropping it. The contained exception was: "+str(e), RNS.LOG_EXTREME)
+            return False
 
     def send(self):
         """

RNS/Transport.py

@@ -585,7 +585,9 @@ class Transport:
         Transport.jobs_locked = True
         
         packet = RNS.Packet(None, raw)
-        packet.unpack()
+        if not packet.unpack():
+            return
+            
         packet.receiving_interface = interface
         packet.hops += 1