Support remote syslogging (#971)

files/etc/config.mesh/system

@@ -3,6 +3,9 @@ config 'system'
         option 'timezone' '<time_zone>'
         option 'description' '<description_node>'
         option 'compat_version' '<compat_version>'
+        option 'log_ip' '<remote_log_ip>'
+        option 'log_port' '<remote_log_port>'
+        option 'log_proto' '<remote_log_proto>'
 
 config 'timeserver' 'ntp'
         list 'server'     '<ntp_server>'

files/usr/local/bin/node-setup

@@ -217,6 +217,20 @@ else
     cfg.lan_dhcp = 1
 end
 
+-- handle possible remote syslog
+local remote_log = c:get("aredn", "@remotelog[0]", "url") or ""
+local proto, ip, port = remote_log:match("^(.+)://(%d+%.%d+%.%d+%.%d+):(%d+)$")
+port = tonumber(port)
+if proto and (proto == "tcp" or proto == "udp") and (port > 0 and port < 65536) and validate_ip(ip) then
+    cfg.remote_log_ip = ip
+    cfg.remote_log_port = port
+    cfg.remote_log_proto = proto
+else
+    deleteme.remote_log_ip = true
+    deleteme.remote_log_port = true
+    deleteme.remote_log_proto = true
+end
+
 -- verify that we have all the variables we need
 for file in nixio.fs.glob("/etc/config.mesh/*")
 do

files/www/cgi-bin/advancedconfig

@@ -146,8 +146,8 @@ local settings = {
         type = "string",
         desc = "<b>Maximum packet size</b> in bytes sent over WiFi (256 to 1500)<br><br><small>aredn.@lqm[0].mtu</small>",
         default = "1500",
-        postcallback = "changeMTU()",
+        needreboot = true,
-        needreboot = true
+        nodesetup = true
     },
     {
         category = "Link Quality Settings",
@@ -171,8 +171,8 @@ local settings = {
         type = "boolean",
         desc = "<b>Allow other MESH nodes to use my WAN</b> - not recommended and OFF by default<br><br><small>aredn.@wan[0].olsrd_gw</small>",
         default = "0",
-        postcallback = "changeWANGW()",
+        needreboot = true,
-        needreboot = true
+        nodesetup = true
     },
     {
         category = "WAN Settings",
@@ -180,8 +180,8 @@ local settings = {
         type = "boolean",
         desc = "<b>Allow my LAN devices to access my WAN</b> - ON by default<br><br><small>aredn.@wan[0].lan_dhcp_route</small>",
         default = "1",
-        postcallback = "changeWANGW()",
+        needreboot = true,
-        needreboot = true
+        nodesetup = true
     },
     {
         category = "WAN Settings",
@@ -189,8 +189,8 @@ local settings = {
         type = "boolean",
         desc = "<b>Provide default route to LAN devices</b> even when WAN access is disabled<br><br><small>aredn.@wan[0].lan_dhcp_defaultroute</small>",
         default = "0",
-        postcallback = "changeWANGW()",
+        needreboot = true,
-        needreboot = true
+        nodesetup = true
     },
     {
         category = "WAN Settings",
@@ -201,7 +201,8 @@ local settings = {
         condition = "supportsVLANChange()",
         current = "currentWANVLAN()",
         postcallback = "changeWANVLAN()",
-        needreboot = true
+        needreboot = true,
+        nodesetup = true
     },
     {
         category = "WAN Settings",
@@ -316,6 +317,16 @@ local settings = {
         desc = "<b>IPERF Enable</b> allows the included iperf3 client/server<br><br><small>aredn.@iperf[0].enable</small>",
         default = "1"
     },
+    {
+        category = "Remote Logging",
+        key = "aredn.@remotelog[0].url",
+        type = "string",
+        desc = "<b>Remote logging URL</b> for the remote syslog machine. Must be formatted as <i>protocol://ipaddress:port</i><br><br><small>aredn.@remotelog[0].url</small>",
+        default = "",
+        needreboot = true,
+        nodesetup = true,
+        precallback = "validate_rsyslog()"
+    },
     {
         category = "Map Paths",
         key = "aredn.@map[0].maptiles",
@@ -751,15 +762,16 @@ function changeWANVLAN()
         end
         f:close()
     end
-    os.execute("/usr/local/bin/node-setup -a mesh")
 end
 
-function changeWANGW()
+function validate_rsyslog()
-    os.execute("/usr/local/bin/node-setup -a mesh")
+    if newval ~= "" then
-end
+        local proto, ip, port = newval:match("^(.+)://(%d+%.%d+%.%d+%.%d+):(%d+)$")
-
+        if not proto or not (proto == "tcp" or proto == "udp") then
-function changeMTU()
+            msg("Badly formatted remote logging URL")
-    os.execute("/usr/local/bin/node-setup -a mesh")
+            newval = ""
+        end
+    end
 end
 
 -- read_postdata
@@ -812,6 +824,9 @@ do
         if setting.postcallback then
             loadstring(setting.postcallback)()
         end
+        if setting.nodesetup then
+            os.execute("/usr/local/bin/node-setup -a mesh")
+        end
         if setting.needreboot then
             io.open("/tmp/reboot-required", "w"):close()
         end