From f4a776d1750c02004bd4151ccc13e6e98315ce58 Mon Sep 17 00:00:00 2001 From: mohanish2504 Date: Sun, 29 Oct 2023 19:27:25 +0530 Subject: [PATCH 1/2] adding: resource_fhir_test.go update: source_test.go moved test data creating to a common logic. --- backend/pkg/web/handler/resource_fhir_test.go | 149 ++++++++++++++++++ backend/pkg/web/handler/source_test.go | 46 ++++-- 2 files changed, 182 insertions(+), 13 deletions(-) create mode 100644 backend/pkg/web/handler/resource_fhir_test.go diff --git a/backend/pkg/web/handler/resource_fhir_test.go b/backend/pkg/web/handler/resource_fhir_test.go new file mode 100644 index 00000000..c6e7b198 --- /dev/null +++ b/backend/pkg/web/handler/resource_fhir_test.go @@ -0,0 +1,149 @@ +package handler + +import ( + "context" + "encoding/json" + "fmt" + "log" + + "net/http" + "net/http/httptest" + "os" + "testing" + + "github.com/fastenhealth/fasten-onprem/backend/pkg" + mock_config "github.com/fastenhealth/fasten-onprem/backend/pkg/config/mock" + "github.com/fastenhealth/fasten-onprem/backend/pkg/database" + "github.com/fastenhealth/fasten-onprem/backend/pkg/event_bus" + "github.com/fastenhealth/fasten-onprem/backend/pkg/models" + "github.com/google/uuid" + + "github.com/gin-gonic/gin" + "github.com/golang/mock/gomock" + "github.com/sirupsen/logrus" + "github.com/stretchr/testify/require" + "github.com/stretchr/testify/suite" +) + +type ResourcFhirHandlerTestSuite struct { + suite.Suite + MockCtrl *gomock.Controller + TestDatabase *os.File + + AppConfig *mock_config.MockInterface + AppRepository database.DatabaseRepository + AppEventBus event_bus.Interface + SourceId uuid.UUID +} + + +func (suite *ResourcFhirHandlerTestSuite) BeforeTest(suiteName string, testName string){ + suite.MockCtrl = gomock.NewController(suite.T()) + + // ioutils is deprecated, used os.CreateTemp + dbFile, err := os.CreateTemp("",fmt.Sprintf("%s.*.db",suiteName)) + if err!=nil { + log.Fatal(err) + } + suite.TestDatabase = dbFile + + appConfig := mock_config.NewMockInterface(suite.MockCtrl) + appConfig.EXPECT().GetString("database.location").Return(suite.TestDatabase.Name()).AnyTimes() + appConfig.EXPECT().GetString("database.type").Return("sqlite").AnyTimes() + appConfig.EXPECT().GetString("log.level").Return("INFO").AnyTimes() + suite.AppConfig = appConfig + + appRepo, err := database.NewRepository(suite.AppConfig,logrus.WithField("test",suite.T().Name()),event_bus.NewNoopEventBusServer()) + suite.AppRepository = appRepo + + suite.AppEventBus = event_bus.NewNoopEventBusServer() + appRepo.CreateUser(context.Background(),&models.User{ + Username: "test_user", + Password: "test", + }) + + //Pre adding the source data + w := httptest.NewRecorder() + ctx, _ := gin.CreateTestContext(w) + ctx.Set(pkg.ContextKeyTypeLogger, logrus.WithField("test", suite.T().Name())) + ctx.Set(pkg.ContextKeyTypeDatabase, suite.AppRepository) + ctx.Set(pkg.ContextKeyTypeConfig, suite.AppConfig) + ctx.Set(pkg.ContextKeyTypeEventBusServer, suite.AppEventBus) + ctx.Set(pkg.ContextKeyTypeAuthUsername, "test_user") + + req, err := CreateManualSourceHttpRequestFromFile("testdata/Tania553_Harris789_545c2380-b77f-4919-ab5d-0f615f877250.json") + require.NoError(suite.T(), err) + ctx.Request = req + + CreateManualSource(ctx) + //assert + require.Equal(suite.T(), http.StatusOK, w.Code) + type ResponseWrapper struct { + Success bool `json:"success"` + Source models.SourceCredential `json:"source"` + } + + var respWrapper ResponseWrapper + err = json.Unmarshal(w.Body.Bytes(), &respWrapper) + require.NoError(suite.T(), err) + + suite.SourceId = respWrapper.Source.ID +} + + +// AfterTest has a function to be executed right after the test finishes and receives the suite and test names as input +func (suite *ResourcFhirHandlerTestSuite) AfterTest(suiteName, testName string) { + suite.MockCtrl.Finish() + os.Remove(suite.TestDatabase.Name()) +} + +func TestResourceHandlerTestSuite(t *testing.T) { + suite.Run(t, new(ResourcFhirHandlerTestSuite)) +} + +func (suite *ResourcFhirHandlerTestSuite) TestGetResourceFhirHandler() { + w := httptest.NewRecorder() + ctx, _ := gin.CreateTestContext(w) + ctx.Set(pkg.ContextKeyTypeLogger, logrus.WithField("test", suite.T().Name())) + ctx.Set(pkg.ContextKeyTypeDatabase, suite.AppRepository) + ctx.Set(pkg.ContextKeyTypeConfig, suite.AppConfig) + ctx.Set(pkg.ContextKeyTypeEventBusServer, suite.AppEventBus) + ctx.Set(pkg.ContextKeyTypeAuthUsername, "test_user") + + ctx.AddParam("sourceId", suite.SourceId.String()) + ctx.AddParam("resourceId", "57959813-8cd2-4e3c-8970-e4364b74980a") + + GetResourceFhir(ctx) + + type ResponseWrapper struct { + Data *models.ResourceBase `json:"data"` + Success bool `json:"success"` + } + var respWrapper ResponseWrapper + err := json.Unmarshal(w.Body.Bytes(), &respWrapper) + require.NoError(suite.T(),err) + require.Equal(suite.T(),true,respWrapper.Success) + require.Equal(suite.T(),"Patient",respWrapper.Data.SourceResourceType) + require.Equal(suite.T(),suite.SourceId, respWrapper.Data.SourceID) + require.Equal(suite.T(),"57959813-8cd2-4e3c-8970-e4364b74980a", respWrapper.Data.SourceResourceID) + + // passing invalid sourceId & responseId + w.Body.Reset() + ctx.Params = []gin.Param { + { + Key: "sourceId", + Value: "57959813-9999-4e3c-8970-e4364b74980a", + }, + { + Key: "resourceId", + Value: "57959813-9999-4e3c-8970-e4364b74980a", + }, + } + + GetResourceFhir(ctx) + + err = json.Unmarshal(w.Body.Bytes(), &respWrapper) + require.NoError(suite.T(),err) + require.Equal(suite.T(),false,respWrapper.Success) +} + diff --git a/backend/pkg/web/handler/source_test.go b/backend/pkg/web/handler/source_test.go index d7a201da..1d114fbc 100644 --- a/backend/pkg/web/handler/source_test.go +++ b/backend/pkg/web/handler/source_test.go @@ -26,6 +26,9 @@ import ( "testing" ) +// Go through this page to understand how this file is structured. +// https://pkg.go.dev/github.com/stretchr/testify/suite#section-documentation + // Define the suite, and absorb the built-in basic suite // functionality from testify - including a T() method which // returns the current testing context @@ -73,6 +76,34 @@ func (suite *SourceHandlerTestSuite) AfterTest(suiteName, testName string) { os.Remove(suite.TestDatabase.Name()) } + +func CreateManualSourceHttpRequestFromFile(fileName string) (*http.Request, error) { + + file, err := os.Open(fileName) + if err!= nil { + log.Fatal("Could not open file ", err.Error()) + return nil, err + } + defer file.Close() + + + body := &bytes.Buffer{} + writer := multipart.NewWriter(body) + part, _ := writer.CreateFormFile("file", filepath.Base(file.Name())) + io.Copy(part, file) + writer.Close() + + + req, err := http.NewRequest("POST", "/source/manual", body) + if err!= nil { + log.Fatal("Could not make http request ", err.Error()) + return nil, err + } + req.Header.Add("Content-Type", writer.FormDataContentType()) + + return req, nil +} + // In order for 'go test' to run this suite, we need to create // a normal test function and pass our suite to suite.Run func TestSourceHandlerTestSuite(t *testing.T) { @@ -90,19 +121,8 @@ func (suite *SourceHandlerTestSuite) TestCreateManualSourceHandler() { ctx.Set(pkg.ContextKeyTypeAuthUsername, "test_username") //test - file, err := os.Open("testdata/Tania553_Harris789_545c2380-b77f-4919-ab5d-0f615f877250.json") - require.NoError(suite.T(), err) - defer file.Close() - - body := &bytes.Buffer{} - writer := multipart.NewWriter(body) - part, _ := writer.CreateFormFile("file", filepath.Base(file.Name())) - io.Copy(part, file) - writer.Close() - - req, err := http.NewRequest("POST", "/source/manual", body) - require.NoError(suite.T(), err) - req.Header.Add("Content-Type", writer.FormDataContentType()) + req, err := CreateManualSourceHttpRequestFromFile("testdata/Tania553_Harris789_545c2380-b77f-4919-ab5d-0f615f877250.json") + require.NoError(suite.T(),err) ctx.Request = req CreateManualSource(ctx) From ca450f57933f5991267ca5f2af203603977c06c6 Mon Sep 17 00:00:00 2001 From: mohanish2504 Date: Mon, 30 Oct 2023 23:30:37 +0530 Subject: [PATCH 2/2] update: sepated logic to hit invalid source,resource id during test case. --- backend/pkg/web/handler/resource_fhir_test.go | 38 +++++++++++-------- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/backend/pkg/web/handler/resource_fhir_test.go b/backend/pkg/web/handler/resource_fhir_test.go index c6e7b198..9b319fb6 100644 --- a/backend/pkg/web/handler/resource_fhir_test.go +++ b/backend/pkg/web/handler/resource_fhir_test.go @@ -127,23 +127,31 @@ func (suite *ResourcFhirHandlerTestSuite) TestGetResourceFhirHandler() { require.Equal(suite.T(),suite.SourceId, respWrapper.Data.SourceID) require.Equal(suite.T(),"57959813-8cd2-4e3c-8970-e4364b74980a", respWrapper.Data.SourceResourceID) - // passing invalid sourceId & responseId - w.Body.Reset() - ctx.Params = []gin.Param { - { - Key: "sourceId", - Value: "57959813-9999-4e3c-8970-e4364b74980a", - }, - { - Key: "resourceId", - Value: "57959813-9999-4e3c-8970-e4364b74980a", - }, - } +} + +func (suite *ResourcFhirHandlerTestSuite) TestGetResourceFhirHandler_WithInvalidSourceResourceId() { + w := httptest.NewRecorder() + ctx, _ := gin.CreateTestContext(w) + ctx.Set(pkg.ContextKeyTypeLogger, logrus.WithField("test", suite.T().Name())) + ctx.Set(pkg.ContextKeyTypeDatabase, suite.AppRepository) + ctx.Set(pkg.ContextKeyTypeConfig, suite.AppConfig) + ctx.Set(pkg.ContextKeyTypeEventBusServer, suite.AppEventBus) + ctx.Set(pkg.ContextKeyTypeAuthUsername, "test_user") + + ctx.AddParam("sourceId", "-1") + ctx.AddParam("resourceId", "57959813-9999-4e3c-8970-e4364b74980a") GetResourceFhir(ctx) - err = json.Unmarshal(w.Body.Bytes(), &respWrapper) + type ResponseWrapper struct { + Data *models.ResourceBase `json:"data"` + Success bool `json:"success"` + } + var respWrapper ResponseWrapper + err := json.Unmarshal(w.Body.Bytes(), &respWrapper) require.NoError(suite.T(),err) + require.Equal(suite.T(),false,respWrapper.Success) -} - + require.Nil(suite.T(),respWrapper.Data) + +} \ No newline at end of file