2018-11-28 18:46:30 -07:00
|
|
|
{{template "base/head" .}}
|
2023-02-01 15:56:10 -07:00
|
|
|
<div role="main" aria-label="{{.Title}}" class="page-content repository">
|
2018-11-28 18:46:30 -07:00
|
|
|
{{template "repo/header" .}}
|
|
|
|
|
<div class="ui container">
|
2021-05-20 15:53:55 -06:00
|
|
|
<div class="ui two column stackable grid">
|
2018-11-28 18:46:30 -07:00
|
|
|
<div class="column">
|
2021-03-20 03:36:52 -06:00
|
|
|
<h1>{{.Milestone.Name}}</h1>
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
2019-01-23 11:58:38 -07:00
|
|
|
{{if not .Repository.IsArchived}}
|
|
|
|
|
<div class="column right aligned">
|
2019-03-15 09:50:27 -06:00
|
|
|
{{if or .CanWriteIssues .CanWritePulls}}
|
2022-06-27 14:58:46 -06:00
|
|
|
<a class="ui button" href="{{.RepoLink}}/milestones/{{.MilestoneID}}/edit">{{.locale.Tr "repo.milestones.edit"}}</a>
|
2019-03-15 09:50:27 -06:00
|
|
|
{{end}}
|
2022-06-27 14:58:46 -06:00
|
|
|
<a class="ui primary button" href="{{.RepoLink}}/issues/new{{if .NewIssueChooseTemplate}}/choose{{end}}?milestone={{.MilestoneID}}">{{.locale.Tr "repo.issues.new"}}</a>
|
2019-01-23 11:58:38 -07:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
2021-05-20 15:53:55 -06:00
|
|
|
<div class="ui one column stackable grid">
|
|
|
|
|
<div class="column markup content">
|
|
|
|
|
{{.Milestone.RenderedContent|Str2html}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2021-04-10 21:46:37 -06:00
|
|
|
<div class="ui one column stackable grid">
|
|
|
|
|
<div class="column">
|
2022-08-31 09:58:54 -06:00
|
|
|
{{$closedDate:= TimeSinceUnix .Milestone.ClosedDateUnix $.locale}}
|
2021-04-10 21:46:37 -06:00
|
|
|
{{if .IsClosed}}
|
2022-06-27 14:58:46 -06:00
|
|
|
{{svg "octicon-clock"}} {{$.locale.Tr "repo.milestones.closed" $closedDate|Str2html}}
|
2021-04-10 21:46:37 -06:00
|
|
|
{{else}}
|
2020-09-11 14:19:00 -06:00
|
|
|
{{svg "octicon-calendar"}}
|
2021-04-10 21:46:37 -06:00
|
|
|
{{if .Milestone.DeadlineString}}
|
|
|
|
|
<span {{if .IsOverdue}}class="overdue"{{end}}>{{.Milestone.DeadlineString}}</span>
|
|
|
|
|
{{else}}
|
2022-06-27 14:58:46 -06:00
|
|
|
{{$.locale.Tr "repo.milestones.no_due_date"}}
|
2021-04-10 21:46:37 -06:00
|
|
|
{{end}}
|
|
|
|
|
{{end}}
|
|
|
|
|
|
2022-06-27 14:58:46 -06:00
|
|
|
<b>{{.locale.Tr "repo.milestones.completeness" .Milestone.Completeness}}</b>
|
2021-04-10 21:46:37 -06:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2018-11-28 18:46:30 -07:00
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
<div id="issue-filters" class="ui stackable grid">
|
|
|
|
|
<div class="six wide column">
|
2020-11-29 08:52:11 -07:00
|
|
|
{{template "repo/issue/openclose" .}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
<div class="ten wide right aligned column">
|
2019-10-29 14:50:38 -06:00
|
|
|
<div class="ui secondary filter stackable menu labels">
|
2018-11-28 18:46:30 -07:00
|
|
|
<!-- Label -->
|
2019-10-29 14:50:38 -06:00
|
|
|
<div class="ui {{if not .Labels}}disabled{{end}} dropdown jump item label-filter" style="margin-left: auto">
|
2018-11-28 18:46:30 -07:00
|
|
|
<span class="text">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.filter_label"}}
|
2020-10-31 16:15:11 -06:00
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
2022-09-22 23:23:24 -06:00
|
|
|
<div class="ui icon search input">
|
2023-02-13 10:59:59 -07:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-10-10 08:05:32 -06:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_label"}}">
|
2022-09-22 23:23:24 -06:00
|
|
|
</div>
|
2022-06-27 14:58:46 -06:00
|
|
|
<span class="info">{{.locale.Tr "repo.issues.filter_label_exclude" | Safe}}</span>
|
2022-08-08 14:03:58 -06:00
|
|
|
<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_label_no_select"}}</a>
|
2018-11-28 18:46:30 -07:00
|
|
|
{{range .Labels}}
|
2023-03-05 14:59:05 -07:00
|
|
|
<a class="item label-filter-item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.QueryString}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}" data-label-id="{{.ID}}">{{if .IsExcluded}}{{svg "octicon-circle-slash"}}{{else if contain $.SelLabelIDs .ID}}{{svg "octicon-check"}}{{end}} {{RenderLabel $.Context .}}</a>
|
2022-08-08 14:03:58 -06:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
|
|
|
|
|
<!-- Author -->
|
|
|
|
|
<div class="ui {{if not .Posters}}disabled{{end}} dropdown jump item">
|
|
|
|
|
<span class="text">
|
|
|
|
|
{{.locale.Tr "repo.issues.filter_poster"}}
|
|
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
|
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
|
|
|
|
<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}">{{.locale.Tr "repo.issues.filter_poster_no_select"}}</a>
|
|
|
|
|
{{range .Posters}}
|
|
|
|
|
<a class="{{if eq $.PosterID .ID}}active selected{{end}} item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{.ID}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 06:37:34 -07:00
|
|
|
{{avatar $.Context .}} {{.GetDisplayName}}
|
2022-08-08 14:03:58 -06:00
|
|
|
</a>
|
2018-11-28 18:46:30 -07:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
|
|
|
|
|
<!-- Assignee -->
|
|
|
|
|
<div class="ui {{if not .Assignees}}disabled{{end}} dropdown jump item">
|
|
|
|
|
<span class="text">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.filter_assignee"}}
|
2020-10-31 16:15:11 -06:00
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
2022-09-22 23:23:24 -06:00
|
|
|
<div class="ui icon search input">
|
2023-02-13 10:59:59 -07:00
|
|
|
<i class="icon gt-df gt-ac gt-jc">{{svg "octicon-search" 16}}</i>
|
2022-10-10 08:05:32 -06:00
|
|
|
<input type="text" placeholder="{{.locale.Tr "repo.issues.filter_assignee"}}">
|
2022-09-22 23:23:24 -06:00
|
|
|
</div>
|
2022-08-08 14:03:58 -06:00
|
|
|
<a class="item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_assginee_no_select"}}</a>
|
2018-11-28 18:46:30 -07:00
|
|
|
{{range .Assignees}}
|
2022-08-08 14:03:58 -06:00
|
|
|
<a class="{{if eq $.AssigneeID .ID}}active selected{{end}} item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&labels={{$.SelectLabels}}&assignee={{.ID}}&poster={{$.PosterID}}">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 06:37:34 -07:00
|
|
|
{{avatar $.Context . 28 "gt-mr-2"}}
|
2020-12-03 11:46:11 -07:00
|
|
|
{{.GetDisplayName}}
|
|
|
|
|
</a>
|
2018-11-28 18:46:30 -07:00
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
|
|
|
|
|
{{if .IsSigned}}
|
|
|
|
|
<!-- Type -->
|
|
|
|
|
<div class="ui dropdown type jump item">
|
|
|
|
|
<span class="text">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.filter_type"}}
|
2020-10-31 16:15:11 -06:00
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
2022-12-09 06:34:51 -07:00
|
|
|
<a class="{{if eq .ViewType "all"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=all&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.all_issues"}}</a>
|
|
|
|
|
<a class="{{if eq .ViewType "assigned"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=assigned&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.assigned_to_you"}}</a>
|
|
|
|
|
<a class="{{if eq .ViewType "created_by"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=created_by&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.created_by_you"}}</a>
|
|
|
|
|
<a class="{{if eq .ViewType "review_requested"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=review_requested&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.review_requested"}}</a>
|
2023-02-24 19:55:50 -07:00
|
|
|
<a class="{{if eq .ViewType "reviewed_by"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=reviewed_by&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.reviewed_by_you"}}</a>
|
|
|
|
|
<a class="{{if eq .ViewType "mentioned"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=mentioned&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.mentioning_you"}}</a>
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
|
|
|
|
|
<!-- Sort -->
|
|
|
|
|
<div class="ui dropdown type jump item">
|
|
|
|
|
<span class="text">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.filter_sort"}}
|
2020-10-31 16:15:11 -06:00
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
2022-12-09 06:34:51 -07:00
|
|
|
<a class="{{if or (eq .SortType "latest") (not .SortType)}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=latest&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a>
|
|
|
|
|
<a class="{{if eq .SortType "oldest"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=oldest&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a>
|
|
|
|
|
<a class="{{if eq .SortType "recentupdate"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=recentupdate&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.recentupdate"}}</a>
|
|
|
|
|
<a class="{{if eq .SortType "leastupdate"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=leastupdate&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.leastupdate"}}</a>
|
|
|
|
|
<a class="{{if eq .SortType "mostcomment"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=mostcomment&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.mostcomment"}}</a>
|
|
|
|
|
<a class="{{if eq .SortType "leastcomment"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=leastcomment&state={{$.State}}&labels={{.SelectLabels}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.leastcomment"}}</a>
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2023-02-18 21:06:14 -07:00
|
|
|
<div id="issue-actions" class="ui stackable grid gt-hidden">
|
2018-11-28 18:46:30 -07:00
|
|
|
<div class="six wide column">
|
2020-11-29 08:52:11 -07:00
|
|
|
{{template "repo/issue/openclose" .}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
|
|
|
|
|
{{/* Ten wide does not cope well and makes the columns stack.
|
|
|
|
|
This seems to be related to jQuery's hide/show: in fact, switching
|
|
|
|
|
issue-actions and issue-filters and having this ten wide will show
|
|
|
|
|
this one correctly, but not the other one. */}}
|
|
|
|
|
<div class="nine wide right aligned right floated column">
|
|
|
|
|
<div class="ui secondary filter stackable menu">
|
2019-03-15 09:50:27 -06:00
|
|
|
<!-- Action Button -->
|
|
|
|
|
{{if .IsShowClosed}}
|
2022-06-27 14:58:46 -06:00
|
|
|
<div class="ui green active basic button issue-action" data-action="open" data-url="{{$.RepoLink}}/issues/status" style="margin-left: auto">{{.locale.Tr "repo.issues.action_open"}}</div>
|
2019-03-15 09:50:27 -06:00
|
|
|
{{else}}
|
2022-06-27 14:58:46 -06:00
|
|
|
<div class="ui red active basic button issue-action" data-action="close" data-url="{{$.RepoLink}}/issues/status" style="margin-left: auto">{{.locale.Tr "repo.issues.action_close"}}</div>
|
2019-03-15 09:50:27 -06:00
|
|
|
{{end}}
|
2018-11-28 18:46:30 -07:00
|
|
|
<!-- Labels -->
|
2019-03-15 09:50:27 -06:00
|
|
|
<div class="ui {{if not .Labels}}disabled{{end}} dropdown jump item">
|
2018-11-28 18:46:30 -07:00
|
|
|
<span class="text">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.action_label"}}
|
2020-10-31 16:15:11 -06:00
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
|
|
|
|
{{range .Labels}}
|
2020-05-01 11:58:45 -06:00
|
|
|
<div class="item issue-action" data-action="toggle" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/labels">
|
2023-03-05 14:59:05 -07:00
|
|
|
{{if contain $.SelLabelIDs .ID}}{{svg "octicon-check"}}{{end}} {{RenderLabel $.Context .}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
|
|
|
|
|
<!-- Assignees -->
|
|
|
|
|
<div class="ui {{if not .Assignees}}disabled{{end}} dropdown jump item">
|
|
|
|
|
<span class="text">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.action_assignee"}}
|
2020-10-31 16:15:11 -06:00
|
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</span>
|
|
|
|
|
<div class="menu">
|
|
|
|
|
<div class="item issue-action" data-element-id="0" data-url="{{$.Link}}/assignee">
|
2022-06-27 14:58:46 -06:00
|
|
|
{{.locale.Tr "repo.issues.action_assignee_no_select"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
{{range .Assignees}}
|
|
|
|
|
<div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/assignee">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 06:37:34 -07:00
|
|
|
{{avatar $.Context . 28 "gt-mr-2"}}
|
2020-12-03 11:46:11 -07:00
|
|
|
{{.GetDisplayName}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
{{end}}
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
2020-11-25 04:20:40 -07:00
|
|
|
{{template "shared/issuelist" mergeinto . "listType" "milestone"}}
|
2018-11-28 18:46:30 -07:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
{{template "base/footer" .}}
|