Don't return 500 if mirror url contains special chars (#31859) (#31895)

Backport #31859
This commit is contained in:
Lunny Xiao 2024-08-22 00:10:50 +08:00 committed by GitHub
parent d9c65c9a52
commit e060ae88e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions

View File

@ -248,7 +248,8 @@ func SettingsPost(ctx *context.Context) {
remoteAddress, err := util.SanitizeURL(form.MirrorAddress) remoteAddress, err := util.SanitizeURL(form.MirrorAddress)
if err != nil { if err != nil {
ctx.ServerError("SanitizeURL", err) ctx.Data["Err_MirrorAddress"] = true
handleSettingRemoteAddrError(ctx, err, form)
return return
} }
pullMirror.RemoteAddress = remoteAddress pullMirror.RemoteAddress = remoteAddress
@ -409,7 +410,8 @@ func SettingsPost(ctx *context.Context) {
remoteAddress, err := util.SanitizeURL(form.PushMirrorAddress) remoteAddress, err := util.SanitizeURL(form.PushMirrorAddress)
if err != nil { if err != nil {
ctx.ServerError("SanitizeURL", err) ctx.Data["Err_PushMirrorAddress"] = true
handleSettingRemoteAddrError(ctx, err, form)
return return
} }