mirror of https://github.com/go-gitea/gitea.git
Add result check in TestAPIEditUser (#29674)
Fix #29514 There are too many usage of `NewRequestWithValues`, so there's no need to check all of them. Just one is enough I think.
This commit is contained in:
parent
bb0e4ce581
commit
ecd1d96f49
|
@ -195,14 +195,17 @@ func TestAPIEditUser(t *testing.T) {
|
||||||
token := getUserToken(t, adminUsername, auth_model.AccessTokenScopeWriteAdmin)
|
token := getUserToken(t, adminUsername, auth_model.AccessTokenScopeWriteAdmin)
|
||||||
urlStr := fmt.Sprintf("/api/v1/admin/users/%s", "user2")
|
urlStr := fmt.Sprintf("/api/v1/admin/users/%s", "user2")
|
||||||
|
|
||||||
|
fullNameToChange := "Full Name User 2"
|
||||||
req := NewRequestWithValues(t, "PATCH", urlStr, map[string]string{
|
req := NewRequestWithValues(t, "PATCH", urlStr, map[string]string{
|
||||||
// required
|
// required
|
||||||
"login_name": "user2",
|
"login_name": "user2",
|
||||||
"source_id": "0",
|
"source_id": "0",
|
||||||
// to change
|
// to change
|
||||||
"full_name": "Full Name User 2",
|
"full_name": fullNameToChange,
|
||||||
}).AddTokenAuth(token)
|
}).AddTokenAuth(token)
|
||||||
MakeRequest(t, req, http.StatusOK)
|
MakeRequest(t, req, http.StatusOK)
|
||||||
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{LoginName: "user2"})
|
||||||
|
assert.Equal(t, fullNameToChange, user2.FullName)
|
||||||
|
|
||||||
empty := ""
|
empty := ""
|
||||||
req = NewRequestWithJSON(t, "PATCH", urlStr, api.EditUserOption{
|
req = NewRequestWithJSON(t, "PATCH", urlStr, api.EditUserOption{
|
||||||
|
@ -216,7 +219,7 @@ func TestAPIEditUser(t *testing.T) {
|
||||||
json.Unmarshal(resp.Body.Bytes(), &errMap)
|
json.Unmarshal(resp.Body.Bytes(), &errMap)
|
||||||
assert.EqualValues(t, "e-mail invalid [email: ]", errMap["message"].(string))
|
assert.EqualValues(t, "e-mail invalid [email: ]", errMap["message"].(string))
|
||||||
|
|
||||||
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{LoginName: "user2"})
|
user2 = unittest.AssertExistsAndLoadBean(t, &user_model.User{LoginName: "user2"})
|
||||||
assert.False(t, user2.IsRestricted)
|
assert.False(t, user2.IsRestricted)
|
||||||
bTrue := true
|
bTrue := true
|
||||||
req = NewRequestWithJSON(t, "PATCH", urlStr, api.EditUserOption{
|
req = NewRequestWithJSON(t, "PATCH", urlStr, api.EditUserOption{
|
||||||
|
|
Loading…
Reference in New Issue