Regression in 356854fc5f, where
a log.Fatal call was removed. log.Fatal calls os.Exit(1) as intended,
but without it the fail() function returns normally and execution
continues past the fatal error, causing a panic.
This is visible as a go panic log and stack trace returned to the SSH
client, which is not only ugly, it leaks server and build system
information.
Fix by removing the stray return statement so that the fail() function
always calls os.Exit(1).
Backport: 2186a99c76
Fixes: https://github.com/go-gitea/gitea/issues/7457
Signed-off-by: Allen Wild <allenwild93@gmail.com>
* only return head: null if source branch was deleted
* add URL into GetPullRequest
* TestPullRequest_APIFormat
* log error if it is not Err(Branch)NotExist
(cherry picked from commit ff85a6331e)
* issue view - fix icon position
- move style from template to css
- add bullets to: key, circle-slash, comment
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* add border to symbols
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* fix circle slash position
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* fix top margin
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* changed mixed space/tab indent to tabindent only
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* cut timeline length with last element on issue view
fix#7304
- lightly enlight dark theme issue timeline color
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* remove new container
Signed-off-by: Michael Gnehr <michael@gnehr.de>
Previously, only the first return value of ctx.GetSuperSecureCookie
was used to check whether decryption of the auth cookie succeeded.
ctx.GetSuperSecureCookie also returns a second value, a boolean,
indicating success or not. That value should be checked first to
be on the safe side and not rely on internal logic of the encryption
and decryption blackbox.
* workaround broken swagger
only master brach is not working, latest release seems to work
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* make vendor
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* Don't export GO111MODULE
* set go-swagger to fixed release version
mentioned here: https://github.com/go-gitea/gitea/pull/7362#discussion_r300831537
Signed-off-by: Michael Gnehr <michael@gnehr.de>
- ran `make npm-update`
- ran `make js`, fixed new lint issue
- ran `make css`, this added back some vendor prefixes
- added `engines` property to package.json to specify minimum required
Node.js version
- added `private` property to package.json to prevent accidential
publishing to npm
* Experimental support for git commit graph files and bloom filter index
Signed-off-by: Filip Navara <filip.navara@gmail.com>
* Force vendor of commitgraph
Signed-off-by: Filip Navara <filip.navara@gmail.com>
* Remove bloom filter experiment and debug prints
* Remove old code for building commit graphs
* Remove unused function
* Remove mmap usage
* gofmt
* sort vendor/modules.txt
* Add copyright header and log commit-graph error
* Fix#6946 by checking PullRequest ID on pushing
* Ensure we have the owner name, the pr attributes and the the issue
* Fix TestSearchRepo by waiting till indexing is done
* Update integrations/repo_search_test.go
* changes as per @mrsdizzie
* missing comma
* Spelling mistake
* Fix full pushing environment
* chore: update drone format to 1.0
* Converted old drone config
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Moved translations to seperate pipeline
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Split the steps in multiple pipelines and add dependencies
Signed-off-by: konrad <konrad@kola-entertainments.de>
* format
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed step depenednecies
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed discord notify
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Exclude translations and docs pipelines from prs
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed exclude prs
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed exclude prs
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Moved releases to seperate pipeline
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Re-trigger drone
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Disable release step
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed depending step
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Adopted dependencies
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Changed pipeline conditions
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Replaced pipeline conditions with triggers
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed coverage step
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Import changes from #7331
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Add comment for lowest go version
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Exclude fetch-tags from prs
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Re-added comment about no tags
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Removed unneeded conditions
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Moved release version and release latest to different pipelines
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Fixed depending pipeline
Signed-off-by: konrad <konrad@kola-entertainments.de>
* Removed the conditions for all services
Signed-off-by: konrad <konrad@kola-entertainments.de>
* - do not select if escape is pressed
- allow prefixes by adding current request content to result list
- remove html-tags before insert on page
fix#7126
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* sort current query to top
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* remove already added topics from dropdown list
Signed-off-by: Michael Gnehr <michael@gnehr.de>
* protoct against xss
thanks to @silverwind
Signed-off-by: Michael Gnehr <michael@gnehr.de>
Allen Wild