Mirrors
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gitea/routers/web/repo
History
Jason Song acd7053e9d
Avoid returning without written ctx when posting PR (#31843) 
Fix #31625.

If `pull_service.NewPullRequest` return an error which misses each `if`
check, `CompareAndPullRequestPost` will return immediately, since it
doesn't write the HTTP response, a 200 response with empty body will be
sent to clients.

```go
	if err := pull_service.NewPullRequest(ctx, repo, pullIssue, labelIDs, attachments, pullRequest, assigneeIDs); err != nil {
		if repo_model.IsErrUserDoesNotHaveAccessToRepo(err) {
			ctx.Error(http.StatusBadRequest, "UserDoesNotHaveAccessToRepo", err.Error())
		} else if git.IsErrPushRejected(err) {
			// ...
			ctx.JSONError(flashError)
		} else if errors.Is(err, user_model.ErrBlockedUser) {
			// ...
			ctx.JSONError(flashError)
		} else if errors.Is(err, issues_model.ErrMustCollaborator) {
			// ...
			ctx.JSONError(flashError)
		}
		return
	}
```

Not sure what kind of error can cause it to happen, so this PR just
expose it. And we can fix it when users report that creating PRs failed
with error responses.

It's all my guess since I cannot reproduce the problem, but even if it's
not related, the code here needs to be improved.
 		2024-08-16 17:04:54 +00:00
..
actions Show latest run when visit /run/latest (#31808) 2024-08-10 08:40:41 +08:00
setting Show lock owner instead of repo owner on LFS setting page (#31788) 2024-08-11 14:48:20 +00:00
activity.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
attachment.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
blame.go Improve detecting empty files (#31332) 2024-06-13 01:06:46 +00:00
branch.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
cherry_pick.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
code_frequency.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
commit.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
compare.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
contributors.go Fix Activity Page Contributors dropdown (#31264) 2024-06-06 10:28:33 +08:00
download.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
editor.go Add missed return after `ctx.ServerError` (#31130) 2024-05-28 12:31:59 +03:00
editor_test.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
find.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
fork.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
githttp.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
helper.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
issue.go Support issue template assignees (#31083) 2024-08-12 16:00:40 +08:00
issue_content_history.go Remove unnecessary inline style for tab-size (#31224) 2024-06-03 17:21:45 +00:00
issue_dependency.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
issue_label.go Refactor label.IsArchived() (#29750) 2024-03-13 07:04:07 +01:00
issue_label_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_lock.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_pin.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
issue_watch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
migrate.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
milestone.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
packages.go Remove AddParamIfExist(AddParam) (#29841) 2024-03-16 12:07:56 +00:00
patch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
projects.go Add issue comment when moving issues from one column to another of the project (#29311) 2024-08-09 01:29:02 +00:00
projects_test.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
pull.go Avoid returning without written ctx when posting PR (#31843) 2024-08-16 17:04:54 +00:00
pull_review.go Prevent allow/reject reviews on merged/closed PRs (#30686) 2024-04-27 11:55:03 +00:00
pull_review_test.go Fix template error when comment review doesn't exist (#29888) 2024-03-19 04:19:48 +00:00
recent_commits.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
release_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
render.go Fix rendered wiki page link (#31398) 2024-06-18 03:09:20 +00:00
repo.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
search.go Improve grep search (#30843) 2024-05-03 09:13:48 +00:00
search_test.go Improve grep search (#30843) 2024-05-03 09:13:48 +00:00
topic.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
treelist.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
view.go render plain text file if the LFS object doesn't exist (#31812) 2024-08-15 05:50:09 +08:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Fix raw wiki links (#31825) 2024-08-16 20:40:51 +08:00
wiki_test.go Fix raw wiki links (#31825) 2024-08-16 20:40:51 +08:00