gitea/models
zeripath 596eebb2b6
Protect against NPEs in notifications list (#10879) (#10883)
* Protect against NPEs in notifications list (#10879)

Unfortunately there appears to be potential race with notifications
being set before the associated issue has been committed.

This PR adds protection in to the notifications list to log any failures
and remove these notifications from the display.

References #10815 - and prevents the panic but does not completely fix
this.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* add log import

* Update models/notification.go

Co-Authored-By: Lauris BH <lauris@nix.lv>

Co-authored-by: Lauris BH <lauris@nix.lv>
2020-03-30 15:23:02 +08:00
..
fixtures Only serve attachments when linked to issue/release and if accessible by user (#9340) 2020-01-05 01:20:08 +02:00
migrations Fix migration bug on v96.go (#10572) (#10573) 2020-03-02 10:32:20 -06:00
access.go
access_test.go
action.go Fix potential bugs (#10513) (#10518) 2020-02-28 00:12:23 -03:00
action_list.go
action_test.go Move UpdateIssuesCommit from models to repofiles (#9276) 2019-12-07 23:52:36 +08:00
admin.go
admin_test.go
attachment.go Fix potential bugs (#10513) (#10518) 2020-02-28 00:12:23 -03:00
attachment_test.go Reading pull attachments should depend on read UnitTypePullRequests (#10346) (#10354) 2020-02-18 21:02:50 -06:00
branches.go Fix bug on branch API (#10767) (#10775) 2020-03-20 23:31:01 +02:00
branches_test.go
commit_status.go Fix wrong hint when status checking is running on pull request view (#9886) (#9928) 2020-01-22 08:06:11 +02:00
commit_status_test.go Fix wrong hint when status checking is running on pull request view (#9886) (#9928) 2020-01-22 08:06:11 +02:00
consistency.go Auto-subscribe user to repository when they commit/tag to it (#7657) 2019-11-10 09:22:19 +00:00
context.go Move all mail related codes from models to services/mailer (#7200) 2019-09-24 13:02:49 +08:00
convert.go
error.go account for empty lines in receive-hook message (#10773) (#10784) 2020-03-21 10:49:02 +08:00
error_oauth2.go
external_login_user.go
gpg_key.go Show Signer in commit lists and add basic trust (#10425) (#10524) 2020-02-28 14:18:02 -03:00
gpg_key_test.go
helper.go
helper_directory.go Remove SavePatch and generate patches on the fly (#9302) 2019-12-13 23:21:06 +01:00
helper_environment.go Properly enforce gitea environment for pushes (#9501) 2019-12-27 21:15:04 +00:00
issue.go Fix wrong num closed issues on repository when close issue via commit (#10364) (#10380) 2020-02-20 15:52:19 +01:00
issue_assignees.go remove unused method and rename createcommentWithNoAction (#9367) 2019-12-16 11:54:24 +08:00
issue_assignees_test.go Fix API Bug (fail on empty assignees) (#8873) 2019-11-10 16:07:21 +08:00
issue_comment.go Fix potential bugs (#10513) (#10518) 2020-02-28 00:12:23 -03:00
issue_comment_list.go Fixed repo link in generated comment for cross repository dependency (#9863) (#9935) 2020-01-22 12:54:40 +02:00
issue_comment_test.go
issue_dependency.go
issue_dependency_test.go Refactor comment (#9330) 2019-12-15 16:57:34 -05:00
issue_label.go remove unused method and rename createcommentWithNoAction (#9367) 2019-12-16 11:54:24 +08:00
issue_label_test.go
issue_list.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_list_test.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_lock.go remove unused method and rename createcommentWithNoAction (#9367) 2019-12-16 11:54:24 +08:00
issue_milestone.go Fix milestone API state parameter unhandled (#10049) (#10052) 2020-01-29 18:01:44 +02:00
issue_milestone_test.go Fix milestone API state parameter unhandled (#10049) (#10052) 2020-01-29 18:01:44 +02:00
issue_reaction.go [API] Fix 9544 | return 200 when reaction already exist (#9550) 2019-12-31 03:21:21 -05:00
issue_reaction_test.go [API] Fix 9544 | return 200 when reaction already exist (#9550) 2019-12-31 03:21:21 -05:00
issue_stopwatch.go [API] extend StopWatch (#9196) 2019-12-11 23:23:05 -05:00
issue_stopwatch_test.go
issue_test.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_tracked_time.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_tracked_time_test.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_user.go Mail assignee when issue/pull request is assigned (#8546) 2019-10-25 22:46:37 +08:00
issue_user_test.go
issue_watch.go [BugFix] Avoid mailing explicit unwatched (#10475) (#10500) 2020-02-27 11:42:51 -06:00
issue_watch_test.go Fix Issue Unsubscription (#9634) 2020-01-07 15:41:35 +00:00
issue_xref.go remove unused method and rename createcommentWithNoAction (#9367) 2019-12-16 11:54:24 +08:00
issue_xref_test.go Refactor comment (#9330) 2019-12-15 16:57:34 -05:00
lfs.go Add basic repository lfs management (#7199) 2019-10-28 18:31:55 +00:00
lfs_lock.go Make repository management section handle lfs locks (#8726) 2019-12-12 21:18:07 +08:00
log.go
login_source.go Various fixes in login sources (#10428) (#10429) 2020-02-23 22:46:17 +02:00
main_test.go
migrate.go
models.go Divide GetIssueStats query in smaller chunks (#10176) (#10282) 2020-02-15 19:07:09 +02:00
models_test.go
notification.go Protect against NPEs in notifications list (#10879) (#10883) 2020-03-30 15:23:02 +08:00
notification_test.go Improve notification (#8835) 2019-11-12 16:33:34 +08:00
oauth2.go
oauth2_application.go
oauth2_application_test.go
org.go Only show part of members on orgnization dashboard and add paging for orgnization members page (#9092) 2019-12-06 13:34:54 +08:00
org_team.go Branch protection: Possibility to not use whitelist but allow anyone with write access (#9055) 2019-12-03 20:08:56 -05:00
org_team_test.go Various fixes in login sources (#10428) (#10429) 2020-02-23 22:46:17 +02:00
org_test.go Only show part of members on orgnization dashboard and add paging for orgnization members page (#9092) 2019-12-06 13:34:54 +08:00
pull.go Repo name added to automatically generated commit message when mergin… (#9997) (#10285) 2020-02-15 21:17:01 +00:00
pull_list.go Graceful: Xorm, RepoIndexer, Cron and Others (#9282) 2019-12-15 09:51:28 +00:00
pull_sign.go Sign protected branches (#8993) 2019-12-15 11:06:31 +00:00
pull_test.go Move PushToBaseRepo from models to services/pull (#9352) 2019-12-15 04:28:51 +01:00
release.go Move some repository methods from models to modules/repository (#9353) 2019-12-14 18:30:01 +01:00
repo.go Delete dependencies when deleting a repository (#10608) (#10616) 2020-03-05 13:56:53 +00:00
repo_activity.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repo_branch.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repo_collaboration.go Show Signer in commit lists and add basic trust (#10425) (#10524) 2020-02-28 14:18:02 -03:00
repo_collaboration_test.go
repo_generate.go Fix nil reference in repo generation (#9660) (#9666) 2020-01-09 16:50:21 +00:00
repo_generate_test.go Variable expansion in repository templates (#9163) 2019-11-30 01:54:47 -05:00
repo_indexer.go Graceful: Xorm, RepoIndexer, Cron and Others (#9282) 2019-12-15 09:51:28 +00:00
repo_issue.go
repo_list.go Ensure that feeds are appropriately restricted (#10018) (#10019) 2020-01-28 23:54:09 +02:00
repo_list_test.go [BugFix] Hide public repos owned by private orgs (#9609) 2020-01-05 18:48:47 +00:00
repo_mirror.go Move some repository methods from models to modules/repository (#9353) 2019-12-14 18:30:01 +01:00
repo_permission.go Fix access issues on milestone and issue overview pages. (#9603) 2020-01-04 20:23:29 -05:00
repo_permission_test.go
repo_redirect.go Move repoWorkPool outside rename/transfer repository (#9086) 2019-12-06 12:00:50 +08:00
repo_redirect_test.go Move repoWorkPool outside rename/transfer repository (#9086) 2019-12-06 12:00:50 +08:00
repo_sign.go Sign protected branches (#8993) 2019-12-15 11:06:31 +00:00
repo_test.go Fix team links in HTML rendering (#9127) 2019-11-24 11:34:44 -05:00
repo_unit.go
repo_watch.go Batch hook pre- and post-receive calls (#8602) 2019-12-26 13:29:45 +02:00
repo_watch_test.go Auto-subscribe user to repository when they commit/tag to it (#7657) 2019-11-10 09:22:19 +00:00
review.go Provide Default messages for merges (#9393) 2019-12-30 18:34:11 -05:00
review_test.go Branch protection: Possibility to not use whitelist but allow anyone with write access (#9055) 2019-12-03 20:08:56 -05:00
ssh_key.go Fix SSH2 conditonal in key parsing code (#8806) 2019-11-03 19:08:18 +08:00
ssh_key_test.go Fix SSH2 conditonal in key parsing code (#8806) 2019-11-03 19:08:18 +08:00
star.go
star_test.go
task.go Hide given credentials for migrated repos. (#9097) 2019-11-20 13:01:09 -05:00
test_fixtures.go Testing: Update postgres sequences (#9304) 2019-12-10 07:49:05 +00:00
token.go
token_test.go
topic.go Update topics repo count when deleting repository (#10081) 2020-01-31 08:04:49 +00:00
topic_test.go
twofactor.go
u2f.go
u2f_test.go
unit.go
unit_tests.go Fix SQLite concurrency problems by using BEGIN IMMEDIATE (#10368) (#10493) 2020-02-26 23:30:57 -03:00
update.go Properly enforce gitea environment for pushes (#9501) 2019-12-27 21:15:04 +00:00
update_test.go
upload.go
user.go Show the username as a fallback on feeds if full name is blank (#10461) 2020-02-26 20:59:07 -05:00
user_follow.go
user_follow_test.go
user_heatmap.go
user_heatmap_test.go Update heatmap fixtures to restore tests (#8615) 2019-10-21 21:19:53 +01:00
user_mail.go Admin page for managing user e-mail activation (#10557) (#10579) 2020-03-02 17:09:37 -03:00
user_mail_test.go Admin page for managing user e-mail activation (#10557) (#10579) 2020-03-02 17:09:37 -03:00
user_openid.go
user_openid_test.go
user_test.go Team permission to create repository in organization (#8312) 2019-11-20 19:27:49 +08:00
userlist.go Add API for Issue set Subscription (#8729) 2019-11-02 23:27:49 +08:00
userlist_test.go Team permission to create repository in organization (#8312) 2019-11-20 19:27:49 +08:00
webhook.go Move more webhook codes from models to webhook module (#8802) 2019-11-03 22:13:25 +00:00
webhook_test.go Move more webhook codes from models to webhook module (#8802) 2019-11-03 22:13:25 +00:00
wiki.go Move wiki related funtions from models to services/wiki (#9355) 2020-01-07 18:27:36 +00:00
wiki_test.go Move wiki related funtions from models to services/wiki (#9355) 2020-01-07 18:27:36 +00:00