Mirrors
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gitea/routers/web
History
Zettat123 898f852d03
Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365) (#32397) 
Backport #32365

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.


348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html <img
width="600px"

src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
 		2024-11-01 03:53:59 +00:00
..
admin Add missed return after `ctx.ServerError` (#31130) (#31133) 2024-05-28 12:47:11 +02:00
auth add CfTurnstileSitekey context data to all captcha templates (#31874) (#31876) 2024-08-20 14:45:08 +00:00
devtest Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
events Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
explore Respect UI.ExploreDefaultSort setting again (#32357) (#32385) 2024-10-31 13:49:09 +08:00
feed Rename Str2html to SanitizeHTML and clarify its behavior (#29516) 2024-03-01 10:16:19 +00:00
healthcheck Always enable caches (#28527) 2023-12-19 09:29:05 +00:00
misc Make sure git version&feature are always prepared (#30877) (#30879) 2024-05-07 02:07:33 +00:00
org Fix sort order for organization home and user profile page (#31921) (#31922) 2024-09-02 07:58:18 +00:00
repo Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
shared Fix various problems around projects board view (#30696) (#30902) 2024-05-08 15:46:21 +00:00
user Fix disable 2fa bug (#32320) (#32330) 2024-10-25 17:54:56 +08:00
base.go Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365) (#32397) 2024-11-01 03:53:59 +00:00
githttp.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
goget.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
home.go migrate some more "OptionalBool" to "Option[bool]" (#29479) 2024-02-29 18:52:49 +00:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
passkey.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
swagger_json.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
web.go Fix the permission check for user search API and limit the number of returned users for `/user/search` (#32310) 2024-10-23 04:56:13 +00:00
webfinger.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00