mirror of https://github.com/go-gitea/gitea.git
dd12384f22
* Fix --port setting Unfortunately there was an error in #13195 which set the --port option before the settings were read. This PR fixes this by moving applying this option to after the the settings are read However, on looking further into this code I believe that the setPort code was slightly odd. Firstly, it may make sense to run the install page on a different temporary port to the full system and this should be possible with a --install-port option. Secondy, if the --port option is provided we should apply it to both otherwise there will be unusual behaviour on graceful restart Thirdly, the documentation for --port says that the setting is temporary - it should therefore not save its result to the configuration (This however, does mean that authorized_keys and internal links may not be correct. - I think we need to discuss this option further.) Fix #13277 Signed-off-by: Andrew Thornton <art27@cantab.net> * Update cmd/web.go * Apply suggestions from code review Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
||
|---|---|---|
| .. | ||
| advanced | ||
| developers | ||
| features | ||
| help | ||
| installation | ||
| upgrade | ||
| usage | ||
| advanced.en-us.md | ||
| advanced.fr-fr.md | ||
| advanced.zh-cn.md | ||
| developers.en-us.md | ||
| features.en-us.md | ||
| features.zh-cn.md | ||
| features.zh-tw.md | ||
| help.en-us.md | ||
| help.fr-fr.md | ||
| help.zh-cn.md | ||
| help.zh-tw.md | ||
| installation.en-us.md | ||
| installation.fr-fr.md | ||
| installation.zh-cn.md | ||
| installation.zh-tw.md | ||
| upgrade.en-us.md | ||
| upgrade.fr-fr.md | ||
| upgrade.zh-cn.md | ||
| upgrade.zh-tw.md | ||
| usage.en-us.md | ||
| usage.zh-cn.md | ||