gitea/routers/api/v1/repo
Jason Song 174213530d
Fix `Permission` in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
2023-06-22 13:08:08 +00:00
..
blob.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
branch.go Create a branch directly from commit on the create branch API (#22956) 2023-05-09 18:22:32 +08:00
collaborators.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
commits.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
file.go Fix all possible setting error related storages and added some tests (#23911) 2023-06-14 11:42:38 +08:00
fork.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
git_hook.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
git_ref.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
hook_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
issue.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
issue_attachment.go Preserve file size when creating attachments (#23406) 2023-03-12 03:48:07 -04:00
issue_comment.go Use `CommentList` instead of `[]*Comment` (#24828) 2023-05-21 20:48:28 +08:00
issue_comment_attachment.go Preserve file size when creating attachments (#23406) 2023-03-12 03:48:07 -04:00
issue_dependency.go Add API to manage issue dependencies (#17935) 2023-03-28 13:23:25 -04:00
issue_label.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
issue_pin.go Followup to pinned Issues (#24945) 2023-05-30 15:26:51 +00:00
issue_reaction.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
issue_stopwatch.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
issue_subscription.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
issue_tracked_time.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
key.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
label.go Add loading yaml label template files (#22976) 2023-03-02 01:44:23 +02:00
language.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Merge setting.InitXXX into one function with options (#24389) 2023-05-04 11:55:35 +08:00
migrate.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
milestone.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
mirror.go Add `sync_on_commit` option for push mirrors api (#22271) 2022-12-30 19:22:51 +08:00
notes.go Filters for GetAllCommits (#24568) 2023-05-09 09:06:05 +08:00
patch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pull.go Filters for GetAllCommits (#24568) 2023-05-09 09:06:05 +08:00
pull_review.go Make more functions use ctx instead of db.DefaultContext (#24068) 2023-04-14 14:18:28 -04:00
release.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
release_attachment.go Preserve file size when creating attachments (#23406) 2023-03-12 03:48:07 -04:00
release_tags.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
repo.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
repo_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
star.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
status.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
subscriber.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
tag.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
teams.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
topic.go Move `convert` package to services (#22264) 2022-12-29 10:57:15 +08:00
transfer.go Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
tree.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Pass 'not' to commit count (#24473) 2023-05-08 07:10:53 +00:00