2004-11-17 06:00:25 -07:00
|
|
|
/* Copyright (C) 2004 Bart
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
2014-01-23 03:59:48 -07:00
|
|
|
* GNU General Public License for more details.
|
2004-11-17 06:00:25 -07:00
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
2014-01-23 03:59:48 -07:00
|
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
2004-11-17 06:00:25 -07:00
|
|
|
*/
|
2016-10-18 16:45:28 -06:00
|
|
|
|
|
|
|
#include "FileSystem.h"
|
|
|
|
#include "GParted_Core.h"
|
2004-11-17 06:00:25 -07:00
|
|
|
|
2011-12-27 04:05:11 -07:00
|
|
|
#include <cerrno>
|
2013-02-21 17:57:33 -07:00
|
|
|
#include <iostream>
|
2018-12-04 09:46:27 -07:00
|
|
|
#include <glibmm/miscutils.h>
|
|
|
|
#include <glibmm/stringutils.h>
|
|
|
|
#include <glibmm/shell.h>
|
|
|
|
#include <glibmm/main.h>
|
2013-02-21 17:57:33 -07:00
|
|
|
#include <gtkmm/main.h>
|
2013-04-14 07:23:47 -06:00
|
|
|
#include <signal.h>
|
2013-02-21 17:57:33 -07:00
|
|
|
#include <fcntl.h>
|
2016-01-23 02:27:38 -07:00
|
|
|
#include <sigc++/slot.h>
|
2011-12-27 04:05:11 -07:00
|
|
|
|
2004-11-17 06:00:25 -07:00
|
|
|
namespace GParted
|
|
|
|
{
|
2013-02-21 17:57:33 -07:00
|
|
|
|
2006-01-19 12:15:15 -07:00
|
|
|
FileSystem::FileSystem()
|
2004-11-21 14:49:38 -07:00
|
|
|
{
|
|
|
|
}
|
2006-02-15 09:05:26 -07:00
|
|
|
|
2018-01-30 09:31:31 -07:00
|
|
|
const Glib::ustring & FileSystem::get_custom_text( CUSTOM_TEXT ttype, int index ) const
|
2012-01-27 11:14:53 -07:00
|
|
|
{
|
|
|
|
return get_generic_text( ttype, index ) ;
|
|
|
|
}
|
|
|
|
|
2018-01-30 09:31:31 -07:00
|
|
|
const Glib::ustring & FileSystem::get_generic_text( CUSTOM_TEXT ttype, int index )
|
2012-01-27 11:14:53 -07:00
|
|
|
{
|
2012-01-27 12:41:31 -07:00
|
|
|
/*TO TRANSLATORS: these labels will be used in the partition menu */
|
|
|
|
static const Glib::ustring activate_text = _( "_Mount" ) ;
|
|
|
|
static const Glib::ustring deactivate_text = _( "_Unmount" ) ;
|
2018-01-30 09:31:31 -07:00
|
|
|
static const Glib::ustring empty_text;
|
2012-01-27 12:41:31 -07:00
|
|
|
|
|
|
|
switch ( ttype ) {
|
|
|
|
case CTEXT_ACTIVATE_FILESYSTEM :
|
2018-01-30 09:31:31 -07:00
|
|
|
return index == 0 ? activate_text : empty_text;
|
2012-01-27 12:41:31 -07:00
|
|
|
case CTEXT_DEACTIVATE_FILESYSTEM :
|
2018-01-30 09:31:31 -07:00
|
|
|
return index == 0 ? deactivate_text : empty_text;
|
2012-01-27 12:41:31 -07:00
|
|
|
default :
|
2018-01-30 09:31:31 -07:00
|
|
|
return empty_text;
|
2012-01-27 12:41:31 -07:00
|
|
|
}
|
2012-01-27 11:14:53 -07:00
|
|
|
}
|
|
|
|
|
2013-02-21 17:57:33 -07:00
|
|
|
void FileSystem::store_exit_status( GPid pid, int status )
|
2006-01-19 12:15:15 -07:00
|
|
|
{
|
Implement shell style exit status decoding (#754684)
Command exit status is a 1 byte value between 0 and 255. [1][2] However
at the Unix API level the value is encoded as documented in the
waitpid(2) manual page. This is true for the Glib API too. [3] This is
why, for example, the comment in ext2::check_repair() reported receiving
undocumented exit status 256. It was actually receiving exit status 1
encoded as per the waitpid(2) method.
Add shell style exit status decoding [2] to execution of all external
commands. Return value from Utils::execute_command() and
FileSystem::execute_command() functions are now:
0 - 125 - Exit status from the command
126 - Error executing the command
127 - Command not found
128+N - Command terminated by signal N
255 - Unexpected waitpid(2) condition
Also adjust checking of the returned statuses as necessary.
[1] Advanced Bash-Scripting Guide: Appendix D. Exit Codes With Special
Meanings
http://www.linuxtopia.org/online_books/advanced_bash_scripting_guide/exitcodes.html
[2] Quote from the bash(1) manual page:
EXIT STATUS
... Exit statuses fall between 0 and 255, though as
explained below, the shell may use values above 125
specially. ...
... When a command terminates on a fatal signal N, bash uses
the value of 128+N as the exit status.
If a command is not found, the child process created to
execute it returns a status of 127. If a command is found
but is not executable, the return status is 126.
[3] Quote from the Glib Reference Manual, Spawning Processes section,
for function g_spawn_check_exit_status():
https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-check-exit-status
The g_spawn_sync() and g_child_watch_add() family of APIs return
an exit status for subprocesses encoded in a platform-specific
way. On Unix, this is guaranteed to be in the same format
waitpid() returns, ...
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-09-06 07:39:07 -06:00
|
|
|
exit_status = Utils::decode_wait_status( status );
|
2013-02-21 17:57:33 -07:00
|
|
|
running = false;
|
|
|
|
if (pipecount == 0) // pipes finished first
|
|
|
|
Gtk::Main::quit();
|
|
|
|
Glib::spawn_close_pid( pid );
|
2006-01-22 06:23:58 -07:00
|
|
|
}
|
|
|
|
|
2013-05-02 14:05:14 -06:00
|
|
|
//Callback passing the latest partial output from the external command
|
|
|
|
// to operation detail for updating in the UI
|
|
|
|
static void update_command_output( OperationDetail *operationdetail, Glib::ustring *str )
|
2011-12-27 04:05:11 -07:00
|
|
|
{
|
2013-02-21 17:57:33 -07:00
|
|
|
operationdetail->set_description( *str, FONT_ITALIC );
|
|
|
|
}
|
2011-12-27 04:05:11 -07:00
|
|
|
|
2013-01-20 19:50:55 -07:00
|
|
|
static void cancel_command( bool force, Glib::Pid pid, bool cancel_safe )
|
|
|
|
{
|
|
|
|
if( force || cancel_safe )
|
|
|
|
kill( -pid, SIGINT );
|
|
|
|
}
|
|
|
|
|
|
|
|
static void setup_child()
|
|
|
|
{
|
|
|
|
setpgrp();
|
|
|
|
}
|
|
|
|
|
2021-04-03 02:16:48 -06:00
|
|
|
|
2021-04-03 04:20:27 -06:00
|
|
|
// Execute command and capture stdout and stderr to operation details.
|
2013-01-20 19:50:55 -07:00
|
|
|
int FileSystem::execute_command( const Glib::ustring & command, OperationDetail & operationdetail,
|
2016-02-03 14:17:30 -07:00
|
|
|
ExecFlags flags )
|
|
|
|
{
|
|
|
|
StreamSlot empty_stream_slot;
|
|
|
|
TimedSlot empty_timed_slot;
|
2021-04-03 02:16:48 -06:00
|
|
|
return execute_command_internal(command, NULL, operationdetail, flags, empty_stream_slot, empty_timed_slot);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2021-04-03 04:20:27 -06:00
|
|
|
// Execute command, pass string to stdin and capture stdout and stderr to operation
|
|
|
|
// details.
|
2021-04-03 02:16:48 -06:00
|
|
|
int FileSystem::execute_command(const Glib::ustring& command, const char *input, OperationDetail& operationdetail,
|
|
|
|
ExecFlags flags)
|
|
|
|
{
|
|
|
|
StreamSlot empty_stream_slot;
|
|
|
|
TimedSlot empty_timed_slot;
|
|
|
|
return execute_command_internal(command, input, operationdetail, flags, empty_stream_slot, empty_timed_slot);
|
2016-02-03 14:17:30 -07:00
|
|
|
}
|
|
|
|
|
2021-04-03 02:16:48 -06:00
|
|
|
|
2021-04-03 04:20:27 -06:00
|
|
|
// Execute command, capture stdout and stderr to operation details and run progress
|
|
|
|
// tracking callback when either stdout or stderr is updated (as requested by flag
|
|
|
|
// EXEC_PROGRESS_STDOUT or EXEC_PROGRESS_STDERR respectively).
|
2016-02-03 14:17:30 -07:00
|
|
|
int FileSystem::execute_command( const Glib::ustring & command, OperationDetail & operationdetail,
|
|
|
|
ExecFlags flags,
|
|
|
|
StreamSlot stream_progress_slot )
|
|
|
|
{
|
|
|
|
TimedSlot empty_timed_slot;
|
2021-04-03 02:16:48 -06:00
|
|
|
return execute_command_internal(command, NULL, operationdetail, flags, stream_progress_slot, empty_timed_slot);
|
2016-02-03 14:17:30 -07:00
|
|
|
}
|
|
|
|
|
2021-04-03 02:16:48 -06:00
|
|
|
|
2021-04-03 04:20:27 -06:00
|
|
|
// Execute command, capture stdout and stderr to operation details and run progress
|
|
|
|
// tracking callback periodically (when requested by flag EXEC_PROGRESS_TIMED).
|
2016-02-03 14:17:30 -07:00
|
|
|
int FileSystem::execute_command( const Glib::ustring & command, OperationDetail & operationdetail,
|
|
|
|
ExecFlags flags,
|
|
|
|
TimedSlot timed_progress_slot )
|
|
|
|
{
|
|
|
|
StreamSlot empty_stream_slot;
|
2021-04-03 02:16:48 -06:00
|
|
|
return execute_command_internal(command, NULL, operationdetail, flags, empty_stream_slot, timed_progress_slot);
|
2016-02-03 14:17:30 -07:00
|
|
|
}
|
|
|
|
|
2021-04-03 02:16:48 -06:00
|
|
|
|
|
|
|
int FileSystem::execute_command_internal(const Glib::ustring& command, const char *input,
|
|
|
|
OperationDetail& operationdetail,
|
|
|
|
ExecFlags flags,
|
|
|
|
StreamSlot stream_progress_slot,
|
|
|
|
TimedSlot timed_progress_slot)
|
2013-02-21 17:57:33 -07:00
|
|
|
{
|
Time and check nearly all file system action commands (#754684)
There has been an undocumented rule that external commands displayed in
the operation details, as part of file system manipulations, only get a
time and check mark displayed when multiple commands are needed, and not
otherwise. (GParted checks whether all commands are successful or not
regardless of whether a check mark is displayed in the operation details
or not).
EXCEPTION 1: btrfs resize
Since the following commit [1] from 2013-02-22, GParted stopped
displaying the timing for the btrfs resize command in the operation
details. It being part of a multi-command sequence to perform the step.
This is because FileSystem::execute_command() since the commit can only
check the exit status for zero / non-zero while timing and checking the
command status but btrfs resize needs to consider some non-zero statuses
as successful.
[1] 52a2a9b00a32996921ace055e71d0e09fb33c5fe
Reduce threading (#685740)
EXCEPTION 2: ext2/3/4 move and copy using e2image
When use of e2image was added [2] the single command steps were timed
and check.
[2] 86111fe12a26d23d9fc2a9e2d19281290ecaf985
Use e2image to move/copy ext[234] file systems (#721516)
EXCEPTION 3: fat16/32 write label and UUID
Uses Utils::execute_command() rather than FileSystem::execute_command()
so can be separately changed. See the following commit for resolution
of the final commands not yet timed and check mark displayed.
CHANGE:
Lets make a simpler rule of always displaying the time and a check mark
for all external commands displayed in the operation details. However
this makes several of the other single command actions need special exit
status handling because zero success, non-zero failure is not correct
for every case. Specifically affects resizing of reiserfs and check
repair of ext2/3/4, fat16/32, jfs and reiserfs.
After this change all external commands run as file system actions must
follow one of these two patterns of using the EXEC_CHECK_STATUS flag or
separately calling FileSystem::set_status() to register success or
failure of the command:
exit_status = execute_command(cmd, od, EXEC_CHECK_STATUS...);
or:
exit_status = execute_command(cmd, od, ...);
bool success = (exit_status == 0 || exit_status == OTHER_SUCCESS_VALUE...);
set_status(od, success );
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-09-05 02:31:16 -06:00
|
|
|
operationdetail.add_child( OperationDetail( command, STATUS_EXECUTE, FONT_BOLD_ITALIC ) );
|
2016-02-08 13:02:42 -07:00
|
|
|
OperationDetail & cmd_operationdetail = operationdetail.get_last_child();
|
2013-02-21 17:57:33 -07:00
|
|
|
Glib::Pid pid;
|
2021-04-03 02:16:48 -06:00
|
|
|
int in = -1;
|
2013-02-21 17:57:33 -07:00
|
|
|
// set up pipes for capture
|
|
|
|
int out, err;
|
|
|
|
// spawn external process
|
|
|
|
running = true;
|
|
|
|
try {
|
|
|
|
Glib::spawn_async_with_pipes(
|
2013-04-18 10:06:37 -06:00
|
|
|
std::string( "." ),
|
2013-02-21 17:57:33 -07:00
|
|
|
Glib::shell_parse_argv( command ),
|
|
|
|
Glib::SPAWN_DO_NOT_REAP_CHILD | Glib::SPAWN_SEARCH_PATH,
|
2013-01-20 19:50:55 -07:00
|
|
|
sigc::ptr_fun(setup_child),
|
2013-02-21 17:57:33 -07:00
|
|
|
&pid,
|
2021-04-03 02:16:48 -06:00
|
|
|
(input != NULL) ? &in : 0,
|
2013-02-21 17:57:33 -07:00
|
|
|
&out,
|
|
|
|
&err );
|
|
|
|
} catch (Glib::SpawnError &e) {
|
|
|
|
std::cerr << e.what() << std::endl;
|
2016-02-08 13:02:42 -07:00
|
|
|
cmd_operationdetail.add_child( OperationDetail( e.what(), STATUS_ERROR, FONT_ITALIC ) );
|
Implement shell style exit status decoding (#754684)
Command exit status is a 1 byte value between 0 and 255. [1][2] However
at the Unix API level the value is encoded as documented in the
waitpid(2) manual page. This is true for the Glib API too. [3] This is
why, for example, the comment in ext2::check_repair() reported receiving
undocumented exit status 256. It was actually receiving exit status 1
encoded as per the waitpid(2) method.
Add shell style exit status decoding [2] to execution of all external
commands. Return value from Utils::execute_command() and
FileSystem::execute_command() functions are now:
0 - 125 - Exit status from the command
126 - Error executing the command
127 - Command not found
128+N - Command terminated by signal N
255 - Unexpected waitpid(2) condition
Also adjust checking of the returned statuses as necessary.
[1] Advanced Bash-Scripting Guide: Appendix D. Exit Codes With Special
Meanings
http://www.linuxtopia.org/online_books/advanced_bash_scripting_guide/exitcodes.html
[2] Quote from the bash(1) manual page:
EXIT STATUS
... Exit statuses fall between 0 and 255, though as
explained below, the shell may use values above 125
specially. ...
... When a command terminates on a fatal signal N, bash uses
the value of 128+N as the exit status.
If a command is not found, the child process created to
execute it returns a status of 127. If a command is found
but is not executable, the return status is 126.
[3] Quote from the Glib Reference Manual, Spawning Processes section,
for function g_spawn_check_exit_status():
https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-check-exit-status
The g_spawn_sync() and g_child_watch_add() family of APIs return
an exit status for subprocesses encoded in a platform-specific
way. On Unix, this is guaranteed to be in the same format
waitpid() returns, ...
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-09-06 07:39:07 -06:00
|
|
|
return Utils::get_failure_status( e );
|
2013-02-21 17:57:33 -07:00
|
|
|
}
|
|
|
|
fcntl( out, F_SETFL, O_NONBLOCK );
|
|
|
|
fcntl( err, F_SETFL, O_NONBLOCK );
|
|
|
|
Glib::signal_child_watch().connect( sigc::mem_fun( *this, &FileSystem::store_exit_status ), pid );
|
|
|
|
pipecount = 2;
|
|
|
|
PipeCapture outputcapture( out, output );
|
|
|
|
PipeCapture errorcapture( err, error );
|
2013-05-02 01:35:17 -06:00
|
|
|
outputcapture.signal_eof.connect( sigc::mem_fun( *this, &FileSystem::execute_command_eof ) );
|
|
|
|
errorcapture.signal_eof.connect( sigc::mem_fun( *this, &FileSystem::execute_command_eof ) );
|
2016-02-08 13:02:42 -07:00
|
|
|
cmd_operationdetail.add_child( OperationDetail( output, STATUS_NONE, FONT_ITALIC ) );
|
|
|
|
cmd_operationdetail.add_child( OperationDetail( error, STATUS_NONE, FONT_ITALIC ) );
|
|
|
|
std::vector<OperationDetail*> &children = cmd_operationdetail.get_childs();
|
2013-05-02 14:05:14 -06:00
|
|
|
outputcapture.signal_update.connect( sigc::bind( sigc::ptr_fun( update_command_output ),
|
2014-04-01 20:04:01 -06:00
|
|
|
children[children.size() - 2],
|
2013-05-02 01:35:17 -06:00
|
|
|
&output ) );
|
2013-05-02 14:05:14 -06:00
|
|
|
errorcapture.signal_update.connect( sigc::bind( sigc::ptr_fun( update_command_output ),
|
2014-04-01 20:04:01 -06:00
|
|
|
children[children.size() - 1],
|
2013-05-02 01:35:17 -06:00
|
|
|
&error ) );
|
2016-02-03 14:17:30 -07:00
|
|
|
sigc::connection timed_conn;
|
2016-01-23 02:27:38 -07:00
|
|
|
if ( flags & EXEC_PROGRESS_STDOUT && ! stream_progress_slot.empty() )
|
|
|
|
// Call progress tracking callback when stdout updates
|
2016-02-08 13:02:42 -07:00
|
|
|
outputcapture.signal_update.connect( sigc::bind( stream_progress_slot, &cmd_operationdetail ) );
|
2016-01-23 02:27:38 -07:00
|
|
|
else if ( flags & EXEC_PROGRESS_STDERR && ! stream_progress_slot.empty() )
|
|
|
|
// Call progress tracking callback when stderr updates
|
2016-02-08 13:02:42 -07:00
|
|
|
errorcapture.signal_update.connect( sigc::bind( stream_progress_slot, &cmd_operationdetail ) );
|
2016-02-03 14:17:30 -07:00
|
|
|
else if ( flags & EXEC_PROGRESS_TIMED && ! timed_progress_slot.empty() )
|
|
|
|
// Call progress tracking callback every 500 ms
|
2016-02-08 13:02:42 -07:00
|
|
|
timed_conn = Glib::signal_timeout().connect( sigc::bind( timed_progress_slot, &cmd_operationdetail ), 500 );
|
2013-04-25 14:08:58 -06:00
|
|
|
outputcapture.connect_signal();
|
|
|
|
errorcapture.connect_signal();
|
2013-02-21 17:57:33 -07:00
|
|
|
|
2016-02-08 13:02:42 -07:00
|
|
|
cmd_operationdetail.signal_cancel.connect(
|
2013-01-20 19:50:55 -07:00
|
|
|
sigc::bind(
|
|
|
|
sigc::ptr_fun( cancel_command ),
|
|
|
|
pid,
|
Refactor flags in method FileSystem::execute_command() (#754684)
Change the two optional boolean parameters into a single optional flags
parameter which uses symbolically defined names. Makes reading the
execute_command() calls much easier to understand. (Implemented as bit
field using the same technique as used for Glib::SpawnFlags [1]).
This changes the calls thus:
execute_command(cmd, od) -> (cmd, od)
execute_command(cmd, od, false) -> (cmd, od, EXEC_NONE) // [2]
execute_command(cmd, od, true ) -> (cmd, od, EXEC_CHECK_STATUS)
execute_command(cmd, od, false, true) -> (cmd, od, EXEC_CANCEL_SAFE)
execute_command(cmd, od, true , true) ->
(cmd, od, EXEC_CHECK_STATUS|EXEC_CANCEL_SAFE)
[1] SpawnFlags bitwise operators in
/usr/include/glibmm-2.4/glibmm/spawn.h.
[2] False and EXEC_NONE are the default values for the optional third
parameter before and after this change respectively and both mean
the same. This is being used in btrfs::resize() and being kept for
now despite it being the default.
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-08-29 08:15:24 -06:00
|
|
|
flags & EXEC_CANCEL_SAFE ) );
|
2021-04-03 02:16:48 -06:00
|
|
|
|
|
|
|
if (input != NULL && in != -1)
|
|
|
|
{
|
|
|
|
// Write small amount of input to pipe to the child process. Linux will
|
|
|
|
// always accept up to 4096 bytes without blocking. See pipe(7).
|
|
|
|
size_t len = strlen(input);
|
|
|
|
ssize_t written = write(in, input, len);
|
|
|
|
if (written == -1 || (size_t)written < len)
|
|
|
|
{
|
|
|
|
int e = errno;
|
|
|
|
std::cerr << "Write to child failed: " << Glib::strerror(e) << std::endl;
|
|
|
|
cmd_operationdetail.add_child(OperationDetail("Write to child failed: " + Glib::strerror(e),
|
|
|
|
STATUS_NONE, FONT_ITALIC));
|
|
|
|
}
|
|
|
|
close(in);
|
|
|
|
}
|
|
|
|
|
2013-02-21 17:57:33 -07:00
|
|
|
Gtk::Main::run();
|
|
|
|
|
Refactor flags in method FileSystem::execute_command() (#754684)
Change the two optional boolean parameters into a single optional flags
parameter which uses symbolically defined names. Makes reading the
execute_command() calls much easier to understand. (Implemented as bit
field using the same technique as used for Glib::SpawnFlags [1]).
This changes the calls thus:
execute_command(cmd, od) -> (cmd, od)
execute_command(cmd, od, false) -> (cmd, od, EXEC_NONE) // [2]
execute_command(cmd, od, true ) -> (cmd, od, EXEC_CHECK_STATUS)
execute_command(cmd, od, false, true) -> (cmd, od, EXEC_CANCEL_SAFE)
execute_command(cmd, od, true , true) ->
(cmd, od, EXEC_CHECK_STATUS|EXEC_CANCEL_SAFE)
[1] SpawnFlags bitwise operators in
/usr/include/glibmm-2.4/glibmm/spawn.h.
[2] False and EXEC_NONE are the default values for the optional third
parameter before and after this change respectively and both mean
the same. This is being used in btrfs::resize() and being kept for
now despite it being the default.
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-08-29 08:15:24 -06:00
|
|
|
if ( flags & EXEC_CHECK_STATUS )
|
2017-11-25 09:31:47 -07:00
|
|
|
cmd_operationdetail.set_success_and_capture_errors( exit_status == 0 );
|
2013-02-21 17:57:33 -07:00
|
|
|
close( out );
|
|
|
|
close( err );
|
2016-02-03 14:17:30 -07:00
|
|
|
if ( timed_conn.connected() )
|
|
|
|
timed_conn.disconnect();
|
2016-02-08 13:02:42 -07:00
|
|
|
cmd_operationdetail.stop_progressbar();
|
2013-02-21 17:57:33 -07:00
|
|
|
return exit_status;
|
|
|
|
}
|
2011-12-27 04:05:11 -07:00
|
|
|
|
Time and check nearly all file system action commands (#754684)
There has been an undocumented rule that external commands displayed in
the operation details, as part of file system manipulations, only get a
time and check mark displayed when multiple commands are needed, and not
otherwise. (GParted checks whether all commands are successful or not
regardless of whether a check mark is displayed in the operation details
or not).
EXCEPTION 1: btrfs resize
Since the following commit [1] from 2013-02-22, GParted stopped
displaying the timing for the btrfs resize command in the operation
details. It being part of a multi-command sequence to perform the step.
This is because FileSystem::execute_command() since the commit can only
check the exit status for zero / non-zero while timing and checking the
command status but btrfs resize needs to consider some non-zero statuses
as successful.
[1] 52a2a9b00a32996921ace055e71d0e09fb33c5fe
Reduce threading (#685740)
EXCEPTION 2: ext2/3/4 move and copy using e2image
When use of e2image was added [2] the single command steps were timed
and check.
[2] 86111fe12a26d23d9fc2a9e2d19281290ecaf985
Use e2image to move/copy ext[234] file systems (#721516)
EXCEPTION 3: fat16/32 write label and UUID
Uses Utils::execute_command() rather than FileSystem::execute_command()
so can be separately changed. See the following commit for resolution
of the final commands not yet timed and check mark displayed.
CHANGE:
Lets make a simpler rule of always displaying the time and a check mark
for all external commands displayed in the operation details. However
this makes several of the other single command actions need special exit
status handling because zero success, non-zero failure is not correct
for every case. Specifically affects resizing of reiserfs and check
repair of ext2/3/4, fat16/32, jfs and reiserfs.
After this change all external commands run as file system actions must
follow one of these two patterns of using the EXEC_CHECK_STATUS flag or
separately calling FileSystem::set_status() to register success or
failure of the command:
exit_status = execute_command(cmd, od, EXEC_CHECK_STATUS...);
or:
exit_status = execute_command(cmd, od, ...);
bool success = (exit_status == 0 || exit_status == OTHER_SUCCESS_VALUE...);
set_status(od, success );
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-09-05 02:31:16 -06:00
|
|
|
void FileSystem::set_status( OperationDetail & operationdetail, bool success )
|
|
|
|
{
|
2017-11-25 09:31:47 -07:00
|
|
|
operationdetail.get_last_child().set_success_and_capture_errors( success );
|
Time and check nearly all file system action commands (#754684)
There has been an undocumented rule that external commands displayed in
the operation details, as part of file system manipulations, only get a
time and check mark displayed when multiple commands are needed, and not
otherwise. (GParted checks whether all commands are successful or not
regardless of whether a check mark is displayed in the operation details
or not).
EXCEPTION 1: btrfs resize
Since the following commit [1] from 2013-02-22, GParted stopped
displaying the timing for the btrfs resize command in the operation
details. It being part of a multi-command sequence to perform the step.
This is because FileSystem::execute_command() since the commit can only
check the exit status for zero / non-zero while timing and checking the
command status but btrfs resize needs to consider some non-zero statuses
as successful.
[1] 52a2a9b00a32996921ace055e71d0e09fb33c5fe
Reduce threading (#685740)
EXCEPTION 2: ext2/3/4 move and copy using e2image
When use of e2image was added [2] the single command steps were timed
and check.
[2] 86111fe12a26d23d9fc2a9e2d19281290ecaf985
Use e2image to move/copy ext[234] file systems (#721516)
EXCEPTION 3: fat16/32 write label and UUID
Uses Utils::execute_command() rather than FileSystem::execute_command()
so can be separately changed. See the following commit for resolution
of the final commands not yet timed and check mark displayed.
CHANGE:
Lets make a simpler rule of always displaying the time and a check mark
for all external commands displayed in the operation details. However
this makes several of the other single command actions need special exit
status handling because zero success, non-zero failure is not correct
for every case. Specifically affects resizing of reiserfs and check
repair of ext2/3/4, fat16/32, jfs and reiserfs.
After this change all external commands run as file system actions must
follow one of these two patterns of using the EXEC_CHECK_STATUS flag or
separately calling FileSystem::set_status() to register success or
failure of the command:
exit_status = execute_command(cmd, od, EXEC_CHECK_STATUS...);
or:
exit_status = execute_command(cmd, od, ...);
bool success = (exit_status == 0 || exit_status == OTHER_SUCCESS_VALUE...);
set_status(od, success );
Bug 754684 - Updates to FileSystem:: and Utils::execute_command()
functions
2015-09-05 02:31:16 -06:00
|
|
|
}
|
|
|
|
|
2013-02-21 17:57:33 -07:00
|
|
|
void FileSystem::execute_command_eof()
|
|
|
|
{
|
|
|
|
if (--pipecount)
|
|
|
|
return; // wait for second pipe to eof
|
|
|
|
if ( !running ) // already got exit status
|
|
|
|
Gtk::Main::quit();
|
2011-12-27 04:05:11 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
//Create uniquely named temporary directory and add results to operation detail
|
|
|
|
Glib::ustring FileSystem::mk_temp_dir( const Glib::ustring & infix, OperationDetail & operationdetail )
|
|
|
|
{
|
|
|
|
// Construct template like "$TMPDIR/gparted-XXXXXX" or "$TMPDIR/gparted-INFIX-XXXXXX"
|
|
|
|
Glib::ustring dir_template = Glib::get_tmp_dir() + "/gparted-" ;
|
|
|
|
if ( ! infix .empty() )
|
|
|
|
dir_template += infix + "-" ;
|
|
|
|
dir_template += "XXXXXX" ;
|
|
|
|
//Secure Programming for Linux and Unix HOWTO, Chapter 6. Avoid Buffer Overflow
|
|
|
|
// http://tldp.org/HOWTO/Secure-Programs-HOWTO/library-c.html
|
|
|
|
char dir_buf[4096+1];
|
2012-01-12 13:07:37 -07:00
|
|
|
sprintf( dir_buf, "%.*s", (int) sizeof(dir_buf)-1, dir_template .c_str() ) ;
|
2011-12-27 04:05:11 -07:00
|
|
|
|
|
|
|
//Looks like "mkdir -v" command was run to the user
|
|
|
|
operationdetail .add_child( OperationDetail(
|
|
|
|
Glib::ustring( "mkdir -v " ) + dir_buf, STATUS_EXECUTE, FONT_BOLD_ITALIC ) ) ;
|
|
|
|
const char * dir_name = mkdtemp( dir_buf ) ;
|
|
|
|
if ( NULL == dir_name )
|
|
|
|
{
|
|
|
|
int e = errno ;
|
|
|
|
operationdetail .get_last_child() .add_child( OperationDetail(
|
2019-03-25 14:41:08 -06:00
|
|
|
Glib::ustring::compose( "mkdtemp(%1): %2", dir_buf, Glib::strerror( e ) ), STATUS_NONE ) ) ;
|
2017-11-26 06:08:15 -07:00
|
|
|
operationdetail.get_last_child().set_success_and_capture_errors( false );
|
2011-12-27 04:05:11 -07:00
|
|
|
dir_name = "" ;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
//Update command with actually created temporary directory
|
|
|
|
operationdetail .get_last_child() .set_description(
|
|
|
|
Glib::ustring( "mkdir -v " ) + dir_name, FONT_BOLD_ITALIC ) ;
|
|
|
|
operationdetail .get_last_child() .add_child( OperationDetail(
|
|
|
|
/*TO TRANSLATORS: looks like Created directory /tmp/gparted-CEzvSp */
|
2019-03-25 14:41:08 -06:00
|
|
|
Glib::ustring::compose( _("Created directory %1"), dir_name ), STATUS_NONE ) ) ;
|
2017-11-26 06:08:15 -07:00
|
|
|
operationdetail.get_last_child().set_success_and_capture_errors( true );
|
2011-12-27 04:05:11 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
return Glib::ustring( dir_name ) ;
|
|
|
|
}
|
|
|
|
|
|
|
|
//Remove directory and add results to operation detail
|
|
|
|
void FileSystem::rm_temp_dir( const Glib::ustring dir_name, OperationDetail & operationdetail )
|
|
|
|
{
|
|
|
|
//Looks like "rmdir -v" command was run to the user
|
|
|
|
operationdetail .add_child( OperationDetail( Glib::ustring( "rmdir -v " ) + dir_name,
|
|
|
|
STATUS_EXECUTE, FONT_BOLD_ITALIC ) ) ;
|
|
|
|
if ( rmdir( dir_name .c_str() ) )
|
|
|
|
{
|
|
|
|
//Don't mark operation as errored just because rmdir
|
|
|
|
// failed. Set to Warning (N/A) instead.
|
|
|
|
int e = errno ;
|
|
|
|
operationdetail .get_last_child() .add_child( OperationDetail(
|
2019-03-25 14:41:08 -06:00
|
|
|
Glib::ustring::compose( "rmdir(%1): ", dir_name ) + Glib::strerror( e ), STATUS_NONE ) ) ;
|
2017-11-25 09:55:28 -07:00
|
|
|
operationdetail.get_last_child().set_status( STATUS_WARNING );
|
2011-12-27 04:05:11 -07:00
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
operationdetail .get_last_child() .add_child( OperationDetail(
|
|
|
|
/*TO TRANSLATORS: looks like Removed directory /tmp/gparted-CEzvSp */
|
2019-03-25 14:41:08 -06:00
|
|
|
Glib::ustring::compose( _("Removed directory %1"), dir_name ), STATUS_NONE ) ) ;
|
2017-11-26 06:08:15 -07:00
|
|
|
operationdetail.get_last_child().set_success_and_capture_errors( true );
|
2011-12-27 04:05:11 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2004-11-17 06:00:25 -07:00
|
|
|
} //GParted
|