2009-04-19 15:44:31 -06:00
|
|
|
git guidelines for gparted
|
2008-10-08 15:23:54 -06:00
|
|
|
==========================
|
2004-09-23 02:33:59 -06:00
|
|
|
|
2009-04-19 15:44:31 -06:00
|
|
|
Please do not commit directly to the git.gnome.org/gparted repository
|
|
|
|
|
unless you have been given the green light to commit freely to
|
|
|
|
|
gparted. When in doubt assume you haven't ;-).
|
2004-09-23 02:33:59 -06:00
|
|
|
|
2009-04-19 15:44:31 -06:00
|
|
|
If you are a translator feel free to mark strings for translation, fix
|
|
|
|
|
typos in the code, etc. I'd appreciate it if you would notify me of
|
|
|
|
|
anything you've done.
|
2004-09-23 02:33:59 -06:00
|
|
|
|
|
|
|
|
Please send patches for build & configure fixes too. I really appreciate
|
|
|
|
|
your help, I just want to review these fixes before applying.
|
|
|
|
|
|
2009-04-19 15:44:31 -06:00
|
|
|
!!WHENEVER YOU COMMIT, PLACE A COMMENT IN GIT!!
|
2004-09-30 15:01:19 -06:00
|
|
|
even when it's only one character. =)
|
|
|
|
|
|
2004-09-23 02:33:59 -06:00
|
|
|
Thanks,
|
2009-04-19 15:44:31 -06:00
|
|
|
Curtis
|
Enhance calculation of significant unallocated space (#499202)
Many file systems report differing percentages of unallocated space over
a range of sizes, as well differing figures using their own specific
tools or using statvfs() system call when mounted.
File systems reporting intrinsic unallocated space using their specific
tools are: jfs, lvm2 pv and ntfs. LVM2 PV has the largest amount of
unallocated space with its default Physical Extent size of 4 MiB. For a
100 MiB partition it has 4.0% unallocated space.
File systems reporting intrinsic unallocated space using the statvfs()
system call when mounted are: ext2/3/4, fat16/32, hfs, jfs, nilfs2,
ntfs, reiserfs, and xfs. Xfs has the worst identified unallocated space
of ~4.7% in a 100 MiB partition. Ext2/3 exhibit unusual behaviour by
reporting unallocated space of ~4.6% in a 100 MiB partition falling to a
constant percentage of ~1.8% for sizes of 1 GiB and above.
Update the calculation for used to estimate the maximum size of
intrinsic unallocated space. Limit is now 5% for partitions smaller
than 100 MiB, 2% for partitions larger than 1 GiB and linear scaling of
the percentage between. Will still get false unallocated space warnings
for mounted xfs file systems and lvm2 pvs smaller than 100 MiB.
Also add a short note and worked example calculation of unallocated
space to the HACKING file.
Bug #499202 - gparted does not see the difference if partition size
differs from filesystem size
2012-06-05 12:32:52 -06:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-03-19 14:23:34 -06:00
|
|
|
Coding style
|
|
|
|
|
============
|
|
|
|
|
|
|
|
|
|
The GParted code is all over the place in terms of coding style. New
|
|
|
|
|
code, and updated code where reasonable, should use Allman style and
|
|
|
|
|
Smart Tabs alignment. See src/OptionComboBox.cc and
|
|
|
|
|
src/SupportedFileSystems.cc as examples. Don't worry too much about the
|
|
|
|
|
style, we can always adjust it if necessary during the review and merge
|
|
|
|
|
process.
|
|
|
|
|
|
|
|
|
|
* https://en.wikipedia.org/wiki/Indentation_style#Allman_style
|
|
|
|
|
* https://www.emacswiki.org/emacs/SmartTabs
|
|
|
|
|
* https://vim.fandom.com/wiki/Indent_with_tabs,_align_with_spaces
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-14 00:54:55 -06:00
|
|
|
Translatable files
|
|
|
|
|
==================
|
|
|
|
|
|
|
|
|
|
The file po/POTFILES.in lists all source files which do or could contain
|
|
|
|
|
translatable strings. Remember to update when adding new and removing
|
|
|
|
|
old source code files include/*.h and src/*.cc. Generally .cc files are
|
|
|
|
|
included and .h files are not, but there are exceptions. Some mistakes
|
|
|
|
|
can be detected using:
|
|
|
|
|
make distcheck
|