gparted/configure.ac

403 lines
13 KiB
Plaintext
Raw Normal View History

AC_INIT([gparted],[1.6.0-git],[https://gitlab.gnome.org/GNOME/gparted/issues])
AC_PREREQ([2.50])
AC_CONFIG_SRCDIR([src/main.cc])
AC_CONFIG_HEADERS([config.h])
AC_CONFIG_MACRO_DIR([m4])
Silence subdir-objects warning from automake 1.14 (#781978) Configuring GParted on a machine with automake >= 1.14 produces this warning: $ ./autogen.sh ... lib/gtest/Makefile.am:58: warning: source file 'src/gtest-all.cc' is in a subdirectory, lib/gtest/Makefile.am:58: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. lib/gtest/Makefile.am:60: warning: source file 'src/gtest_main.cc' is in a subdirectory, lib/gtest/Makefile.am:60: but option 'subdir-objects' is disabled lib/gtest/Makefile.am: installing './depcomp' tests/Makefile.am:22: warning: source file '../src/BlockSpecial.cc' is in a subdirectory, tests/Makefile.am:22: but option 'subdir-objects' is disabled tests/Makefile.am:23: warning: source file '../src/PipeCapture.cc' is in a subdirectory, tests/Makefile.am:23: but option 'subdir-objects' is disabled ... From the automake 1.14 NEWS file: http://git.savannah.gnu.org/cgit/automake.git/tree/NEWS?h=v1.14#n125 "The next major Automake version (2.0) will unconditionally activate the 'subdir-objects' option. In order to smooth out the transition, we now give a warning (in the category 'unsupported') whenever a source file is present in a subdirectory but the 'subdir-object' is not enabled. For example, the following usage will trigger such a warning: bin_PROGRAMS = sub/foo sub_foo_SOURCES = sub/main.c sub/bar.c " Set the subdir-objects automake option, silencing the warning. Bug 781978 - Add Google Test C++ test framework
2017-06-21 06:55:59 -06:00
AM_INIT_AUTOMAKE([1.9 subdir-objects])
2004-09-19 16:32:22 -06:00
AM_MAINTAINER_MODE
2004-09-19 14:24:53 -06:00
2004-09-20 09:46:21 -06:00
2004-09-23 13:32:57 -06:00
dnl======================
dnl checks for programs
2004-09-23 13:32:57 -06:00
dnl======================
2004-09-19 14:24:53 -06:00
AC_PROG_CXX
AC_PROG_CC
LT_INIT
AC_PROG_AWK
dnl Check for pkg-config early to avoid splitting message when first used.
PKG_CHECK_EXISTS
2004-09-19 14:24:53 -06:00
dnl======================
dnl Find graphical privilege escalation program
dnl======================
dnl Check for pkexec >= 0.102 for it's ability to run X11 apps.
AM_CONDITIONAL([INSTALL_POLKIT_ACTIONS], false)
PKEXEC_REQUIRED_VERSION='0.102'
AC_MSG_CHECKING([for pkexec >= $PKEXEC_REQUIRED_VERSION])
PKEXEC_REQUIRED_INT=`echo "$PKEXEC_REQUIRED_VERSION" | $AWK -F. '{print $1 * 10000 + $2}'`
PKEXEC_VERSION_OUTPUT=`pkexec --version 2> /dev/null` ||
AC_MSG_RESULT([not found])
if test "x$PKEXEC_VERSION_OUTPUT" != 'x'; then
PKEXEC_FOUND_VERSION=`echo "$PKEXEC_VERSION_OUTPUT" | head -1 | cut -d' ' -f3`
PKEXEC_FOUND_INT=`echo "$PKEXEC_FOUND_VERSION" | $AWK -F. '{print $1 * 10000 + $2}'`
AC_MSG_RESULT([$PKEXEC_FOUND_VERSION found])
if test "$PKEXEC_FOUND_INT" -ge "$PKEXEC_REQUIRED_INT"; then
GKSUPROG='pkexec --disable-internal-agent'
AC_SUBST([GKSUPROG])
AM_CONDITIONAL([INSTALL_POLKIT_ACTIONS], true)
fi
fi
dnl Check for alternative graphical privilege escalation programs.
if test "x$GKSUPROG" = 'x'; then
AC_CHECK_PROGS([GKSUPROG], [gksudo gksu kdesudo "xdg-su -c"], [])
fi
2004-09-23 13:32:57 -06:00
dnl======================
dnl i18n stuff
2004-09-23 13:32:57 -06:00
dnl======================
2004-09-20 09:46:21 -06:00
GETTEXT_PACKAGE=gparted
AC_SUBST([GETTEXT_PACKAGE])
AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], "$GETTEXT_PACKAGE", [description])
2004-09-20 09:46:21 -06:00
Migrate build from intltool to gettext translation (!107) [0] GNOME Goal: Gettext Migration https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration This goal from 2016 is to migrate away from using intltool to help translate especially GNOME application related files, and instead use gettext directly now that gettext can handle a lot more file formats [1][2][3]. The GNOME Goal: Gettext Migration [0] says: "With gettext 0.19.8, there is really no need anymore to use intltool or GLib's dated gettext glue (AM_GLIB_GNU_GETTEXT and glib-gettextize)." This version or later of gettext is available in the oldest supported distributions except for SLES 12: Distribution EOL gettext -V Debian 10 2022-Aug 0.19.8.1 RHEL / CentOS 7 2024-Jun 0.19.8.1 Ubuntu 18.04 LTS 2023-Apr 0.19.8.1 SLES 12 SP5 2024-Oct 0.19.2 [4][5] As SLES 12 SP5 doesn't contain GParted and SLES 15 contains GParted 0.31.0 [6] loosing the ability to compile future GParted 1.5 release on SLES 12 SP5 is acceptable. Additionally the use of intltool and the associated GLib provided macro AM_GLIB_GNU_GETTEXT was the source of the remaining warnings from autoconf 2.71 seen in Fedora 36 and Ubuntu 22.04 LTS about the use of obsolete macros: $ ./autogen.sh ... autoreconf: running: /usr/bin/autoconf --force configure.ac:59: warning: The macro `GLIB_GNU_GETTEXT' is obsolete. configure.ac:59: You should run autoupdate. aclocal.m4:426: GLIB_GNU_GETTEXT is expanded from... >> aclocal.m4:526: AM_GLIB_GNU_GETTEXT is expanded from... >> configure.ac:59: the top level configure.ac:59: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:59: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... aclocal.m4:111: GLIB_LC_MESSAGES is expanded from... aclocal.m4:426: GLIB_GNU_GETTEXT is expanded from... >> aclocal.m4:526: AM_GLIB_GNU_GETTEXT is expanded from... >> configure.ac:59: the top level configure.ac:59: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:59: You should run autoupdate. ... Note that use of AM_GLIB_GNU_GETTEXT was deprecated in GLib 2.47.5 released 2016-01-18 [7]. Newer versions of GLib are included in the oldest supported distributions: Distro Package containing Version glib-gettext.m4 Debian 10 libglib2.0-dev-bin 2.58.3 RHEL / CentOS 7 glib2-devel 2.56.1 Ubuntu 18.04 LTS libglib2.0-dev-bin 2.56.4 SLES 12 SP5 glib2-devel 2.48.2 Therefore perform the migration described in the GNOME wiki documents [0][1]. This involves: 1. Replacing the macros used in configure.ac; 2. Copying Makevars.template to po/Makevars and setting PO_DEPENDS_ON_POT and DIST_DEPENDS_ON_UPDATE_PO to "no"; 3. Replace @INTLTOOL_*@ macros in Makefile.am with rules to use gettext to directly translate the relevent GNOME application files; 4. Removing (_) underscore marking translation prefixes from XML tags in GNOME application files as gettext understands which tags of which files need translating. For reference are these commits in projects GNOME-System-Monitor [8], Reversi [9] and Evince [10] making the same transition. At this point "./autogen.sh && make" succeeds, at least on Ubuntu which provides the instructions gettext needs to correctly translate .policy files by default. These: /usr/share/gettext/its/polkit.its /usr/share/gettext/its/polkit.loc are included in the base policykit-1 package. [1] Migrating from Intltool to Gettext https://wiki.gnome.org/MigratingFromIntltoolToGettext [2] Using Modern Gettext https://blogs.gnome.org/mclasen/2016/07/21/using-modern-gettext/ [3] On the killing of intltool https://blogs.gnome.org/mcatanzaro/2016/07/27/on-the-killing-of-intltool/ [4] SUSE package search, SLES 12 SP5, gettext https://scc.suse.com/packages?name=SUSE%20Linux%20Enterprise%20Server&version=12.5&arch=x86_64&query=gettext&module= [5] SUSE Long Term Service Pack Support https://links.imagerelay.com/cdn/3404/ql/f3a083e9bcd34c76addd096d7f60ec00/long_term_service_pack_support_flyer.pdf [6] SUSE package search, SLES 15, gparted https://scc.suse.com/packages?name=SUSE%20Linux%20Enterprise%20Server&version=15&arch=x86_64&query=gparted&module= [7] Deprecate GLIB_GNU_GETTEXT macro, use upstream gettext instead https://gitlab.gnome.org/GNOME/glib/-/commit/6b577196eed0754d2805fd48caa64f58f9bb8ee4 [8] [GNOME-System-Monitor] Migrate from intltool https://gitlab.gnome.org/GNOME/gnome-system-monitor/-/commit/9185b9c713980391a6f1a2377eb5ea249a0df182 [9] [Reversi] Gettext migration (bgo#793040) https://gitlab.gnome.org/GNOME/iagno/-/commit/d22f560ac80d0ded2cb3a38cb10a65e17ead3850 [10] [Evince] build: Migrate from Intltool to Gettext https://gitlab.gnome.org/GNOME/evince/-/commit/4fd682132430feb8c012e4b0aa0c2c5da5ffe5ac Closes !107 - Migrate from intltool to gettext translation
2022-08-26 05:05:18 -06:00
AM_GNU_GETTEXT_VERSION([0.19.8])
AM_GNU_GETTEXT([external])
2004-09-23 13:32:57 -06:00
dnl======================
dnl checks for libs
2004-09-23 13:32:57 -06:00
dnl======================
AC_CHECK_LIB([uuid], [uuid_generate], [], AC_MSG_ERROR([*** libuuid not found.]))
AC_CHECK_LIB([dl], [dlopen], [], AC_MSG_ERROR([*** libdl not found.]))
AC_CHECK_LIB([parted], [ped_device_read], [], AC_MSG_ERROR([*** libparted not found.]))
dnl Check for minimum required libparted version.
dnl 1) Check using pkg-config.
dnl (Older distros tend to not provide pkg-config information for libparted).
dnl 2) Check by linking and running a program to report libparted version directly.
LIBPARTED_REQUIRED_VERSION='2.2'
AC_MSG_CHECKING([for libparted >= $LIBPARTED_REQUIRED_VERSION (querying pkg-config)])
LIBPARTED_REQUIRED_INT=`echo "$LIBPARTED_REQUIRED_VERSION" |
Fix configuration version compare issue affecting libparted from GIT (#753525) When configuring GParted build with libparted from GIT it may perform the version compares incorrectly and think the version of libparted is higher that it actually is. Libparted uses the number of commits from the last git tag as the third part of the version number. For example install libparted from one commit before release 3.1, 142 commits after release 3.0. $ git checkout v3.1^ $ describe v3.0-142-g82327a3 $ ./bootstrap $ ./configure --prefix=/tmp/parted-3.0-git $ make && make install Configure GParted: $ export CPPFLAGS=-I/tmp/parted-3.0-git/include $ export LDFLAGS=-L/tmp/parted-3.0-git/lib $ export LD_RUN_PATH=/tmp/parted-3.0-git/lib $ export PKG_CONFIG_PATH=/tmp/parted-3.0-git/lib/pkgconfig $ ./configure ... checking for libparted >= 1.7.1 (querying pkg-config)... 3.0.142-8232 checking for 2.0 <= libparted <= 3.0 (loop table creation doesn't delete old partitions)... (cached) no checking for libparted >= 2.2 (improved pt re-read)... (cached) yes checking for ped_file_system_resize in -lparted... no checking for ped_file_system_resize in -lparted-fs-resize... yes checking for libparted >= 3.2 (online resize)... (cached) no ... Libparted is reported as version 3.0.142, but checking of the version between 2.0 and 3.0 inclusive fails. The configure script is multiplying components of the version by 100 when adding them together. $ echo 3.0.142-8232 | awk -F. '{print $1 * 10000 + $2 * 100 + $3}' 30142 So it is only allowing up to 99 commits before it is equivalent to the second minor number increasing by one. Increase the multiplication factor to 10000, allowing up to 9999 commits between releases. An order of magnitude more commits than so far seen between parted releases. Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
2015-08-11 12:29:12 -06:00
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
dnl 1) Check using pkg-config.
PKG_CHECK_EXISTS(
[libparted],
[LIBPARTED_FOUND_VERSION=`$PKG_CONFIG --modversion libparted`
LIBPARTED_FOUND_INT=`echo "$LIBPARTED_FOUND_VERSION" |
Fix configuration version compare issue affecting libparted from GIT (#753525) When configuring GParted build with libparted from GIT it may perform the version compares incorrectly and think the version of libparted is higher that it actually is. Libparted uses the number of commits from the last git tag as the third part of the version number. For example install libparted from one commit before release 3.1, 142 commits after release 3.0. $ git checkout v3.1^ $ describe v3.0-142-g82327a3 $ ./bootstrap $ ./configure --prefix=/tmp/parted-3.0-git $ make && make install Configure GParted: $ export CPPFLAGS=-I/tmp/parted-3.0-git/include $ export LDFLAGS=-L/tmp/parted-3.0-git/lib $ export LD_RUN_PATH=/tmp/parted-3.0-git/lib $ export PKG_CONFIG_PATH=/tmp/parted-3.0-git/lib/pkgconfig $ ./configure ... checking for libparted >= 1.7.1 (querying pkg-config)... 3.0.142-8232 checking for 2.0 <= libparted <= 3.0 (loop table creation doesn't delete old partitions)... (cached) no checking for libparted >= 2.2 (improved pt re-read)... (cached) yes checking for ped_file_system_resize in -lparted... no checking for ped_file_system_resize in -lparted-fs-resize... yes checking for libparted >= 3.2 (online resize)... (cached) no ... Libparted is reported as version 3.0.142, but checking of the version between 2.0 and 3.0 inclusive fails. The configure script is multiplying components of the version by 100 when adding them together. $ echo 3.0.142-8232 | awk -F. '{print $1 * 10000 + $2 * 100 + $3}' 30142 So it is only allowing up to 99 commits before it is equivalent to the second minor number increasing by one. Increase the multiplication factor to 10000, allowing up to 9999 commits between releases. An order of magnitude more commits than so far seen between parted releases. Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
2015-08-11 12:29:12 -06:00
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
AC_MSG_RESULT([$LIBPARTED_FOUND_VERSION])
test "$LIBPARTED_FOUND_INT" -ge "$LIBPARTED_REQUIRED_INT" ||
AC_MSG_ERROR([*** libparted too old. Require libparted >= $LIBPARTED_REQUIRED_VERSION but only found libparted $LIBPARTED_FOUND_VERSION.])
],
[AC_MSG_RESULT([not found])
dnl 2) Check by linking and running a program to report libparted version
dnl directly.
AC_MSG_CHECKING([for libparted >= $LIBPARTED_REQUIRED_VERSION (querying libparted)])
AC_RUN_IFELSE(
[AC_LANG_SOURCE(
[[
#include <stdio.h>
#include <stdlib.h>
#include <parted/parted.h>
int main()
{
const char *version = ped_get_version();
if (version == NULL)
{
fprintf(stderr, "ERROR: ped_get_version() returned NULL\n");
return EXIT_FAILURE;
}
printf("%s\n", version);
return EXIT_SUCCESS;
}
]]
)],
dnl Run test program again to cache libparted version.
[LIBPARTED_FOUND_VERSION=`./conftest$EXEEXT`
LIBPARTED_FOUND_INT=`echo "$LIBPARTED_FOUND_VERSION" |
Fix configuration version compare issue affecting libparted from GIT (#753525) When configuring GParted build with libparted from GIT it may perform the version compares incorrectly and think the version of libparted is higher that it actually is. Libparted uses the number of commits from the last git tag as the third part of the version number. For example install libparted from one commit before release 3.1, 142 commits after release 3.0. $ git checkout v3.1^ $ describe v3.0-142-g82327a3 $ ./bootstrap $ ./configure --prefix=/tmp/parted-3.0-git $ make && make install Configure GParted: $ export CPPFLAGS=-I/tmp/parted-3.0-git/include $ export LDFLAGS=-L/tmp/parted-3.0-git/lib $ export LD_RUN_PATH=/tmp/parted-3.0-git/lib $ export PKG_CONFIG_PATH=/tmp/parted-3.0-git/lib/pkgconfig $ ./configure ... checking for libparted >= 1.7.1 (querying pkg-config)... 3.0.142-8232 checking for 2.0 <= libparted <= 3.0 (loop table creation doesn't delete old partitions)... (cached) no checking for libparted >= 2.2 (improved pt re-read)... (cached) yes checking for ped_file_system_resize in -lparted... no checking for ped_file_system_resize in -lparted-fs-resize... yes checking for libparted >= 3.2 (online resize)... (cached) no ... Libparted is reported as version 3.0.142, but checking of the version between 2.0 and 3.0 inclusive fails. The configure script is multiplying components of the version by 100 when adding them together. $ echo 3.0.142-8232 | awk -F. '{print $1 * 10000 + $2 * 100 + $3}' 30142 So it is only allowing up to 99 commits before it is equivalent to the second minor number increasing by one. Increase the multiplication factor to 10000, allowing up to 9999 commits between releases. An order of magnitude more commits than so far seen between parted releases. Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
2015-08-11 12:29:12 -06:00
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
test "$LIBPARTED_FOUND_INT" -ge "$LIBPARTED_REQUIRED_INT" ||
AC_MSG_ERROR([*** libparted too old. Require libparted >= $LIBPARTED_REQUIRED_VERSION but only found libparted $LIBPARTED_FOUND_VERSION.])
],
[AC_MSG_ERROR([*** Error querying libparted version. Check config.log for details.])]
)]
)
Fix failure to recognise whole disk file systems in certain cases (#743181) When the following conditions were met GParted would fail to recognise a newly created whole disk device file system, and instead show an unknown file system filling the disk: 1) Disk was previously partitioned and contained at least one partition. 2) Using libparted version 2.0 to 3.0 inclusive. Initial status: # blkid | fgrep sdc # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 # parted /dev/sdc GNU Parted 2.4 Using /dev/sdc Welcome to GNU Parted! Type 'help' to view a list of commands. (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: msdos Number Start End Size Type File system Flags 1 1049kB 107GB 107GB primary When creating the loop partition table libparted would not inform the kernel to delete the old partitions. /proc/partitions still contained the details of the old partitions. (parted) mktable loop Warning: The existing disk label on /dev/sdc will be destroyed and all data on this disk will be lost. Do you want to continue? Yes/No? Yes (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: loop Number Start End Size File system Flags (parted) quit # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 Creation of the whole disk device file system goes unnoticed by blkid because the kernel and therefore blkid's cache have stale partition information. # mkfs.xfs -f /dev/sdc # blkid | fgrep sdc NOTE: On a Linux Software RAID array, as opposed to a hard disk, blkid does notice creation of the whole disk device file system. However the kernel still has old partition details. This was fixed in libparted 3.1 by commit: http://git.savannah.gnu.org/cgit/parted.git/commit/?id=f5c909c0cd50ed52a48dae6d35907dc08b137e88 libparted: remove has_partitions check to allow loopback partitions Fix by deleting old partitions before creating the loop table when compiled with a broken version of libparted. The GParted UI provides no feedback while a new partition table is created, and with some versions of GTK the UI become unresponsive too, so it is important to be as fast as possible. Evaluated three different methods, deleting 15 and 22 MSDOS partitions on a physical 5400 RPM hard drive using libparted 2.4: M1) Delete and commit one partition at a time. Takes up to 24 seconds to delete 15 partitions. With 22 partitions libparted always reports finding some of the partitions busy and unable to inform the kernel about the modifications. Too slow and doesn't work. M2) Delete all partitions in one go and commit once. Takes up to 1.4 seconds to delete either 15 or 22 partitions. Never removes partitions 17 and higher from the kernel. Doesn't work. M3) Write GPT table (letting libparted delete any old partitions). Takes up to 0.8 seconds to delete either 15 or 22 partitions. Fast and works. Use method 3 - write a GPT table thus using libparted code to inform the kernel of the old partition deletions. Bug 743181 - Add unpartitioned drive read-write support
2015-02-21 09:43:42 -07:00
dnl Check for libparted 2.0 to 3.0 inclusive for a bug where loop table
dnl creation doesn't delete old partitions.
LIBPARTED_MIN_WANTED_VERSION='2.0'
LIBPARTED_MAX_WANTED_VERSION='3.0'
AC_MSG_CHECKING([for $LIBPARTED_MIN_WANTED_VERSION <= libparted <= $LIBPARTED_MAX_WANTED_VERSION (loop table creation doesn't delete old partitions)])
LIBPARTED_MIN_WANTED_INT=`echo "$LIBPARTED_MIN_WANTED_VERSION" |
Fix configuration version compare issue affecting libparted from GIT (#753525) When configuring GParted build with libparted from GIT it may perform the version compares incorrectly and think the version of libparted is higher that it actually is. Libparted uses the number of commits from the last git tag as the third part of the version number. For example install libparted from one commit before release 3.1, 142 commits after release 3.0. $ git checkout v3.1^ $ describe v3.0-142-g82327a3 $ ./bootstrap $ ./configure --prefix=/tmp/parted-3.0-git $ make && make install Configure GParted: $ export CPPFLAGS=-I/tmp/parted-3.0-git/include $ export LDFLAGS=-L/tmp/parted-3.0-git/lib $ export LD_RUN_PATH=/tmp/parted-3.0-git/lib $ export PKG_CONFIG_PATH=/tmp/parted-3.0-git/lib/pkgconfig $ ./configure ... checking for libparted >= 1.7.1 (querying pkg-config)... 3.0.142-8232 checking for 2.0 <= libparted <= 3.0 (loop table creation doesn't delete old partitions)... (cached) no checking for libparted >= 2.2 (improved pt re-read)... (cached) yes checking for ped_file_system_resize in -lparted... no checking for ped_file_system_resize in -lparted-fs-resize... yes checking for libparted >= 3.2 (online resize)... (cached) no ... Libparted is reported as version 3.0.142, but checking of the version between 2.0 and 3.0 inclusive fails. The configure script is multiplying components of the version by 100 when adding them together. $ echo 3.0.142-8232 | awk -F. '{print $1 * 10000 + $2 * 100 + $3}' 30142 So it is only allowing up to 99 commits before it is equivalent to the second minor number increasing by one. Increase the multiplication factor to 10000, allowing up to 9999 commits between releases. An order of magnitude more commits than so far seen between parted releases. Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
2015-08-11 12:29:12 -06:00
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
Fix failure to recognise whole disk file systems in certain cases (#743181) When the following conditions were met GParted would fail to recognise a newly created whole disk device file system, and instead show an unknown file system filling the disk: 1) Disk was previously partitioned and contained at least one partition. 2) Using libparted version 2.0 to 3.0 inclusive. Initial status: # blkid | fgrep sdc # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 # parted /dev/sdc GNU Parted 2.4 Using /dev/sdc Welcome to GNU Parted! Type 'help' to view a list of commands. (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: msdos Number Start End Size Type File system Flags 1 1049kB 107GB 107GB primary When creating the loop partition table libparted would not inform the kernel to delete the old partitions. /proc/partitions still contained the details of the old partitions. (parted) mktable loop Warning: The existing disk label on /dev/sdc will be destroyed and all data on this disk will be lost. Do you want to continue? Yes/No? Yes (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: loop Number Start End Size File system Flags (parted) quit # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 Creation of the whole disk device file system goes unnoticed by blkid because the kernel and therefore blkid's cache have stale partition information. # mkfs.xfs -f /dev/sdc # blkid | fgrep sdc NOTE: On a Linux Software RAID array, as opposed to a hard disk, blkid does notice creation of the whole disk device file system. However the kernel still has old partition details. This was fixed in libparted 3.1 by commit: http://git.savannah.gnu.org/cgit/parted.git/commit/?id=f5c909c0cd50ed52a48dae6d35907dc08b137e88 libparted: remove has_partitions check to allow loopback partitions Fix by deleting old partitions before creating the loop table when compiled with a broken version of libparted. The GParted UI provides no feedback while a new partition table is created, and with some versions of GTK the UI become unresponsive too, so it is important to be as fast as possible. Evaluated three different methods, deleting 15 and 22 MSDOS partitions on a physical 5400 RPM hard drive using libparted 2.4: M1) Delete and commit one partition at a time. Takes up to 24 seconds to delete 15 partitions. With 22 partitions libparted always reports finding some of the partitions busy and unable to inform the kernel about the modifications. Too slow and doesn't work. M2) Delete all partitions in one go and commit once. Takes up to 1.4 seconds to delete either 15 or 22 partitions. Never removes partitions 17 and higher from the kernel. Doesn't work. M3) Write GPT table (letting libparted delete any old partitions). Takes up to 0.8 seconds to delete either 15 or 22 partitions. Fast and works. Use method 3 - write a GPT table thus using libparted code to inform the kernel of the old partition deletions. Bug 743181 - Add unpartitioned drive read-write support
2015-02-21 09:43:42 -07:00
LIBPARTED_MAX_WANTED_INT=`echo "$LIBPARTED_MAX_WANTED_VERSION" |
Fix configuration version compare issue affecting libparted from GIT (#753525) When configuring GParted build with libparted from GIT it may perform the version compares incorrectly and think the version of libparted is higher that it actually is. Libparted uses the number of commits from the last git tag as the third part of the version number. For example install libparted from one commit before release 3.1, 142 commits after release 3.0. $ git checkout v3.1^ $ describe v3.0-142-g82327a3 $ ./bootstrap $ ./configure --prefix=/tmp/parted-3.0-git $ make && make install Configure GParted: $ export CPPFLAGS=-I/tmp/parted-3.0-git/include $ export LDFLAGS=-L/tmp/parted-3.0-git/lib $ export LD_RUN_PATH=/tmp/parted-3.0-git/lib $ export PKG_CONFIG_PATH=/tmp/parted-3.0-git/lib/pkgconfig $ ./configure ... checking for libparted >= 1.7.1 (querying pkg-config)... 3.0.142-8232 checking for 2.0 <= libparted <= 3.0 (loop table creation doesn't delete old partitions)... (cached) no checking for libparted >= 2.2 (improved pt re-read)... (cached) yes checking for ped_file_system_resize in -lparted... no checking for ped_file_system_resize in -lparted-fs-resize... yes checking for libparted >= 3.2 (online resize)... (cached) no ... Libparted is reported as version 3.0.142, but checking of the version between 2.0 and 3.0 inclusive fails. The configure script is multiplying components of the version by 100 when adding them together. $ echo 3.0.142-8232 | awk -F. '{print $1 * 10000 + $2 * 100 + $3}' 30142 So it is only allowing up to 99 commits before it is equivalent to the second minor number increasing by one. Increase the multiplication factor to 10000, allowing up to 9999 commits between releases. An order of magnitude more commits than so far seen between parted releases. Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
2015-08-11 12:29:12 -06:00
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
Fix failure to recognise whole disk file systems in certain cases (#743181) When the following conditions were met GParted would fail to recognise a newly created whole disk device file system, and instead show an unknown file system filling the disk: 1) Disk was previously partitioned and contained at least one partition. 2) Using libparted version 2.0 to 3.0 inclusive. Initial status: # blkid | fgrep sdc # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 # parted /dev/sdc GNU Parted 2.4 Using /dev/sdc Welcome to GNU Parted! Type 'help' to view a list of commands. (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: msdos Number Start End Size Type File system Flags 1 1049kB 107GB 107GB primary When creating the loop partition table libparted would not inform the kernel to delete the old partitions. /proc/partitions still contained the details of the old partitions. (parted) mktable loop Warning: The existing disk label on /dev/sdc will be destroyed and all data on this disk will be lost. Do you want to continue? Yes/No? Yes (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: loop Number Start End Size File system Flags (parted) quit # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 Creation of the whole disk device file system goes unnoticed by blkid because the kernel and therefore blkid's cache have stale partition information. # mkfs.xfs -f /dev/sdc # blkid | fgrep sdc NOTE: On a Linux Software RAID array, as opposed to a hard disk, blkid does notice creation of the whole disk device file system. However the kernel still has old partition details. This was fixed in libparted 3.1 by commit: http://git.savannah.gnu.org/cgit/parted.git/commit/?id=f5c909c0cd50ed52a48dae6d35907dc08b137e88 libparted: remove has_partitions check to allow loopback partitions Fix by deleting old partitions before creating the loop table when compiled with a broken version of libparted. The GParted UI provides no feedback while a new partition table is created, and with some versions of GTK the UI become unresponsive too, so it is important to be as fast as possible. Evaluated three different methods, deleting 15 and 22 MSDOS partitions on a physical 5400 RPM hard drive using libparted 2.4: M1) Delete and commit one partition at a time. Takes up to 24 seconds to delete 15 partitions. With 22 partitions libparted always reports finding some of the partitions busy and unable to inform the kernel about the modifications. Too slow and doesn't work. M2) Delete all partitions in one go and commit once. Takes up to 1.4 seconds to delete either 15 or 22 partitions. Never removes partitions 17 and higher from the kernel. Doesn't work. M3) Write GPT table (letting libparted delete any old partitions). Takes up to 0.8 seconds to delete either 15 or 22 partitions. Fast and works. Use method 3 - write a GPT table thus using libparted code to inform the kernel of the old partition deletions. Bug 743181 - Add unpartitioned drive read-write support
2015-02-21 09:43:42 -07:00
if test "$LIBPARTED_MIN_WANTED_INT" -le "$LIBPARTED_FOUND_INT" -a \
"$LIBPARTED_FOUND_INT" -le "$LIBPARTED_MAX_WANTED_INT"; then
need_loop_delete_old_ptns_workaround=yes
AC_DEFINE([ENABLE_LOOP_DELETE_OLD_PTNS_WORKAROUND], 1,
[Define to 1 to enable deletion of old partitions before creating a loop table workaround])
AC_MSG_RESULT([(cached) yes])
else
need_loop_delete_old_ptns_workaround=no
AC_MSG_RESULT([(cached) no])
fi
dnl Check for ped_file_system_resize() function to determine the existence
dnl of the API in the original parted library. Available in parted <= 2.4.
dnl
dnl NOTE:
dnl For AC_CHECK_LIB the default action-if-found ($3) includes extending
dnl LIBS with the newly found library ($1) thus:
dnl LIBS="-l$1 $LIBS"
dnl
dnl As the default action-if-found is overridden, LIBS isn't extended so
dnl saving and restoring LIBS isn't required.
have_old_lp_fs_resize_api=no
AC_CHECK_LIB(
[parted], [ped_file_system_resize],
[have_old_lp_fs_resize_api=yes]
)
dnl If not already found, check for ped_file_system_resize() function in
dnl the parted-fs-resize library to determine the need to use the new
dnl library. Available in parted >= 3.1.
have_new_lp_fs_resize_lib=no
AS_IF(
[test "x$have_old_lp_fs_resize_api" != xyes],
[AC_CHECK_LIB(
[parted-fs-resize], [ped_file_system_resize],
[have_new_lp_fs_resize_lib=yes
LIBS="-lparted-fs-resize $LIBS"
]
)]
)
Only explicitly flush devices when using libparted < 3.2 (#259) During device probing GParted always explicitly calls ped_device_sync() to flush the caches for coherency between the whole disk device and the partition devices [1]. As the GParted_Core::flush_device() comment explains, since v3.1.61-gfb99ba5 [2], libparted flushes the devices every time a device is opened [3], so also explicitly doing this in GParted is unnecessary. Therefore stop explicitly flushing the devices in GParted, except when using libparted 3.1 and older which doesn't do it itself. The ped_device_open() and ped_device_close() needed for the ped_device_sync() is also a trigger of device changes and udev rule execution performing LVM Volume Group activation, because libparted opens the device read-write [4]. This is another reason to remove it when possible. However even when eliminated it does not solve the issue of LVM VG activation because other triggers remain. Do want this change first though so that the sequence of libparted calls isn't changed immediately after documenting them and fixing the issue and so that there is no doubt that this change doesn't fix the issue. Removing this extra device flush saves a little bit of time, depending on the speed of the drive and number of partitions. Sample savings on my desktop: Drive type and partitions Saving (seconds) ----------------------------- ---------------- fast SSD with 3 partitions 0.05 slow SSD with 12 partitions 0.27 HDD with 1 partition 0.05 VHDD in VM with 1 partition 0.14 VHDD in VM with 10 partitions 0.58 Also the settle_device() call in flush_device() needs to be kept to wait for device changes and udev rule execution whether it is GParted explicitly flushing the device or just libparted automatically doing it for cache coherency in ped_device_get(). This is because: 1. Libparted <= 3.2 opens the whole disk device read-write for ped_device_get() [5]. (This was changed with parted v3.2.26-g44d5ae0 [6] to open the whole disk device read-only). 2. Libparted up to and including the latest 3.6 release still opens all partition devices read-write for ped_device_get() [7]. 3. A whole disk device FAT32 file system looks enough like a partition table that both the Linux kernel and libparted think it is partitioned: # mkfs.fat -F32 /dev/sdb mkfs.fat 4.2 (2021-01-31) # grep sdb /proc/partitions 8 16 8388608 sdb 8 17 8388607 sdb1 # parted /dev/sdb print Model: ATA VBOX HARDDISK (scsi) Disk /dev/sdb: 8590MB Sector size (logical/physical): 512B/512B Partition Table: loop Disk Flags: Number Start End Size File system Flags 1 0s 16777215s 16777216s fat32 So the ped_device_get() call on a whole disk device FAT32 file system still triggers device change and udev rule execution which needs to be waited for, as this is exactly the case fixed previously by commit: 1382e0b828f630a705cecd97c346dfc6267909bf Wait for udev change on /dev/DISK when querying whole device FS (!46) [1] 3bea067596e3e2d6513cda2a66df1b3e4fa432fb Flush devices when scanning to prevent reading stale signatures (#723842) [2] Revert "linux-commit: do not unnecessarily open partition device nodes" http://git.savannah.gnu.org/cgit/parted.git/commit/?id=fb99ba5ebd0dc34204fc9f1014131d5d494805bc [3] parted libparted/arch/linux.c:_device_open() https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6#n1752 1709 static int 1710 linux_open (PedDevice* dev) 1711 { 1712 return _device_open (dev, RW_MODE); 1713 } 1714 1715 static int 1716 _device_open (PedDevice* dev, int flags) ... 1752 _flush_cache (dev); [4] parted libparted/device.c:ped_device_open() v3.6 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/device.c?h=v3.6#n226 parted libparted/arch/linux.c v3.6 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6 ped_device_open(...) ped_architecture->dev_ops->open(...) = linux_open(...) _device_open(..., RW_MODE) open(..., O_RDWR) [5] parted libparted/device.c:ped_device_get() v3.2 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/device.c?h=v3.2#n149 parted libparted/arch/linux.c v3.2 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.2 ped_device_get(...) ped_architecture->dev_ops->_new(...) = linux_new() init_ide(...) init_scsi(...) init_generic(...) ped_device_open(...) ped_architecture->dev_ops->open(...) = linux_open(...) open(..., O_RDWR) [6] libparted: Use read only when probing devices on linux (#1245144) http://git.savannah.gnu.org/cgit/parted.git/commit/?id=44d5ae0115c4ecfe3158748309e9912c5aede92d [7] parted libparted/arch/linux.v v3.6 http://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6#n1660 1660 static void 1661 _flush_cache (PedDevice* dev) ... 1673 for (i = 1; i < lpn; i++) { ... 1680 if (!_partition_is_mounted_by_path(name)) { 1681 fd = open (name, WR_MODE, 0); Closes #259 - Trying to deactivate LVM PV fails
2024-08-25 13:19:09 -06:00
dnl Check for libparted < 3.2 which needs explicit flush for coherency between
dnl whole disk device and partition devices.
LIBPARTED_FIXED_VERSION='3.2'
AC_MSG_CHECKING([for libparted < $LIBPARTED_FIXED_VERSION (need explicit flush for device coherency workaround)])
LIBPARTED_FIXED_INT=`echo "$LIBPARTED_FIXED_VERSION" |
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
if test "$LIBPARTED_FOUND_INT" -lt "$LIBPARTED_FIXED_INT"; then
need_explicit_flush_workaround=yes
AC_DEFINE([ENABLE_EXPLICIT_FLUSH_WORKAROUND], 1,
[Define to 1 to enable explicit flush for device coherency workaround])
AC_MSG_RESULT([(cached) yes])
else
need_explicit_flush_workaround=no
AC_MSG_RESULT([(cached) no])
fi
dnl Check for libparted >= 3.2 for online resize support.
LIBPARTED_WANTED_VERSION='3.2'
AC_MSG_CHECKING([for libparted >= $LIBPARTED_WANTED_VERSION (online resize)])
LIBPARTED_WANTED_INT=`echo "$LIBPARTED_WANTED_VERSION" |
Fix configuration version compare issue affecting libparted from GIT (#753525) When configuring GParted build with libparted from GIT it may perform the version compares incorrectly and think the version of libparted is higher that it actually is. Libparted uses the number of commits from the last git tag as the third part of the version number. For example install libparted from one commit before release 3.1, 142 commits after release 3.0. $ git checkout v3.1^ $ describe v3.0-142-g82327a3 $ ./bootstrap $ ./configure --prefix=/tmp/parted-3.0-git $ make && make install Configure GParted: $ export CPPFLAGS=-I/tmp/parted-3.0-git/include $ export LDFLAGS=-L/tmp/parted-3.0-git/lib $ export LD_RUN_PATH=/tmp/parted-3.0-git/lib $ export PKG_CONFIG_PATH=/tmp/parted-3.0-git/lib/pkgconfig $ ./configure ... checking for libparted >= 1.7.1 (querying pkg-config)... 3.0.142-8232 checking for 2.0 <= libparted <= 3.0 (loop table creation doesn't delete old partitions)... (cached) no checking for libparted >= 2.2 (improved pt re-read)... (cached) yes checking for ped_file_system_resize in -lparted... no checking for ped_file_system_resize in -lparted-fs-resize... yes checking for libparted >= 3.2 (online resize)... (cached) no ... Libparted is reported as version 3.0.142, but checking of the version between 2.0 and 3.0 inclusive fails. The configure script is multiplying components of the version by 100 when adding them together. $ echo 3.0.142-8232 | awk -F. '{print $1 * 10000 + $2 * 100 + $3}' 30142 So it is only allowing up to 99 commits before it is equivalent to the second minor number increasing by one. Increase the multiplication factor to 10000, allowing up to 9999 commits between releases. An order of magnitude more commits than so far seen between parted releases. Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
2015-08-11 12:29:12 -06:00
$AWK -F. '{print $1 * 1000000 + $2 * 10000 + $3}'`
if test "$LIBPARTED_FOUND_INT" -ge "$LIBPARTED_WANTED_INT"; then
have_online_resize=yes
AC_MSG_RESULT([(cached) yes])
else
have_online_resize=no
AC_MSG_RESULT([(cached) no])
fi
dnl Check if have libparted fs resize capability
if test [ ${have_old_lp_fs_resize_api} = yes -o ${have_new_lp_fs_resize_lib} = yes ]; then
AC_DEFINE([HAVE_LIBPARTED_FS_RESIZE], [1], [Define to 1 if have libparted fs resize capability])
fi
dnl gthread
PKG_CHECK_MODULES([GTHREAD], [gthread-2.0])
AC_SUBST([GTHREAD_LIBS])
AC_SUBST([GTHREAD_CFLAGS])
dnl GTKMM
PKG_CHECK_MODULES([GTKMM], [gtkmm-3.0 >= 3.18.0])
AC_SUBST([GTKMM_LIBS])
AC_SUBST([GTKMM_CFLAGS])
2004-09-23 13:32:57 -06:00
2004-09-20 09:46:21 -06:00
dnl Check for glibmm minimum required version.
Remove deprecated Glib::thread_init() (!22) Use of Glib::thread_init() was deprecated in glibmm 2.32 [1]. The oldest supported distributions have these versions: Debian 8 glibmm 2.42.0 RHEL / CentOS 7 glibmm 2.56.0 SLES 12 glibmm 2.38.1 Ubuntu 14.04 LTS glibmm 2.39.93 Checking further the glibmm 2.32 reference manual says this about Glib::thread_init() [2]: Initializes the GLib thread system. Deprecated: Calling thread_init() is no longer necessary and no longer has any effect. However only some of the glibmm example programs had Glib::thread_init() removed, others had it replaced by Glib::init() [3]. Again the glibmm 2.32 reference manual says this about Glib::init() [4]: Initialize glibmm. You may call this more than once. You do not need to call this if you are using Glib::MainLoop or Gtk::Main, because they call it for you. GParted does call Gtk::Main and test_PipeCapture does call Glib::MainLoop. Therefore just raise the minimum version to glibmm 2.32 and remove both calls to Glib::thread_init(). [1] Glibmm 2.32 NEWS file https://gitlab.gnome.org/GNOME/glibmm/blob/2.32.0/NEWS#L207 [2] glibmm 2.32, glibmm: Glib Namespace Reference, Glib::thread_init() https://developer.gnome.org/glibmm/2.32/namespaceGlib.html#ab26d01c776801f1fff00753e97af4fc7 [3] glibmm commit "Avoid use of deprecates API in tests and examples." https://gitlab.gnome.org/GNOME/glibmm/commit/3e0fbb22c0d4814de4174d32e12a45cbad79980e [4] glibmm 2.32, glibmm: Glib Namespace Reference, Glib::init() https://developer.gnome.org/glibmm/2.32/namespaceGlib.html#ac90aee10d0b90e3d8a96a86b5394f87b Closes !22 - Increase minimums to libparted 2.2 and glibmm 2.32
2018-12-24 02:52:15 -07:00
PKG_CHECK_MODULES([GLIBMM], [glibmm-2.4 >= 2.32.0])
Always require C++11 compilation (!117) All the oldest supported distributions now have versions of GTK C++ libraries which require C++11 compilation, therefore forcing GParted to require C++11 compilation [1][2][3]. Fragment of existing ./configure output which lists the library versions requiring C++11 compilation: $ ./configure ... checking for glibmm >= 2.45.40 which requires C++11 compilation... yes checking for libsigc++ >= 2.5.1 which requires C++11 compilation... yes checking for gtkmm >= 3.18.0 which requires C++11 compilation... yes checking whether g++ supports C++11 features with -std=gnu++11... yes The oldest supported distributions and their versions of GTK C++ libraries and GCC compiler: Distribution gtkmm glibmm libsigc++ gcc Debian 10 3.24.0 2.58.0 2.10.1 4.8.3 RHEL / CentOS 7.9 3.22.2 2.56.0 2.10.0 4.8.5 SLES 12 SP5 3.20.1 2.48.1 2.8.0 4.8 Ubuntu 20.04 LTS 3.24.2 2.64.2 2.10.2 9.3.0 Technically GCC didn't have full C++11 support until GCC 4.8.1 [6] and SLES 12 SP5 only has GCC 4.8 (as well as many later versions of GCC). However which ever version of the GCC compiler is being used to compile the GTK C++ libraries it must have all the features needed to compile those libraries. Simplify the configure script and just always require a C++11 capable compiler. This also allows the use of C++11 features in the GParted code. [1] commit cc0740148e6ba0da9e30608deea2aa13078c2584 port-to-gtk3: Switch to Gtkmm3 (#7) [2] commit 707bae6fed6783e84600c6143f0f4bfd7989f56f Enable C++11 compilation when using libsigc++ 2.5.1 and later (#758545) [3] commit d6d7cb2bbf2fc381b890f63bbbf626eacfc8cdf8 Enable C++11 compilation when using glibmm 2.45.40 and later (#756035) [4] SUSE Product Support Lifecycle, SUSE Linux Enterprise Server 12 https://www.suse.com/lifecycle/#suse-linux-enterprise-server-12 [5] SUSE package search https://scc.suse.com/packages?name=SUSE%20Linux%20Enterprise%20Server&version=12.5&arch=x86_64&query=&module= [6] C++ Standards Support in GCC, C++11 Support in GCC https://gcc.gnu.org/projects/cxx-status.html#cxx11 Closes !117 - Require C++11 compilation
2023-08-30 12:01:40 -06:00
dnl Require C++11 compilation.
AX_CXX_COMPILE_STDCXX_11()
Request natural width in Gtk::ScrolledWindows for Gtk >= 3.22 (!39) Before Gtk 3.22 GtkScrolledWindow propagated natural size to its Children and so on to descendants. In Gtk 3.22 this was changed to always request the minimum size. This was done because it is believed to be a safer default (gives a better behaviour) in case of dynamic content inside the scrolled window, that is, content that may change allocated size. [1][2][3] When the scrolled window content is not dynamic the natural size is preferable because it gives a better looking layout and without any downside. In the case of GParted content which is not dynamic, so request the scrolled windows to allocate children at natural sizes for Gtk >= 3.22. The benefits of natural size allocation are evident in presence of wrapping labels (for example inside the "Partition Info" dialog), that with the minimum size request likely end up taking a very small width. References: [1] Gtk commit from 2016-08-31: GtkScrolledWindow: Make propagation of natural child sizes optional https://gitlab.gnome.org/GNOME/gtk/commit/0984d1622d022bf67207f985f7842b6299818e20 "Making propagation of child natural sizes mandatory (or default, even) was evidently a mistake as this causes dynamic content in a scrolled window to resize it's parent when the scrolled window is competing for space with an adjacent widget." [2] Gtk 3.22 Reference Documentation - gtk_scrolled_window_set_propagate_natural_width https://developer.gnome.org/gtk3/3.22/GtkScrolledWindow.html#gtk-scrolled-window-set-propagate-natural-width [3] Gtkmm 3.24 Gtk::ScrolledWindow Class Reference, set_propagate_natural_width() method https://developer.gnome.org/gtkmm/3.24/classGtk_1_1ScrolledWindow.html#a2d4cb945688ecb8739efd70b18742779 [4] Gtkmm 3.21.6 NEWS https://gitlab.gnome.org/GNOME/gtkmm/blob/3.21.6/NEWS "ScrolledWindow: Added get/set_propagate_natural_height/width() and the properties." Closes !39 - Always request natural size inside Gtk::ScrolledWindow
2019-05-01 04:57:38 -06:00
dnl Check for gtkmm >= 3.22 to determine availability of Gtk::ScrolledWindow::set_propagate_natural_width().
AC_MSG_CHECKING([for Gtk::ScrolledWindow::set_propagate_natural_width() method])
PKG_CHECK_EXISTS(
[gtkmm-3.0 >= 3.22.0],
[AC_DEFINE([HAVE_SET_PROPAGATE_NATURAL_WIDTH], 1,
[Define to 1 if gtkmm provides Gtk::ScrolledWindow::set_propagate_natural_width() method.])
AC_MSG_RESULT([yes])
],
[AC_MSG_RESULT([no])]
)
dnl Check for gtk+-3.0 >= 3.22 to determine availability of gtk_show_uri_on_window() function.
AC_MSG_CHECKING([for gtk_show_uri_on_window() function])
PKG_CHECK_EXISTS(
[gtk+-3.0 >= 3.22.0],
[AC_DEFINE([HAVE_GTK_SHOW_URI_ON_WINDOW], 1,
[Define to 1 if gtk provides gtk_show_uri_on_window function.])
AC_MSG_RESULT([yes])
],
[AC_MSG_RESULT([no])]
)
dnl Definitions for building of and with gtest. Gets flags for pthread via earlier
dnl gthread package check.
GTEST_CPPFLAGS="-DGTEST_HAS_PTHREAD=1"
GTEST_CXXFLAGS="$GTHREAD_CFLAGS $GTKMM_CFLAGS"
GTEST_LDFLAGS=
GTEST_LIBS="$GTHREAD_LIBS $GTKMM_LIBS"
AC_SUBST([GTEST_CPPFLAGS])
AC_SUBST([GTEST_CXXFLAGS])
AC_SUBST([GTEST_LDFLAGS])
AC_SUBST([GTEST_LIBS])
dnl======================
dnl check whether to build documentation - gnome-doc-utils
dnl======================
AC_ARG_ENABLE(
[doc],
AS_HELP_STRING(
[--disable-doc],
dnl Autoconf quadrigraphs '@<:@' = '[' and '@:>@' = ']'
[disable building help documentation @<:@default=enabled@:>@]),
[enable_doc=$enableval],
[enable_doc=yes]
)
AC_MSG_CHECKING([whether help documentation should be built])
if test "x$enable_doc" = xyes; then
AC_DEFINE([ENABLE_HELP_DOC], [1], [Define to 1 when help documentation is built])
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no])
fi
if test "x$enable_doc" = xyes; then
dnl YELP_HELP_INIT has to start at column 0 for gnome-autogen.sh to detect it
dnl and automatically required yelp.m4.
YELP_HELP_INIT
fi
AM_CONDITIONAL([BUILD_HELP_DOC], [test "x$enable_doc" = xyes])
dnl======================
dnl check whether to use native libparted dmraid support
dnl======================
AC_ARG_ENABLE(
[libparted_dmraid],
AS_HELP_STRING(
[--enable-libparted-dmraid],
[use native libparted /dev/mapper dmraid support @<:@default=disabled@:>@]),
[enable_libparted_dmraid=$enableval],
[enable_libparted_dmraid=no]
)
AC_MSG_CHECKING([whether to use native libparted /dev/mapper dmraid support])
if test "x$enable_libparted_dmraid" = xyes; then
AC_DEFINE([USE_LIBPARTED_DMRAID], [1],
[Define to 1 to use native libparted /dev/mapper dmraid support])
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no])
fi
dnl======================
dnl check whether to enable online resize support
dnl======================
AC_ARG_ENABLE(
[online-resize],
AS_HELP_STRING(
[--enable-online-resize],
[enable online resize support @<:@default=auto@:>@]),
[enable_online_resize=$enableval],
[enable_online_resize=$have_online_resize]
)
AC_MSG_CHECKING([whether online resize support is enabled])
if test "x$enable_online_resize" = xyes; then
AC_DEFINE([ENABLE_ONLINE_RESIZE], [1], [Define to 1 if online resize is enabled])
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no])
fi
dnl Check whether to explicitly grant root access to the display.
AC_ARG_ENABLE(
[xhost-root],
AS_HELP_STRING(
[--enable-xhost-root],
[enable explicitly granting root access to the display @<:@default=disabled@:>@]),
[enable_xhost_root=$enableval],
[enable_xhost_root=no]
)
AC_MSG_CHECKING([whether to explicitly grant root access to the display])
if test "x$enable_xhost_root" = 'xyes'; then
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no])
fi
AC_SUBST([ENABLE_XHOST_ROOT], $enable_xhost_root)
AC_CONFIG_FILES([
2004-09-19 14:24:53 -06:00
Makefile
data/Makefile
data/icons/Makefile
doc/Makefile
help/Makefile
2004-09-19 14:24:53 -06:00
include/Makefile
lib/Makefile
lib/gtest/Makefile
2004-09-19 14:24:53 -06:00
src/Makefile
2004-09-20 09:46:21 -06:00
po/Makefile.in
tests/Makefile
2004-09-19 14:24:53 -06:00
])
AC_OUTPUT
dnl======================
dnl Summary
dnl======================
echo ""
echo "======================== Final configuration ==========================="
echo " Installing into prefix : $prefix"
echo ""
echo " Build help documentation? : $enable_doc"
echo ""
echo " Use native libparted dmraid support? : $enable_libparted_dmraid"
echo ""
echo " Explicitly grant root access to the display? : $enable_xhost_root"
echo ""
echo " --- Features Based On Libparted Version ---"
Fix failure to recognise whole disk file systems in certain cases (#743181) When the following conditions were met GParted would fail to recognise a newly created whole disk device file system, and instead show an unknown file system filling the disk: 1) Disk was previously partitioned and contained at least one partition. 2) Using libparted version 2.0 to 3.0 inclusive. Initial status: # blkid | fgrep sdc # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 # parted /dev/sdc GNU Parted 2.4 Using /dev/sdc Welcome to GNU Parted! Type 'help' to view a list of commands. (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: msdos Number Start End Size Type File system Flags 1 1049kB 107GB 107GB primary When creating the loop partition table libparted would not inform the kernel to delete the old partitions. /proc/partitions still contained the details of the old partitions. (parted) mktable loop Warning: The existing disk label on /dev/sdc will be destroyed and all data on this disk will be lost. Do you want to continue? Yes/No? Yes (parted) print Model: ATA ST1000LM024 HN-M (scsi) Disk /dev/sdc: 1000GB Sector size (logical/physical): 512B/4096B Partition Table: loop Number Start End Size File system Flags (parted) quit # fgrep sdc /proc/partitions 8 32 976762584 sdc 8 33 104857600 sdc1 Creation of the whole disk device file system goes unnoticed by blkid because the kernel and therefore blkid's cache have stale partition information. # mkfs.xfs -f /dev/sdc # blkid | fgrep sdc NOTE: On a Linux Software RAID array, as opposed to a hard disk, blkid does notice creation of the whole disk device file system. However the kernel still has old partition details. This was fixed in libparted 3.1 by commit: http://git.savannah.gnu.org/cgit/parted.git/commit/?id=f5c909c0cd50ed52a48dae6d35907dc08b137e88 libparted: remove has_partitions check to allow loopback partitions Fix by deleting old partitions before creating the loop table when compiled with a broken version of libparted. The GParted UI provides no feedback while a new partition table is created, and with some versions of GTK the UI become unresponsive too, so it is important to be as fast as possible. Evaluated three different methods, deleting 15 and 22 MSDOS partitions on a physical 5400 RPM hard drive using libparted 2.4: M1) Delete and commit one partition at a time. Takes up to 24 seconds to delete 15 partitions. With 22 partitions libparted always reports finding some of the partitions busy and unable to inform the kernel about the modifications. Too slow and doesn't work. M2) Delete all partitions in one go and commit once. Takes up to 1.4 seconds to delete either 15 or 22 partitions. Never removes partitions 17 and higher from the kernel. Doesn't work. M3) Write GPT table (letting libparted delete any old partitions). Takes up to 0.8 seconds to delete either 15 or 22 partitions. Fast and works. Use method 3 - write a GPT table thus using libparted code to inform the kernel of the old partition deletions. Bug 743181 - Add unpartitioned drive read-write support
2015-02-21 09:43:42 -07:00
echo " Need delete old partitions before"
echo " creating a loop table workaround? : $need_loop_delete_old_ptns_workaround"
echo " Have old libparted file system resizing API? : $have_old_lp_fs_resize_api"
echo " Have new libparted file system resizing LIB? : $have_new_lp_fs_resize_lib"
Only explicitly flush devices when using libparted < 3.2 (#259) During device probing GParted always explicitly calls ped_device_sync() to flush the caches for coherency between the whole disk device and the partition devices [1]. As the GParted_Core::flush_device() comment explains, since v3.1.61-gfb99ba5 [2], libparted flushes the devices every time a device is opened [3], so also explicitly doing this in GParted is unnecessary. Therefore stop explicitly flushing the devices in GParted, except when using libparted 3.1 and older which doesn't do it itself. The ped_device_open() and ped_device_close() needed for the ped_device_sync() is also a trigger of device changes and udev rule execution performing LVM Volume Group activation, because libparted opens the device read-write [4]. This is another reason to remove it when possible. However even when eliminated it does not solve the issue of LVM VG activation because other triggers remain. Do want this change first though so that the sequence of libparted calls isn't changed immediately after documenting them and fixing the issue and so that there is no doubt that this change doesn't fix the issue. Removing this extra device flush saves a little bit of time, depending on the speed of the drive and number of partitions. Sample savings on my desktop: Drive type and partitions Saving (seconds) ----------------------------- ---------------- fast SSD with 3 partitions 0.05 slow SSD with 12 partitions 0.27 HDD with 1 partition 0.05 VHDD in VM with 1 partition 0.14 VHDD in VM with 10 partitions 0.58 Also the settle_device() call in flush_device() needs to be kept to wait for device changes and udev rule execution whether it is GParted explicitly flushing the device or just libparted automatically doing it for cache coherency in ped_device_get(). This is because: 1. Libparted <= 3.2 opens the whole disk device read-write for ped_device_get() [5]. (This was changed with parted v3.2.26-g44d5ae0 [6] to open the whole disk device read-only). 2. Libparted up to and including the latest 3.6 release still opens all partition devices read-write for ped_device_get() [7]. 3. A whole disk device FAT32 file system looks enough like a partition table that both the Linux kernel and libparted think it is partitioned: # mkfs.fat -F32 /dev/sdb mkfs.fat 4.2 (2021-01-31) # grep sdb /proc/partitions 8 16 8388608 sdb 8 17 8388607 sdb1 # parted /dev/sdb print Model: ATA VBOX HARDDISK (scsi) Disk /dev/sdb: 8590MB Sector size (logical/physical): 512B/512B Partition Table: loop Disk Flags: Number Start End Size File system Flags 1 0s 16777215s 16777216s fat32 So the ped_device_get() call on a whole disk device FAT32 file system still triggers device change and udev rule execution which needs to be waited for, as this is exactly the case fixed previously by commit: 1382e0b828f630a705cecd97c346dfc6267909bf Wait for udev change on /dev/DISK when querying whole device FS (!46) [1] 3bea067596e3e2d6513cda2a66df1b3e4fa432fb Flush devices when scanning to prevent reading stale signatures (#723842) [2] Revert "linux-commit: do not unnecessarily open partition device nodes" http://git.savannah.gnu.org/cgit/parted.git/commit/?id=fb99ba5ebd0dc34204fc9f1014131d5d494805bc [3] parted libparted/arch/linux.c:_device_open() https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6#n1752 1709 static int 1710 linux_open (PedDevice* dev) 1711 { 1712 return _device_open (dev, RW_MODE); 1713 } 1714 1715 static int 1716 _device_open (PedDevice* dev, int flags) ... 1752 _flush_cache (dev); [4] parted libparted/device.c:ped_device_open() v3.6 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/device.c?h=v3.6#n226 parted libparted/arch/linux.c v3.6 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6 ped_device_open(...) ped_architecture->dev_ops->open(...) = linux_open(...) _device_open(..., RW_MODE) open(..., O_RDWR) [5] parted libparted/device.c:ped_device_get() v3.2 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/device.c?h=v3.2#n149 parted libparted/arch/linux.c v3.2 https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.2 ped_device_get(...) ped_architecture->dev_ops->_new(...) = linux_new() init_ide(...) init_scsi(...) init_generic(...) ped_device_open(...) ped_architecture->dev_ops->open(...) = linux_open(...) open(..., O_RDWR) [6] libparted: Use read only when probing devices on linux (#1245144) http://git.savannah.gnu.org/cgit/parted.git/commit/?id=44d5ae0115c4ecfe3158748309e9912c5aede92d [7] parted libparted/arch/linux.v v3.6 http://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6#n1660 1660 static void 1661 _flush_cache (PedDevice* dev) ... 1673 for (i = 1; i < lpn; i++) { ... 1680 if (!_partition_is_mounted_by_path(name)) { 1681 fd = open (name, WR_MODE, 0); Closes #259 - Trying to deactivate LVM PV fails
2024-08-25 13:19:09 -06:00
echo " Need explicit flush for device coherency"
echo " workaround? : $need_explicit_flush_workaround"
echo " Enable online resize support? : $enable_online_resize"
echo ""
echo " If all settings are OK, type make and then (as root) make install"
echo "========================================================================"