Mirrors
/
gparted
mirror of https://gitlab.gnome.org/GNOME/gparted.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gparted/src/Win_GParted.cc

3018 lines
110 KiB
C++
Raw Normal View History

Cleanup file copyright entries Restore copyright entries by original author to those of his last known repository commit titled "released gparted-0.3.4 on LarryT's request." on Feb 25, 2007. Add my own copyright entries for files in which I changed source code. Files in which I only made spelling changes do not have my copyright entry added.
2009-11-05 11:08:32 -07:00
/* Copyright (C) 2004 Bart
Add Mike Fleetwood to menu_help_about
2015-02-01 13:14:05 -07:00
* Copyright (C) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015 Curtis Gedak
Initial revision
2004-09-19 14:24:53 -06:00
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Replace obsolete FSF postal address in copyright notices (#721565) This is part of parent bug: Bug #721455 - Obsolete info in license text on multiple modules and GNOME Goal: https://wiki.gnome.org/Initiatives/GnomeGoals/Proposals * verify all source files to make sure they have a license and a copyright, and that both are up-to-date Bug #721565 - License text contains obsolete FSF postal address
2014-01-23 03:59:48 -07:00
* GNU General Public License for more details.
Initial revision
2004-09-19 14:24:53 -06:00
*
* You should have received a copy of the GNU General Public License
Replace obsolete FSF postal address in copyright notices (#721565) This is part of parent bug: Bug #721455 - Obsolete info in license text on multiple modules and GNOME Goal: https://wiki.gnome.org/Initiatives/GnomeGoals/Proposals * verify all source files to make sure they have a license and a copyright, and that both are up-to-date Bug #721565 - License text contains obsolete FSF postal address
2014-01-23 03:59:48 -07:00
* along with this program; if not, see <http://www.gnu.org/licenses/>.
Initial revision
2004-09-19 14:24:53 -06:00
*/
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
#include "../include/Win_GParted.h"
:get_tmp_dir() instead of hardcoding it as '/tmp' :find_program_in_path() * use Glib::get_tmp_dir() instead of hardcoding it as '/tmp' * use Glib::find_program_in_path() instead af a system/which combi * display current device in windowtitle
2006-01-24 05:31:58 -07:00
#include "../include/Dialog_Progress.h"
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
#include "../include/DialogFeatures.h"
cleanups * include/Dialog_Partition_Info.h, include/Win_GParted.h, src/Win_GParted.cc: cleanups
2006-01-26 13:58:55 -07:00
#include "../include/Dialog_Disklabel.h"
Added support to lost data recovery using gpart
2011-01-28 11:09:21 -07:00
#include "../include/Dialog_Rescue_Data.h"
cleanups * include/Dialog_Partition_Info.h, include/Win_GParted.h, src/Win_GParted.cc: cleanups
2006-01-26 13:58:55 -07:00
#include "../include/Dialog_Partition_Resize_Move.h"
#include "../include/Dialog_Partition_Copy.h"
#include "../include/Dialog_Partition_New.h"
#include "../include/Dialog_Partition_Info.h"
Rename class to Dialog_FileSystem_Label (#741424) class Dialog_Partition_Label -> Dialog_FileSystem_Label file Dialog_Partition_Label.h -> Dialog_FileSystem_Label.h file Dialog_Partition_Label.cc -> Dialog_FileSystem_Label.cc Bug 741424 - Add support for GPT partition names
2014-12-19 14:08:28 -07:00
#include "../include/Dialog_FileSystem_Label.h"
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
#include "../include/Dialog_Partition_Name.h"
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
#include "../include/DialogManageFlags.h"
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
#include "../include/OperationCopy.h"
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
#include "../include/OperationCheck.h"
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
#include "../include/OperationCreate.h"
#include "../include/OperationDelete.h"
#include "../include/OperationFormat.h"
#include "../include/OperationResizeMove.h"
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
#include "../include/OperationChangeUUID.h"
Rename class to OperationLabelFileSystem (#741424) class OperationLabelPartition -> OperationLabelFileSystem file OperationLabelPartition.h -> OperationLabelFileSystem.h file OperationLabelPartition.cc -> OperationLabelFileSystem.cc Bug 741424 - Add support for GPT partition names
2014-12-19 13:41:08 -07:00
#include "../include/OperationLabelFileSystem.h"
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
#include "../include/OperationNamePartition.h"
Use PartitionVector class throughout the code (#759726) Replace all occurrences of std::vector<Partition> with PartitionVector. Bug 759726 - Implement Partition object polymorphism
2015-05-23 13:22:37 -06:00
#include "../include/Partition.h"
#include "../include/PartitionVector.h"
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
#include "../include/LVM2_PV_Info.h"
Use Btrfs handlers, if enabled at configure time GParted already has basic support only to recognize Btrfs volumes; if configured, use our newer methods to handle them. Also, put in place interface controls for all supported generic actions.
2010-01-02 04:13:31 -07:00
#include "../config.h"
Initial revision
2004-09-19 14:24:53 -06:00
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
#include <gtkmm/aboutdialog.h>
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
#include <gtkmm/messagedialog.h>
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
#include <gtkmm/radiobuttongroup.h>
finally fixed #169683!! ( party, party! :p ) cleanups * src/TreeView_Detail.cc: finally fixed #169683!! ( party, party! :p ) * include/Win_GParted.h, src/Win_GParted.cc, src/main.cc: cleanups
2006-02-10 15:16:31 -07:00
#include <gtkmm/main.h>
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
#include <gtkmm/separator.h>
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
namespace GParted
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added support for commandline arguments (#329414) * include/GParted_Core.h, include/Win_GParted.h, src/GParted_Core.cc, src/Win_GParted.cc, src/main.cc: added support for commandline arguments (#329414)
2006-02-02 06:50:37 -07:00
Win_GParted::Win_GParted( const std::vector<Glib::ustring> & user_devices )
Initial revision
2004-09-19 14:24:53 -06:00
{
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
copied_partition = NULL;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr = NULL;
Initial revision
2004-09-19 14:24:53 -06:00
new_count = 1;
P) It still needs a lot of love, but the foundations are laid =) * Rewrote a large part of gparteds internal code. Filesystemssupport is now much more separated from the rest of gparted and adding support for other filesystems should be a piece of cake now (hope that's true :P) It still needs a lot of love, but the foundations are laid =)
2004-11-17 06:00:25 -07:00
current_device = 0 ;
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
OPERATIONSLIST_OPEN = true ;
added support for commandline arguments (#329414) * include/GParted_Core.h, include/Win_GParted.h, src/GParted_Core.cc, src/Win_GParted.cc, src/main.cc: added support for commandline arguments (#329414)
2006-02-02 06:50:37 -07:00
gparted_core .set_user_devices( user_devices ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_NEW = TOOLBAR_NEW =
MENU_DEL = TOOLBAR_DEL =
MENU_RESIZE_MOVE = TOOLBAR_RESIZE_MOVE =
MENU_COPY = TOOLBAR_COPY =
MENU_PASTE = TOOLBAR_PASTE =
MENU_FORMAT =
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
MENU_TOGGLE_BUSY =
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_MOUNT =
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
MENU_NAME_PARTITION =
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_FLAGS =
MENU_INFO =
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
MENU_LABEL_PARTITION =
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
MENU_CHANGE_UUID =
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
TOOLBAR_UNDO =
TOOLBAR_APPLY = -1 ;
Initial revision
2004-09-19 14:24:53 -06:00
//==== GUI =========================
Removed 'deep_scan' flag. From now on all scans are 'deep scans'. Gui is * include/GParted_Core.h, src/GParted_Core.cc: Removed 'deep_scan' flag. From now on all scans are 'deep scans'. * include/Win_GParted.h, src/Win_GParted.cc: Gui is now loaded before anything else. (#161054)
2004-12-17 12:45:04 -07:00
this ->set_title( _("GParted") );
this ->set_default_size( 775, 500 );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
merry christmas cleanups replaced popen() with * merry christmas * src/GParted_Core.cc, src/VBox_VisualDisk.cc, src/Win_GParted.cc: cleanups * include/FileSystem.h, src/FileSystem.cc, src/ext2.cc, src/ext3.cc: replaced popen() with Glib::spawn_command_line_sync()
2005-12-24 16:55:54 -07:00
try
{
Add fallback method for specifying GParted icon (#695279) On RHEL / CentOS 5.9 GParted couldn't set an icon as the set_default_icon_name() method is not available. See commit [1] for details. Re-add the old set_icon_from_file() method as a fallback and re-install a GParted pixmap as was used before commit [2]. Commit [1]: a04210788399736ff7f097cb75650ebcbd0a4950 Only use Gtk::Window::set_default_icon_name method when available Commit [2]: f5a80bc9048ffa859aab40de27d96a5dd1d7f65b Enabled GParted to use themed app icon (Tango theme) Bug #695279 - GParted doesn't compile on RHEL / CentOS 5.9
2013-04-24 10:50:53 -06:00
#ifdef HAVE_SET_DEFAULT_ICON_NAME
Enabled GParted to use themed app icon (Tango theme). Thanks to Sebastion Kraft for designing the icons. Thanks to Michael Monreal for the small patch to make use of themed app icon from hicolor. svn path=/trunk/; revision=909
2008-09-22 16:41:49 -06:00
this ->set_default_icon_name( "gparted" ) ;
Add fallback method for specifying GParted icon (#695279) On RHEL / CentOS 5.9 GParted couldn't set an icon as the set_default_icon_name() method is not available. See commit [1] for details. Re-add the old set_icon_from_file() method as a fallback and re-install a GParted pixmap as was used before commit [2]. Commit [1]: a04210788399736ff7f097cb75650ebcbd0a4950 Only use Gtk::Window::set_default_icon_name method when available Commit [2]: f5a80bc9048ffa859aab40de27d96a5dd1d7f65b Enabled GParted to use themed app icon (Tango theme) Bug #695279 - GParted doesn't compile on RHEL / CentOS 5.9
2013-04-24 10:50:53 -06:00
#else
this ->set_icon_from_file( GNOME_ICONDIR "/gparted.png" ) ;
#endif
merry christmas cleanups replaced popen() with * merry christmas * src/GParted_Core.cc, src/VBox_VisualDisk.cc, src/Win_GParted.cc: cleanups * include/FileSystem.h, src/FileSystem.cc, src/ext2.cc, src/ext3.cc: replaced popen() with Glib::spawn_command_line_sync()
2005-12-24 16:55:54 -07:00
}
catch ( Glib::Exception & e )
Only use Gtk::Window::set_default_icon_name method when available (#695279) GParted fails to compile on RHEL/CentOS 5.9 because it doesn't provide the Gtk::Window::set_default_icon_name() method. The "gtkmm GTK::Window Class Reference" document says that set_default_icon_name() is available in gtkmm >= 2.6, however it is not available in RHEL/CentOS 5.9 with gtkmm 2.10. Add an autoconf compile and link check for the set_default_icon_name() method and make GParted only use the method when available. Bug #695279 - GParted doesn't compile on RHEL / CentOS 5.9
2013-03-03 16:01:05 -07:00
{
merry christmas cleanups replaced popen() with * merry christmas * src/GParted_Core.cc, src/VBox_VisualDisk.cc, src/Win_GParted.cc: cleanups * include/FileSystem.h, src/FileSystem.cc, src/ext2.cc, src/ext3.cc: replaced popen() with Glib::spawn_command_line_sync()
2005-12-24 16:55:54 -07:00
std::cout << e .what() << std::endl ;
Only use Gtk::Window::set_default_icon_name method when available (#695279) GParted fails to compile on RHEL/CentOS 5.9 because it doesn't provide the Gtk::Window::set_default_icon_name() method. The "gtkmm GTK::Window Class Reference" document says that set_default_icon_name() is available in gtkmm >= 2.6, however it is not available in RHEL/CentOS 5.9 with gtkmm 2.10. Add an autoconf compile and link check for the set_default_icon_name() method and make GParted only use the method when available. Bug #695279 - GParted doesn't compile on RHEL / CentOS 5.9
2013-03-03 16:01:05 -07:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//Pack the main box
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
this ->add( vbox_main );
Initial revision
2004-09-19 14:24:53 -06:00
//menubar....
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
init_menubar() ;
Initial revision
2004-09-19 14:24:53 -06:00
vbox_main .pack_start( menubar_main, Gtk::PACK_SHRINK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//toolbar....
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
init_toolbar() ;
Initial revision
2004-09-19 14:24:53 -06:00
vbox_main.pack_start( hbox_toolbar, Gtk::PACK_SHRINK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
//drawingarea_visualdisk... ( contains the visual represenation of the disks )
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
drawingarea_visualdisk .signal_partition_selected .connect(
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
sigc::mem_fun( this, &Win_GParted::on_partition_selected ) ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
drawingarea_visualdisk .signal_partition_activated .connect(
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
sigc::mem_fun( this, &Win_GParted::on_partition_activated ) ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
drawingarea_visualdisk .signal_popup_menu .connect(
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
sigc::mem_fun( this, &Win_GParted::on_partition_popup_menu ) );
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
vbox_main .pack_start( drawingarea_visualdisk, Gtk::PACK_SHRINK ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//hpaned_main (NOTE: added to vpaned_main)
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
init_hpaned_main() ;
Initial revision
2004-09-19 14:24:53 -06:00
vpaned_main .pack1( hpaned_main, true, true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//vpaned_main....
Removed 'deep_scan' flag. From now on all scans are 'deep scans'. Gui is * include/GParted_Core.h, src/GParted_Core.cc: Removed 'deep_scan' flag. From now on all scans are 'deep scans'. * include/Win_GParted.h, src/Win_GParted.cc: Gui is now loaded before anything else. (#161054)
2004-12-17 12:45:04 -07:00
vbox_main .pack_start( vpaned_main );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//device info...
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
init_device_info() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//operationslist...
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
hbox_operations .signal_undo .connect( sigc::mem_fun( this, &Win_GParted::activate_undo ) ) ;
hbox_operations .signal_clear .connect( sigc::mem_fun( this, &Win_GParted::clear_operationslist ) ) ;
hbox_operations .signal_apply .connect( sigc::mem_fun( this, &Win_GParted::activate_apply ) ) ;
hbox_operations .signal_close .connect( sigc::mem_fun( this, &Win_GParted::close_operationslist ) ) ;
Initial revision
2004-09-19 14:24:53 -06:00
vpaned_main .pack2( hbox_operations, true, true ) ;
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//statusbar...
removed separator in accordance to the HIG it's now possible to deactivate * src/Dialog_Partition_Info.cc: removed separator in accordance to the HIG * include/Win_GParted.h, src/Win_GParted.cc: it's now possible to deactivate swap from within gparted. * src/GParted_Core.cc: sleep one second after deletion of a partition to give the kernel some time to reread the partitiontable.
2006-01-07 14:23:09 -07:00
pulsebar .set_pulse_step( 0.01 );
statusbar .add( pulsebar );
logic unallocated space wasn't read correctly, fixed. added * src/Device.cc (Read_Disk_Layout): logic unallocated space wasn't read correctly, fixed. * include/Win_GParted.h: added open_operationslist() and menu_view_operations() . * src/Win_GParted.cc: tweaked operationlist behaviour a bit. Also added 'Operations" toggle-item to View menu.
2004-10-11 08:19:56 -06:00
vbox_main .pack_start( statusbar, Gtk::PACK_SHRINK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
this ->show_all_children();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
//make sure harddisk information is closed..
hpaned_main .get_child1() ->hide() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
Win_GParted::~Win_GParted()
{
delete copied_partition;
copied_partition = NULL;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::init_menubar()
Initial revision
2004-09-19 14:24:53 -06:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//fill menubar_main and connect callbacks
Initial revision
2004-09-19 14:24:53 -06:00
//gparted
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menu = manage( new Gtk::Menu() ) ;
Initial revision
2004-09-19 14:24:53 -06:00
image = manage( new Gtk::Image( Gtk::Stock::REFRESH, Gtk::ICON_SIZE_MENU ) );
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
menu ->items() .push_back( Gtk::Menu_Helpers::ImageMenuElem(
_("_Refresh Devices"),
Gtk::AccelKey("<control>r"),
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
*image,
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
sigc::mem_fun(*this, &Win_GParted::menu_gparted_refresh_devices) ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
image = manage( new Gtk::Image( Gtk::Stock::HARDDISK, Gtk::ICON_SIZE_MENU ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::ImageMenuElem( _("_Devices"), *image ) ) ;
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::SeparatorElem( ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::StockMenuElem(
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
Gtk::Stock::QUIT, sigc::mem_fun(*this, &Win_GParted::menu_gparted_quit) ) );
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menubar_main .items() .push_back( Gtk::Menu_Helpers::MenuElem( _("_GParted"), *menu ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Added a menu 'Edit' which contains 'Undo' and 'Apply'. (#322550) * include/Win_GParted.h, src/Win_GParted.cc: Added a menu 'Edit' which contains 'Undo' and 'Apply'. (#322550)
2005-11-27 12:48:00 -07:00
//edit
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menu = manage( new Gtk::Menu() ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::ImageMenuElem(
_("_Undo Last Operation"),
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
Gtk::AccelKey("<control>z"),
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
* manage( new Gtk::Image( Gtk::Stock::UNDO, Gtk::ICON_SIZE_MENU ) ),
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
sigc::mem_fun(*this, &Win_GParted::activate_undo) ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::ImageMenuElem(
_("_Clear All Operations"),
* manage( new Gtk::Image( Gtk::Stock::CLEAR, Gtk::ICON_SIZE_MENU ) ),
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
sigc::mem_fun(*this, &Win_GParted::clear_operationslist) ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::ImageMenuElem(
Bind ctrl-enter to apply-operations Bind the keyboard accelerator key ctrl-enter to apply operations.
2013-01-20 21:20:11 -07:00
_("_Apply All Operations"),
Gtk::AccelKey(GDK_Return, Gdk::CONTROL_MASK),
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
* manage( new Gtk::Image( Gtk::Stock::APPLY, Gtk::ICON_SIZE_MENU ) ),
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
sigc::mem_fun(*this, &Win_GParted::activate_apply) ) );
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menubar_main .items() .push_back( Gtk::Menu_Helpers::MenuElem( _("_Edit"), *menu ) );
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
//view
disabled resizing of this dialog renamed 'Filesystems' to 'Features' in * src/DialogManageFlags.cc: disabled resizing of this dialog * include/DialogFeatures.h, include/Makefile.am, include/Win_GParted.h, src/DialogFeatures.cc, src/Makefile.am, src/Win_GParted.cc: renamed 'Filesystems' to 'Features' in the featuredialog to better reflect the actual functionality * include/Dialog_Filesystems.h, src/Dialog_Filesystems.cc: removed
2006-04-05 03:33:04 -06:00
menu = manage( new Gtk::Menu() ) ;
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
menu ->items() .push_back( Gtk::Menu_Helpers::CheckMenuElem(
_("Device _Information"), sigc::mem_fun(*this, &Win_GParted::menu_view_harddisk_info) ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::CheckMenuElem(
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
_("Pending _Operations"), sigc::mem_fun(*this, &Win_GParted::menu_view_operations) ) );
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menubar_main .items() .push_back( Gtk::Menu_Helpers::MenuElem( _("_View"), *menu ) );
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
Moved menu entry "Gparted->Show Features" to "View->File System Support" svn path=/trunk/; revision=964
2008-11-14 12:41:14 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::SeparatorElem( ) );
menu ->items() .push_back( Gtk::Menu_Helpers::MenuElem(
_("_File System Support"), sigc::mem_fun( *this, &Win_GParted::menu_gparted_features ) ) );
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
//device
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menu = manage( new Gtk::Menu() ) ;
Removed space between menu entry and periods svn path=/trunk/; revision=1031
2009-01-13 11:14:20 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::MenuElem( Glib::ustring( _("_Create Partition Table") ) + "...",
usability stuff + trivial fix (#353109, #353111) * src/Win_GParted.cc: usability stuff + trivial fix (#353109, #353111)
2006-08-28 14:11:58 -06:00
sigc::mem_fun(*this, &Win_GParted::activate_disklabel) ) );
Added support to lost data recovery using gpart
2011-01-28 11:09:21 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::MenuElem( Glib::ustring( _("_Attempt Data Rescue") ) + "...",
sigc::mem_fun(*this, &Win_GParted::activate_attempt_rescue_data) ) );
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menubar_main .items() .push_back( Gtk::Menu_Helpers::MenuElem( _("_Device"), *menu ) );
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
//partition
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
init_partition_menu() ;
menubar_main .items() .push_back( Gtk::Menu_Helpers::MenuElem( _("_Partition"), menu_partition ) );
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
Initial revision
2004-09-19 14:24:53 -06:00
//help
menu = manage( new Gtk::Menu() ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back( Gtk::Menu_Helpers::ImageMenuElem(
_("_Contents"),
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
Gtk::AccelKey("F1"),
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
* manage( new Gtk::Image( Gtk::Stock::HELP, Gtk::ICON_SIZE_MENU ) ),
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
sigc::mem_fun(*this, &Win_GParted::menu_help_contents) ) );
menu ->items() .push_back( Gtk::Menu_Helpers::SeparatorElem( ) );
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
menu ->items() .push_back( Gtk::Menu_Helpers::StockMenuElem(
Gtk::Stock::ABOUT, sigc::mem_fun(*this, &Win_GParted::menu_help_about) ) );
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
menubar_main.items() .push_back( Gtk::Menu_Helpers::MenuElem(_("_Help"), *menu ) );
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::init_toolbar()
Initial revision
2004-09-19 14:24:53 -06:00
{
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
int index = 0 ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//initialize and pack toolbar_main
Initial revision
2004-09-19 14:24:53 -06:00
hbox_toolbar.pack_start( toolbar_main );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//NEW and DELETE
Make partition "New" label available for translation (#610540)
2010-02-22 10:30:14 -07:00
image = manage( new Gtk::Image( Gtk::Stock::NEW, Gtk::ICON_SIZE_BUTTON ) );
/*TO TRANSLATORS: "New" is a tool bar item for partition actions. */
Glib::ustring str_temp = _("New") ;
toolbutton = Gtk::manage(new Gtk::ToolButton( *image, str_temp ));
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
toolbutton ->signal_clicked() .connect( sigc::mem_fun( *this, &Win_GParted::activate_new ) );
toolbar_main .append( *toolbutton );
TOOLBAR_NEW = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
toolbutton ->set_tooltip(tooltips, _("Create a new partition in the selected unallocated space") );
Initial revision
2004-09-19 14:24:53 -06:00
toolbutton = Gtk::manage(new Gtk::ToolButton(Gtk::Stock::DELETE));
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
toolbutton ->signal_clicked().connect( sigc::mem_fun(*this, &Win_GParted::activate_delete) );
toolbar_main.append(*toolbutton);
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
TOOLBAR_DEL = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
toolbutton ->set_tooltip(tooltips, _("Delete the selected partition") );
Initial revision
2004-09-19 14:24:53 -06:00
toolbar_main.append( *(Gtk::manage(new Gtk::SeparatorToolItem)) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//RESIZE/MOVE
image = manage( new Gtk::Image( Gtk::Stock::GOTO_LAST, Gtk::ICON_SIZE_BUTTON ) );
Make partition "New" label available for translation (#610540)
2010-02-22 10:30:14 -07:00
str_temp = _("Resize/Move") ;
Added language length conditional Undo display. If translated language is relatively long, then split the "Resize/Move" toolbar button text into two lines, and do not display the "Undo" button. svn path=/trunk/; revision=971
2008-11-19 13:17:32 -07:00
//Condition string split and Undo button.
// for longer translated string, split string in two and skip the Undo button to permit full toolbar to display
// FIXME: Is there a better way to do this, perhaps without the conditional? At the moment this seems to be the best compromise.
bool display_undo = true ;
if( str_temp .length() > 14 ) {
Fixed crash on startup with Russian language svn path=/trunk/; revision=1061
2009-02-09 10:58:42 -07:00
size_t index = str_temp .find( "/" ) ;
if ( index != Glib::ustring::npos ) {
str_temp .replace( index, 1, "\n/" ) ;
display_undo = false ;
}
Added language length conditional Undo display. If translated language is relatively long, then split the "Resize/Move" toolbar button text into two lines, and do not display the "Undo" button. svn path=/trunk/; revision=971
2008-11-19 13:17:32 -07:00
}
toolbutton = Gtk::manage(new Gtk::ToolButton( *image, str_temp ));
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
toolbutton ->signal_clicked().connect( sigc::mem_fun(*this, &Win_GParted::activate_resize) );
toolbar_main.append(*toolbutton);
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
TOOLBAR_RESIZE_MOVE = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
toolbutton ->set_tooltip(tooltips, _("Resize/Move the selected partition") );
Initial revision
2004-09-19 14:24:53 -06:00
toolbar_main.append( *(Gtk::manage(new Gtk::SeparatorToolItem)) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Initial revision
2004-09-19 14:24:53 -06:00
//COPY and PASTE
toolbutton = Gtk::manage(new Gtk::ToolButton(Gtk::Stock::COPY));
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
toolbutton ->signal_clicked().connect( sigc::mem_fun(*this, &Win_GParted::activate_copy) );
toolbar_main.append(*toolbutton);
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
TOOLBAR_COPY = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
toolbutton ->set_tooltip(tooltips, _("Copy the selected partition to the clipboard") );
Initial revision
2004-09-19 14:24:53 -06:00
toolbutton = Gtk::manage(new Gtk::ToolButton(Gtk::Stock::PASTE));
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
toolbutton ->signal_clicked().connect( sigc::mem_fun(*this, &Win_GParted::activate_paste) );
toolbar_main.append(*toolbutton);
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
TOOLBAR_PASTE = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
toolbutton ->set_tooltip(tooltips, _("Paste the partition from the clipboard") );
Initial revision
2004-09-19 14:24:53 -06:00
toolbar_main.append( *(Gtk::manage(new Gtk::SeparatorToolItem)) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//UNDO and APPLY
Added language length conditional Undo display. If translated language is relatively long, then split the "Resize/Move" toolbar button text into two lines, and do not display the "Undo" button. svn path=/trunk/; revision=971
2008-11-19 13:17:32 -07:00
if ( display_undo ) {
//Undo button is displayed only if translated language "Resize/Move" is not too long. See above setting of this condition.
toolbutton = Gtk::manage(new Gtk::ToolButton(Gtk::Stock::UNDO));
toolbutton ->signal_clicked().connect( sigc::mem_fun(*this, &Win_GParted::activate_undo) );
toolbar_main.append(*toolbutton);
TOOLBAR_UNDO = index++ ;
toolbutton ->set_sensitive( false );
toolbutton ->set_tooltip(tooltips, _("Undo Last Operation") );
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
toolbutton = Gtk::manage(new Gtk::ToolButton(Gtk::Stock::APPLY));
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
toolbutton ->signal_clicked().connect( sigc::mem_fun(*this, &Win_GParted::activate_apply) );
toolbar_main.append(*toolbutton);
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
TOOLBAR_APPLY = index++ ;
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
toolbutton ->set_sensitive( false );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
toolbutton ->set_tooltip(tooltips, _("Apply All Operations") );
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
//initialize and pack combo_devices
liststore_devices = Gtk::ListStore::create( treeview_devices_columns ) ;
combo_devices .set_model( liststore_devices ) ;
fixed alignments of cells in combo_devices * src/Win_GParted.cc: fixed alignments of cells in combo_devices
2005-12-30 11:11:03 -07:00
combo_devices .pack_start( treeview_devices_columns .icon, false ) ;
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
combo_devices .pack_start( treeview_devices_columns .device ) ;
fixed alignments of cells in combo_devices * src/Win_GParted.cc: fixed alignments of cells in combo_devices
2005-12-30 11:11:03 -07:00
combo_devices .pack_start( treeview_devices_columns .size, false ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Prevent flashing redraw of the devices combobox (#696149) The device combobox was getting drawn blank, then getting drawn again with the selected device. This was happening because at the start of Win_GParted::refresh_combo_devices() the GTK model behind the combobox, liststore_devices, was cleared, changing the active item, causing the combobox to get redrawn empty. After the GTK model had been repopulated the active item was reset causing the comboxbox to get redrawn again, now showing the selected device. Call flow: Win_GParted::refresh_combo_devices() liststore_devices->clear() //Gtk::Combobox emits signal_change. Registered callbacks //called. Win_GParted::combo_devices_changed() Win_GParted::Refresh_Visual() ... ... combo_devices.set_active(current_device); //Gtk::Combobox emits signal_change. Registered callbacks //called. Win_GParted::combo_devices_changed() Win_GParted::Refresh_Visual() ... This has always been the case, since the device combobox was first added to GParted before version 0.1 by commit: 3a4b43e0adb3974dea656fcbe90d5e191e0e9784 replaced deprecated OptionMenu with ComboBox ... Fix by temporarily blocking the devices comboxbox from emitting signal_changed while the GTK model behind the combobox is recreated. However, since automatic selection of the largest free space was added [1] in GParted 0.15.0, a more noticeable flashing redraw issue was caused in which the partition graphic and partition list were both drawn blank then redrawn fully populated. Some distributions were not affected by this at all, some only experienced a single flash and others suffered from two or more flashing redraws. Some affected distributions: CentOS 5.10, 6.5, 7.0, Debian 6, Fedora 14, 19, 20, Ubuntu 13.10, Xubuntu 14.04 LTS. Did not occur on Kubuntu 12.04 LTS. [1] 5b53c12f6ee12312a9bacb44b8b05b12a540d3d6 Select largest unallocated partition by default (#667365) Bug #696149 - Double refresh of display introduced with default unallocated space
2014-08-22 04:35:39 -06:00
combo_devices_changed_connection =
combo_devices .signal_changed() .connect( sigc::mem_fun(*this, &Win_GParted::combo_devices_changed) );
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
hbox_toolbar .pack_start( combo_devices, Gtk::PACK_SHRINK ) ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::init_partition_menu()
Initial revision
2004-09-19 14:24:53 -06:00
{
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
int index = 0 ;
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
//fill menu_partition
Make partition "New" label available for translation (#610540)
2010-02-22 10:30:14 -07:00
image = manage( new Gtk::Image( Gtk::Stock::NEW, Gtk::ICON_SIZE_MENU ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items() .push_back(
Make partition "New" label available for translation (#610540)
2010-02-22 10:30:14 -07:00
/*TO TRANSLATORS: "_New" is a sub menu item for the partition menu. */
Bind Insert key to new partition Add an accelerator key for Insert to trigger the new partition menu item.
2013-01-20 20:52:52 -07:00
Gtk::Menu_Helpers::ImageMenuElem( _("_New"),
Gtk::AccelKey( GDK_Insert, Gdk::BUTTON1_MASK),
*image,
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
sigc::mem_fun(*this, &Win_GParted::activate_new) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_NEW = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items() .push_back(
Gtk::Menu_Helpers::StockMenuElem( Gtk::Stock::DELETE,
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
Gtk::AccelKey( GDK_Delete, Gdk::BUTTON1_MASK ),
sigc::mem_fun(*this, &Win_GParted::activate_delete) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_DEL = index++ ;
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
menu_partition .items() .push_back( Gtk::Menu_Helpers::SeparatorElem() );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
image = manage( new Gtk::Image( Gtk::Stock::GOTO_LAST, Gtk::ICON_SIZE_MENU ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items() .push_back(
Gtk::Menu_Helpers::ImageMenuElem( _("_Resize/Move"),
*image,
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
sigc::mem_fun(*this, &Win_GParted::activate_resize) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_RESIZE_MOVE = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
menu_partition .items() .push_back( Gtk::Menu_Helpers::SeparatorElem() );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items() .push_back(
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
Gtk::Menu_Helpers::StockMenuElem( Gtk::Stock::COPY,
sigc::mem_fun(*this, &Win_GParted::activate_copy) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_COPY = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items() .push_back(
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
Gtk::Menu_Helpers::StockMenuElem( Gtk::Stock::PASTE,
sigc::mem_fun(*this, &Win_GParted::activate_paste) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_PASTE = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
menu_partition .items() .push_back( Gtk::Menu_Helpers::SeparatorElem() );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
image = manage( new Gtk::Image( Gtk::Stock::CONVERT, Gtk::ICON_SIZE_MENU ) );
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
/*TO TRANSLATORS: menuitem which holds a submenu with file systems.. */
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
menu_partition .items() .push_back(
Gtk::Menu_Helpers::ImageMenuElem( _("_Format to"),
*image,
* create_format_menu() ) ) ;
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_FORMAT = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
menu_partition .items() .push_back( Gtk::Menu_Helpers::SeparatorElem() ) ;
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
menu_partition .items() .push_back(
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
//This is a placeholder text. It will be replaced with some other text before it is used
Gtk::Menu_Helpers::MenuElem( "--placeholder--",
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
sigc::mem_fun( *this, &Win_GParted::toggle_busy_state ) ) );
MENU_TOGGLE_BUSY = index++ ;
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
/*TO TRANSLATORS: menuitem which holds a submenu with mount points.. */
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
menu_partition .items() .push_back(
usability stuff + trivial fix (#353109, #353111) * src/Win_GParted.cc: usability stuff + trivial fix (#353109, #353111)
2006-08-28 14:11:58 -06:00
Gtk::Menu_Helpers::MenuElem( _("_Mount on"), * manage( new Gtk::Menu() ) ) ) ;
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_MOUNT = index++ ;
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
menu_partition .items() .push_back( Gtk::Menu_Helpers::SeparatorElem() ) ;
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
menu_partition.items().push_back(
Gtk::Menu_Helpers::MenuElem( _("_Name Partition"),
sigc::mem_fun( *this, &Win_GParted::activate_name_partition ) ) );
MENU_NAME_PARTITION = index++;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
menu_partition .items() .push_back(
usability stuff + trivial fix (#353109, #353111) * src/Win_GParted.cc: usability stuff + trivial fix (#353109, #353111)
2006-08-28 14:11:58 -06:00
Gtk::Menu_Helpers::MenuElem( _("M_anage Flags"),
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
sigc::mem_fun( *this, &Win_GParted::activate_manage_flags ) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_FLAGS = index++ ;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
menu_partition .items() .push_back(
Gtk::Menu_Helpers::MenuElem( _("C_heck"),
sigc::mem_fun( *this, &Win_GParted::activate_check ) ) );
MENU_CHECK = index++ ;
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
menu_partition .items() .push_back(
Rename Partition Label to File System Label in the GUI (#741424) Rename the Partition Label concept to File System Label throughout the GUI. This is to better reflect that it is the label of the file system that is being modified and to separate it from the Partition Name concept about to be added. Bug 741424 - Add support for GPT partition names
2014-12-15 16:20:12 -07:00
Gtk::Menu_Helpers::MenuElem( _("_Label File System"),
Rename methods in GParted_Core and Win_GParted classes (#741424) class GParted_Core: label_partition() -> label_filesystem() class Win_GParted: allow_label_partition() -> allow_label_filesystem() activate_label_partition() -> activate_label_filesystem() Bug 741424 - Add support for GPT partition names
2014-12-18 15:18:33 -07:00
sigc::mem_fun( *this, &Win_GParted::activate_label_filesystem ) ) );
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
MENU_LABEL_PARTITION = index++ ;
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
menu_partition .items() .push_back(
Gtk::Menu_Helpers::MenuElem( _("New UU_ID"),
sigc::mem_fun( *this, &Win_GParted::activate_change_uuid ) ) );
MENU_CHANGE_UUID = index++ ;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
menu_partition .items() .push_back( Gtk::Menu_Helpers::SeparatorElem() ) ;
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items() .push_back(
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
Gtk::Menu_Helpers::StockMenuElem( Gtk::Stock::DIALOG_INFO,
sigc::mem_fun(*this, &Win_GParted::activate_info) ) );
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
MENU_INFO = index++ ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .accelerate( *this ) ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Refactor Win_GParted::create_format_menu() (#688882) Move some code into new create_format_menu_add_item() sub-function which adds one file system entry to the Partition --> Format to --> (file system list) menu. Bug #688882 - Improve clearing of file system signatures
2012-12-07 14:30:15 -07:00
//Create the Partition --> Format to --> (file system list) menu
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
Gtk::Menu * Win_GParted::create_format_menu()
Initial revision
2004-09-19 14:24:53 -06:00
{
Refactor Win_GParted::create_format_menu() (#688882) Move some code into new create_format_menu_add_item() sub-function which adds one file system entry to the Partition --> Format to --> (file system list) menu. Bug #688882 - Improve clearing of file system signatures
2012-12-07 14:30:15 -07:00
const std::vector<FS> & fss = gparted_core .get_filesystems() ;
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
menu = manage( new Gtk::Menu() ) ;
Refactor Win_GParted::create_format_menu() (#688882) Move some code into new create_format_menu_add_item() sub-function which adds one file system entry to the Partition --> Format to --> (file system list) menu. Bug #688882 - Improve clearing of file system signatures
2012-12-07 14:30:15 -07:00
for ( unsigned int t = 0 ; t < fss .size() ; t++ )
Initial revision
2004-09-19 14:24:53 -06:00
{
Prevent crypt-luks appearing in the Create New dialog and Format menu (#760080) This patchset is adding read-only LUKS support. Creation of LUKS is planned to be a tick box adding encryption in the Create New Partition dialog. Therefore remove the greyed out crypt-luks entry in the Create New Partition dialog and the Format menu. Bug 760080 - Implement read-only LUKS support
2015-11-29 01:57:45 -07:00
if ( GParted_Core::supported_filesystem( fss[t].filesystem ) &&
fss[t].filesystem != FS_LUKS )
Use supported_filesystem() predicate (#738471) Use GParted_Core::supported_filesystem() to remove the need to explicitly list the growing number of recognised, but otherwise unsupported, file system signatures in multiple places. Bug #738471 - ReFS file system is not recognised
2014-10-11 13:58:18 -06:00
create_format_menu_add_item( fss[t].filesystem, fss[t].create );
Initial revision
2004-09-19 14:24:53 -06:00
}
Add new "cleared" file system format (#688882) Add "cleared" to the bottom of list of file system formats available in the Create new Partition dialog and in the Format to --> (file system list) menu. This clears existing file system signatures in the newly created partitions and existing partitions respectively. Bug #688882 - Improve clearing of file system signatures
2012-12-08 12:41:00 -07:00
//Add cleared at the end of the list
create_format_menu_add_item( FS_CLEARED, true ) ;
Refactor Win_GParted::create_format_menu() (#688882) Move some code into new create_format_menu_add_item() sub-function which adds one file system entry to the Partition --> Format to --> (file system list) menu. Bug #688882 - Improve clearing of file system signatures
2012-12-07 14:30:15 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
return menu ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Refactor Win_GParted::create_format_menu() (#688882) Move some code into new create_format_menu_add_item() sub-function which adds one file system entry to the Partition --> Format to --> (file system list) menu. Bug #688882 - Improve clearing of file system signatures
2012-12-07 14:30:15 -07:00
//Add one entry to the Partition --> Format to --> (file system list) menu
void Win_GParted::create_format_menu_add_item( FILESYSTEM filesystem, bool activate )
{
hbox = manage( new Gtk::HBox() ) ;
//the colored square
hbox ->pack_start( * manage( new Gtk::Image( Utils::get_color_as_pixbuf( filesystem, 16, 16 ) ) ),
Gtk::PACK_SHRINK ) ;
//the label...
hbox ->pack_start( * Utils::mk_label( " " + Utils::get_filesystem_string( filesystem ) ),
Gtk::PACK_SHRINK ) ;
menu ->items() .push_back( * manage( new Gtk::MenuItem( *hbox ) ) ) ;
if ( activate )
menu ->items() .back() .signal_activate() .connect(
sigc::bind<GParted::FILESYSTEM>( sigc::mem_fun( *this, &Win_GParted::activate_format ),
filesystem ) ) ;
else
menu ->items() .back() .set_sensitive( false ) ;
}
Initial revision
2004-09-19 14:24:53 -06:00
void Win_GParted::init_device_info()
{
removed expander. The diskinfo is now always visible.
2004-09-25 15:59:53 -06:00
vbox_info.set_spacing( 5 );
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
int top = 0, bottom = 1;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed expander. The diskinfo is now always visible.
2004-09-25 15:59:53 -06:00
//title
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
vbox_info .pack_start(
Change field labels to sentence capitalization Change is to align with GNOME Human Interface Guidelines 2.2. http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en
2009-12-06 14:36:39 -07:00
* Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Device Information") ) + "</b>" ),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
Gtk::PACK_SHRINK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//GENERAL DEVICE INFO
Initial revision
2004-09-19 14:24:53 -06:00
table = manage( new Gtk::Table() ) ;
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
table ->set_col_spacings( 10 ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//model
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Model:") ) + "</b>" ),
0, 1,
top, bottom,
Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Display device serial numbers (#751251) Run "hdparm -I /dev/DISK" to get the hard drive serial number of every device which has one and display it in the Device Information. The displayed value can either be the actual serial number, "none" or blank. "none" means the device doesn't have a hard drive serial number, such as for Linux software RAID arrays, BIOS fake RAID arrays or USB flash drives. Blank means something went wrong getting the serial number. Either it couldn't be found in the hdparm output or the hdparm command wasn't installed. Example real hard drive: # hdparm -I /dev/sda ... ATA device, with non-removable media Model Number: SAMSUNG HM500JI Serial Number: S1WFJDSZ123732 ... Example Linux software RAID array: # hdparm -I /dev/md127 /dev/md127: HDIO_DRIVE_CMD(identify) failed: Inappropriate ioctl for device On my desktop with 4 internal hard drives 2 Linux software RAID arrays on those hard drives, 2 USB flash drives and 1 USB hard drive attached, running hdparm 9 times added 0.07 seconds to the device refresh time. Bug 751251 - Show serial number in device information
2015-06-22 07:08:02 -06:00
// Serial number
table->attach( *Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Serial:") ) + "</b>" ),
0, 1, top, bottom, Gtk::FILL );
device_info.push_back( Utils::mk_label( "", true, false, true ) );
table->attach( *device_info.back(), 1, 2, top++, bottom++, Gtk::FILL );
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//size
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Size:") ) + "</b>" ),
0, 1,
top, bottom,
Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//path
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Path:") ) + "</b>" ),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
0, 1,
top, bottom,
Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed expander. The diskinfo is now always visible.
2004-09-25 15:59:53 -06:00
vbox_info .pack_start( *table, Gtk::PACK_SHRINK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//DETAILED DEVICE INFO
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
top = 0 ; bottom = 1;
table = manage( new Gtk::Table() ) ;
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
table ->set_col_spacings( 10 ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//one blank line
replaced the inline Utils functions with static functions. This shaves a * replaced the inline Utils functions with static functions. This shaves a few kbytes (24 in fact) off the binary and is a bit cleaner code-wise (imho).
2005-12-13 14:30:13 -07:00
table ->attach( * Utils::mk_label( "" ), 1, 2, top++, bottom++, Gtk::FILL );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//disktype
Change wording from disk label type to more common partition table
2009-12-06 14:32:12 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Partition table:") ) + "</b>" ),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
0, 1,
top, bottom,
Gtk::FILL );
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//heads
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Heads:") ) + "</b>" ),
0, 1,
top, bottom,
Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//sectors/track
Change field labels to sentence capitalization Change is to align with GNOME Human Interface Guidelines 2.2. http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en
2009-12-06 14:36:39 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Sectors/track:") ) + "</b>" ),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
0, 1,
top, bottom,
Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//cylinders
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Cylinders:") ) + "</b>" ),
0, 1,
top, bottom,
Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
several (mostly) i18n related fixes/cleanups
2004-09-29 06:33:40 -06:00
//total sectors
Change field labels to sentence capitalization Change is to align with GNOME Human Interface Guidelines 2.2. http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en
2009-12-06 14:36:39 -07:00
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Total sectors:") ) + "</b>" ),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
0, 1,
top, bottom,
Gtk::FILL );
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
Add sector size to device display pane Also add sector_size to Device class. This is the start of an enhancement to add support for devices with sector sizes other than 512 bytes (#607165).
2010-02-20 15:12:26 -07:00
//sector size
table ->attach( * Utils::mk_label( " <b>" + static_cast<Glib::ustring>( _("Sector size:") ) + "</b>" ),
0, 1,
top, bottom,
Gtk::FILL );
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
device_info .push_back( Utils::mk_label( "", true, false, true ) ) ;
Add sector size to device display pane Also add sector_size to Device class. This is the start of an enhancement to add support for devices with sector sizes other than 512 bytes (#607165).
2010-02-20 15:12:26 -07:00
table ->attach( * device_info .back(), 1, 2, top++, bottom++, Gtk::FILL ) ;
removed expander. The diskinfo is now always visible.
2004-09-25 15:59:53 -06:00
vbox_info .pack_start( *table, Gtk::PACK_SHRINK );
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::init_hpaned_main()
Initial revision
2004-09-19 14:24:53 -06:00
{
//left scrollwindow (holds device info)
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
scrollwindow = manage( new Gtk::ScrolledWindow() ) ;
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
scrollwindow ->set_shadow_type( Gtk::SHADOW_ETCHED_IN );
scrollwindow ->set_policy( Gtk::POLICY_AUTOMATIC, Gtk::POLICY_AUTOMATIC );
Initial revision
2004-09-19 14:24:53 -06:00
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
hpaned_main .pack1( *scrollwindow, true, true );
Initial revision
2004-09-19 14:24:53 -06:00
scrollwindow ->add( vbox_info );
//right scrollwindow (holds treeview with partitions)
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
scrollwindow = manage( new Gtk::ScrolledWindow() ) ;
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
scrollwindow ->set_shadow_type( Gtk::SHADOW_ETCHED_IN );
scrollwindow ->set_policy( Gtk::POLICY_AUTOMATIC, Gtk::POLICY_AUTOMATIC );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
//connect signals and add treeview_detail
treeview_detail .signal_partition_selected .connect( sigc::mem_fun( this, &Win_GParted::on_partition_selected ) );
treeview_detail .signal_partition_activated .connect( sigc::mem_fun( this, &Win_GParted::on_partition_activated ) );
treeview_detail .signal_popup_menu .connect( sigc::mem_fun( this, &Win_GParted::on_partition_popup_menu ) );
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
scrollwindow ->add( treeview_detail );
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
hpaned_main .pack2( *scrollwindow, true, true );
Initial revision
2004-09-19 14:24:53 -06:00
}
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
void Win_GParted::refresh_combo_devices()
made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) * include/Device.h, src/Device.cc: made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) commented function. * include/Partition.h, src/Partition.cc: Took used sectors out of Set() and added a Set_Used() function instead. Also added Reset() . * src/Dialog_Partition_New.cc: minor change to make use of the new Set() in Partition.. * include/Win_GParted.h, src/Win_GParted.cc: show pulsing progressbar while refreshing devices.
2004-10-11 04:23:24 -06:00
{
Prevent flashing redraw of the devices combobox (#696149) The device combobox was getting drawn blank, then getting drawn again with the selected device. This was happening because at the start of Win_GParted::refresh_combo_devices() the GTK model behind the combobox, liststore_devices, was cleared, changing the active item, causing the combobox to get redrawn empty. After the GTK model had been repopulated the active item was reset causing the comboxbox to get redrawn again, now showing the selected device. Call flow: Win_GParted::refresh_combo_devices() liststore_devices->clear() //Gtk::Combobox emits signal_change. Registered callbacks //called. Win_GParted::combo_devices_changed() Win_GParted::Refresh_Visual() ... ... combo_devices.set_active(current_device); //Gtk::Combobox emits signal_change. Registered callbacks //called. Win_GParted::combo_devices_changed() Win_GParted::Refresh_Visual() ... This has always been the case, since the device combobox was first added to GParted before version 0.1 by commit: 3a4b43e0adb3974dea656fcbe90d5e191e0e9784 replaced deprecated OptionMenu with ComboBox ... Fix by temporarily blocking the devices comboxbox from emitting signal_changed while the GTK model behind the combobox is recreated. However, since automatic selection of the largest free space was added [1] in GParted 0.15.0, a more noticeable flashing redraw issue was caused in which the partition graphic and partition list were both drawn blank then redrawn fully populated. Some distributions were not affected by this at all, some only experienced a single flash and others suffered from two or more flashing redraws. Some affected distributions: CentOS 5.10, 6.5, 7.0, Debian 6, Fedora 14, 19, 20, Ubuntu 13.10, Xubuntu 14.04 LTS. Did not occur on Kubuntu 12.04 LTS. [1] 5b53c12f6ee12312a9bacb44b8b05b12a540d3d6 Select largest unallocated partition by default (#667365) Bug #696149 - Double refresh of display introduced with default unallocated space
2014-08-22 04:35:39 -06:00
// Temporarily block the on change callback while re-creating the device list
// behind the combobox to prevent flashing redraw by being redrawn with an empty
// device list.
combo_devices_changed_connection .block();
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
liststore_devices ->clear() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
menu = manage( new Gtk::Menu() ) ;
Gtk::RadioButtonGroup radio_group ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
for ( unsigned int i = 0 ; i < devices .size( ) ; i++ )
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
{
//combo...
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
treerow = *( liststore_devices ->append() ) ;
treerow[ treeview_devices_columns .icon ] =
render_icon( Gtk::Stock::HARDDISK, Gtk::ICON_SIZE_LARGE_TOOLBAR ) ;
changed the way devices and partitions store their devicepaths. Instead of * changed the way devices and partitions store their devicepaths. Instead of holding a 'realpath' and a symbolic path we store paths in a list. This allows for improved detection of mountpoins, free space, etc.. Also fixed a nasty bug which showed up when you copy a partition from one device to another. (thanks to mario for the report)
2006-03-14 14:37:47 -07:00
treerow[ treeview_devices_columns .device ] = devices[ i ] .get_path() ;
Replace default sector size with appropriate sector size This change is in preparation for supporting sectors sizes > 512 bytes.
2010-04-26 11:42:23 -06:00
treerow[ treeview_devices_columns .size ] = "(" + Utils::format_size( devices[ i ] .length, devices[ i ] .sector_size ) + ")" ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
//devices submenu....
fixed a few issues with selecting/activating partitions. improved support * include/DrawingAreaVisualDisk.h, src/DrawingAreaVisualDisk.cc: fixed a few issues with selecting/activating partitions. * include/Utils.h, src/Utils.cc, src/Dialog_Disklabel.cc, src/Dialog_Partition_Info.cc (mk_label): improved support for aligment. * src/Win_GParted.cc: fixed a small alignmentissue in the devices submenu.
2006-03-20 03:12:55 -07:00
hbox = manage( new Gtk::HBox() ) ;
Replace widget alignment ALIGN_RIGHT with ALIGN_LEFT (#652044) Step 2 of 3: ALIGN_RIGHT was only used for the size figures in the GParted > Devices device selector with radio buttons. Change to ALIGN_LEFT and adjust the widget packing to maintain appearance. Bug #652044 - uses deprecated APIs
2013-10-16 15:12:29 -06:00
hbox ->pack_start( * Utils::mk_label( devices[ i ] .get_path() ), Gtk::PACK_EXPAND_WIDGET ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
hbox ->pack_start( * Utils::mk_label( " (" + Utils::format_size( devices[ i ] .length, devices[ i ] .sector_size ) + ")" ),
Replace widget alignment ALIGN_RIGHT with ALIGN_LEFT (#652044) Step 2 of 3: ALIGN_RIGHT was only used for the size figures in the GParted > Devices device selector with radio buttons. Change to ALIGN_LEFT and adjust the widget packing to maintain appearance. Bug #652044 - uses deprecated APIs
2013-10-16 15:12:29 -06:00
Gtk::PACK_SHRINK ) ;
fixed a few issues with selecting/activating partitions. improved support * include/DrawingAreaVisualDisk.h, src/DrawingAreaVisualDisk.cc: fixed a few issues with selecting/activating partitions. * include/Utils.h, src/Utils.cc, src/Dialog_Disklabel.cc, src/Dialog_Partition_Info.cc (mk_label): improved support for aligment. * src/Win_GParted.cc: fixed a small alignmentissue in the devices submenu.
2006-03-20 03:12:55 -07:00
menu ->items() .push_back( * manage( new Gtk::RadioMenuItem( radio_group ) ) ) ;
menu ->items() .back() .add( *hbox ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .back() .signal_activate() .connect(
fixed a few issues with selecting/activating partitions. improved support * include/DrawingAreaVisualDisk.h, src/DrawingAreaVisualDisk.cc: fixed a few issues with selecting/activating partitions. * include/Utils.h, src/Utils.cc, src/Dialog_Disklabel.cc, src/Dialog_Partition_Info.cc (mk_label): improved support for aligment. * src/Win_GParted.cc: fixed a small alignmentissue in the devices submenu.
2006-03-20 03:12:55 -07:00
sigc::bind<unsigned int>( sigc::mem_fun(*this, &Win_GParted::radio_devices_changed), i ) ) ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .remove_submenu() ;
if ( menu ->items() .size() )
fixed a few issues with selecting/activating partitions. improved support * include/DrawingAreaVisualDisk.h, src/DrawingAreaVisualDisk.cc: fixed a few issues with selecting/activating partitions. * include/Utils.h, src/Utils.cc, src/Dialog_Disklabel.cc, src/Dialog_Partition_Info.cc (mk_label): improved support for aligment. * src/Win_GParted.cc: fixed a small alignmentissue in the devices submenu.
2006-03-20 03:12:55 -07:00
{
menu ->show_all() ;
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .set_submenu( *menu ) ;
fixed a few issues with selecting/activating partitions. improved support * include/DrawingAreaVisualDisk.h, src/DrawingAreaVisualDisk.cc: fixed a few issues with selecting/activating partitions. * include/Utils.h, src/Utils.cc, src/Dialog_Disklabel.cc, src/Dialog_Partition_Info.cc (mk_label): improved support for aligment. * src/Win_GParted.cc: fixed a small alignmentissue in the devices submenu.
2006-03-20 03:12:55 -07:00
}
Prevent flashing redraw of the devices combobox (#696149) The device combobox was getting drawn blank, then getting drawn again with the selected device. This was happening because at the start of Win_GParted::refresh_combo_devices() the GTK model behind the combobox, liststore_devices, was cleared, changing the active item, causing the combobox to get redrawn empty. After the GTK model had been repopulated the active item was reset causing the comboxbox to get redrawn again, now showing the selected device. Call flow: Win_GParted::refresh_combo_devices() liststore_devices->clear() //Gtk::Combobox emits signal_change. Registered callbacks //called. Win_GParted::combo_devices_changed() Win_GParted::Refresh_Visual() ... ... combo_devices.set_active(current_device); //Gtk::Combobox emits signal_change. Registered callbacks //called. Win_GParted::combo_devices_changed() Win_GParted::Refresh_Visual() ... This has always been the case, since the device combobox was first added to GParted before version 0.1 by commit: 3a4b43e0adb3974dea656fcbe90d5e191e0e9784 replaced deprecated OptionMenu with ComboBox ... Fix by temporarily blocking the devices comboxbox from emitting signal_changed while the GTK model behind the combobox is recreated. However, since automatic selection of the largest free space was added [1] in GParted 0.15.0, a more noticeable flashing redraw issue was caused in which the partition graphic and partition list were both drawn blank then redrawn fully populated. Some distributions were not affected by this at all, some only experienced a single flash and others suffered from two or more flashing redraws. Some affected distributions: CentOS 5.10, 6.5, 7.0, Debian 6, Fedora 14, 19, 20, Ubuntu 13.10, Xubuntu 14.04 LTS. Did not occur on Kubuntu 12.04 LTS. [1] 5b53c12f6ee12312a9bacb44b8b05b12a540d3d6 Select largest unallocated partition by default (#667365) Bug #696149 - Double refresh of display introduced with default unallocated space
2014-08-22 04:35:39 -06:00
combo_devices_changed_connection .unblock();
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
combo_devices .set_active( current_device ) ;
made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) * include/Device.h, src/Device.cc: made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) commented function. * include/Partition.h, src/Partition.cc: Took used sectors out of Set() and added a Set_Used() function instead. Also added Reset() . * src/Dialog_Partition_New.cc: minor change to make use of the new Set() in Partition.. * include/Win_GParted.h, src/Win_GParted.cc: show pulsing progressbar while refreshing devices.
2004-10-11 04:23:24 -06:00
}
Use a full fledged nested main loop while waiting and pulsing progress bars (#685740) Win_Gparted and Dialog_Progress were looping on Gtk::Main::events_pending() and iteration() with usleeps in between. Use a full mainloop instead and a proper timeout to trigger pulsebar updates instead of usleeps. Part of Bug 685740 - Refactor to use asynchronous command execution
2013-01-14 19:20:49 -07:00
bool Win_GParted::pulsebar_pulse()
{
pulsebar.pulse();
Glib::ustring tmp_msg = gparted_core .get_thread_status_message() ;
if ( tmp_msg != "" ) {
statusbar.pop();
statusbar.push( tmp_msg );
}
return true;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::show_pulsebar( const Glib::ustring & status_message )
made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) * include/Device.h, src/Device.cc: made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) commented function. * include/Partition.h, src/Partition.cc: Took used sectors out of Set() and added a Set_Used() function instead. Also added Reset() . * src/Dialog_Partition_New.cc: minor change to make use of the new Set() in Partition.. * include/Win_GParted.h, src/Win_GParted.cc: show pulsing progressbar while refreshing devices.
2004-10-11 04:23:24 -06:00
{
removed separator in accordance to the HIG it's now possible to deactivate * src/Dialog_Partition_Info.cc: removed separator in accordance to the HIG * include/Win_GParted.h, src/Win_GParted.cc: it's now possible to deactivate swap from within gparted. * src/GParted_Core.cc: sleep one second after deletion of a partition to give the kernel some time to reread the partitiontable.
2006-01-07 14:23:09 -07:00
pulsebar .show();
added visual feedback when unmounting or deactivating swap. This can be * include/Win_GParted.h, src/Win_GParted.cc: added visual feedback when unmounting or deactivating swap. This can be usefull when it takes longer then usual.
2006-01-08 08:20:14 -07:00
statusbar .push( status_message) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) * include/Device.h, src/Device.cc: made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) commented function. * include/Partition.h, src/Partition.cc: Took used sectors out of Set() and added a Set_Used() function instead. Also added Reset() . * src/Dialog_Partition_New.cc: minor change to make use of the new Set() in Partition.. * include/Win_GParted.h, src/Win_GParted.cc: show pulsing progressbar while refreshing devices.
2004-10-11 04:23:24 -06:00
//disable all input stuff
toolbar_main .set_sensitive( false ) ;
menubar_main .set_sensitive( false ) ;
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
combo_devices .set_sensitive( false ) ;
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
menu_partition .set_sensitive( false ) ;
disable treeview and graphical partition display at scantime fixed two * src/Win_GParted.cc: disable treeview and graphical partition display at scantime * src/GParted_Core.cc: fixed two (potential) problems with device detection.
2005-12-29 07:21:45 -07:00
treeview_detail .set_sensitive( false ) ;
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
drawingarea_visualdisk .set_sensitive( false ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Use a full fledged nested main loop while waiting and pulsing progress bars (#685740) Win_Gparted and Dialog_Progress were looping on Gtk::Main::events_pending() and iteration() with usleeps in between. Use a full mainloop instead and a proper timeout to trigger pulsebar updates instead of usleeps. Part of Bug 685740 - Refactor to use asynchronous command execution
2013-01-14 19:20:49 -07:00
// connect pulse update timer
pulsetimer = Glib::signal_timeout().connect( sigc::mem_fun(*this, &Win_GParted::pulsebar_pulse), 100 );
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
}
void Win_GParted::hide_pulsebar()
{
Use a full fledged nested main loop while waiting and pulsing progress bars (#685740) Win_Gparted and Dialog_Progress were looping on Gtk::Main::events_pending() and iteration() with usleeps in between. Use a full mainloop instead and a proper timeout to trigger pulsebar updates instead of usleeps. Part of Bug 685740 - Refactor to use asynchronous command execution
2013-01-14 19:20:49 -07:00
pulsetimer.disconnect();
removed separator in accordance to the HIG it's now possible to deactivate * src/Dialog_Partition_Info.cc: removed separator in accordance to the HIG * include/Win_GParted.h, src/Win_GParted.cc: it's now possible to deactivate swap from within gparted. * src/GParted_Core.cc: sleep one second after deletion of a partition to give the kernel some time to reread the partitiontable.
2006-01-07 14:23:09 -07:00
pulsebar .hide();
disable treeview and graphical partition display at scantime fixed two * src/Win_GParted.cc: disable treeview and graphical partition display at scantime * src/GParted_Core.cc: fixed two (potential) problems with device detection.
2005-12-29 07:21:45 -07:00
statusbar .pop() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) * include/Device.h, src/Device.cc: made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) commented function. * include/Partition.h, src/Partition.cc: Took used sectors out of Set() and added a Set_Used() function instead. Also added Reset() . * src/Dialog_Partition_New.cc: minor change to make use of the new Set() in Partition.. * include/Win_GParted.h, src/Win_GParted.cc: show pulsing progressbar while refreshing devices.
2004-10-11 04:23:24 -06:00
//enable all disabled stuff
toolbar_main .set_sensitive( true ) ;
menubar_main .set_sensitive( true ) ;
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
combo_devices .set_sensitive( true ) ;
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
menu_partition .set_sensitive( true ) ;
disable treeview and graphical partition display at scantime fixed two * src/Win_GParted.cc: disable treeview and graphical partition display at scantime * src/GParted_Core.cc: fixed two (potential) problems with device detection.
2005-12-29 07:21:45 -07:00
treeview_detail .set_sensitive( true ) ;
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
drawingarea_visualdisk .set_sensitive( true ) ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::Fill_Label_Device_Info( bool clear )
Initial revision
2004-09-19 14:24:53 -06:00
{
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
if ( clear )
for ( unsigned int t = 0 ; t < device_info .size( ) ; t++ )
device_info[ t ] ->set_text( "" ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
else
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
{
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
short t = 0;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
//global info...
device_info[ t++ ] ->set_text( devices[ current_device ] .model ) ;
Display device serial numbers (#751251) Run "hdparm -I /dev/DISK" to get the hard drive serial number of every device which has one and display it in the Device Information. The displayed value can either be the actual serial number, "none" or blank. "none" means the device doesn't have a hard drive serial number, such as for Linux software RAID arrays, BIOS fake RAID arrays or USB flash drives. Blank means something went wrong getting the serial number. Either it couldn't be found in the hdparm output or the hdparm command wasn't installed. Example real hard drive: # hdparm -I /dev/sda ... ATA device, with non-removable media Model Number: SAMSUNG HM500JI Serial Number: S1WFJDSZ123732 ... Example Linux software RAID array: # hdparm -I /dev/md127 /dev/md127: HDIO_DRIVE_CMD(identify) failed: Inappropriate ioctl for device On my desktop with 4 internal hard drives 2 Linux software RAID arrays on those hard drives, 2 USB flash drives and 1 USB hard drive attached, running hdparm 9 times added 0.07 seconds to the device refresh time. Bug 751251 - Show serial number in device information
2015-06-22 07:08:02 -06:00
device_info[ t++ ] ->set_text( devices[current_device].serial_number );
Replace default sector size with appropriate sector size This change is in preparation for supporting sectors sizes > 512 bytes.
2010-04-26 11:42:23 -06:00
device_info[ t++ ] ->set_text( Utils::format_size( devices[ current_device ] .length, devices[ current_device ] .sector_size ) ) ;
changed the way devices and partitions store their devicepaths. Instead of * changed the way devices and partitions store their devicepaths. Instead of holding a 'realpath' and a symbolic path we store paths in a list. This allows for improved detection of mountpoins, free space, etc.. Also fixed a nasty bug which showed up when you copy a partition from one device to another. (thanks to mario for the report)
2006-03-14 14:37:47 -07:00
device_info[ t++ ] ->set_text( Glib::build_path( "\n", devices[ current_device ] .get_paths() ) ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
//detailed info
device_info[ t++ ] ->set_text( devices[ current_device ] .disktype ) ;
replaced the inline Utils functions with static functions. This shaves a * replaced the inline Utils functions with static functions. This shaves a few kbytes (24 in fact) off the binary and is a bit cleaner code-wise (imho).
2005-12-13 14:30:13 -07:00
device_info[ t++ ] ->set_text( Utils::num_to_str( devices[ current_device ] .heads ) );
device_info[ t++ ] ->set_text( Utils::num_to_str( devices[ current_device ] .sectors ) );
device_info[ t++ ] ->set_text( Utils::num_to_str( devices[ current_device ] .cylinders ) );
device_info[ t++ ] ->set_text( Utils::num_to_str( devices[ current_device ] .length ) );
Add sector size to device display pane Also add sector_size to Device class. This is the start of an enhancement to add support for devices with sector sizes other than 512 bytes (#607165).
2010-02-20 15:12:26 -07:00
device_info[ t++ ] ->set_text( Utils::num_to_str( devices[ current_device ] .sector_size ) );
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
}
Initial revision
2004-09-19 14:24:53 -06:00
}
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
bool Win_GParted::on_delete_event( GdkEventAny *event )
Initial revision
2004-09-19 14:24:53 -06:00
{
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
return ! Quit_Check_Operations();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
}
Initial revision
2004-09-19 14:24:53 -06:00
Remove unused index parameter from Add_Operation() (#755214) Since this commit earlier in the patchset the second optional parameter of method Win_GParted::Add_Operation() is no longer used. Remove it. Replace open coded merge of resize/move into create operation (#755214) Bug 755214 - Refactor operation merging
2015-09-27 02:14:04 -06:00
void Win_GParted::Add_Operation( Operation * operation )
Initial revision
2004-09-19 14:24:53 -06:00
{
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
if ( operation )
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
{
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
Glib::ustring error ;
Fix uninitialised read when pasting into an existing partition GParted_Core::set_device_partitions() creates and initialises the partition objects based on the partitions on the disk using partition.Reset() and partition.Set(). These methods never set the alignment attribute. Copy and pasting into an existing partition calls GParted_Core:: snap_to_alignment() to adjust the start and end of the newly created in memory partition object. When pasting into unallocated space the user has selected the required alignment and this is exactly what is needed. However when pasting into an existing partition the in memory partition object should always match the actual partition boundaries on disk. Unfortunately the partition boundaries are adjusted based on reading the uninitialised alignment attribute. Initialise the alignment attribute of newly created partition objects to ALIGN_STRICT. Also, when pasting into an existing partition set the alignment of that partition object to ALIGN_STRICT so that no boundary adjustment is performed. valgrind: ==6845== Conditional jump or move depends on uninitialised value(s) ==6845== at 0x80C779A: GParted::GParted_Core::snap_to_alignment(...) (GParted_Core.cc:566) ==6845== by 0x810C115: GParted::Win_GParted::Add_Operation(...) (Win_GParted.cc:692) ==6845== by 0x8110499: GParted::Win_GParted::activate_paste() (Win_GParted.cc:1649) ... ==6845== Conditional jump or move depends on uninitialised value(s) ==6845== at 0x80C77A8: GParted::GParted_Core::snap_to_alignment(...) (GParted_Core.cc:568) ==6845== by 0x810C115: GParted::Win_GParted::Add_Operation(...) (Win_GParted.cc:692) ==6845== by 0x8110499: GParted::Win_GParted::activate_paste() (Win_GParted.cc:1649) GParted_Core.cc: 562 bool GParted_Core::snap_to_alignment( const Device & device, Partition & partition, Glib::ustring & error ) 563 { 564 bool rc = true ; 565 >> 566 if ( partition .alignment == ALIGN_CYLINDER ) 567 rc = snap_to_cylinder( device, partition, error ) ; >> 568 else if ( partition .alignment == ALIGN_MEBIBYTE ) 569 rc = snap_to_mebibyte( device, partition, error ) ; 570 Closes Bug #672654 - Pasting into an existing partition may shrink GParted's representation of it
2012-03-23 09:51:08 -06:00
//Add any of the listed operations without further checking, but
// for the other operations (_CREATE, _RESIZE_MOVE and _COPY)
// ensure the partition is correctly aligned.
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
//FIXME: this is becoming a mess.. maybe it's better to check if partition_new > 0
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
if ( operation ->type == OPERATION_DELETE ||
operation ->type == OPERATION_FORMAT ||
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
operation ->type == OPERATION_CHECK ||
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
operation ->type == OPERATION_CHANGE_UUID ||
Rename enum to OPERATION_LABEL_FILESYSTEM (#741424) This and the following few commits rename variables, methods, classes, etc from *label_partition* to *label_filesystem* so that the code also reflects that it is the label of the file system that is being modified and to separate it from the name partition operation about to be added. enum OPERATION_LABEL_PARTITION -> OPERATION_LABEL_FILESYSTEM Bug 741424 - Add support for GPT partition names
2014-12-16 14:06:20 -07:00
operation ->type == OPERATION_LABEL_FILESYSTEM ||
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
operation ->type == OPERATION_NAME_PARTITION ||
Protect partition members within Operation classes (#759726) The Operation classes contain partition objects which are copied by value. Need to replace these with pointers to Partition objects instead and manage their lifetimes so that they can be used polymorphically. First step is to protect the partition members partition_new, partition_original, and for OperationCopy class only, partition_copied within the Operation classes and provide accessor methods. get_partition_new() and get_partition_original() accessors are implemented in the Operation base class so all derived classes get an implementation. get_partition_new() is also virtual so that OperationCheck and OperationDelete can override the implementation and assert that they don't use partition_new. get_partition_copied() is provided for the OperationCopy class only so can only be accessed via an OperationCopy type variable. Bug 759726 - Implement Partition object polymorphism
2015-09-19 08:57:39 -06:00
gparted_core.snap_to_alignment( operation->device, operation->get_partition_new(), error )
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
)
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
{
operation ->create_description() ;
Remove unused index parameter from Add_Operation() (#755214) Since this commit earlier in the patchset the second optional parameter of method Win_GParted::Add_Operation() is no longer used. Remove it. Replace open coded merge of resize/move into create operation (#755214) Bug 755214 - Refactor operation merging
2015-09-27 02:14:04 -06:00
operations.push_back( operation );
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
}
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
else
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
{
Gtk::MessageDialog dialog( *this,
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
_("Could not add this operation to the list"),
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true );
dialog .set_secondary_text( error ) ;
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
perform some checks before adding a new operation to the list. made * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: perform some checks before adding a new operation to the list. * src/Partition.cc: made get_length() a bit safer
2006-07-20 13:14:44 -06:00
dialog .run() ;
}
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
}
Initial revision
2004-09-19 14:24:53 -06:00
}
Better comment what each Merge_Operations() call is achieving (#755214) ... before refactoring the code. See the commit message from 2011-10-05 for details of what operations, available at that time, on the same partition can be merged and in what cases: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Bug 755214 - Refactor operation merging
2015-09-14 08:48:43 -06:00
// Try to merge the second operation into the first in the operations[] vector.
Rename function to merge_two_operations() and update validation (#755214) Rename Win_GParted::Merge_Operations() to merge_two_operations(). To reflect what it does and in preparation for further refactoring of the code. Be more strict on the validation of the first and second indexes. The first operation must also be before the second operation in the operation[] vector. (It is actually a programming bug if first and second fail validation. However so far g_assert() is only being used to validate pointers, which if wrong would likely cause the program to eventually crash when dereferenced later. In this case a bug would merely cause the incorrectly specified pair of operations to not be merged). Move validate_display_partition_ptr() declaration in the header file to be in the same ordering as it's definition in the source file. Bug 755214 - Refactor operation merging
2015-09-15 07:30:03 -06:00
bool Win_GParted::merge_two_operations( unsigned int first, unsigned int second )
Merge overlapping operations (#438573) When a new operation is added to operations list, check if a merge is possible depending on the operation type: OPERATION_RESIZE_MOVE: 2 consecutive "resize" operations on the same partition OPERATION_LABEL_PARTITION: 2 "label change" operations (need not be consecutive) on the same partition OPERATION_CHECK: 2 "check" operations (need not be consecutive) on the same partition OPERATION_FORMAT: 2 consecutive "format" operations on the same partition Closes Bug #438573 - Cancel out overlapping actions Also fix a bug when copying partition using the Partition::Set(...) method. This method did not initialize "sectors_used" and "sectors_unused" members.
2011-10-05 12:15:16 -06:00
{
Rename function to merge_two_operations() and update validation (#755214) Rename Win_GParted::Merge_Operations() to merge_two_operations(). To reflect what it does and in preparation for further refactoring of the code. Be more strict on the validation of the first and second indexes. The first operation must also be before the second operation in the operation[] vector. (It is actually a programming bug if first and second fail validation. However so far g_assert() is only being used to validate pointers, which if wrong would likely cause the program to eventually crash when dereferenced later. In this case a bug would merely cause the incorrectly specified pair of operations to not be merged). Move validate_display_partition_ptr() declaration in the header file to be in the same ordering as it's definition in the source file. Bug 755214 - Refactor operation merging
2015-09-15 07:30:03 -06:00
unsigned int num_ops = operations.size();
if ( first >= num_ops-1 )
return false;
if ( first >= second || second >= num_ops )
Improve Merge_Operations method parameters and checks
2011-10-13 11:26:16 -06:00
return false;
Encapsulate operation merging inside the Operation* classes (#755214) Win_GParted::Merge_Operations() method was modifying the internals of Operation* objects; in particular the partition_new member variable. This is breaking data hiding and encapsulation tenant of object oriented programming. Implement exactly the same operation merge semantics, but hide the manipulation of the internals of the Operation* objects within the Operation* classes themselves. Bug 755214 - Refactor operation merging
2015-09-12 07:59:40 -06:00
if ( operations[first]->merge_operations( *operations[second] ) )
Merge overlapping operations (#438573) When a new operation is added to operations list, check if a merge is possible depending on the operation type: OPERATION_RESIZE_MOVE: 2 consecutive "resize" operations on the same partition OPERATION_LABEL_PARTITION: 2 "label change" operations (need not be consecutive) on the same partition OPERATION_CHECK: 2 "check" operations (need not be consecutive) on the same partition OPERATION_FORMAT: 2 consecutive "format" operations on the same partition Closes Bug #438573 - Cancel out overlapping actions Also fix a bug when copying partition using the Partition::Set(...) method. This method did not initialize "sectors_used" and "sectors_unused" members.
2011-10-05 12:15:16 -06:00
{
remove_operation( second );
return true;
}
return false;
}
Add comment summarising current operation merging rules (#755214) This information is already documented in the existing comments associated with the calls to merge_operations() and assignments to the mergetype variables. The table just summaries the rules together in one place. Bug 755214 - Refactor operation merging
2015-09-19 02:17:43 -06:00
// Try to merge pending operations in the operations[] vector using the specified merge
// type.
//
// Summary of all the operation merging rules for each operation type coded into the
// ::activate_*() methods:
//
// Operation type Partition status Merge type Method
// ----------------- ---------------- -------------------- -----------------
// resize/move Real MERGE_LAST_WITH_PREV activate_resize()
// resize/move New MERGE_LAST_WITH_ANY activate_resize()
// paste * none activate_paste()
// new * none activate_new()
// delete Real none activate_delete()
// delete New MERGE_ALL_ADJACENT activate_delete()
// format Real MERGE_LAST_WITH_PREV activate_format()
// format New MERGE_LAST_WITH_ANY activate_format()
// check Real [1] MERGE_LAST_WITH_ANY activate_check()
// label file system Real [1] MERGE_LAST_WITH_ANY activate_label_filesystem()
// name partition Real [1] MERGE_LAST_WITH_ANY activate_name_partition()
// new UUID Real [1] MERGE_LAST_WITH_ANY activate_change_uuid()
//
// [1] The UI only allows these operations to be applied to real partitions; where as the
// other mergeable operations can be applied to both real partitions and new, pending
// create partitions.
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
void Win_GParted::merge_operations( MergeType mergetype )
{
unsigned int num_ops = operations.size();
if ( num_ops <= 1 )
return; // Nothing to merge. One or fewer operations.
switch ( mergetype )
{
case MERGE_LAST_WITH_PREV:
merge_two_operations( num_ops-2, num_ops-1 );
break;
case MERGE_LAST_WITH_ANY:
for ( unsigned int i = 0 ; i < num_ops-1 ; i ++ )
{
if ( merge_two_operations( i, num_ops-1 ) )
break;
}
break;
case MERGE_ALL_ADJACENT:
// Must check against operations.size() as looping continues after
// merging which might have reduced the number of items in the
// vector.
for ( unsigned int i = 0 ; i < operations.size()-1 ; i ++ )
{
merge_two_operations( i, i+1 );
}
break;
}
}
added FIXME force processing of all pending Gtk::Main events after * src/Dialog_Base_Partition.cc, src/FrameVisualDisk.cc: added FIXME * src/Win_GParted.cc: force processing of all pending Gtk::Main events after Refresh_Visual. This fixes an issue with incorrect displayed Visual Partition Display.
2006-03-01 14:50:52 -07:00
void Win_GParted::Refresh_Visual()
Initial revision
2004-09-19 14:24:53 -06:00
{
Document how the GUI works and the lifetimes of important data (#750168) Document how GParted displays partitions in the GUI and manages the lifetime and ownership of that data. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-19 13:25:07 -06:00
// How GParted displays partitions in the GUI and manages the lifetime and
// ownership of that data:
//
// (1) Queries the devices and partitions on disk and refreshes the model.
//
// Data owner: std::vector<Devices> Win_GParted::devices
// Lifetime: Valid until the next call to Refresh_Visual()
// Call chain:
//
// Win_GParted::menu_gparted_refresh_devices()
// gparted_core.set_devices( devices )
// GParted_Core::set_devices_thread( devices )
// devices.clear()
// etc.
//
// (2) Takes a copy of the partitions for the device currently being shown in the
// GUI and visually applies pending operations.
//
Use PartitionVector class throughout the code (#759726) Replace all occurrences of std::vector<Partition> with PartitionVector. Bug 759726 - Implement Partition object polymorphism
2015-05-23 13:22:37 -06:00
// Data owner: PartitionVector Win_GParted::display_partitions
Document how the GUI works and the lifetimes of important data (#750168) Document how GParted displays partitions in the GUI and manages the lifetime and ownership of that data. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-19 13:25:07 -06:00
// Lifetime: Valid until the next call to Refresh_Visual().
// Function: Refresh_Visual()
//
// (3) Loads the disk graphic and partition list with partitions to be shown in
// the GUI. Both classes store pointers pointing back to each partition
// object in the vector of display partitions.
//
// Aliases: Win_GParted::display_partitions[]
// Call chain:
//
// Win_GParted::Refresh_Visual()
// drawingarea_visualdisk.load_partitions( display_partitions, device_sectors )
// DrawingAreaVisualDisk::set_static_data( ... )
// treeview_detail.load_partitions( display_partitions )
// TreeView_Detail::create_row()
// TreeView_Detail::load_partitions()
// TreeView_Detail::create_row()
//
// (4) Selecting a partition in the disk graphic or in the partition list fires
// the callback which passes a pointer to the selected partition stored in
// step (3). The callback saves the selected partition and calls the opposite
// class to update it's selection.
//
// Data owner: const Partition * Win_GParted::selected_partition_ptr
// Aliases: Win_GParted::display_partitions[]
// Lifetime: Valid until the next call to Refresh_Visual().
// Call chain: (example clicking on a partition in the disk graphic)
//
// DrawingAreaVisualDisk::on_button_press_event()
// DawingAreaVisualDisk::set_selected( visual_partitions, x, y )
// signal_partition_selected.emit( ..., false )
// Win_GParted::on_partition_selected( partition_ptr, src_is_treeview )
// treeview_detail.set_selected( treestore_detail->children(), partition_ptr )
// TreeView::set_selected( rows, partition_ptr, inside_extended )
// set_cursor()
// TreeView::set_selected( rows, partition_ptr, true )
// set_cursor()
//
// (5) Each new operation is added to the vector of pending operations.
// Eventually Refresh_Visual() is call to update the GUI. This goes to step
// (2) which visually reapplies all pending operations again, including the
// newly added operation.
//
// Data owner: std::vector<Operation *> Win_GParted::operations
// Lifetime: Valid until operations have been applied by
// GParted_Core::apply_operation_to_disk(). Specifically longer
// than the next call call to Refresh_Visual().
// Call chain: (example setting a file system label)
//
// Win_GParted::activate_label_filesystem()
// Win_GParted::Add_Operation( operation )
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
// Win_GParted::merge_operations( ... )
Document how the GUI works and the lifetimes of important data (#750168) Document how GParted displays partitions in the GUI and manages the lifetime and ownership of that data. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-19 13:25:07 -06:00
// Win_GParted::show_operationslist()
// Win_GParted::Refresh_Visual()
//
// (6) Selecting a partition as a copy source makes a copy of that partition
// object.
//
// Data owner: Partition Win_GParted::copied_partition
// Lifetime: Valid until GParted closed or the device is removed.
// Specifically longer than the next call to Refresh_Visual().
// Function: Win_GParted::activate_copy()
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
display_partitions = devices[current_device].partitions;
Initial revision
2004-09-19 14:24:53 -06:00
//make all operations visible
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
for ( unsigned int t = 0 ; t < operations .size(); t++ )
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
if ( operations[ t ] ->device == devices[ current_device ] )
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
operations[t]->apply_to_visual( display_partitions );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
hbox_operations .load_operations( operations ) ;
Initial revision
2004-09-19 14:24:53 -06:00
//set new statusbartext
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
statusbar .pop() ;
Added proper plural handling for PO files svn path=/trunk/; revision=852
2008-06-10 13:16:26 -06:00
statusbar .push( String::ucompose( ngettext( "%1 operation pending"
, "%1 operations pending"
, operations .size()
)
, operations .size()
)
);
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
if ( ! operations .size() )
some small changes to make the GUI more consistent (#353140) * include/Win_GParted.h, src/Win_GParted.cc: some small changes to make the GUI more consistent (#353140)
2006-09-16 05:27:05 -06:00
allow_undo_clear_apply( false ) ;
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
Localise checking for an extended partition into activate_new() As previous commit, display_partitions is now a Win_GParted member variable so checking for the existence of an extended partition can be localised where it is used. Remove index_extended member variable and localise the same checking in activate_new().
2015-09-10 11:24:49 -06:00
// Refresh copy partition source as necessary and select the largest unallocated
// partition if there is one.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr = NULL;
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
Sector largest_unalloc_size = -1 ;
Sector current_size ;
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
for ( unsigned int t = 0 ; t < display_partitions.size() ; t++ )
Initial revision
2004-09-19 14:24:53 -06:00
{
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
if ( copied_partition != NULL && display_partitions[t].get_path() == copied_partition->get_path() )
{
delete copied_partition;
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
copied_partition = display_partitions[t].clone();
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
}
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
switch ( display_partitions[t].type )
Initial revision
2004-09-19 14:24:53 -06:00
{
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
case TYPE_EXTENDED:
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
for ( unsigned int u = 0 ; u < display_partitions[t].logicals.size() ; u ++ )
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
{
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
if ( copied_partition != NULL &&
display_partitions[t].logicals[u].get_path() == copied_partition->get_path() )
{
delete copied_partition;
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
copied_partition = display_partitions[t].logicals[u].clone();
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
}
Refresh copy source when its a logical partition too (#754827) Perform a copy, reformat source and paste sequence in GParted. When the source is a primary partition everything works as expected, with the newly pasted partition reflecting the reformatted source. However when the source is a logical partition GParted thinks it is pasting the original source, rather than the reformatted source. The same is also true for other file system manipulation operations: resize, file system label and new UUID. It is just that reformatting the source to a different file system type is the most obvious in the UI and causes the most significantly wrong actions to be performed. For example start with an ext4 logical partition, select it for copy, format it to xfs and paste into a new partition. GParted thinks the second operation will create a copy of an ext4 file system instead of the xfs file system. When applied the operation details are: Format /dev/sdd5 as xfs + calibrate /dev/sdd5 + clear old file system signatures in /dev/sdd5 + set partition type on /dev/sdd5 + create new xfs file system + mkfs.xfs -f -L "" /dev/sdd5 Copy /dev/sdd5 to /dev/sdd (start at 131.00 MiB) + calibrate /dev/sdd5 + check file system on /dev/sdd5 for errors and (if possible) fix them + e2fsck -f -y -v -C 0 /dev/sdd5 e2fsck: Subperblock invalid, trying backup blocks... Resize inode not valid. Recreate? yes ... /dev/sdd5: ***** FILE SYSTEM WAS MODIFIED ***** + create empty partition + set partition type on /dev/sdd6 new partition type: ext4 + copy file system of /dev/sdd5 to /dev/sdd6 using internal algorithm ... GParted formatted sdd5 to xfs, but then the copy step ran e2fsck and managed to resurrect the ext4 file system and then performed a block copy of it to partition sdd6. The copy step should have ran xfs_repair and used xfsdump | xfsrestore to copy the xfs file system. Afterwards sdd5 contains both xfs and ext4 signatures. # wipefs /dev/sdd5 offset type ---------------------------------------------------------------- 0x438 ext4 [filesystem] UUID: f0ed4247-76db-4d93-b3bc-c7da4a70f95e 0x0 xfs [filesystem] UUID: 1ac8e7c3-0311-4c64-8e4a-b715a23ea0bd This has been broken at least as far back as GParted 0.1.0. Fix by simply refreshing the copy source partition object when it is a logical partition too, as well as when it is a primary partition. Bug 754827 - Copy, reformat source and paste a logical partition thinks it's pasting the original file system
2015-09-10 06:49:28 -06:00
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
switch ( display_partitions[t].logicals[u].type )
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
{
case TYPE_UNALLOCATED:
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
current_size = display_partitions[t].logicals[u].get_sector_length();
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
if ( current_size > largest_unalloc_size )
{
largest_unalloc_size = current_size ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr = & display_partitions[t].logicals[u];
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
}
break;
default:
break;
}
}
rewrote quite some stuff to use an enum to indentify filesystems instead * rewrote quite some stuff to use an enum to indentify filesystems instead of stringcomparisons.
2005-12-07 04:21:27 -07:00
break;
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
case TYPE_UNALLOCATED:
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
current_size = display_partitions[t].get_sector_length();
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
if ( current_size > largest_unalloc_size )
{
largest_unalloc_size = current_size ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr = & display_partitions[t];
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
}
break;
rewrote quite some stuff to use an enum to indentify filesystems instead * rewrote quite some stuff to use an enum to indentify filesystems instead of stringcomparisons.
2005-12-07 04:21:27 -07:00
default :
break;
Initial revision
2004-09-19 14:24:53 -06:00
}
}
Move vector of partition objects to a Win_GParted class member (#750168) Win_GParted::Refresh_Visual() used a local variable containing a copy of the vector of partitions in the current device to be displayed. After visually applying pending operations it loaded copies of each partition object into the GUI widgets to display the disk graphic and partition list, DrawingAreaVisualDisk and TreeView_Details classes respectively. When a partition is selected in the UI, again a partition object is copied. Also several of the partition dialogs, including the information dialog, take a copy of the partition object. All these are copies of the same set of partition objects, those currently being displayed in the UI. Move the vector of displayed partitions from a local variable in Refresh_Visual() to a Win_GParted member variable. This will allow for the above cases to be changed to used pointers and references to the same set of partition objects. The valid lifetime of pointers to elements in this partition object vector is from one refresh to the next, when the vector is cleared and repopulated with a new set of partition objects. This is exactly what is needed as the GUI widgets are reloaded on each refresh, the selected partition is reset and none of the partition dialog objects exist. Dialog objects being created and destroyed on each use. On the other hand some copies of partition objects currently being displayed, still need to be made because they have lifetimes which need to last longer than the next call to Refresh_Visual(). Specifically the source of the copy partition and the partition objects copied into the in the list of pending operations. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-15 08:51:26 -06:00
// frame visualdisk
drawingarea_visualdisk.load_partitions( display_partitions, devices[current_device].length );
// treeview details
treeview_detail.load_partitions( display_partitions );
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
set_valid_operations() ;
Reduce flashing redraw from automatic partition selection (#696149) Automatic selection of the largest unallocated partition caused flashing redraw of the partition graphic and partition list. Both the partition graphic and partition list were being drawn blank then redrawn fully populated. This only happened on some distributions including: CentOS 5.10, 6.5, 7.0, Debian 6, Fedora 14, 20, Xubuntu 14.04 LTS. Did not happen on: Kubuntu 12.04 LTS. This is a workaround, not a complete fix. It moves automatic selection of the largest unallocated partition to after processing of the GTK Event loop in Refresh_Visual() which redraws the partition graphic and partition list. These visuals are now drawn only once, fully populated, however this draws them without the selected partition. The partition selection is then drawn afterwards which causes the selection to flash instead. This is significant improvement to the whole partition graphic and partition list flashing when redrawn. Bug #696149 - Double refresh of display introduced with default unallocated space
2014-08-23 03:41:42 -06:00
// Process Gtk events to redraw visuals with reloaded partition details
while ( Gtk::Main::events_pending() )
Gtk::Main::iteration();
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
if ( largest_unalloc_size >= 0 )
{
Reduce flashing redraw from automatic partition selection (#696149) Automatic selection of the largest unallocated partition caused flashing redraw of the partition graphic and partition list. Both the partition graphic and partition list were being drawn blank then redrawn fully populated. This only happened on some distributions including: CentOS 5.10, 6.5, 7.0, Debian 6, Fedora 14, 20, Xubuntu 14.04 LTS. Did not happen on: Kubuntu 12.04 LTS. This is a workaround, not a complete fix. It moves automatic selection of the largest unallocated partition to after processing of the GTK Event loop in Refresh_Visual() which redraws the partition graphic and partition list. These visuals are now drawn only once, fully populated, however this draws them without the selected partition. The partition selection is then drawn afterwards which causes the selection to flash instead. This is significant improvement to the whole partition graphic and partition list flashing when redrawn. Bug #696149 - Double refresh of display introduced with default unallocated space
2014-08-23 03:41:42 -06:00
// Flashing redraw work around. Inform visuals of selection of the
// largest unallocated partition after drawing those visuals above.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
drawingarea_visualdisk.set_selected( selected_partition_ptr );
treeview_detail.set_selected( selected_partition_ptr );
Select largest unallocated partition by default (#667365) After a refresh, instead of having no partition selected, default to the largest unallocated partition. This allows immediate creation of a new partition in the unallocated space. Bug 667365 - Free space should be selected by default
2013-03-17 06:22:28 -06:00
Reduce flashing redraw from automatic partition selection (#696149) Automatic selection of the largest unallocated partition caused flashing redraw of the partition graphic and partition list. Both the partition graphic and partition list were being drawn blank then redrawn fully populated. This only happened on some distributions including: CentOS 5.10, 6.5, 7.0, Debian 6, Fedora 14, 20, Xubuntu 14.04 LTS. Did not happen on: Kubuntu 12.04 LTS. This is a workaround, not a complete fix. It moves automatic selection of the largest unallocated partition to after processing of the GTK Event loop in Refresh_Visual() which redraws the partition graphic and partition list. These visuals are now drawn only once, fully populated, however this draws them without the selected partition. The partition selection is then drawn afterwards which causes the selection to flash instead. This is significant improvement to the whole partition graphic and partition list flashing when redrawn. Bug #696149 - Double refresh of display introduced with default unallocated space
2014-08-23 03:41:42 -06:00
// Process Gtk events to draw selection
while ( Gtk::Main::events_pending() )
Gtk::Main::iteration();
}
Initial revision
2004-09-19 14:24:53 -06:00
}
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
// Confirms that the pointer points to one of the partition objects in the vector of
// displayed partitions, Win_GParted::display_partitions[].
// Usage: g_assert( valid_display_partition_ptr( my_partition_ptr ) );
bool Win_GParted::valid_display_partition_ptr( const Partition * partition_ptr )
{
for ( unsigned int i = 0 ; i < display_partitions.size() ; i++ )
{
if ( & display_partitions[i] == partition_ptr )
return true;
else if ( display_partitions[i].type == TYPE_EXTENDED )
{
for ( unsigned int j = 0 ; j < display_partitions[i].logicals.size() ; j++ )
{
if ( & display_partitions[i].logicals[j] == partition_ptr )
return true;
}
}
}
return false;
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
bool Win_GParted::Quit_Check_Operations()
Initial revision
2004-09-19 14:24:53 -06:00
{
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
if ( operations .size() )
Initial revision
2004-09-19 14:24:53 -06:00
{
added support for activating swap (#392672) * include/Win_GParted.h, src/Win_GParted.cc: added support for activating swap (#392672)
2006-02-08 13:36:18 -07:00
Gtk::MessageDialog dialog( *this,
_("Quit GParted?"),
false,
Gtk::MESSAGE_QUESTION,
Gtk::BUTTONS_NONE,
true );
Added proper plural handling for PO files svn path=/trunk/; revision=852
2008-06-10 13:16:26 -06:00
dialog .set_secondary_text( String::ucompose( ngettext( "%1 operation is currently pending."
, "%1 operations are currently pending."
, operations .size()
)
, operations .size()
)
) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
dialog .add_button( Gtk::Stock::QUIT, Gtk::RESPONSE_CLOSE );
dialog .add_button( Gtk::Stock::CANCEL,Gtk::RESPONSE_CANCEL );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
if ( dialog .run() == Gtk::RESPONSE_CANCEL )
Fixed some errors with 'unknown' filesystem. + some cosmetics * src/Dialog_Partition_New.cc, src/Win_GParted.cc: Fixed some errors with 'unknown' filesystem. + some cosmetics
2004-11-23 12:03:39 -07:00
return false;//don't close GParted
Initial revision
2004-09-19 14:24:53 -06:00
}
return true; //close GParted
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::set_valid_operations()
Initial revision
2004-09-19 14:24:53 -06:00
{
added umount option. Also include unistd.h to solve some issues with gcc * include/Win_GParted.h, src/Win_GParted.cc: added umount option. Also include unistd.h to solve some issues with gcc 3.2.x
2004-11-06 12:48:24 -07:00
allow_new( false ); allow_delete( false ); allow_resize( false ); allow_copy( false );
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
allow_paste( false ); allow_format( false ); allow_toggle_busy_state( false ) ;
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
allow_name_partition( false ); allow_manage_flags( false ); allow_check( false );
allow_label_filesystem( false ); allow_change_uuid( false ); allow_info( false );
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
dynamic_cast<Gtk::Label*>( menu_partition .items()[ MENU_TOGGLE_BUSY ] .get_child() )
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
->set_label( FileSystem::get_generic_text ( CTEXT_DEACTIVATE_FILESYSTEM ) ) ;
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
menu_partition .items()[ MENU_TOGGLE_BUSY ] .show() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items()[ MENU_MOUNT ] .hide() ;
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// No partition selected ...
if ( ! selected_partition_ptr )
Added menu 'Operations' to menubar. This menu is a duplicate of the * include/Win_GParted.h, src/Win_GParted.cc: Added menu 'Operations' to menubar. This menu is a duplicate of the popupmenu and imho a bit unnecessary, but lots of people requested this.. :) Besides this, i removed 'menu_devices' and performed a few other cleanups.
2005-01-09 12:33:48 -07:00
return ;
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Add online resize support (#694622) Many file systems are capable of growing while mounted, and a few can even shrink. This support must be explicitly enabled at configure time with the --enable-online-resize flag and depends on a patched libparted. Also requires kernel >= 3.6 for partition resizing, even if the partition is in use (BLKPG_RESIZE_PARTITION). Thanks to Mike Fleetwood for double check mark idea instead of a second column to show the online grow/shrink. Bug #694622 - Add support for online resize
2013-11-15 09:27:12 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Get filesystem capabilities
fs = gparted_core.get_fs( selected_partition_ptr->filesystem );
Add online resize support (#694622) Many file systems are capable of growing while mounted, and a few can even shrink. This support must be explicitly enabled at configure time with the --enable-online-resize flag and depends on a patched libparted. Also requires kernel >= 3.6 for partition resizing, even if the partition is in use (BLKPG_RESIZE_PARTITION). Thanks to Mike Fleetwood for double check mark idea instead of a second column to show the online grow/shrink. Bug #694622 - Add support for online resize
2013-11-15 09:27:12 -07:00
Added menu 'Operations' to menubar. This menu is a duplicate of the * include/Win_GParted.h, src/Win_GParted.cc: Added menu 'Operations' to menubar. This menu is a duplicate of the popupmenu and imho a bit unnecessary, but lots of people requested this.. :) Besides this, i removed 'menu_devices' and performed a few other cleanups.
2005-01-09 12:33:48 -07:00
//if there's something, there's some info ;)
added support for activating swap (#392672) * include/Win_GParted.h, src/Win_GParted.cc: added support for activating swap (#392672)
2006-02-08 13:36:18 -07:00
allow_info( true ) ;
Disable manipulation operations on "none" partition tables (#741430) At this time we are providing read-only support for file systems on whole disk devices. Also all manipulation operations fail at the calibrate step with libparted error "unrecognised disk label", and manage flags is for real partitions only. Bug 741430 - GParted cannot recognise LVM signature on unpartitioned drive
2014-12-28 06:18:58 -07:00
Set activate/deactivate partition menu item name earlier (#741430) So that, even though the menu item is greyed out, it is correctly named Activate or Deactivate for an LVM2 Physical Volume on a whole disk device, rather than the default Mount or Unmount. Bug 741430 - GParted cannot recognise LVM signature on unpartitioned drive
2014-12-28 07:21:34 -07:00
// Set an appropriate name for the activate/deactivate menu item.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
const FileSystem * filesystem_object = gparted_core.get_filesystem_object( selected_partition_ptr->filesystem );
Small simplification of Win_GParted code which calls get_custom_text() Avoid long lines, long statements and repeated calls to gparted_core.get_filesystem_object( selected_partition.filesystem ) by storing the returned pointer in a local variable. Needs the previous commit so that the the local variable can be a pointer to a const FileSystem object instead of a pointer to a (modifiable) FileSystem object.
2015-05-16 02:58:58 -06:00
if ( filesystem_object )
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
dynamic_cast<Gtk::Label*>( menu_partition .items()[ MENU_TOGGLE_BUSY ] .get_child() )
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
->set_label( filesystem_object->get_custom_text( selected_partition_ptr->busy
Small simplification of Win_GParted code which calls get_custom_text() Avoid long lines, long statements and repeated calls to gparted_core.get_filesystem_object( selected_partition.filesystem ) by storing the returned pointer in a local variable. Needs the previous commit so that the the local variable can be a pointer to a const FileSystem object instead of a pointer to a (modifiable) FileSystem object.
2015-05-16 02:58:58 -06:00
? CTEXT_DEACTIVATE_FILESYSTEM
: CTEXT_ACTIVATE_FILESYSTEM ) );
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
else
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
dynamic_cast<Gtk::Label*>( menu_partition .items()[ MENU_TOGGLE_BUSY ] .get_child() )
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
->set_label( FileSystem::get_generic_text ( selected_partition_ptr->busy
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
? CTEXT_DEACTIVATE_FILESYSTEM
: CTEXT_ACTIVATE_FILESYSTEM )
) ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Only permit mount/unmount, swapon/swapoff, activate/deactivate if action is available
if ( selected_partition_ptr->status == STAT_REAL
&& selected_partition_ptr->type != TYPE_EXTENDED
&& selected_partition_ptr->filesystem != FS_LVM2_PV
&& selected_partition_ptr->filesystem != FS_LINUX_SWRAID
Prevent Mount/Umount operation being available for LUKS (#760080) The code currently allows attempting to mount and unmount a LUKS partition. It is nonsense to directly try to mount and unmount a LUKS partition and obviously doesn't work. For read-only LUKS support there is no need to attempt to apply this to the encrypted file system within. Therefore prevent these operations for LUKS partitions. Bug 760080 - Implement read-only LUKS support
2015-12-31 10:03:30 -07:00
&& selected_partition_ptr->filesystem != FS_LUKS
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
&& ( selected_partition_ptr->busy
|| selected_partition_ptr->get_mountpoints().size() /* Have mount point(s) */
|| selected_partition_ptr->filesystem == FS_LINUX_SWAP
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
)
)
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
allow_toggle_busy_state( true ) ;
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
//Only permit VG deactivation if busy, or activation if not busy and a member of a VG.
// For now specifically allow activation of an exported VG, which LVM will fail
// with "Volume group "VGNAME" is exported", otherwise user won't know why the
// inactive PV can't be activated.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->status == STAT_REAL
&& selected_partition_ptr->type != TYPE_EXTENDED
&& selected_partition_ptr->filesystem == FS_LVM2_PV
&& ( selected_partition_ptr->busy
|| ( ! selected_partition_ptr->busy
&& ! selected_partition_ptr->get_mountpoints().empty() // VGNAME from mount point
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
)
)
)
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
allow_toggle_busy_state( true ) ;
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
Allow partition naming on busy partitions (#746214) Allow partition names to be changed whether or not the partition is busy, rather than only when not busy, because it doesn't effect the busy file system or change the partition boundaries in any way. Bug 746214 - Partition naming enhancements
2015-03-13 11:38:48 -06:00
// Allow naming on devices that support it
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->type != TYPE_UNALLOCATED &&
selected_partition_ptr->status == STAT_REAL &&
Make support of naming for other partition table types possible (#746214) Previously partition naming had only been implemented for gpt. Make the code ready to support naming of the other partition table types for which libparted supports naming. Specifically: amiga, dvh, mac and pc98 in addition to gpt. Document issues found with some of these partition table types, which can relatively easily been worked around. Leave support of naming for partition table types other than gpt disabled, mostly just to reduce ongoing testing effort, at least until there is any user demand for it. Bug 746214 - Partition naming enhancements
2015-03-13 16:36:08 -06:00
devices[current_device].partition_naming_supported() )
Allow partition naming on busy partitions (#746214) Allow partition names to be changed whether or not the partition is busy, rather than only when not busy, because it doesn't effect the busy file system or change the partition boundaries in any way. Bug 746214 - Partition naming enhancements
2015-03-13 11:38:48 -06:00
allow_name_partition( true );
Set activate/deactivate partition menu item name earlier (#741430) So that, even though the menu item is greyed out, it is correctly named Activate or Deactivate for an LVM2 Physical Volume on a whole disk device, rather than the default Mount or Unmount. Bug 741430 - GParted cannot recognise LVM signature on unpartitioned drive
2014-12-28 07:21:34 -07:00
// Manage flags
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->type != TYPE_UNALLOCATED &&
selected_partition_ptr->status == STAT_REAL &&
! selected_partition_ptr->whole_device )
Set activate/deactivate partition menu item name earlier (#741430) So that, even though the menu item is greyed out, it is correctly named Activate or Deactivate for an LVM2 Physical Volume on a whole disk device, rather than the default Mount or Unmount. Bug 741430 - GParted cannot recognise LVM signature on unpartitioned drive
2014-12-28 07:21:34 -07:00
allow_manage_flags( true );
Add online resize support (#694622) Many file systems are capable of growing while mounted, and a few can even shrink. This support must be explicitly enabled at configure time with the --enable-online-resize flag and depends on a patched libparted. Also requires kernel >= 3.6 for partition resizing, even if the partition is in use (BLKPG_RESIZE_PARTITION). Thanks to Mike Fleetwood for double check mark idea instead of a second column to show the online grow/shrink. Bug #694622 - Add support for online resize
2013-11-15 09:27:12 -07:00
#ifdef ENABLE_ONLINE_RESIZE
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Find out if online resizing is possible
if ( selected_partition_ptr->busy )
Add online resize support (#694622) Many file systems are capable of growing while mounted, and a few can even shrink. This support must be explicitly enabled at configure time with the --enable-online-resize flag and depends on a patched libparted. Also requires kernel >= 3.6 for partition resizing, even if the partition is in use (BLKPG_RESIZE_PARTITION). Thanks to Mike Fleetwood for double check mark idea instead of a second column to show the online grow/shrink. Bug #694622 - Add support for online resize
2013-11-15 09:27:12 -07:00
{
if ( ( fs .online_grow || fs .online_shrink ) && ! devices[ current_device ] .readonly )
allow_resize( true ) ;
}
#endif
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Only unmount/swapoff/VG deactivate or online actions allowed if busy
if ( selected_partition_ptr->busy )
added support for activating swap (#392672) * include/Win_GParted.h, src/Win_GParted.cc: added support for activating swap (#392672)
2006-02-08 13:36:18 -07:00
return ;
Use custom text functions for mount/unmount and swapon/swapoff texts Part 3 of 4 to provide new UUID support for NTFS. See Bug #667278 - Add support for setting UUID
2012-01-27 12:41:31 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// UNALLOCATED
if ( selected_partition_ptr->type == TYPE_UNALLOCATED )
Initial revision
2004-09-19 14:24:53 -06:00
{
allow_new( true );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
// Find out if there is a partition to be copied and if it fits inside this unallocated space
if ( copied_partition != NULL && ! devices[current_device].readonly )
fixed small bug with resizing and lower limits. use * src/Dialog_Partition_Resize_Move.cc: fixed small bug with resizing and lower limits. * src/GParted_Core.cc: use ped_file_system_clobber before creating a filesystem on a partition. * src/Win_GParted.cc: pasting is now only allowed if unallocated >= copied partition + cylindersize. Instead of dividing length device by amount of cylinders i use heads * sectors/track to get cylindersize. Changed device busy warning a bit to more decent english (adamw) * src/ntfs.cc: readded '-Q' to mkntfs. The error about an 'unknown filesystem' was related to detection problems and not to faulty creation of the filesystem. Should be solved anyway by implementing ped_file_system_clobber. Also removed ntfsfix since it didn't do anything relevant. Instead i use ntfsresize, because this contains relevant checks (szaka)
2004-11-25 12:21:42 -07:00
{
Enhance set_valid_operations method to handle different sector sizes
2010-04-27 11:41:43 -06:00
Byte_Value required_size ;
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
if ( copied_partition->filesystem == FS_XFS )
required_size = copied_partition->estimated_min_size() * copied_partition->sector_size;
in some places i still used MiB's instead of sectors to store sizes. this * in some places i still used MiB's instead of sectors to store sizes. this has been fixed everywhere. Only the spinbuttons still use MiB's. I have a few ideas on how to solve this, but i'll take it up with #usability first.
2006-02-25 03:09:30 -07:00
else
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
required_size = copied_partition->get_byte_length();
in some places i still used MiB's instead of sectors to store sizes. this * in some places i still used MiB's instead of sectors to store sizes. this has been fixed everywhere. Only the spinbuttons still use MiB's. I have a few ideas on how to solve this, but i'll take it up with #usability first.
2006-02-25 03:09:30 -07:00
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
//Determine if space is needed for the Master Boot Record or
// the Extended Boot Record. Generally an an additional track or MEBIBYTE
// is required so for our purposes reserve a MEBIBYTE in front of the partition.
// NOTE: This logic also contained in Dialog_Base_Partition::MB_Needed_for_Boot_Record
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( ( selected_partition_ptr->inside_extended
&& selected_partition_ptr->type == TYPE_UNALLOCATED
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
)
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
|| ( selected_partition_ptr->type == TYPE_LOGICAL )
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
/* Beginning of disk device */
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
|| ( selected_partition_ptr->sector_start <= (MEBIBYTE / selected_partition_ptr->sector_size) )
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
)
required_size += MEBIBYTE;
//Determine if space is needed for the Extended Boot Record for a logical partition
// after this partition. Generally an an additional track or MEBIBYTE
// is required so for our purposes reserve a MEBIBYTE in front of the partition.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( ( ( selected_partition_ptr->inside_extended
&& selected_partition_ptr->type == TYPE_UNALLOCATED
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
)
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
|| ( selected_partition_ptr->type == TYPE_LOGICAL )
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
)
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
&& ( selected_partition_ptr->sector_end
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
< ( devices[ current_device ] .length
- ( 2 * MEBIBYTE / devices[ current_device ] .sector_size )
)
)
Enhanced copy/paste checks when MBR/EBR involved. svn path=/trunk/; revision=1040
2009-01-24 10:16:57 -07:00
)
Add partition alignment option to align to MiB (#617409) Make align to MiB the default setting instead of align to cylinder. Migrate logic for alignment to cylinder into its own method snap_to_cylinder, and place common logic in snap_to_alignment. Add alignment checks for situations where space is needed for Master Boot Record or Extended Boot Record. Adjust ranges on spin buttons according to required boot record space. Copy fix for off by one sector (#596552) from Dialog_Partition_New::Get_New_Partition to Dialog_Base_Partition::Get_New_Partition Enhance resize / move logic for checking locations of nearby logical partitions to not depend on the partition ordering. Note: This commit does not include limiting graphic movement according to required boot record space.
2010-05-20 10:00:14 -06:00
required_size += MEBIBYTE;
Enhanced copy/paste checks when MBR/EBR involved. svn path=/trunk/; revision=1040
2009-01-24 10:16:57 -07:00
Ensure space available for GPT backup partition table on paste
2010-05-20 15:12:14 -06:00
//Determine if space is needed for the backup partition on a GPT partition table
if ( ( devices[ current_device ] .disktype == "gpt" )
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
&& ( ( devices[current_device].length - selected_partition_ptr->sector_end )
Ensure space available for GPT backup partition table on paste
2010-05-20 15:12:14 -06:00
< ( MEBIBYTE / devices[ current_device ] .sector_size )
)
)
required_size += MEBIBYTE ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( required_size <= selected_partition_ptr->get_byte_length() )
fixed small bug with resizing and lower limits. use * src/Dialog_Partition_Resize_Move.cc: fixed small bug with resizing and lower limits. * src/GParted_Core.cc: use ped_file_system_clobber before creating a filesystem on a partition. * src/Win_GParted.cc: pasting is now only allowed if unallocated >= copied partition + cylindersize. Instead of dividing length device by amount of cylinders i use heads * sectors/track to get cylindersize. Changed device busy warning a bit to more decent english (adamw) * src/ntfs.cc: readded '-Q' to mkntfs. The error about an 'unknown filesystem' was related to detection problems and not to faulty creation of the filesystem. Should be solved anyway by implementing ped_file_system_clobber. Also removed ntfsfix since it didn't do anything relevant. Instead i use ntfsresize, because this contains relevant checks (szaka)
2004-11-25 12:21:42 -07:00
allow_paste( true ) ;
Enhanced copy/paste checks when MBR/EBR involved. svn path=/trunk/; revision=1040
2009-01-24 10:16:57 -07:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
return ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// EXTENDED
if ( selected_partition_ptr->type == TYPE_EXTENDED )
added support for jfs (create, copy, grow) and hfs (create, copy) fixed a * added support for jfs (create, copy, grow) and hfs (create, copy) * fixed a bug in copying xfs filesystems. * fixed a number of small bugs/annoying issues.
2004-12-14 15:49:44 -07:00
{
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Deletion is only allowed when there are no logical partitions inside.
if ( selected_partition_ptr->logicals.size() == 1 &&
selected_partition_ptr->logicals.back().type == TYPE_UNALLOCATED )
added support for jfs (create, copy, grow) and hfs (create, copy) fixed a * added support for jfs (create, copy, grow) and hfs (create, copy) * fixed a bug in copying xfs filesystems. * fixed a number of small bugs/annoying issues.
2004-12-14 15:49:44 -07:00
allow_delete( true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added support for jfs (create, copy, grow) and hfs (create, copy) fixed a * added support for jfs (create, copy, grow) and hfs (create, copy) * fixed a bug in copying xfs filesystems. * fixed a number of small bugs/annoying issues.
2004-12-14 15:49:44 -07:00
if ( ! devices[ current_device ] .readonly )
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
allow_resize( true ) ;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
added support for jfs (create, copy, grow) and hfs (create, copy) fixed a * added support for jfs (create, copy, grow) and hfs (create, copy) * fixed a bug in copying xfs filesystems. * fixed a number of small bugs/annoying issues.
2004-12-14 15:49:44 -07:00
return ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// PRIMARY and LOGICAL
if ( selected_partition_ptr->type == TYPE_PRIMARY || selected_partition_ptr->type == TYPE_LOGICAL )
Initial revision
2004-09-19 14:24:53 -06:00
{
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
allow_format( true ) ;
Enable operations on whole disk device virtual partitions (#743181) Enable operations on whole disk devices containing any recognised file system. The new partition operation on an empty whole disk device continues to display the "No partition table found on device /dev/DEVICE" information dialog. Specifically unsupported operations: * Delete - Deletion of a partition only involves removal of the entry in the partition table leaving the file system intact on the disk. However this doesn't work for a whole disk device file system. Instead the file system signatures would have to be erased which is much more destructive and virtually impossible to undo. Therefore don't implement whole disk device file system deletion. Alternatives are to format the file system to cleared or create a partition table on the device. Both of these imply overwriting the existing data and set the expectation that undo is not possible. * Manage flags - There's no partition table, so there's no partition, so there's no flags. Resize/Move operation is being supported so that a whole disk device file system can be resized to handle devices which can be resize, such as those from SANs or Linux Software RAID arrays. The start of the file system must remain fixed so move won't be allowed. So far only simple operations work if they don't need libparted support at all [1], or only need libparted support for the calibrate step AND the file system on the whole disk device is recognised by libparted [2]. (Needs libparted to provide a "loop" partition, hence the recognition requirement, so that the calibrate step can successfully read the virtual "loop" partition table. Doesn't matter whether it's an old version of libparted and it gets the name of the device wrong as GParted is already using the whole disk device name anyway). [1] Operations not needing any libparted support: Mount on, Unmount, Swapon, Swapoff, Activate and Deactivate [2] Operations only needing libparted support for the calibrate step: Check, Label, New UUID Bug 743181 - Add unpartitioned drive read-write support
2014-12-31 05:41:03 -07:00
// only allow deletion of partitions within a partition table
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( ! selected_partition_ptr->whole_device )
Enable operations on whole disk device virtual partitions (#743181) Enable operations on whole disk devices containing any recognised file system. The new partition operation on an empty whole disk device continues to display the "No partition table found on device /dev/DEVICE" information dialog. Specifically unsupported operations: * Delete - Deletion of a partition only involves removal of the entry in the partition table leaving the file system intact on the disk. However this doesn't work for a whole disk device file system. Instead the file system signatures would have to be erased which is much more destructive and virtually impossible to undo. Therefore don't implement whole disk device file system deletion. Alternatives are to format the file system to cleared or create a partition table on the device. Both of these imply overwriting the existing data and set the expectation that undo is not possible. * Manage flags - There's no partition table, so there's no partition, so there's no flags. Resize/Move operation is being supported so that a whole disk device file system can be resized to handle devices which can be resize, such as those from SANs or Linux Software RAID arrays. The start of the file system must remain fixed so move won't be allowed. So far only simple operations work if they don't need libparted support at all [1], or only need libparted support for the calibrate step AND the file system on the whole disk device is recognised by libparted [2]. (Needs libparted to provide a "loop" partition, hence the recognition requirement, so that the calibrate step can successfully read the virtual "loop" partition table. Doesn't matter whether it's an old version of libparted and it gets the name of the device wrong as GParted is already using the whole disk device name anyway). [1] Operations not needing any libparted support: Mount on, Unmount, Swapon, Swapoff, Activate and Deactivate [2] Operations only needing libparted support for the calibrate step: Check, Label, New UUID Bug 743181 - Add unpartitioned drive read-write support
2014-12-31 05:41:03 -07:00
allow_delete( true );
fixed bug with enabling/disabling 'copy' in menus. added missing check * src/Win_GParted.cc: fixed bug with enabling/disabling 'copy' in menus. * src/ext2.cc, src/ext3.cc: added missing check while deciding to disable/enable copy feature.
2004-12-17 09:26:49 -07:00
//find out if resizing/moving is possible
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
if ( (fs .grow || fs .shrink || fs .move ) && ! devices[ current_device ] .readonly )
Initial revision
2004-09-19 14:24:53 -06:00
allow_resize( true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
fixed bug with enabling/disabling 'copy' in menus. added missing check * src/Win_GParted.cc: fixed bug with enabling/disabling 'copy' in menus. * src/ext2.cc, src/ext3.cc: added missing check while deciding to disable/enable copy feature.
2004-12-17 09:26:49 -07:00
//only allow copying of real partitions
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->status == STAT_REAL && fs.copy )
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
allow_copy( true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
//only allow labelling of real partitions that support labelling
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->status == STAT_REAL && fs.write_label )
Rename methods in GParted_Core and Win_GParted classes (#741424) class GParted_Core: label_partition() -> label_filesystem() class Win_GParted: allow_label_partition() -> allow_label_filesystem() activate_label_partition() -> activate_label_filesystem() Bug 741424 - Add support for GPT partition names
2014-12-18 15:18:33 -07:00
allow_label_filesystem( true );
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
//only allow changing UUID of real partitions that support it
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->status == STAT_REAL && fs.write_uuid )
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
allow_change_uuid( true ) ;
Prevent Mount/Umount operation being available for LUKS (#760080) The code currently allows attempting to mount and unmount a LUKS partition. It is nonsense to directly try to mount and unmount a LUKS partition and obviously doesn't work. For read-only LUKS support there is no need to attempt to apply this to the encrypted file system within. Therefore prevent these operations for LUKS partitions. Bug 760080 - Implement read-only LUKS support
2015-12-31 10:03:30 -07:00
// Generate Mount on submenu, except for LVM2 PVs borrowing mount point to
// display the VGNAME and read-only supported LUKS.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->filesystem != FS_LVM2_PV &&
Prevent Mount/Umount operation being available for LUKS (#760080) The code currently allows attempting to mount and unmount a LUKS partition. It is nonsense to directly try to mount and unmount a LUKS partition and obviously doesn't work. For read-only LUKS support there is no need to attempt to apply this to the encrypted file system within. Therefore prevent these operations for LUKS partitions. Bug 760080 - Implement read-only LUKS support
2015-12-31 10:03:30 -07:00
selected_partition_ptr->filesystem != FS_LUKS &&
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_mountpoints().size() )
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
{
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
menu = menu_partition .items()[ MENU_MOUNT ] .get_submenu() ;
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
menu ->items() .clear() ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
for ( unsigned int t = 0 ; t < selected_partition_ptr->get_mountpoints().size() ; t++ )
moved comment to correct position fixed issues with mountpoints containing * src/GParted_Core.cc: moved comment to correct position * src/Win_GParted.cc: fixed issues with mountpoints containing underscores and/or spaces.
2006-03-17 03:07:49 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu ->items() .push_back(
Gtk::Menu_Helpers::MenuElem(
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_mountpoints()[t],
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
sigc::bind<unsigned int>( sigc::mem_fun(*this, &Win_GParted::activate_mount_partition), t ) ) );
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
moved comment to correct position fixed issues with mountpoints containing * src/GParted_Core.cc: moved comment to correct position * src/Win_GParted.cc: fixed issues with mountpoints containing underscores and/or spaces.
2006-03-17 03:07:49 -07:00
dynamic_cast<Gtk::Label*>( menu ->items() .back() .get_child() ) ->set_use_underline( false ) ;
}
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
menu_partition .items()[ MENU_TOGGLE_BUSY ] .hide() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
menu_partition .items()[ MENU_MOUNT ] .show() ;
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
}
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
// See if there is a partition to be copied and it fits inside this selected partition
if ( copied_partition != NULL &&
copied_partition->get_byte_length() <= selected_partition_ptr->get_byte_length() &&
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->status == STAT_REAL &&
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
*copied_partition != *selected_partition_ptr )
allow_paste( true );
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
//see if we can somehow check/repair this file system....
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( fs.check && selected_partition_ptr->status == STAT_REAL )
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
allow_check( true ) ;
Initial revision
2004-09-19 14:24:53 -06:00
}
}
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
void Win_GParted::show_operationslist()
{
//Enable (or disable) Undo and Apply buttons
allow_undo_clear_apply( operations .size() ) ;
//Updates view of operations list and sensitivity of Undo and Apply buttons
Refresh_Visual();
if ( operations .size() == 1 ) //first operation, open operationslist
open_operationslist() ;
//FIXME: A slight flicker may be introduced by this extra display refresh.
//An extra display refresh seems to prevent the disk area visual disk from
// disappearing when enough operations are added to require a scrollbar
// (about 4 operations with default window size).
// Note that commenting out the code to
// "//make scrollwindow focus on the last operation in the list"
// in HBoxOperations::load_operations() prevents this problem from occurring as well.
// See also Win_GParted::activate_undo().
drawingarea_visualdisk .queue_draw() ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::open_operationslist()
logic unallocated space wasn't read correctly, fixed. added * src/Device.cc (Read_Disk_Layout): logic unallocated space wasn't read correctly, fixed. * include/Win_GParted.h: added open_operationslist() and menu_view_operations() . * src/Win_GParted.cc: tweaked operationlist behaviour a bit. Also added 'Operations" toggle-item to View menu.
2004-10-11 08:19:56 -06:00
{
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
if ( ! OPERATIONSLIST_OPEN )
logic unallocated space wasn't read correctly, fixed. added * src/Device.cc (Read_Disk_Layout): logic unallocated space wasn't read correctly, fixed. * include/Win_GParted.h: added open_operationslist() and menu_view_operations() . * src/Win_GParted.cc: tweaked operationlist behaviour a bit. Also added 'Operations" toggle-item to View menu.
2004-10-11 08:19:56 -06:00
{
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
OPERATIONSLIST_OPEN = true ;
hbox_operations .show() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
for ( int t = vpaned_main .get_height() ; t > ( vpaned_main .get_height() - 100 ) ; t -= 5 )
{
vpaned_main .set_position( t );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
while ( Gtk::Main::events_pending() )
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
Gtk::Main::iteration() ;
}
Added a menu 'Edit' which contains 'Undo' and 'Apply'. (#322550) * include/Win_GParted.h, src/Win_GParted.cc: Added a menu 'Edit' which contains 'Undo' and 'Apply'. (#322550)
2005-11-27 12:48:00 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
static_cast<Gtk::CheckMenuItem *>( & menubar_main .items()[ 2 ] .get_submenu() ->items()[ 1 ] )
->set_active( true ) ;
}
logic unallocated space wasn't read correctly, fixed. added * src/Device.cc (Read_Disk_Layout): logic unallocated space wasn't read correctly, fixed. * include/Win_GParted.h: added open_operationslist() and menu_view_operations() . * src/Win_GParted.cc: tweaked operationlist behaviour a bit. Also added 'Operations" toggle-item to View menu.
2004-10-11 08:19:56 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::close_operationslist()
Initial revision
2004-09-19 14:24:53 -06:00
{
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
if ( OPERATIONSLIST_OPEN )
Initial revision
2004-09-19 14:24:53 -06:00
{
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
OPERATIONSLIST_OPEN = false ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
for ( int t = vpaned_main .get_position() ; t < vpaned_main .get_height() ; t += 5 )
{
vpaned_main .set_position( t ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
while ( Gtk::Main::events_pending() )
Gtk::Main::iteration();
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
hbox_operations .hide() ;
static_cast<Gtk::CheckMenuItem *>( & menubar_main .items()[ 2 ] .get_submenu() ->items()[ 1 ] )
->set_active( false ) ;
Initial revision
2004-09-19 14:24:53 -06:00
}
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::clear_operationslist()
Initial revision
2004-09-19 14:24:53 -06:00
{
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
remove_operation( -1, true ) ;
some small changes to make the GUI more consistent (#353140) * include/Win_GParted.h, src/Win_GParted.cc: some small changes to make the GUI more consistent (#353140)
2006-09-16 05:27:05 -06:00
close_operationslist() ;
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
Refresh_Visual() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
void Win_GParted::combo_devices_changed()
{
gparted-0.3.5 - code recreation from Source Forge svn path=/trunk/; revision=809
2008-04-07 09:26:19 -06:00
unsigned int old_current_device = current_device;
Initial revision
2004-09-19 14:24:53 -06:00
//set new current device
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
current_device = combo_devices .get_active_row_number() ;
gparted-0.3.5 - code recreation from Source Forge svn path=/trunk/; revision=809
2008-04-07 09:26:19 -06:00
if ( current_device == (unsigned int) -1 )
current_device = old_current_device;
if ( current_device >= devices .size() )
current_device = 0 ;
changed the way devices and partitions store their devicepaths. Instead of * changed the way devices and partitions store their devicepaths. Instead of holding a 'realpath' and a symbolic path we store paths in a list. This allows for improved detection of mountpoins, free space, etc.. Also fixed a nasty bug which showed up when you copy a partition from one device to another. (thanks to mario for the report)
2006-03-14 14:37:47 -07:00
set_title( String::ucompose( _("%1 - GParted"), devices[ current_device ] .get_path() ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//refresh label_device_info
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
Fill_Label_Device_Info();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//rebuild visualdisk and treeview
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
Refresh_Visual();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
//uodate radiobuttons..
if ( menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .get_submenu() )
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
static_cast<Gtk::RadioMenuItem *>(
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
& menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .get_submenu() ->
items()[ current_device ] ) ->set_active( true ) ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::radio_devices_changed( unsigned int item )
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
if ( static_cast<Gtk::RadioMenuItem *>(
added mountpointcolumn (#304688) added submenu 'Devices' which allows one * include/TreeView_Detail.h, src/TreeView_Detail.cc: added mountpointcolumn (#304688) * include/Win_GParted.h, src/Win_GParted.cc: added submenu 'Devices' which allows one to select devices from the menu (#329415)
2006-02-02 03:59:44 -07:00
& menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .get_submenu() ->
items()[ item ] ) ->get_active() )
{
combo_devices .set_active( item ) ;
}
Initial revision
2004-09-19 14:24:53 -06:00
}
override Gtk::Window::on_show instead of connecting to signal_show() added * include/Win_GParted.h, src/Win_GParted.cc: override Gtk::Window::on_show instead of connecting to signal_show() * include/Dialog_Filesystems.h, src/Dialog_Filesystems.cc: added columns 'detect' and 'read'
2006-04-02 08:04:44 -06:00
void Win_GParted::on_show()
{
Gtk::Window::on_show() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
prevent crasher when visual_disks is empty. load devices at startup on * src/FrameVisualDisk.cc: prevent crasher when visual_disks is empty. * include/Win_GParted.h, src/Win_GParted.cc: load devices at startup on signal_show instead of dispatching it from the c'tor. Also did some cleanups in the behaviour of opening and closing of the operationslist.
2006-02-22 15:05:15 -07:00
vpaned_main .set_position( vpaned_main .get_height() ) ;
close_operationslist() ;
menu_gparted_refresh_devices() ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
overloaded == and != cleanups * include/Device.h, src/Device.cc: overloaded == and != * src/Win_GParted.cc: cleanups
2006-03-15 14:44:24 -07:00
void Win_GParted::menu_gparted_refresh_devices()
Initial revision
2004-09-19 14:24:53 -06:00
{
added visual feedback when unmounting or deactivating swap. This can be * include/Win_GParted.h, src/Win_GParted.cc: added visual feedback when unmounting or deactivating swap. This can be usefull when it takes longer then usual.
2006-01-08 08:20:14 -07:00
show_pulsebar( _("Scanning all devices...") ) ;
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
gparted_core.set_devices( devices );
hide_pulsebar();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added visual feedback when unmounting or deactivating swap. This can be * include/Win_GParted.h, src/Win_GParted.cc: added visual feedback when unmounting or deactivating swap. This can be usefull when it takes longer then usual.
2006-01-08 08:20:14 -07:00
//check if current_device is still available (think about hotpluggable stuff like usbdevices)
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
if ( current_device >= devices .size() )
When ( ! deep_scan ) now only one device is scanned (first found one). * src/GParted_Core.cc: When ( ! deep_scan ) now only one device is scanned (first found one). Shaves off a couple of millisec from startuptime |-) * src/Win_GParted.cc: Fixed small bug with removable devices and the devicemenu. Also fixed redundant calling of 2 functions.
2004-12-03 03:53:01 -07:00
current_device = 0 ;
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
//see if there are any pending operations on non-existent devices
//NOTE that this isn't 100% foolproof since some stuff (e.g. sourcedevice of copy) may slip through.
//but anyone who removes the sourcedevice before applying the operations gets what he/she deserves :-)
overloaded == and != cleanups * include/Device.h, src/Device.cc: overloaded == and != * src/Win_GParted.cc: cleanups
2006-03-15 14:44:24 -07:00
//FIXME: this actually sucks ;) see if we can use STL predicates here..
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
unsigned int i ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
for ( unsigned int t = 0 ; t < operations .size() ; t++ )
overloaded == and != cleanups * include/Device.h, src/Device.cc: overloaded == and != * src/Win_GParted.cc: cleanups
2006-03-15 14:44:24 -07:00
{
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
for ( i = 0 ; i < devices .size() && devices[ i ] != operations[ t ] ->device ; i++ ) {}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
if ( i >= devices .size() )
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
remove_operation( t-- ) ;
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
//if no devices were detected we disable some stuff and show a message in the statusbar
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
if ( devices .empty() )
wrap mount/umount/swapon/swapoff instead of implementing it ourselves * wrap mount/umount/swapon/swapoff instead of implementing it ourselves (#330641) * moved execute_command() to Utils and made the filesystems use it. All in all this decreased the size of the binary with 10% and made stuff more readable.
2006-02-15 09:05:26 -07:00
{
:get_tmp_dir() instead of hardcoding it as '/tmp' :find_program_in_path() * use Glib::get_tmp_dir() instead of hardcoding it as '/tmp' * use Glib::find_program_in_path() instead af a system/which combi * display current device in windowtitle
2006-01-24 05:31:58 -07:00
this ->set_title( _("GParted") );
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
combo_devices .hide() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added support for commandline arguments (#329414) * include/GParted_Core.h, include/Win_GParted.h, src/GParted_Core.cc, src/Win_GParted.cc, src/main.cc: added support for commandline arguments (#329414)
2006-02-02 06:50:37 -07:00
menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .set_sensitive( false ) ;
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
menubar_main .items()[ 1 ] .set_sensitive( false ) ;
menubar_main .items()[ 2 ] .set_sensitive( false ) ;
menubar_main .items()[ 3 ] .set_sensitive( false ) ;
menubar_main .items()[ 4 ] .set_sensitive( false ) ;
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
toolbar_main .set_sensitive( false ) ;
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
drawingarea_visualdisk .set_sensitive( false ) ;
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
treeview_detail .set_sensitive( false ) ;
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
Fill_Label_Device_Info( true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
drawingarea_visualdisk .clear() ;
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
treeview_detail .clear() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
//hmzz, this is really paranoid, but i think it's the right thing to do ;)
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
hbox_operations .clear() ;
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
close_operationslist() ;
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
remove_operation( -1, true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
overloaded operator == rewrote the graphical partitiondisplay. It now * include/Partition.h, src/Partition.cc: overloaded operator == * include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc: rewrote the graphical partitiondisplay. It now supports resizing and the extended partition is also selectable. see also #312656 * include/Win_GParted.h, src/Win_GParted.cc: use the new graphical partitiondisplay. * src/TreeView_Detail.cc: minor cleanups
2005-12-22 15:20:55 -07:00
statusbar .pop() ;
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
statusbar .push( _( "No devices detected" ) );
}
else //at least one device detected
{
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
combo_devices .show() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added support for commandline arguments (#329414) * include/GParted_Core.h, include/Win_GParted.h, src/GParted_Core.cc, src/Win_GParted.cc, src/main.cc: added support for commandline arguments (#329414)
2006-02-02 06:50:37 -07:00
menubar_main .items()[ 0 ] .get_submenu() ->items()[ 1 ] .set_sensitive( true ) ;
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
menubar_main .items()[ 1 ] .set_sensitive( true ) ;
menubar_main .items()[ 2 ] .set_sensitive( true ) ;
menubar_main .items()[ 3 ] .set_sensitive( true ) ;
menubar_main .items()[ 4 ] .set_sensitive( true ) ;
toolbar_main .set_sensitive( true ) ;
removed the frame from the visualdiskwidget and changed some visual * include/DrawingAreaVisualDisk.h, include/Makefile.am, include/Win_GParted.h src/DrawingAreaVisualDisk.cc, src/Makefile.am src/Win_GParted.cc: removed the frame from the visualdiskwidget and changed some visual details. Also changed visual representation of selected partition. The latter might be considered as a work in progress. * include/FrameVisualDisk.h, src/FrameVisualDisk.cc: Removed.
2006-03-09 06:12:44 -07:00
drawingarea_visualdisk .set_sensitive( true ) ;
replaced deprecated OptionMenu with ComboBox. also fixed some issues which * include/Win_GParted.h, src/Win_GParted.cc: replaced deprecated OptionMenu with ComboBox. also fixed some issues which arised when no devices were detected.
2005-12-29 16:35:37 -07:00
treeview_detail .set_sensitive( true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
refresh_combo_devices() ;
Fixed a bunch of bugs (some of them crashers) which showed up if no * Fixed a bunch of bugs (some of them crashers) which showed up if no devices were detected.
2005-02-01 10:04:03 -07:00
}
Initial revision
2004-09-19 14:24:53 -06:00
}
disabled resizing of this dialog renamed 'Filesystems' to 'Features' in * src/DialogManageFlags.cc: disabled resizing of this dialog * include/DialogFeatures.h, include/Makefile.am, include/Win_GParted.h, src/DialogFeatures.cc, src/Makefile.am, src/Win_GParted.cc: renamed 'Filesystems' to 'Features' in the featuredialog to better reflect the actual functionality * include/Dialog_Filesystems.h, src/Dialog_Filesystems.cc: removed
2006-04-05 03:33:04 -06:00
void Win_GParted::menu_gparted_features()
Added dialog (accessable from 'gparted' menu) which shows supported * Added dialog (accessable from 'gparted' menu) which shows supported operations for the various filesystems. I plan to put some more info in it, like what is missing etc..
2004-12-15 09:38:37 -07:00
{
disabled resizing of this dialog renamed 'Filesystems' to 'Features' in * src/DialogManageFlags.cc: disabled resizing of this dialog * include/DialogFeatures.h, include/Makefile.am, include/Win_GParted.h, src/DialogFeatures.cc, src/Makefile.am, src/Win_GParted.cc: renamed 'Filesystems' to 'Features' in the featuredialog to better reflect the actual functionality * include/Dialog_Filesystems.h, src/Dialog_Filesystems.cc: removed
2006-04-05 03:33:04 -06:00
DialogFeatures dialog ;
Added dialog (accessable from 'gparted' menu) which shows supported * Added dialog (accessable from 'gparted' menu) which shows supported operations for the various filesystems. I plan to put some more info in it, like what is missing etc..
2004-12-15 09:38:37 -07:00
dialog .set_transient_for( *this ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
disabled resizing of this dialog renamed 'Filesystems' to 'Features' in * src/DialogManageFlags.cc: disabled resizing of this dialog * include/DialogFeatures.h, include/Makefile.am, include/Win_GParted.h, src/DialogFeatures.cc, src/Makefile.am, src/Win_GParted.cc: renamed 'Filesystems' to 'Features' in the featuredialog to better reflect the actual functionality * include/Dialog_Filesystems.h, src/Dialog_Filesystems.cc: removed
2006-04-05 03:33:04 -06:00
dialog .load_filesystems( gparted_core .get_filesystems() ) ;
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
while ( dialog .run() == Gtk::RESPONSE_OK )
Added dialog (accessable from 'gparted' menu) which shows supported * Added dialog (accessable from 'gparted' menu) which shows supported operations for the various filesystems. I plan to put some more info in it, like what is missing etc..
2004-12-15 09:38:37 -07:00
{
Remember result of searching the PATH for the hdparm command (#751251) Previously on every refresh for every device, GParted was searching the PATH to discover if the hdparm command existed. Stracing GParted showed that calling Glib::find_program_in_path("hdparm") made the following OS calls: access("/usr/lib64/qt-3.3/bin/hdparm", X_OK) = -1 ENOENT (No such file or directory) access("/usr/local/sbin/hdparm", X_OK) = -1 ENOENT (No such file or directory) access("/usr/local/bin/hdparm", X_OK) = -1 ENOENT (No such file or directory) access("/sbin/hdparm", X_OK) = 0 getuid() = 0 stat("/sbin/hdparm", {st_mode=S_IFREG|0755, st_size=137, ...}) = 0 stat("/sbin/hdparm", {st_mode=S_IFREG|0755, st_size=137, ...}) = 0 The Linux VFS is very fast but repeatedly doing this is wasteful. Remember the result of searching the PATH for the hdparm command at startup and refresh this when the [Rescan For Supported Actions] button is pressed in the File System Support dialog. This is the same as GParted already does for file system specific commands and their capabilities. Bug 751251 - Show serial number in device information
2015-06-30 05:14:20 -06:00
// Button [Rescan For Supported Actions] pressed in the dialog. Rescan
// for available core and file system specific commands and update the
// view accordingly in the dialog.
GParted_Core::find_supported_core();
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
gparted_core .find_supported_filesystems() ;
disabled resizing of this dialog renamed 'Filesystems' to 'Features' in * src/DialogManageFlags.cc: disabled resizing of this dialog * include/DialogFeatures.h, include/Makefile.am, include/Win_GParted.h, src/DialogFeatures.cc, src/Makefile.am, src/Win_GParted.cc: renamed 'Filesystems' to 'Features' in the featuredialog to better reflect the actual functionality * include/Dialog_Filesystems.h, src/Dialog_Filesystems.cc: removed
2006-04-05 03:33:04 -06:00
dialog .load_filesystems( gparted_core .get_filesystems() ) ;
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
//recreate format menu...
replaced hardcoded menu and toolbar indices with variables. This is far * include/Win_GParted.h, src/Win_GParted.cc: replaced hardcoded menu and toolbar indices with variables. This is far more flexible and reliable.
2006-08-20 10:51:18 -06:00
menu_partition .items()[ MENU_FORMAT ] .remove_submenu() ;
menu_partition .items()[ MENU_FORMAT ] .set_submenu( * create_format_menu() ) ;
usability stuff + trivial fix (#353109, #353111) * src/Win_GParted.cc: usability stuff + trivial fix (#353109, #353111)
2006-08-28 14:11:58 -06:00
menu_partition .items()[ MENU_FORMAT ] .get_submenu() ->show_all_children() ;
Added dialog (accessable from 'gparted' menu) which shows supported * Added dialog (accessable from 'gparted' menu) which shows supported operations for the various filesystems. I plan to put some more info in it, like what is missing etc..
2004-12-15 09:38:37 -07:00
}
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::menu_gparted_quit()
Initial revision
2004-09-19 14:24:53 -06:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
if ( Quit_Check_Operations() )
this ->hide();
Initial revision
2004-09-19 14:24:53 -06:00
}
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
void Win_GParted::menu_view_harddisk_info()
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
if ( static_cast<Gtk::CheckMenuItem *>( & menubar_main .items()[ 2 ] .get_submenu() ->items()[ 0 ] ) ->get_active() )
{ //open harddisk information
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
hpaned_main .get_child1() ->show() ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
for ( int t = hpaned_main .get_position() ; t < 250 ; t += 15 )
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
{
Fixed some errors with 'unknown' filesystem. + some cosmetics * src/Dialog_Partition_New.cc, src/Win_GParted.cc: Fixed some errors with 'unknown' filesystem. + some cosmetics
2004-11-23 12:03:39 -07:00
hpaned_main .set_position( t );
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
while ( Gtk::Main::events_pending() )
Gtk::Main::iteration();
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
}
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
else
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
{ //close harddisk information
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
for ( int t = hpaned_main .get_position() ; t > 0 ; t -= 15 )
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
{
Fixed some errors with 'unknown' filesystem. + some cosmetics * src/Dialog_Partition_New.cc, src/Win_GParted.cc: Fixed some errors with 'unknown' filesystem. + some cosmetics
2004-11-23 12:03:39 -07:00
hpaned_main .set_position( t );
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
while ( Gtk::Main::events_pending() )
Gtk::Main::iteration();
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
hpaned_main .get_child1() ->hide() ;
changed representation of hardisk info
2004-09-27 14:12:47 -06:00
}
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::menu_view_operations()
logic unallocated space wasn't read correctly, fixed. added * src/Device.cc (Read_Disk_Layout): logic unallocated space wasn't read correctly, fixed. * include/Win_GParted.h: added open_operationslist() and menu_view_operations() . * src/Win_GParted.cc: tweaked operationlist behaviour a bit. Also added 'Operations" toggle-item to View menu.
2004-10-11 08:19:56 -06:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
if ( static_cast<Gtk::CheckMenuItem *>( & menubar_main .items()[ 2 ] .get_submenu() ->items()[ 1 ] ) ->get_active() )
open_operationslist() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
else
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
close_operationslist() ;
logic unallocated space wasn't read correctly, fixed. added * src/Device.cc (Read_Disk_Layout): logic unallocated space wasn't read correctly, fixed. * include/Win_GParted.h: added open_operationslist() and menu_view_operations() . * src/Win_GParted.cc: tweaked operationlist behaviour a bit. Also added 'Operations" toggle-item to View menu.
2004-10-11 08:19:56 -06:00
}
Improve feedback when creating or pasting partition (#579266) Improve the feedback to the user when creating or pasting a partition on a device with no partition table found. Prior to this enhancement if a user tried to create or paste a partition onto a device with no partition table found, GParted would present the user with a Create Partition Table dialog. When creating a new partition this could cause confusion for users who were trying to format the disk. The user could mistakenly believe the choice of an MS-DOS file system was being presented. Similarly on a paste operation it could be confusing to be presented with a dialog to create a partition table without any explanation of why a partition table was suddenly required in the midst of the paste operation. Neither the new partition creation, nor the partition paste actions were performed after the Create Partition Table dialog was displayed.
2009-10-24 14:16:40 -06:00
void Win_GParted::show_disklabel_unrecognized ( Glib::ustring device_name )
{
//Display dialog box indicating that no partition table was found on the device
Gtk::MessageDialog dialog( *this,
/*TO TRANSLATORS: looks like No partition table found on device /dev/sda */
String::ucompose( _( "No partition table found on device %1" ), device_name ),
false,
Gtk::MESSAGE_INFO,
Gtk::BUTTONS_OK,
true ) ;
Glib::ustring tmp_msg = _( "A partition table is required before partitions can be added." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "To create a new partition table choose the menu item:" ) ;
tmp_msg += "\n" ;
/*TO TRANSLATORS: this message represents the menu item Create Partition Table under the Device menu. */
tmp_msg += _( "Device --> Create Partition Table." ) ;
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
}
Replace gnome-open with gtk_show_uri (#600046) This change was performed to align with a GNOME goal: http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp For backwards compatibility, the gnome-open command is used when gtkmm < 2.14.0.
2009-11-03 10:27:35 -07:00
void Win_GParted::show_help_dialog( const Glib::ustring & filename /* E.g., gparted */
, const Glib::ustring & link_id /* For context sensitive help */
)
Initial revision
2004-09-19 14:24:53 -06:00
{
Replace gnome-open with gtk_show_uri (#600046) This change was performed to align with a GNOME goal: http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp For backwards compatibility, the gnome-open command is used when gtkmm < 2.14.0.
2009-11-03 10:27:35 -07:00
GError *error = NULL ;
GdkScreen *gscreen = NULL ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Replace gnome-open with gtk_show_uri (#600046) This change was performed to align with a GNOME goal: http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp For backwards compatibility, the gnome-open command is used when gtkmm < 2.14.0.
2009-11-03 10:27:35 -07:00
Glib::ustring uri = "ghelp:" + filename ;
if (link_id .size() > 0 ) {
uri = uri + "?" + link_id ;
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Replace gnome-open with gtk_show_uri (#600046) This change was performed to align with a GNOME goal: http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp For backwards compatibility, the gnome-open command is used when gtkmm < 2.14.0.
2009-11-03 10:27:35 -07:00
gscreen = gdk_screen_get_default() ;
#ifdef HAVE_GTK_SHOW_URI
gtk_show_uri( gscreen, uri .c_str(), gtk_get_current_event_time(), &error ) ;
#else
Glib::ustring command = "gnome-open " + uri ;
gdk_spawn_command_line_on_screen( gscreen, command .c_str(), &error ) ;
#endif
Increase robustness of help manual launch Add direct invocation of yelp if normal open help manual methods fail.
2011-01-17 09:26:28 -07:00
if ( error != NULL )
{
//Try opening yelp application directly
g_clear_error( &error ) ; //Clear error from trying to open gparted help manual above (gtk_show_uri or gnome-open).
Glib::ustring command = "yelp " + uri ;
gdk_spawn_command_line_on_screen( gscreen, command .c_str(), &error ) ;
}
Replace gnome-open with gtk_show_uri (#600046) This change was performed to align with a GNOME goal: http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp For backwards compatibility, the gnome-open command is used when gtkmm < 2.14.0.
2009-11-03 10:27:35 -07:00
if ( error != NULL )
{
Gtk::MessageDialog dialog( *this
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
, _( "Unable to open GParted Manual help file" )
Replace gnome-open with gtk_show_uri (#600046) This change was performed to align with a GNOME goal: http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp For backwards compatibility, the gnome-open command is used when gtkmm < 2.14.0.
2009-11-03 10:27:35 -07:00
, false
, Gtk::MESSAGE_ERROR
, Gtk::BUTTONS_OK
, true
) ;
dialog .set_secondary_text( error ->message ) ;
dialog .run() ;
}
Initial revision
2004-09-19 14:24:53 -06:00
}
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
void Win_GParted::menu_help_contents()
{
Tidyup Autoconf check for --disable-doc (#734076) Use AC_ARG_ENABLE() and AS_HELP_STRING() macros to improve handling of the --disable-doc option. Change the names, and sence, of the Autoconf and Automake definitions used to control building of the help documentation. Reasons are: (1) Switch from negative to positive statements which are more natural to comprehend. (2) Insert HELP in the names from *_DOC to *_HELP_DOC as they control building of the documentation in the help subdirectory, not the manual page in the doc directory. Autoconf: HAVE_DISABLE_DOC -> ENABLE_HELP_DOC Automake: DISABLE_DOC -> BUILD_HELP_DOC Bug #734076 - Autodetect parted online partition resizing capability
2014-08-12 14:36:08 -06:00
#ifdef ENABLE_HELP_DOC
//GParted was built with help documentation
show_help_dialog( "gparted", "" );
#else
//GParted was built *without* help documentation using --disable-doc
Add help dialog when configured with --disable-doc
2009-10-17 15:43:20 -06:00
Gtk::MessageDialog dialog( *this,
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
_( "Documentation is not available" ),
Add help dialog when configured with --disable-doc
2009-10-17 15:43:20 -06:00
false,
Gtk::MESSAGE_INFO,
Gtk::BUTTONS_OK,
true ) ;
Glib::ustring tmp_msg = _( "This build of gparted is configured without documentation." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "Documentation is available at the project web site." ) ;
tmp_msg += "\n" ;
Update URLs to new official web site gparted.org
2010-10-12 11:35:26 -06:00
tmp_msg += "http://gparted.org" ;
Add help dialog when configured with --disable-doc
2009-10-17 15:43:20 -06:00
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
#endif
Added code hooks to prepare for GParted Manual svn path=/trunk/; revision=876
2008-08-05 09:34:10 -06:00
}
Initial revision
2004-09-19 14:24:53 -06:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::menu_help_about()
Initial revision
2004-09-19 14:24:53 -06:00
{
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
std::vector<Glib::ustring> strings ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
Gtk::AboutDialog dialog ;
Initial revision
2004-09-19 14:24:53 -06:00
dialog .set_transient_for( *this ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
dialog .set_name( _("GParted") ) ;
Enabled GParted to use themed app icon (Tango theme). Thanks to Sebastion Kraft for designing the icons. Thanks to Michael Monreal for the small patch to make use of themed app icon from hicolor. svn path=/trunk/; revision=909
2008-09-22 16:41:49 -06:00
dialog .set_logo_icon_name( "gparted" ) ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
dialog .set_version( VERSION ) ;
string tweaks. (#328685) * gparted.desktop.in, src/Dialog_Progress.cc, src/Win_GParted.cc: string tweaks. (#328685)
2006-01-26 05:50:46 -07:00
dialog .set_comments( _( "GNOME Partition Editor" ) ) ;
Add Mike Fleetwood to menu_help_about
2015-02-01 13:14:05 -07:00
std::string names ;
names = "Copyright © 2004-2006 Bart Hakvoort" ;
Update copyright year
2016-01-18 09:28:01 -07:00
names += "\nCopyright © 2008-2016 Curtis Gedak" ;
names += "\nCopyright © 2011-2016 Mike Fleetwood" ;
Add Mike Fleetwood to menu_help_about
2015-02-01 13:14:05 -07:00
dialog .set_copyright( names ) ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
//authors
Provide credit in About dialog for significant contributions (#678486) Closes Bug #678486 - Provide Credit in About Dialog for Significant Contributions
2012-06-30 11:26:34 -06:00
//Names listed in alphabetical order by LAST name.
//See also AUTHORS file -- names listed in opposite order to try to be fair.
Provide credit in About dialog for contributions Recognize contributions by Sinlu Bes.
2013-01-02 11:53:50 -07:00
strings .push_back( "Sinlu Bes <e80f00@gmail.com>" ) ;
Provide credit in About dialog for significant contributions (#678486) Closes Bug #678486 - Provide Credit in About Dialog for Significant Contributions
2012-06-30 11:26:34 -06:00
strings .push_back( "Luca Bruno <lucab@debian.org>" ) ;
Provide credit for patch by Wrolf Courtney (#754649) Add recognition for work done by Wrolf Courtney to display LVM logical volumes. Bug 754649 - Display Logical Volumes in Volume Group of LVM2 Partition
2015-09-20 09:59:31 -06:00
strings .push_back( "Wrolf Courtney <wrolf@wrolf.net>" ) ;
Provide credit in About dialog for significant contributions (#678486) Closes Bug #678486 - Provide Credit in About Dialog for Significant Contributions
2012-06-30 11:26:34 -06:00
strings .push_back( "Jérôme Dumesnil <jerome.dumesnil@gmail.com>" ) ;
strings .push_back( "Markus Elfring <elfring@users.sourceforge.net>" ) ;
strings .push_back( "Mike Fleetwood <mike.fleetwood@googlemail.com>" ) ;
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
strings .push_back( "Curtis Gedak <gedakc@users.sf.net>" ) ;
Provide credit in About dialog for contributions Recognize contributions by Matthias Gehre.
2012-11-30 13:32:31 -07:00
strings .push_back( "Matthias Gehre <m.gehre@gmx.de>" ) ;
Provide credit in About dialog for significant contributions (#678486) Closes Bug #678486 - Provide Credit in About Dialog for Significant Contributions
2012-06-30 11:26:34 -06:00
strings .push_back( "Rogier Goossens <goossens.rogier@gmail.com>" ) ;
strings .push_back( "Bart Hakvoort <gparted@users.sf.net>" ) ;
strings .push_back( "Seth Heeren <sgheeren@gmail.com>" ) ;
strings .push_back( "Joan Lledó <joanlluislledo@gmail.com>" ) ;
strings .push_back( "Phillip Susi <psusi@cfl.rr.com>" ) ;
Provide credit for patch by Michael Zimmermann Provide credit for patch to add support for GPT partition names. Also indicate significant effort by Sinlu Bes while we tried different ideas for how GPT partition name support should work.
2015-02-01 11:01:41 -07:00
strings. push_back( "Michael Zimmermann <sigmaepsilon92@gmail.com>" ) ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
dialog .set_authors( strings ) ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
strings .clear() ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
//artists
Update credits in about dialog for artwork Provide credit for the Tango themed icons designed by Sebastian Kraft.
2012-06-21 14:52:04 -06:00
strings .push_back( "Sebastian Kraft <kraft.sebastian@gmail.com>" ) ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
dialog .set_artists( strings ) ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
strings .clear() ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
/*TO TRANSLATORS: your name(s) here please, if there are more translators put newlines (\n) between the names.
Fixed some spelling mistakes svn path=/trunk/; revision=951
2008-11-04 15:16:06 -07:00
It's a good idea to provide the url of your translation team as well. Thanks! */
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
Glib::ustring str_credits = _("translator-credits") ;
if ( str_credits != "translator-credits" )
dialog .set_translator_credits( str_credits ) ;
Make about dialog website link non-clickable (#758131) To avoid security implications of invoking a web browser with root privileges, make the about dialog website link into a non-clickable label. The set_website_label() method has been available since gtkmm 2.6. https://developer.gnome.org/gtkmm/stable/classGtk_1_1AboutDialog.html#aa3d04115d068363be314414899703caa Bug 758131 - Don't run GUI as root (Was: [wayland] gparted fails to start under wayland)
2015-11-19 09:42:51 -07:00
//the url is not clickable - should not invoke web browser as root
dialog .set_website_label( "http://gparted.org" ) ;
removed Dialog_About.[h,cc] from now on we use Gtk::AboutDialog instead of * include/Makefile.am, include/Win_GParted.h, src/Makefile.am: removed Dialog_About.[h,cc] * src/Win_GParted.cc: from now on we use Gtk::AboutDialog instead of our own AboutDialog. Also use Gtk::Stock items instead of hardcoded paths to images (about and harddisk).
2005-11-25 15:41:49 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
dialog .run() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Pass by pointer in the signal_partition_selected callbacks (#750168) Change from passing a reference to the selected partition, to passing a pointer to the selected partition in the signal_partition_selected callbacks between the disk graphic, partition list and core GUI modules. This is an enabler for the following patches. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-16 10:06:22 -06:00
void Win_GParted::on_partition_selected( const Partition * partition_ptr, bool src_is_treeview )
Initial revision
2004-09-19 14:24:53 -06:00
{
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr = partition_ptr;
it shouldn't be possible to remove an extended partition which contains * include/Win_GParted.h, src/Win_GParted.cc: it shouldn't be possible to remove an extended partition which contains logicals. * src/TreeView_Detail.cc: only show mountpoint column when there is mountinfo.
2006-02-09 10:02:40 -07:00
added support for activating swap (#392672) * include/Win_GParted.h, src/Win_GParted.cc: added support for activating swap (#392672)
2006-02-08 13:36:18 -07:00
set_valid_operations() ;
Pass by pointer in the signal_partition_selected callbacks (#750168) Change from passing a reference to the selected partition, to passing a pointer to the selected partition in the signal_partition_selected callbacks between the disk graphic, partition list and core GUI modules. This is an enabler for the following patches. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-16 10:06:22 -06:00
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
if ( src_is_treeview )
Pass by pointer in the signal_partition_selected callbacks (#750168) Change from passing a reference to the selected partition, to passing a pointer to the selected partition in the signal_partition_selected callbacks between the disk graphic, partition list and core GUI modules. This is an enabler for the following patches. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-16 10:06:22 -06:00
drawingarea_visualdisk.set_selected( partition_ptr );
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
else
Pass by pointer in the signal_partition_selected callbacks (#750168) Change from passing a reference to the selected partition, to passing a pointer to the selected partition in the signal_partition_selected callbacks between the disk graphic, partition list and core GUI modules. This is an enabler for the following patches. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-16 10:06:22 -06:00
treeview_detail.set_selected( partition_ptr );
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::on_partition_activated()
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
{
added visual feedback when unmounting or deactivating swap. This can be * include/Win_GParted.h, src/Win_GParted.cc: added visual feedback when unmounting or deactivating swap. This can be usefull when it takes longer then usual.
2006-01-08 08:20:14 -07:00
activate_info() ;
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::on_partition_popup_menu( unsigned int button, unsigned int time )
emit proper signals for several events. cleanups.. * include/TreeView_Detail.h, src/TreeView_Detail.cc, include/VBox_VisualDisk.h, src/VBox_VisualDisk.cc, include/Win_GParted.h, src/Win_GParted.cc: emit proper signals for several events. * include/Partition.h, src/Partition.cc: cleanups..
2005-12-23 17:06:05 -07:00
{
menu_partition .popup( button, time );
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
bool Win_GParted::max_amount_prim_reached()
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
{
Localise counting of primary partitions into max_amount_prim_reached() Now that display_partitions is a Win_GParted member variable and therefore available throughout the class, since commit [1], calculation of primary_count can be localised in max_amount_prim_reached() where it is used. Implements a FIXME and removes primary_count as a member variable. [1] 545b75d9574e053cadb9ddd5cf15fc28181da87c Move vector of partition objects to a Win_GParted class member (#750168)
2015-09-10 10:40:35 -06:00
int primary_count = 0;
for ( unsigned int i = 0 ; i < display_partitions.size() ; i ++ )
{
if ( display_partitions[i].type == TYPE_PRIMARY || display_partitions[i].type == TYPE_EXTENDED )
primary_count ++;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//Display error if user tries to create more primary partitions than the partition table can hold.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( ! selected_partition_ptr->inside_extended && primary_count >= devices[current_device].max_prims )
made message about max. primary partitions a bit more informative. * src/Win_GParted.cc: made message about max. primary partitions a bit more informative.
2006-03-06 04:56:59 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Gtk::MessageDialog dialog(
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
*this,
Update to support plural forms for string for translators Closes bug #631684 - Needed Translator Comments
2010-10-13 08:54:08 -06:00
String::ucompose( ngettext( "It is not possible to create more than %1 primary partition"
, "It is not possible to create more than %1 primary partitions"
, devices[ current_device ] .max_prims
)
, devices[ current_device ] .max_prims
),
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
dialog .set_secondary_text(
made message about max. primary partitions a bit more informative. * src/Win_GParted.cc: made message about max. primary partitions a bit more informative.
2006-03-06 04:56:59 -07:00
_( "If you want more partitions you should first create an extended partition. Such a partition can contain other partitions. Because an extended partition is also a primary partition it might be necessary to remove a primary partition first.") ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
dialog .run() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
return true ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
return false ;
}
Initial revision
2004-09-19 14:24:53 -06:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::activate_resize()
Initial revision
2004-09-19 14:24:53 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Use PartitionVector class throughout the code (#759726) Replace all occurrences of std::vector<Partition> with PartitionVector. Bug 759726 - Implement Partition object polymorphism
2015-05-23 13:22:37 -06:00
PartitionVector * display_partitions_ptr = &display_partitions;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->type == TYPE_LOGICAL )
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
{
unsigned int ext = 0 ;
Stop copying displayed partition objects in activate_resize() (#750168) The first actions of Win_GParted::activate_resize() were to create a copy of the vector of partitions for the currently displayed device and visually apply any pending operations. Exactly this has already been done in Win_GParted::Refresh_Visual() with the result now available in the member variable display_partitions. Stop this unnecessary partition object copying and processing by just using display_partitions member variable instead. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-23 04:34:08 -06:00
while ( ext < display_partitions.size() && display_partitions[ext].type != TYPE_EXTENDED )
ext++;
Adjust pointers to prevent crash when resizing a logical partition (#752587) Opening the Resize/Move dialog on a logical partition causes GParted to crash. This crash affects current GParted GIT HEAD, but does not affect GParted 0.22.0. Git bisect identifies that it was broken with the following commit: Remove Set_Data() from the copy, resize/move and new dialog class APIs 7a4a375ed629fea77995c98d13bd1992231be6fb The problem was trying to treat the reference display_partitions_ref like a pointer, and in particular on line 1732 trying to make it refer to the a different vector of partitions, .logicals sub-vector. 1721 void Win_GParted::activate_resize() 1722 { ... 1726 std::vector<Partition> & display_partitions_ref = display_partitions; 1727 if ( selected_partition_ptr->type == TYPE_LOGICAL ) 1728 { 1729 unsigned int ext = 0 ; 1730 while ( ext < display_partitions.size() && display_partitions[ext].type != TYPE_EXTENDED ) 1731 ext++; * 1732 display_partitions_ref = display_partitions[ext].logicals; 1733 } 1734 1735 Dialog_Partition_Resize_Move dialog( gparted_core.get_fs( selected_partition_ptr->filesystem ), 1736 *selected_partition_ptr, 1737 display_partitions_ref ); What was actually happening was that the .logicals sub-vector was being copied, replacing the display_partitions vector and freeing the original sub-vector. This left selected_partition_ptr pointing to the original memory where the selected partition use to exist in the .logicals sub-vector. At some point in the Dialog_Partition_Resize_Move class *selected_partition_ptr was referenced, accessing the freed memory. Crash soon followed. Fix by using a pointer instead of a reference, which can be assigned to point to a different object. Bug 752587 - GParted crashing when opening Resize/Move dialog on logical partition
2015-07-20 12:59:46 -06:00
display_partitions_ptr = &display_partitions[ext].logicals;
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Remove Set_Data() from the copy, resize/move and new dialog class APIs The copy, resize/move and new dialog classes (Dialog_Partition_Copy, Dialog_Partition_Resize_Move and Dialog_Partition_New respectively) had to be used like this: construct dialog object passing some parameters call Set_Data() to pass more parameters run() dialog call Get_New_Partition() There is nothing in the classes which forces Set_Data() to be called, but it must be called for the dialogs to work and prevent GParted from crashing. Make these class APIs safer by making it impossible to program incorrectly in this regard. Move all the additional parameters from each Set_Data() method to each constructor. The constructors just call the now private set_data() methods.
2015-06-02 06:10:45 -06:00
Dialog_Partition_Resize_Move dialog( gparted_core.get_fs( selected_partition_ptr->filesystem ),
*selected_partition_ptr,
Adjust pointers to prevent crash when resizing a logical partition (#752587) Opening the Resize/Move dialog on a logical partition causes GParted to crash. This crash affects current GParted GIT HEAD, but does not affect GParted 0.22.0. Git bisect identifies that it was broken with the following commit: Remove Set_Data() from the copy, resize/move and new dialog class APIs 7a4a375ed629fea77995c98d13bd1992231be6fb The problem was trying to treat the reference display_partitions_ref like a pointer, and in particular on line 1732 trying to make it refer to the a different vector of partitions, .logicals sub-vector. 1721 void Win_GParted::activate_resize() 1722 { ... 1726 std::vector<Partition> & display_partitions_ref = display_partitions; 1727 if ( selected_partition_ptr->type == TYPE_LOGICAL ) 1728 { 1729 unsigned int ext = 0 ; 1730 while ( ext < display_partitions.size() && display_partitions[ext].type != TYPE_EXTENDED ) 1731 ext++; * 1732 display_partitions_ref = display_partitions[ext].logicals; 1733 } 1734 1735 Dialog_Partition_Resize_Move dialog( gparted_core.get_fs( selected_partition_ptr->filesystem ), 1736 *selected_partition_ptr, 1737 display_partitions_ref ); What was actually happening was that the .logicals sub-vector was being copied, replacing the display_partitions vector and freeing the original sub-vector. This left selected_partition_ptr pointing to the original memory where the selected partition use to exist in the .logicals sub-vector. At some point in the Dialog_Partition_Resize_Move class *selected_partition_ptr was referenced, accessing the freed memory. Crash soon followed. Fix by using a pointer instead of a reference, which can be assigned to point to a different object. Bug 752587 - GParted crashing when opening Resize/Move dialog on logical partition
2015-07-20 12:59:46 -06:00
*display_partitions_ptr );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
dialog .set_transient_for( *this ) ;
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
if ( dialog .run() == Gtk::RESPONSE_OK )
Initial revision
2004-09-19 14:24:53 -06:00
{
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
dialog .hide() ;
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
Remove unnecessary sector_size parameter from Get_New_Partition methods The sector_size parameter is unnecessary as the value can be retrieved from the sector size of the selected Partition object on which the create new, copy & paste or resize/move operation is being performed. For the create new and resize/move operations it is trivial as the existing unallocated or in use Partition object on which the operation is being perform already contains the correct sector size. For the copy & paste operation, which can copy across disk devices of different sector sizes, we merely have to use the sector size of the existing selected (destination) Partition object rather than copied (source) Partition object. Hence these relevant lines in the new code: Dialog_Partition_Copy::set_data(selected_partition, copied_partition) new_partition = copied_partition.clone(); ... new_partition->sector_size = selected_partition.sector_size;
2015-12-16 13:15:58 -07:00
Partition * part_temp = dialog.Get_New_Partition().clone();
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
// When resizing/moving a partition which already exists on the disk all
// possible operations could be pending so only try merging with the
// previous operation.
MergeType mergetype = MERGE_LAST_WITH_PREV;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// If selected partition is NEW we simply remove the NEW operation from the list and add
// it again with the new size and position ( unless it's an EXTENDED )
if ( selected_partition_ptr->status == STAT_NEW && selected_partition_ptr->type != TYPE_EXTENDED )
Initial revision
2004-09-19 14:24:53 -06:00
{
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
part_temp->status = STAT_NEW;
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
// On a partition which is pending creation only resize/move and
// format operations are possible. These operations are always
// mergeable with the pending operation which will create the
// partition. Hence merge with any earlier operations to achieve
// this.
mergetype = MERGE_LAST_WITH_ANY;
Initial revision
2004-09-19 14:24:53 -06:00
}
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
Operation * operation = new OperationResizeMove( devices[current_device],
*selected_partition_ptr,
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
*part_temp );
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
operation->icon = render_icon( Gtk::Stock::GOTO_LAST, Gtk::ICON_SIZE_MENU );
Warn partition move queued that might break boot process (#627199)
2010-09-01 13:54:00 -06:00
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
delete part_temp;
part_temp = NULL;
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
// Display warning if moving a non-extended partition which already exists
// on the disk.
Protect partition members within Operation classes (#759726) The Operation classes contain partition objects which are copied by value. Need to replace these with pointers to Partition objects instead and manage their lifetimes so that they can be used polymorphically. First step is to protect the partition members partition_new, partition_original, and for OperationCopy class only, partition_copied within the Operation classes and provide accessor methods. get_partition_new() and get_partition_original() accessors are implemented in the Operation base class so all derived classes get an implementation. get_partition_new() is also virtual so that OperationCheck and OperationDelete can override the implementation and assert that they don't use partition_new. get_partition_copied() is provided for the OperationCopy class only so can only be accessed via an OperationCopy type variable. Bug 759726 - Implement Partition object polymorphism
2015-09-19 08:57:39 -06:00
if ( operation->get_partition_original().status != STAT_NEW &&
operation->get_partition_original().sector_start != operation->get_partition_new().sector_start &&
operation->get_partition_original().type != TYPE_EXTENDED )
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
{
// Warn that move operation might break boot process
Gtk::MessageDialog dialog( *this,
_("Moving a partition might cause your operating system to fail to boot"),
false,
Gtk::MESSAGE_WARNING,
Gtk::BUTTONS_OK,
true );
Glib::ustring tmp_msg =
Rearrange text for warning when moving a partition
2010-10-13 09:04:20 -06:00
/*TO TRANSLATORS: looks like You queued an operation to move the start sector of partition /dev/sda3. */
String::ucompose( _( "You have queued an operation to move the start sector of partition %1." )
Protect partition members within Operation classes (#759726) The Operation classes contain partition objects which are copied by value. Need to replace these with pointers to Partition objects instead and manage their lifetimes so that they can be used polymorphically. First step is to protect the partition members partition_new, partition_original, and for OperationCopy class only, partition_copied within the Operation classes and provide accessor methods. get_partition_new() and get_partition_original() accessors are implemented in the Operation base class so all derived classes get an implementation. get_partition_new() is also virtual so that OperationCheck and OperationDelete can override the implementation and assert that they don't use partition_new. get_partition_copied() is provided for the OperationCopy class only so can only be accessed via an OperationCopy type variable. Bug 759726 - Implement Partition object polymorphism
2015-09-19 08:57:39 -06:00
, operation->get_partition_original().get_path() );
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
tmp_msg += _(" Failure to boot is most likely to occur if you move the GNU/Linux partition containing /boot, or if you move the Windows system partition C:.");
tmp_msg += "\n";
tmp_msg += _("You can learn how to repair the boot configuration in the GParted FAQ.");
tmp_msg += "\n";
tmp_msg += "http://gparted.org/faq.php";
tmp_msg += "\n\n";
tmp_msg += _("Moving a partition might take a very long time to apply.");
dialog.set_secondary_text( tmp_msg );
dialog.run();
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
}
Replace open coded merge of resize/move into create operation (#755214) For the case of resizing/moving a new, not yet created partition, activate_resize() open coded the merge operation. Again this code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of resizing/moving an existing partition. NOTES: This commit changes the merge direction. The old coded merged forward by removing the old create operation and adding a new create operation with the new size. This was bad because with multiple pending create operations, each merged resize operation reordered those create operations. Then when the operations were applied the partitions were created and therefore numbered in a different order to that shown in disk graphic. The new code merges backwards by updating the initial create operation with the new size. This maintains the create operation order so that when applied the partitions are numbered in the same order as shown in the disk graphic. Bug 755214 - Refactor operation merging
2015-09-16 15:23:12 -06:00
Add_Operation( operation );
merge_operations( mergetype );
Initial revision
2004-09-19 14:24:53 -06:00
}
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
void Win_GParted::activate_copy()
Initial revision
2004-09-19 14:24:53 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
delete copied_partition;
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
copied_partition = selected_partition_ptr->clone();
Initial revision
2004-09-19 14:24:53 -06:00
}
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
void Win_GParted::activate_paste()
Initial revision
2004-09-19 14:24:53 -06:00
{
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
g_assert( copied_partition != NULL ); // Bug: Paste called without partition to copy
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Correct whole disk device file system format to cleared preview (#743181) The preview of clearing a whole disk device file system was previewing the same as formatting to all other file system types; as a cleared file system spanning the whole disk device. However when implemented this removes all signatures on the disk so it actually becomes an unallocated and unpartitioned device. Make the preview match what happens in when implemented. GParted previously used mydevice.max_prims = -1 to represent an unpartitioned device. It is now represented as: mydevice.max_prims = 1 mydevice.disktype = _("unrecognized") mydevice.partitions[0].type = TYPE_UNALLOCATED mydevice.partitions[0].whole_device = true mydevice.partitions[0].filesystem = FS_UNALLOCATED and the check for an unpartitioned device in Win_GParted.cc becomes: partitions[0].type == TYPE_UNALLOCATED && partitions[0].whole_device Bug 743181 - Add unpartitioned drive read-write support
2015-02-17 08:14:23 -07:00
// Unrecognised whole disk device (See GParted_Core::get_devices_threads(), "unrecognized")
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->whole_device && selected_partition_ptr->type == TYPE_UNALLOCATED )
Initial revision
2004-09-19 14:24:53 -06:00
{
Improve feedback when creating or pasting partition (#579266) Improve the feedback to the user when creating or pasting a partition on a device with no partition table found. Prior to this enhancement if a user tried to create or paste a partition onto a device with no partition table found, GParted would present the user with a Create Partition Table dialog. When creating a new partition this could cause confusion for users who were trying to format the disk. The user could mistakenly believe the choice of an MS-DOS file system was being presented. Similarly on a paste operation it could be confusing to be presented with a dialog to create a partition table without any explanation of why a partition table was suddenly required in the midst of the paste operation. Neither the new partition creation, nor the partition paste actions were performed after the Create Partition Table dialog was displayed.
2009-10-24 14:16:40 -06:00
show_disklabel_unrecognized( devices [current_device ] .get_path() ) ;
fixed bug with copying partition to a disk without disklabel. Also added * src/Win_GParted.cc: fixed bug with copying partition to a disk without disklabel. Also added some FIXME's.
2006-11-26 16:24:39 -07:00
return ;
}
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->type == TYPE_UNALLOCATED )
fixed bug with copying partition to a disk without disklabel. Also added * src/Win_GParted.cc: fixed bug with copying partition to a disk without disklabel. Also added some FIXME's.
2006-11-26 16:24:39 -07:00
{
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
if ( ! max_amount_prim_reached() )
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
{
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
// We don't want the messages, mount points or name of the source
// partition for the new partition being created.
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
Partition * part_temp = copied_partition->clone();
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
part_temp->messages.clear();
part_temp->clear_mountpoints();
part_temp->name.clear();
Remove Set_Data() from the copy, resize/move and new dialog class APIs The copy, resize/move and new dialog classes (Dialog_Partition_Copy, Dialog_Partition_Resize_Move and Dialog_Partition_New respectively) had to be used like this: construct dialog object passing some parameters call Set_Data() to pass more parameters run() dialog call Get_New_Partition() There is nothing in the classes which forces Set_Data() to be called, but it must be called for the dialogs to work and prevent GParted from crashing. Make these class APIs safer by making it impossible to program incorrectly in this regard. Move all the additional parameters from each Set_Data() method to each constructor. The constructors just call the now private set_data() methods.
2015-06-02 06:10:45 -06:00
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
Dialog_Partition_Copy dialog( gparted_core.get_fs( copied_partition->filesystem ),
Remove Set_Data() from the copy, resize/move and new dialog class APIs The copy, resize/move and new dialog classes (Dialog_Partition_Copy, Dialog_Partition_Resize_Move and Dialog_Partition_New respectively) had to be used like this: construct dialog object passing some parameters call Set_Data() to pass more parameters run() dialog call Get_New_Partition() There is nothing in the classes which forces Set_Data() to be called, but it must be called for the dialogs to work and prevent GParted from crashing. Make these class APIs safer by making it impossible to program incorrectly in this regard. Move all the additional parameters from each Set_Data() method to each constructor. The constructors just call the now private set_data() methods.
2015-06-02 06:10:45 -06:00
*selected_partition_ptr,
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
*part_temp );
delete part_temp;
part_temp = NULL;
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
dialog .set_transient_for( *this );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
if ( dialog .run() == Gtk::RESPONSE_OK )
{
dialog .hide() ;
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Operation * operation = new OperationCopy( devices[current_device],
*selected_partition_ptr,
Remove unnecessary sector_size parameter from Get_New_Partition methods The sector_size parameter is unnecessary as the value can be retrieved from the sector size of the selected Partition object on which the create new, copy & paste or resize/move operation is being performed. For the create new and resize/move operations it is trivial as the existing unallocated or in use Partition object on which the operation is being perform already contains the correct sector size. For the copy & paste operation, which can copy across disk devices of different sector sizes, we merely have to use the sector size of the existing selected (destination) Partition object rather than copied (source) Partition object. Hence these relevant lines in the new code: Dialog_Partition_Copy::set_data(selected_partition, copied_partition) new_partition = copied_partition.clone(); ... new_partition->sector_size = selected_partition.sector_size;
2015-12-16 13:15:58 -07:00
dialog.Get_New_Partition(),
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
*copied_partition );
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
operation ->icon = render_icon( Gtk::Stock::COPY, Gtk::ICON_SIZE_MENU );
Add_Operation( operation ) ;
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
}
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
}
Initial revision
2004-09-19 14:24:53 -06:00
}
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
else
{
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
bool shown_dialog = false ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// VGNAME from mount mount
if ( selected_partition_ptr->filesystem == FS_LVM2_PV &&
! selected_partition_ptr->get_mountpoint().empty() )
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
{
if ( ! remove_non_empty_lvm2_pv_dialog( OPERATION_COPY ) )
return ;
shown_dialog = true ;
}
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
Partition * partition_new = selected_partition_ptr->clone();
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
partition_new->alignment = ALIGN_STRICT;
partition_new->filesystem = copied_partition->filesystem;
partition_new->set_filesystem_label( copied_partition->get_filesystem_label() );
partition_new->uuid = copied_partition->uuid;
Sector new_size = partition_new->get_sector_length();
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
if ( copied_partition->get_sector_length() == new_size )
Set unallocated space when performing simple operations (#499202) When pasting a copied partition into an existing partition set its space utilisation so that any unallocated space is displayed correctly before the operation is applied. If the destination partition is larger the file system will be grown to fill the partition. NOTE: GParted will attempt to grow the the file system in this situation regardless of whether the file system supports it or not. These file systems: exfat, hfs, hfs+, reiser4 and ufs can't be grown and will fail with "growing is not available for this file system". The preview will also be wrong in this case for the same reason. Everything will be depicted correctly after the refresh. When formatting an existing partition default its space utilisation to unknown for display before the operation is applied. Bug 499202 - gparted does not see the difference if partition size differs from filesystem size
2012-04-11 14:07:52 -06:00
{
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
// Pasting into same size existing partition, therefore only block
// copy operation will be performed maintaining the file system
// size.
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
partition_new->set_sector_usage(
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
copied_partition->sectors_used + copied_partition->sectors_unused,
copied_partition->sectors_unused );
Set unallocated space when performing simple operations (#499202) When pasting a copied partition into an existing partition set its space utilisation so that any unallocated space is displayed correctly before the operation is applied. If the destination partition is larger the file system will be grown to fill the partition. NOTE: GParted will attempt to grow the the file system in this situation regardless of whether the file system supports it or not. These file systems: exfat, hfs, hfs+, reiser4 and ufs can't be grown and will fail with "growing is not available for this file system". The preview will also be wrong in this case for the same reason. Everything will be depicted correctly after the refresh. When formatting an existing partition default its space utilisation to unknown for display before the operation is applied. Bug 499202 - gparted does not see the difference if partition size differs from filesystem size
2012-04-11 14:07:52 -06:00
}
else
{
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
// Pasting into larger existing partition, therefore block copy
// followed by file system grow operations (if supported) will be
// performed making the file system fill the partition.
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
partition_new->set_sector_usage(
Set unallocated space when performing simple operations (#499202) When pasting a copied partition into an existing partition set its space utilisation so that any unallocated space is displayed correctly before the operation is applied. If the destination partition is larger the file system will be grown to fill the partition. NOTE: GParted will attempt to grow the the file system in this situation regardless of whether the file system supports it or not. These file systems: exfat, hfs, hfs+, reiser4 and ufs can't be grown and will fail with "growing is not available for this file system". The preview will also be wrong in this case for the same reason. Everything will be depicted correctly after the refresh. When formatting an existing partition default its space utilisation to unknown for display before the operation is applied. Bug 499202 - gparted does not see the difference if partition size differs from filesystem size
2012-04-11 14:07:52 -06:00
new_size,
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
new_size - copied_partition->sectors_used );
Set unallocated space when performing simple operations (#499202) When pasting a copied partition into an existing partition set its space utilisation so that any unallocated space is displayed correctly before the operation is applied. If the destination partition is larger the file system will be grown to fill the partition. NOTE: GParted will attempt to grow the the file system in this situation regardless of whether the file system supports it or not. These file systems: exfat, hfs, hfs+, reiser4 and ufs can't be grown and will fail with "growing is not available for this file system". The preview will also be wrong in this case for the same reason. Everything will be depicted correctly after the refresh. When formatting an existing partition default its space utilisation to unknown for display before the operation is applied. Bug 499202 - gparted does not see the difference if partition size differs from filesystem size
2012-04-11 14:07:52 -06:00
}
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
partition_new->messages.clear();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Operation * operation = new OperationCopy( devices[current_device],
*selected_partition_ptr,
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
*partition_new,
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
*copied_partition );
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
operation ->icon = render_icon( Gtk::Stock::COPY, Gtk::ICON_SIZE_MENU );
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
delete partition_new;
partition_new = NULL;
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
Add_Operation( operation ) ;
Re-enable ability to paste into an existing partition (#582101) The ability to paste into an existing partition was disabled in v0.4.0. This ability has been re-enabled along with a warning dialog that indicates the data in the existing partition will be lost if the copy and paste operation is applied.
2009-11-25 12:36:43 -07:00
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
if ( ! shown_dialog )
{
//Only warn that this paste operation will overwrite data in the existing
// partition if not already shown the remove non-empty LVM2 PV dialog.
Gtk::MessageDialog dialog( *this
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
, _( "You have pasted into an existing partition" )
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
, false
, Gtk::MESSAGE_WARNING
, Gtk::BUTTONS_OK
, true
) ;
/*TO TRANSLATORS: looks like The data in /dev/sda3 will be lost if you apply this operation. */
dialog .set_secondary_text(
String::ucompose( _( "The data in %1 will be lost if you apply this operation." ),
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
selected_partition_ptr->get_path() ) );
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
dialog .run() ;
}
added set_used() and operator!= it's now possible to copy from partition * include/Partition.h, src/Partition.cc: added set_used() and operator!= * src/Dialog_Partition_Copy.cc, src/GParted_Core.cc, src/OperationCopy.cc, src/Win_GParted.cc: it's now possible to copy from partition to partition. (before this it was only possible to copy to unallocated space)
2006-03-29 12:21:42 -07:00
}
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
it shouldn't be possible to remove an extended partition which contains * include/Win_GParted.h, src/Win_GParted.cc: it shouldn't be possible to remove an extended partition which contains logicals. * src/TreeView_Detail.cc: only show mountpoint column when there is mountinfo.
2006-02-09 10:02:40 -07:00
void Win_GParted::activate_new()
Initial revision
2004-09-19 14:24:53 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Correct whole disk device file system format to cleared preview (#743181) The preview of clearing a whole disk device file system was previewing the same as formatting to all other file system types; as a cleared file system spanning the whole disk device. However when implemented this removes all signatures on the disk so it actually becomes an unallocated and unpartitioned device. Make the preview match what happens in when implemented. GParted previously used mydevice.max_prims = -1 to represent an unpartitioned device. It is now represented as: mydevice.max_prims = 1 mydevice.disktype = _("unrecognized") mydevice.partitions[0].type = TYPE_UNALLOCATED mydevice.partitions[0].whole_device = true mydevice.partitions[0].filesystem = FS_UNALLOCATED and the check for an unpartitioned device in Win_GParted.cc becomes: partitions[0].type == TYPE_UNALLOCATED && partitions[0].whole_device Bug 743181 - Add unpartitioned drive read-write support
2015-02-17 08:14:23 -07:00
// Unrecognised whole disk device (See GParted_Core::get_devices_threads(), "unrecognized")
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->whole_device && selected_partition_ptr->type == TYPE_UNALLOCATED )
Improve feedback when creating or pasting partition (#579266) Improve the feedback to the user when creating or pasting a partition on a device with no partition table found. Prior to this enhancement if a user tried to create or paste a partition onto a device with no partition table found, GParted would present the user with a Create Partition Table dialog. When creating a new partition this could cause confusion for users who were trying to format the disk. The user could mistakenly believe the choice of an MS-DOS file system was being presented. Similarly on a paste operation it could be confusing to be presented with a dialog to create a partition table without any explanation of why a partition table was suddenly required in the midst of the paste operation. Neither the new partition creation, nor the partition paste actions were performed after the Create Partition Table dialog was displayed.
2009-10-24 14:16:40 -06:00
{
show_disklabel_unrecognized( devices [current_device ] .get_path() ) ;
}
it shouldn't be possible to remove an extended partition which contains * include/Win_GParted.h, src/Win_GParted.cc: it shouldn't be possible to remove an extended partition which contains logicals. * src/TreeView_Detail.cc: only show mountpoint column when there is mountinfo.
2006-02-09 10:02:40 -07:00
else if ( ! max_amount_prim_reached() )
Remove Set_Data() from the copy, resize/move and new dialog class APIs The copy, resize/move and new dialog classes (Dialog_Partition_Copy, Dialog_Partition_Resize_Move and Dialog_Partition_New respectively) had to be used like this: construct dialog object passing some parameters call Set_Data() to pass more parameters run() dialog call Get_New_Partition() There is nothing in the classes which forces Set_Data() to be called, but it must be called for the dialogs to work and prevent GParted from crashing. Make these class APIs safer by making it impossible to program incorrectly in this regard. Move all the additional parameters from each Set_Data() method to each constructor. The constructors just call the now private set_data() methods.
2015-06-02 06:10:45 -06:00
{
Localise checking for an extended partition into activate_new() As previous commit, display_partitions is now a Win_GParted member variable so checking for the existence of an extended partition can be localised where it is used. Remove index_extended member variable and localise the same checking in activate_new().
2015-09-10 11:24:49 -06:00
// Check if an extended partition already exist; so that the dialog can
// decide whether to allow the creation of the only extended partition
// type or not.
bool any_extended = false;
for ( unsigned int i = 0 ; i < display_partitions.size() ; i ++ )
{
if ( display_partitions[i].type == TYPE_EXTENDED )
{
any_extended = true;
break;
}
}
Remove Set_Data() from the copy, resize/move and new dialog class APIs The copy, resize/move and new dialog classes (Dialog_Partition_Copy, Dialog_Partition_Resize_Move and Dialog_Partition_New respectively) had to be used like this: construct dialog object passing some parameters call Set_Data() to pass more parameters run() dialog call Get_New_Partition() There is nothing in the classes which forces Set_Data() to be called, but it must be called for the dialogs to work and prevent GParted from crashing. Make these class APIs safer by making it impossible to program incorrectly in this regard. Move all the additional parameters from each Set_Data() method to each constructor. The constructors just call the now private set_data() methods.
2015-06-02 06:10:45 -06:00
Dialog_Partition_New dialog( devices[current_device],
*selected_partition_ptr,
Localise checking for an extended partition into activate_new() As previous commit, display_partitions is now a Win_GParted member variable so checking for the existence of an extended partition can be localised where it is used. Remove index_extended member variable and localise the same checking in activate_new().
2015-09-10 11:24:49 -06:00
any_extended,
Remove Set_Data() from the copy, resize/move and new dialog class APIs The copy, resize/move and new dialog classes (Dialog_Partition_Copy, Dialog_Partition_Resize_Move and Dialog_Partition_New respectively) had to be used like this: construct dialog object passing some parameters call Set_Data() to pass more parameters run() dialog call Get_New_Partition() There is nothing in the classes which forces Set_Data() to be called, but it must be called for the dialogs to work and prevent GParted from crashing. Make these class APIs safer by making it impossible to program incorrectly in this regard. Move all the additional parameters from each Set_Data() method to each constructor. The constructors just call the now private set_data() methods.
2015-06-02 06:10:45 -06:00
new_count,
gparted_core.get_filesystems() );
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
dialog .set_transient_for( *this );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
it shouldn't be possible to remove an extended partition which contains * include/Win_GParted.h, src/Win_GParted.cc: it shouldn't be possible to remove an extended partition which contains logicals. * src/TreeView_Detail.cc: only show mountpoint column when there is mountinfo.
2006-02-09 10:02:40 -07:00
if ( dialog .run() == Gtk::RESPONSE_OK )
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
{
show greyed-out mountpoint of unmounted partitions in the treeview as an * include/GParted_Core.h, include/TreeView_Detail.h, src/GParted_Core.cc, src/TreeView_Detail.cc: show greyed-out mountpoint of unmounted partitions in the treeview as an improved way to identify partitions. (#333027) * src/Win_GParted.cc: cleanups
2006-03-07 04:55:27 -07:00
dialog .hide() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
new_count++ ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Operation * operation = new OperationCreate( devices[current_device],
*selected_partition_ptr,
Remove unnecessary sector_size parameter from Get_New_Partition methods The sector_size parameter is unnecessary as the value can be retrieved from the sector size of the selected Partition object on which the create new, copy & paste or resize/move operation is being performed. For the create new and resize/move operations it is trivial as the existing unallocated or in use Partition object on which the operation is being perform already contains the correct sector size. For the copy & paste operation, which can copy across disk devices of different sector sizes, we merely have to use the sector size of the existing selected (destination) Partition object rather than copied (source) Partition object. Hence these relevant lines in the new code: Dialog_Partition_Copy::set_data(selected_partition, copied_partition) new_partition = copied_partition.clone(); ... new_partition->sector_size = selected_partition.sector_size;
2015-12-16 13:15:58 -07:00
dialog.Get_New_Partition() );
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
operation ->icon = render_icon( Gtk::Stock::NEW, Gtk::ICON_SIZE_MENU );
Add_Operation( operation );
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
instead of listing all partition in one list, logical partitions are now * instead of listing all partition in one list, logical partitions are now stored in a sublist in extended partition object. This makes partitionhandling in gparted more natural and transparant. It also allowed me to clean up this ugly Operation class ;)
2004-11-06 04:55:03 -07:00
}
}
Initial revision
2004-09-19 14:24:53 -06:00
}
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
void Win_GParted::activate_delete()
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// VGNAME from mount mount
if ( selected_partition_ptr->filesystem == FS_LVM2_PV && ! selected_partition_ptr->get_mountpoint().empty() )
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
{
if ( ! remove_non_empty_lvm2_pv_dialog( OPERATION_DELETE ) )
return ;
}
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
/* since logicals are *always* numbered from 5 to <last logical> there can be a shift
* in numbers after deletion.
* e.g. consider /dev/hda5 /dev/hda6 /dev/hda7. Now after removal of /dev/hda6,
* /dev/hda7 is renumbered to /dev/hda6
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
* the new situation is now /dev/hda5 /dev/hda6. If /dev/hda7 was mounted
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
* the OS cannot find /dev/hda7 anymore and the results aren't that pretty.
* It seems best to check for this and prohibit deletion with some explanation to the user.*/
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->type == TYPE_LOGICAL &&
selected_partition_ptr->status != STAT_NEW &&
selected_partition_ptr->partition_number < devices[current_device].highest_busy )
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Gtk::MessageDialog dialog( *this,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
String::ucompose( _("Unable to delete %1!"), selected_partition_ptr->get_path() ),
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true );
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
dialog .set_secondary_text(
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
String::ucompose( _("Please unmount any logical partitions having a number higher than %1"),
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->partition_number ) );
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
dialog .run() ;
changed some sentences on translators request
2004-09-24 19:10:21 -06:00
return;
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
changed the way devices and partitions store their devicepaths. Instead of * changed the way devices and partitions store their devicepaths. Instead of holding a 'realpath' and a symbolic path we store paths in a list. This allows for improved detection of mountpoins, free space, etc.. Also fixed a nasty bug which showed up when you copy a partition from one device to another. (thanks to mario for the report)
2006-03-14 14:37:47 -07:00
//if partition is on the clipboard...(NOTE: we can't use Partition::== here..)
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
if ( copied_partition != NULL && selected_partition_ptr->get_path() == copied_partition->get_path() )
removed all stringstreams from the project (they were possibly responsible * removed all stringstreams from the project (they were possibly responsible for rare chrashes in certain locales)
2004-10-02 03:39:16 -06:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Gtk::MessageDialog dialog( *this,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
String::ucompose( _("Are you sure you want to delete %1?"),
selected_partition_ptr->get_path() ),
false,
Gtk::MESSAGE_QUESTION,
Gtk::BUTTONS_NONE,
true );
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
dialog .set_secondary_text( _("After deletion this partition is no longer available for copying.") ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//www.iec.ch/zone/si/si_bytes.htm * changed KB/MB/GB/TB to KiB/MiB/GiB/TiB after reading http://www.iec.ch/zone/si/si_bytes.htm
2006-01-20 16:35:06 -07:00
/*TO TRANSLATORS: dialogtitle, looks like Delete /dev/hda2 (ntfs, 2345 MiB) */
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
dialog.set_title( String::ucompose( _("Delete %1 (%2, %3)"),
selected_partition_ptr->get_path(),
Utils::get_filesystem_string( selected_partition_ptr->filesystem ),
Utils::format_size( selected_partition_ptr->get_sector_length(), selected_partition_ptr->sector_size ) ) );
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
dialog .add_button( Gtk::Stock::CANCEL, Gtk::RESPONSE_CANCEL );
dialog .add_button( Gtk::Stock::DELETE, Gtk::RESPONSE_OK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
dialog .show_all_children() ;
if ( dialog .run() != Gtk::RESPONSE_OK )
return ;
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
// Deleting partition on the clipboard. Clear clipboard.
delete copied_partition;
copied_partition = NULL;
removed all stringstreams from the project (they were possibly responsible * removed all stringstreams from the project (they were possibly responsible for rare chrashes in certain locales)
2004-10-02 03:39:16 -06:00
}
Change copied_partition into a pointer (#759726) Change Win_GParted::copied_partition from Partition object which is copied by value into a pointer to a Partition object object which is allocated, copy constructed and deleted. Required as part of the polymorphic implementation of Partitions. As before when managing the lifetime of pointers to objects in a class the Big 3 of destructor, copy constructor and copy assignment operator need to be considered. A destructor is added to finally delete copied_partition. A single Win_GParted object is only ever created and destroyed in main(). The class is never copy constructed or copy assigned. Make the compiler enforce this with private declarations and no implementations. Bug 759726 - Implement Partition object polymorphism
2015-09-10 05:44:48 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// If deleted one is NEW, it doesn't make sense to add it to the operationslist,
// we erase its creation and possible modifications like resize etc.. from the operationslist.
// Calling Refresh_Visual will wipe every memory of its existence ;-)
if ( selected_partition_ptr->status == STAT_NEW )
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
//remove all operations done on this new partition (this includes creation)
for ( int t = 0 ; t < static_cast<int>( operations .size() ) ; t++ )
Protect partition members within Operation classes (#759726) The Operation classes contain partition objects which are copied by value. Need to replace these with pointers to Partition objects instead and manage their lifetimes so that they can be used polymorphically. First step is to protect the partition members partition_new, partition_original, and for OperationCopy class only, partition_copied within the Operation classes and provide accessor methods. get_partition_new() and get_partition_original() accessors are implemented in the Operation base class so all derived classes get an implementation. get_partition_new() is also virtual so that OperationCheck and OperationDelete can override the implementation and assert that they don't use partition_new. get_partition_copied() is provided for the OperationCopy class only so can only be accessed via an OperationCopy type variable. Bug 759726 - Implement Partition object polymorphism
2015-09-19 08:57:39 -06:00
if ( operations[t]->get_partition_new().get_path() == selected_partition_ptr->get_path() )
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
remove_operation( t-- ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
//determine lowest possible new_count
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
new_count = 0 ;
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
for ( unsigned int t = 0 ; t < operations .size() ; t++ )
Protect partition members within Operation classes (#759726) The Operation classes contain partition objects which are copied by value. Need to replace these with pointers to Partition objects instead and manage their lifetimes so that they can be used polymorphically. First step is to protect the partition members partition_new, partition_original, and for OperationCopy class only, partition_copied within the Operation classes and provide accessor methods. get_partition_new() and get_partition_original() accessors are implemented in the Operation base class so all derived classes get an implementation. get_partition_new() is also virtual so that OperationCheck and OperationDelete can override the implementation and assert that they don't use partition_new. get_partition_copied() is provided for the OperationCopy class only so can only be accessed via an OperationCopy type variable. Bug 759726 - Implement Partition object polymorphism
2015-09-19 08:57:39 -06:00
if ( operations[t]->get_partition_new().status == STAT_NEW &&
operations[t]->get_partition_new().partition_number > new_count )
new_count = operations[t]->get_partition_new().partition_number;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
new_count += 1 ;
Better comment what each Merge_Operations() call is achieving (#755214) ... before refactoring the code. See the commit message from 2011-10-05 for details of what operations, available at that time, on the same partition can be merged and in what cases: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Bug 755214 - Refactor operation merging
2015-09-14 08:48:43 -06:00
// After deleting all operations for the never applied partition creation,
// try to merge all remaining adjacent operations to catch any which are
// newly adjacent and can now be merged. (Applies to resize/move and
// format operations on real, already existing partitions which are only
// merged when adjacent).
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
merge_operations( MERGE_ALL_ADJACENT );
Merge overlapping operations (#438573) When a new operation is added to operations list, check if a merge is possible depending on the operation type: OPERATION_RESIZE_MOVE: 2 consecutive "resize" operations on the same partition OPERATION_LABEL_PARTITION: 2 "label change" operations (need not be consecutive) on the same partition OPERATION_CHECK: 2 "check" operations (need not be consecutive) on the same partition OPERATION_FORMAT: 2 consecutive "format" operations on the same partition Closes Bug #438573 - Cancel out overlapping actions Also fix a bug when copying partition using the Partition::Set(...) method. This method did not initialize "sectors_used" and "sectors_unused" members.
2011-10-05 12:15:16 -06:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Refresh_Visual();
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
if ( ! operations .size() )
close_operationslist() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
else //deletion of a real partition...
{
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Operation * operation = new OperationDelete( devices[ current_device ], *selected_partition_ptr );
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
operation ->icon = render_icon( Gtk::Stock::DELETE, Gtk::ICON_SIZE_MENU ) ;
Add_Operation( operation ) ;
}
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::activate_info()
Initial revision
2004-09-19 14:24:53 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Dialog_Partition_Info dialog( *selected_partition_ptr );
Added cylsize to Device and made Operation contain a Device instead of * Added cylsize to Device and made Operation contain a Device instead of only the path and lenght. This way i was able to dump Get_Cyl_Size in the Core. Besides that, i used cylsize in WinGparted and made a lot of cosmetic changes. Most of them were pretty useless, but hey, i'm bored ;)
2004-12-27 05:08:01 -07:00
dialog .set_transient_for( *this );
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
dialog .run();
Initial revision
2004-09-19 14:24:53 -06:00
}
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
void Win_GParted::activate_format( GParted::FILESYSTEM new_fs )
Initial revision
2004-09-19 14:24:53 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// VGNAME from mount mount
if ( selected_partition_ptr->filesystem == FS_LVM2_PV && ! selected_partition_ptr->get_mountpoint().empty() )
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
{
if ( ! remove_non_empty_lvm2_pv_dialog( OPERATION_FORMAT ) )
return ;
}
added MIN and MAX to filesystemstruct to set min. and max sizes of a * added MIN and MAX to filesystemstruct to set min. and max sizes of a filesystem. So instead of checking per filesystem i now simply check the fs.MIN or fs.MAX. this results in less and cleaner code. Also this will come in handy when adding support for new filesystems. (This also fixed several minor bugs with filesystemsizes and gained some improvement in resizer performance)
2004-12-09 15:56:33 -07:00
//check for some limits...
activate_convert used old filesystem instead of new one for checks. fixed. * src/Win_GParted.cc: activate_convert used old filesystem instead of new one for checks. fixed.
2005-01-11 14:18:15 -07:00
fs = gparted_core .get_fs( new_fs ) ;
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( ( selected_partition_ptr->get_byte_length() < fs.MIN ) ||
( fs.MAX && selected_partition_ptr->get_byte_length() > fs.MAX ) )
Initial revision
2004-09-19 14:24:53 -06:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Gtk::MessageDialog dialog( *this,
Add translator comments requested in bug #631684
2010-10-12 18:14:30 -06:00
String::ucompose(
/* TO TRANSLATORS: looks like
* Cannot format this file system to fat16.
*/
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
_( "Cannot format this file system to %1" ),
Add translator comments requested in bug #631684
2010-10-12 18:14:30 -06:00
Utils::get_filesystem_string( new_fs ) ) ,
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true );
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->get_byte_length() < fs.MIN )
Add translator comments requested in bug #631684
2010-10-12 18:14:30 -06:00
dialog .set_secondary_text( String::ucompose(
/* TO TRANSLATORS: looks like
* A fat16 file system requires a partition of at least 16.00 MiB.
*/
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
_( "A %1 file system requires a partition of at least %2."),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
Utils::get_filesystem_string( new_fs ),
Replace default sector size with appropriate sector size This change is in preparation for supporting sectors sizes > 512 bytes.
2010-04-26 11:42:23 -06:00
Utils::format_size( fs .MIN, 1 /* Byte */ ) ) );
added MIN and MAX to filesystemstruct to set min. and max sizes of a * added MIN and MAX to filesystemstruct to set min. and max sizes of a filesystem. So instead of checking per filesystem i now simply check the fs.MIN or fs.MAX. this results in less and cleaner code. Also this will come in handy when adding support for new filesystems. (This also fixed several minor bugs with filesystemsizes and gained some improvement in resizer performance)
2004-12-09 15:56:33 -07:00
else
Add translator comments requested in bug #631684
2010-10-12 18:14:30 -06:00
dialog .set_secondary_text( String::ucompose(
/* TO TRANSLATORS: looks like
* A partition with a hfs file system has a maximum size of 2.00 GiB.
*/
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
_( "A partition with a %1 file system has a maximum size of %2."),
trivial cleanups * trivial cleanups
2006-03-28 05:40:29 -07:00
Utils::get_filesystem_string( new_fs ),
Replace default sector size with appropriate sector size This change is in preparation for supporting sectors sizes > 512 bytes.
2010-04-26 11:42:23 -06:00
Utils::format_size( fs .MAX, 1 /* Byte */ ) ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
happy new year ;) fixed some alignment issues removed confirmationdialogs * happy new year ;) * src/TreeView_Detail.cc: fixed some alignment issues * include/GParted_Core.h, src/GParted_Core.cc, include/Operation.h, src/Operation.cc, include/Win_GParted.h, src/Win_GParted.cc: removed confirmationdialogs for delete and convert partitions (#319841). Also renamed 'convert' to 'format' to reflect the actual functionality.
2006-01-02 08:18:29 -07:00
dialog .run() ;
added MIN and MAX to filesystemstruct to set min. and max sizes of a * added MIN and MAX to filesystemstruct to set min. and max sizes of a filesystem. So instead of checking per filesystem i now simply check the fs.MIN or fs.MAX. this results in less and cleaner code. Also this will come in handy when adding support for new filesystems. (This also fixed several minor bugs with filesystemsizes and gained some improvement in resizer performance)
2004-12-09 15:56:33 -07:00
return ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
//ok we made it. lets create an fitting partition object
changed the way devices and partitions store their devicepaths. Instead of * changed the way devices and partitions store their devicepaths. Instead of holding a 'realpath' and a symbolic path we store paths in a list. This allows for improved detection of mountpoins, free space, etc.. Also fixed a nasty bug which showed up when you copy a partition from one device to another. (thanks to mario for the report)
2006-03-14 14:37:47 -07:00
Partition part_temp ;
Add whole_device flag to the partition object (#743181) Need to be able to take different actions in the GParted_Core partition manipulation methods and in Win_GParted UI methods to deal with libparted supported partitions or whole disk devices without a partition table. Add boolean whole_device to the partition object and set appropriately to allow for this. Bug 743181 - Add unpartitioned drive read-write support
2015-01-04 04:29:01 -07:00
part_temp.Set( devices[current_device].get_path(),
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_path(),
selected_partition_ptr->partition_number,
selected_partition_ptr->type,
selected_partition_ptr->whole_device,
Add whole_device flag to the partition object (#743181) Need to be able to take different actions in the GParted_Core partition manipulation methods and in Win_GParted UI methods to deal with libparted supported partitions or whole disk devices without a partition table. Add boolean whole_device to the partition object and set appropriately to allow for this. Bug 743181 - Add unpartitioned drive read-write support
2015-01-04 04:29:01 -07:00
new_fs,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->sector_start,
selected_partition_ptr->sector_end,
Add whole_device flag to the partition object (#743181) Need to be able to take different actions in the GParted_Core partition manipulation methods and in Win_GParted UI methods to deal with libparted supported partitions or whole disk devices without a partition table. Add boolean whole_device to the partition object and set appropriately to allow for this. Bug 743181 - Add unpartitioned drive read-write support
2015-01-04 04:29:01 -07:00
devices[current_device].sector_size,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->inside_extended,
Add whole_device flag to the partition object (#743181) Need to be able to take different actions in the GParted_Core partition manipulation methods and in Win_GParted UI methods to deal with libparted supported partitions or whole disk devices without a partition table. Add boolean whole_device to the partition object and set appropriately to allow for this. Bug 743181 - Add unpartitioned drive read-write support
2015-01-04 04:29:01 -07:00
false );
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
part_temp.name = selected_partition_ptr->name;
Set unallocated space when performing simple operations (#499202) When pasting a copied partition into an existing partition set its space utilisation so that any unallocated space is displayed correctly before the operation is applied. If the destination partition is larger the file system will be grown to fill the partition. NOTE: GParted will attempt to grow the the file system in this situation regardless of whether the file system supports it or not. These file systems: exfat, hfs, hfs+, reiser4 and ufs can't be grown and will fail with "growing is not available for this file system". The preview will also be wrong in this case for the same reason. Everything will be depicted correctly after the refresh. When formatting an existing partition default its space utilisation to unknown for display before the operation is applied. Bug 499202 - gparted does not see the difference if partition size differs from filesystem size
2012-04-11 14:07:52 -06:00
//Leave sector usage figures to new Partition object defaults of
// -1, -1, 0 (_used, _unused, _unallocated) representing unknown.
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Replace open coded merge of format into create operation (#755214) For the case of formatting a new, not yet created partition, activate_format() open coded the merge operation. This code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of formatting an existing partition. Bug 755214 - Refactor operation merging
2015-09-15 15:10:00 -06:00
part_temp .status = GParted::STAT_FORMATTED ;
// When formatting a partition which already exists on the disk all possible
// operations could be pending so only try merging with the previous operation.
MergeType mergetype = MERGE_LAST_WITH_PREV;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// If selected partition is NEW we simply remove the NEW operation from the list and
// add it again with the new file system
if ( selected_partition_ptr->status == STAT_NEW )
Initial revision
2004-09-19 14:24:53 -06:00
{
Replace open coded merge of format into create operation (#755214) For the case of formatting a new, not yet created partition, activate_format() open coded the merge operation. This code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of formatting an existing partition. Bug 755214 - Refactor operation merging
2015-09-15 15:10:00 -06:00
part_temp.status = STAT_NEW;
// On a partition which is pending creation only resize/move and format
// operations are possible. These operations are always mergeable with
// the pending operation which will create the partition. Hence merge
// with any earlier operations to achieve this.
mergetype = MERGE_LAST_WITH_ANY;
Initial revision
2004-09-19 14:24:53 -06:00
}
construct operations in the activate*() functions instead of in * include/Win_GParted.h, src/Win_GParted.cc: construct operations in the activate*() functions instead of in Add_Operation(). This approach allows for more customization of operations.
2006-08-01 14:19:17 -06:00
Replace open coded merge of format into create operation (#755214) For the case of formatting a new, not yet created partition, activate_format() open coded the merge operation. This code has existed in GParted since before version 0.0.5 and the current code history in Git. Replace the necessary code so that an explicit merge_operations() call is used instead; along with the other case of formatting an existing partition. Bug 755214 - Refactor operation merging
2015-09-15 15:10:00 -06:00
Operation * operation = new OperationFormat( devices[current_device],
*selected_partition_ptr,
part_temp );
operation->icon = render_icon( Gtk::Stock::CONVERT, Gtk::ICON_SIZE_MENU );
Add_Operation( operation );
merge_operations( mergetype );
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
void Win_GParted::unmount_partition( bool * succes, Glib::ustring * error )
added visual feedback when unmounting or deactivating swap. This can be * include/Win_GParted.h, src/Win_GParted.cc: added visual feedback when unmounting or deactivating swap. This can be usefull when it takes longer then usual.
2006-01-08 08:20:14 -07:00
{
Add is_dev_mounted() to expose core partition is mounted test (#723842) Add static member function GParted_Core::is_dev_mounted() so that other modules can determine if a particular partition contains a mounted file system or not. Make it a static member function so that it can be called without needing the gparted_core object. Extend to make the group of manipulated variables (mount_info, fstab_info) and manipulating functions (init_maps(), read_mountpoints_from_file(), read_mountpoints_from_file_swaps(), get_all_mountpoints()) static too. Bug #723842 - GParted resizes the wrong filesystem (does not pass the devid to btrfs filesystem resize)
2014-02-16 06:29:33 -07:00
std::vector<Glib::ustring> errors, failed_mountpoints, mountpoints = GParted_Core::get_all_mountpoints() ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Glib::ustring dummy ;
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
*succes = true ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
for ( unsigned int t = 0 ; t < selected_partition_ptr->get_mountpoints().size() ; t++ )
if ( std::count( mountpoints.begin(),
mountpoints.end(),
selected_partition_ptr->get_mountpoints()[t] ) <= 1 )
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
{
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Glib::ustring cmd = "umount -v \"" + selected_partition_ptr->get_mountpoints()[t] + "\"";
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
if ( Utils::execute_command( cmd, dummy, *error ) )
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
{
*succes = false ;
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
errors.push_back( "# " + cmd + "\n" + *error );
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
}
}
else
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
failed_mountpoints.push_back( selected_partition_ptr->get_mountpoints()[t] );
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
if ( *succes && failed_mountpoints .size() )
{
*succes = false ;
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
*error = _("The partition could not be unmounted from the following mount points:") ;
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
*error += "\n\n<i>" + Glib::build_path( "\n", failed_mountpoints ) + "</i>\n\n" ;
Fixed incorrect spelling of filesystem and mountpoint svn path=/trunk/; revision=970
2008-11-18 16:58:17 -07:00
*error += _("Most likely other partitions are also mounted on these mount points. You are advised to unmount them manually.") ;
deal with the rare situation when 2 partitions are mounted on the same * include/GParted_Core.h, src/GParted_Core.cc, src/Win_GParted.cc: deal with the rare situation when 2 partitions are mounted on the same mountpoint. (see also #330327)
2006-02-20 07:41:05 -07:00
}
else
*error = "<i>" + Glib::build_path( "\n", errors ) + "</i>" ;
added visual feedback when unmounting or deactivating swap. This can be * include/Win_GParted.h, src/Win_GParted.cc: added visual feedback when unmounting or deactivating swap. This can be usefull when it takes longer then usual.
2006-01-08 08:20:14 -07:00
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Rename *toggle_swap_mount* -> *toggle_busy* Rename functions and a variable to use a generic term for the menu item which changes the busy state of partitions now that it also activates and deactivates LVM2 Physical Volumes as well as mounting and unmounting file systems and enables and disables swap partitions.
2012-06-17 05:26:49 -06:00
void Win_GParted::toggle_busy_state()
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
int operation_count = partition_in_operation_queue_count( *selected_partition_ptr );
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
bool success = false ;
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
Glib::ustring cmd;
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
Glib::ustring output;
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
Glib::ustring error;
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
if ( operation_count > 0 )
{
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
//Note that this situation will only occur when trying to swapon a partition
// or activate the Volume Group of a Physical Volume. This is because
// GParted does not permit queueing operations on partitions that are
// currently active (i.e., swap enabled, mounted or active VG). Hence
// this situation will not occur for the swapoff, unmount or deactivate VG
// actions that this method handles.
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
/*TO TRANSLATORS: Singular case looks like 1 operation is currently pending for partition /dev/sdd8. */
Glib::ustring tmp_msg =
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
String::ucompose( ngettext( "%1 operation is currently pending for partition %2"
, "%1 operations are currently pending for partition %2"
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
, operation_count
)
, operation_count
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
, selected_partition_ptr->get_path()
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
) ;
Gtk::MessageDialog dialog( *this
, tmp_msg
, false
, Gtk::MESSAGE_INFO
, Gtk::BUTTONS_OK
, true
) ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->filesystem == FS_LINUX_SWAP )
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
{
tmp_msg = _( "The swapon action cannot be performed if an operation is pending for the partition." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "Use the Edit menu to undo, clear, or apply operations before using swapon with this partition." ) ;
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
else if ( selected_partition_ptr->filesystem == FS_LVM2_PV )
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
{
tmp_msg = _( "The activate Volume Group action cannot be performed if an operation is pending for the partition." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "Use the Edit menu to undo, clear, or apply operations before using activate Volume Group with this partition." ) ;
}
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
return ;
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( selected_partition_ptr->filesystem == FS_LINUX_SWAP )
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
show_pulsebar(
String::ucompose(
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->busy ? _("Deactivating swap on %1") : _("Activating swap on %1"),
selected_partition_ptr->get_path() ) );
if ( selected_partition_ptr->busy )
cmd = "swapoff -v " + selected_partition_ptr->get_path();
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
else
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
cmd = "swapon -v " + selected_partition_ptr->get_path();
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
success = ! Utils::execute_command( cmd, output, error );
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
hide_pulsebar();
if ( ! success )
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Gtk::MessageDialog dialog(
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
*this,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->busy ? _("Could not deactivate swap") : _("Could not activate swap"),
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true ) ;
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
dialog.set_secondary_text( "# " + cmd + "\n" + error );
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
dialog.run() ;
}
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
else if ( selected_partition_ptr->filesystem == FS_LVM2_PV )
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
{
show_pulsebar(
String::ucompose(
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->busy ? _("Deactivating Volume Group %1")
: _("Activating Volume Group %1"),
// VGNAME from mount point
selected_partition_ptr->get_mountpoint() ) );
if ( selected_partition_ptr->busy )
// VGNAME from mount point
cmd = "lvm vgchange -a n " + selected_partition_ptr->get_mountpoint();
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
else
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
cmd = "lvm vgchange -a y " + selected_partition_ptr->get_mountpoint();
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
success = ! Utils::execute_command( cmd, output, error );
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
hide_pulsebar();
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
if ( ! success )
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
{
Gtk::MessageDialog dialog(
*this,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->busy ? _("Could not deactivate Volume Group")
: _("Could not activate Volume Group"),
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true ) ;
Display failing activate/deactivate commands in error dialogs As was done with a failed mount operation, include the failed activate/ deactivate command in the error dialog. Two example error dialogs now look like this: (-) Could not deactivate swap # swapoff -v /dev/sdb7 swapoff: /dev/sdb7: swapoff failed: Invalid argument [ OK ] (-) Could not unmount /dev/sdb6 # umount -v "/mnt/6" umount: /mnt/6: not mounted [ OK ]
2015-01-11 05:49:52 -07:00
dialog.set_secondary_text( "# " + cmd + "\n" + error );
Enable LVM2 VG activation / deactivation (#670171) In the Partition menu enable activation / deactivation of the LVM2 Volume Group of which the Physical Volume is a member. Bug #670171 - Add LVM PV read-write support
2012-02-13 05:44:45 -07:00
dialog.run() ;
}
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
else if ( selected_partition_ptr->busy )
removed separator in accordance to the HIG it's now possible to deactivate * src/Dialog_Partition_Info.cc: removed separator in accordance to the HIG * include/Win_GParted.h, src/Win_GParted.cc: it's now possible to deactivate swap from within gparted. * src/GParted_Core.cc: sleep one second after deletion of a partition to give the kernel some time to reread the partitiontable.
2006-01-07 14:23:09 -07:00
{
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
show_pulsebar( String::ucompose( _("Unmounting %1"), selected_partition_ptr->get_path() ) );
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
unmount_partition( &success, &error );
hide_pulsebar();
if ( ! success )
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Gtk::MessageDialog dialog( *this,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
String::ucompose( _("Could not unmount %1"),
selected_partition_ptr->get_path() ),
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true );
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
dialog .set_secondary_text( error, true ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
dialog.run() ;
}
removed separator in accordance to the HIG it's now possible to deactivate * src/Dialog_Partition_Info.cc: removed separator in accordance to the HIG * include/Win_GParted.h, src/Win_GParted.cc: it's now possible to deactivate swap from within gparted. * src/GParted_Core.cc: sleep one second after deletion of a partition to give the kernel some time to reread the partitiontable.
2006-01-07 14:23:09 -07:00
}
added basic support for mounting unmounted partitions on mountpoints found * include/Win_GParted.h, src/Win_GParted.cc: added basic support for mounting unmounted partitions on mountpoints found in /etc/fstab
2006-03-09 12:37:50 -07:00
removed separator in accordance to the HIG it's now possible to deactivate * src/Dialog_Partition_Info.cc: removed separator in accordance to the HIG * include/Win_GParted.h, src/Win_GParted.cc: it's now possible to deactivate swap from within gparted. * src/GParted_Core.cc: sleep one second after deletion of a partition to give the kernel some time to reread the partitiontable.
2006-01-07 14:23:09 -07:00
menu_gparted_refresh_devices() ;
added umount option. Also include unistd.h to solve some issues with gcc * include/Win_GParted.h, src/Win_GParted.cc: added umount option. Also include unistd.h to solve some issues with gcc 3.2.x
2004-11-06 12:48:24 -07:00
}
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::activate_mount_partition( unsigned int index )
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
int operation_count = partition_in_operation_queue_count( *selected_partition_ptr );
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
if ( operation_count > 0 )
{
/*TO TRANSLATORS: Plural case looks like 4 operations are currently pending for partition /dev/sdd8. */
Glib::ustring tmp_msg =
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
String::ucompose( ngettext( "%1 operation is currently pending for partition %2"
, "%1 operations are currently pending for partition %2"
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
, operation_count
)
, operation_count
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
, selected_partition_ptr->get_path()
Prevent swapon and mount if partition in operation queue (#611431)
2010-08-09 13:37:08 -06:00
) ;
Gtk::MessageDialog dialog( *this
, tmp_msg
, false
, Gtk::MESSAGE_INFO
, Gtk::BUTTONS_OK
, true
) ;
tmp_msg = _( "The mount action cannot be performed if an operation is pending for the partition." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "Use the Edit menu to undo, clear, or apply operations before using mount with this partition." ) ;
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
return ;
}
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
bool success = false ;
Include failing mount command in the error dialog (#742741) On RHEL/CentOS 6 GParted fails to mount nilfs2 file system. Include the failing file system mount command in the error dialog so the user knows what command failed. The error dialog now looks like: (-) Could not mount /dev/sdc1 on /mnt/1 # mount -v /dev/sdc1 "/mnt/1" mount: you must specify the filesystem type [ OK ] Also stop telling the dialog that the secondary text contains pango markup as the command line and error message certainly isn't pango markup text. Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-10 09:00:11 -07:00
Glib::ustring cmd;
Glib::ustring output;
Glib::ustring error;
Second, try mounting file systems specifying the type (#742741) On RHEL/CentOS 6, GParted fails to mount nilfs2 file system like this: # mkfs.nilfs2 /dev/sdb1 # mount /dev/sdb1 /mnt/1 mount: you must specify the filesystem type This fails because mount internally uses libblkid to determine the file system type when it is not specified on the command line. However on RHEL/CentOS 6 libblkid is too old to recognise nilfs2. GParted used libparted recognition first and blkid second. Mount only uses libblkid. When there are multiple signatures on a partition GParted may report a different result to blkid alone. Therefore fix by first trying to mount the file system without specifying the type, as is already done, and if that fails, trying specifying the file system type. This allows GParted to mount nilfs2 file systems. # mount -t nilfs2 /dev/sdb1 /mnt/1 # mount | fgrep sdb1 /dev/sdb1 on /mnt/1 type nilfs2 (rw,gcpid=30946) And for unsupported file systems the error dialog from the failed mount command shows both commands like this: (-) Could not mount /dev/sdb3 on /mnt/3 # mount -v /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' # mount -v -t reiser4 /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' [ OK ] Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-11 03:14:47 -07:00
Glib::ustring message;
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
show_pulsebar( String::ucompose( _("mounting %1 on %2"),
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_path(),
selected_partition_ptr->get_mountpoints()[index] ) );
Second, try mounting file systems specifying the type (#742741) On RHEL/CentOS 6, GParted fails to mount nilfs2 file system like this: # mkfs.nilfs2 /dev/sdb1 # mount /dev/sdb1 /mnt/1 mount: you must specify the filesystem type This fails because mount internally uses libblkid to determine the file system type when it is not specified on the command line. However on RHEL/CentOS 6 libblkid is too old to recognise nilfs2. GParted used libparted recognition first and blkid second. Mount only uses libblkid. When there are multiple signatures on a partition GParted may report a different result to blkid alone. Therefore fix by first trying to mount the file system without specifying the type, as is already done, and if that fails, trying specifying the file system type. This allows GParted to mount nilfs2 file systems. # mount -t nilfs2 /dev/sdb1 /mnt/1 # mount | fgrep sdb1 /dev/sdb1 on /mnt/1 type nilfs2 (rw,gcpid=30946) And for unsupported file systems the error dialog from the failed mount command shows both commands like this: (-) Could not mount /dev/sdb3 on /mnt/3 # mount -v /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' # mount -v -t reiser4 /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' [ OK ] Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-11 03:14:47 -07:00
// First try mounting letting mount (libblkid) determine the file system type.
// Do this because GParted uses libparted first and blkid second and when there
// are multiple signatures GParted may report a different result to blkid alone.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
cmd = "mount -v " + selected_partition_ptr->get_path() +
" \"" + selected_partition_ptr->get_mountpoints()[index] + "\"";
Include failing mount command in the error dialog (#742741) On RHEL/CentOS 6 GParted fails to mount nilfs2 file system. Include the failing file system mount command in the error dialog so the user knows what command failed. The error dialog now looks like: (-) Could not mount /dev/sdc1 on /mnt/1 # mount -v /dev/sdc1 "/mnt/1" mount: you must specify the filesystem type [ OK ] Also stop telling the dialog that the secondary text contains pango markup as the command line and error message certainly isn't pango markup text. Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-10 09:00:11 -07:00
success = ! Utils::execute_command( cmd, output, error );
Second, try mounting file systems specifying the type (#742741) On RHEL/CentOS 6, GParted fails to mount nilfs2 file system like this: # mkfs.nilfs2 /dev/sdb1 # mount /dev/sdb1 /mnt/1 mount: you must specify the filesystem type This fails because mount internally uses libblkid to determine the file system type when it is not specified on the command line. However on RHEL/CentOS 6 libblkid is too old to recognise nilfs2. GParted used libparted recognition first and blkid second. Mount only uses libblkid. When there are multiple signatures on a partition GParted may report a different result to blkid alone. Therefore fix by first trying to mount the file system without specifying the type, as is already done, and if that fails, trying specifying the file system type. This allows GParted to mount nilfs2 file systems. # mount -t nilfs2 /dev/sdb1 /mnt/1 # mount | fgrep sdb1 /dev/sdb1 on /mnt/1 type nilfs2 (rw,gcpid=30946) And for unsupported file systems the error dialog from the failed mount command shows both commands like this: (-) Could not mount /dev/sdb3 on /mnt/3 # mount -v /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' # mount -v -t reiser4 /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' [ OK ] Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-11 03:14:47 -07:00
if ( ! success )
{
message = "# " + cmd + "\n" + error;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Glib::ustring type = Utils::get_filesystem_kernel_name( selected_partition_ptr->filesystem );
Second, try mounting file systems specifying the type (#742741) On RHEL/CentOS 6, GParted fails to mount nilfs2 file system like this: # mkfs.nilfs2 /dev/sdb1 # mount /dev/sdb1 /mnt/1 mount: you must specify the filesystem type This fails because mount internally uses libblkid to determine the file system type when it is not specified on the command line. However on RHEL/CentOS 6 libblkid is too old to recognise nilfs2. GParted used libparted recognition first and blkid second. Mount only uses libblkid. When there are multiple signatures on a partition GParted may report a different result to blkid alone. Therefore fix by first trying to mount the file system without specifying the type, as is already done, and if that fails, trying specifying the file system type. This allows GParted to mount nilfs2 file systems. # mount -t nilfs2 /dev/sdb1 /mnt/1 # mount | fgrep sdb1 /dev/sdb1 on /mnt/1 type nilfs2 (rw,gcpid=30946) And for unsupported file systems the error dialog from the failed mount command shows both commands like this: (-) Could not mount /dev/sdb3 on /mnt/3 # mount -v /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' # mount -v -t reiser4 /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' [ OK ] Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-11 03:14:47 -07:00
if ( ! type.empty() )
{
// Second try mounting specifying the GParted determined file
// system type.
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
cmd = "mount -v -t " + type + " " + selected_partition_ptr->get_path() +
" \"" + selected_partition_ptr->get_mountpoints()[index] + "\"";
Second, try mounting file systems specifying the type (#742741) On RHEL/CentOS 6, GParted fails to mount nilfs2 file system like this: # mkfs.nilfs2 /dev/sdb1 # mount /dev/sdb1 /mnt/1 mount: you must specify the filesystem type This fails because mount internally uses libblkid to determine the file system type when it is not specified on the command line. However on RHEL/CentOS 6 libblkid is too old to recognise nilfs2. GParted used libparted recognition first and blkid second. Mount only uses libblkid. When there are multiple signatures on a partition GParted may report a different result to blkid alone. Therefore fix by first trying to mount the file system without specifying the type, as is already done, and if that fails, trying specifying the file system type. This allows GParted to mount nilfs2 file systems. # mount -t nilfs2 /dev/sdb1 /mnt/1 # mount | fgrep sdb1 /dev/sdb1 on /mnt/1 type nilfs2 (rw,gcpid=30946) And for unsupported file systems the error dialog from the failed mount command shows both commands like this: (-) Could not mount /dev/sdb3 on /mnt/3 # mount -v /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' # mount -v -t reiser4 /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' [ OK ] Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-11 03:14:47 -07:00
success = ! Utils::execute_command( cmd, output, error );
if ( ! success )
message += "\n# " + cmd + "\n" + error;
}
}
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
hide_pulsebar();
if ( ! success )
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
{
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Gtk::MessageDialog dialog( *this,
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
String::ucompose( _("Could not mount %1 on %2"),
selected_partition_ptr->get_path(),
selected_partition_ptr->get_mountpoints()[index] ),
false,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true );
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
Second, try mounting file systems specifying the type (#742741) On RHEL/CentOS 6, GParted fails to mount nilfs2 file system like this: # mkfs.nilfs2 /dev/sdb1 # mount /dev/sdb1 /mnt/1 mount: you must specify the filesystem type This fails because mount internally uses libblkid to determine the file system type when it is not specified on the command line. However on RHEL/CentOS 6 libblkid is too old to recognise nilfs2. GParted used libparted recognition first and blkid second. Mount only uses libblkid. When there are multiple signatures on a partition GParted may report a different result to blkid alone. Therefore fix by first trying to mount the file system without specifying the type, as is already done, and if that fails, trying specifying the file system type. This allows GParted to mount nilfs2 file systems. # mount -t nilfs2 /dev/sdb1 /mnt/1 # mount | fgrep sdb1 /dev/sdb1 on /mnt/1 type nilfs2 (rw,gcpid=30946) And for unsupported file systems the error dialog from the failed mount command shows both commands like this: (-) Could not mount /dev/sdb3 on /mnt/3 # mount -v /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' # mount -v -t reiser4 /dev/sdb3 "/mnt/3" mount: unknown filesystem type 'reiser4' [ OK ] Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-11 03:14:47 -07:00
dialog.set_secondary_text( message );
Include failing mount command in the error dialog (#742741) On RHEL/CentOS 6 GParted fails to mount nilfs2 file system. Include the failing file system mount command in the error dialog so the user knows what command failed. The error dialog now looks like: (-) Could not mount /dev/sdc1 on /mnt/1 # mount -v /dev/sdc1 "/mnt/1" mount: you must specify the filesystem type [ OK ] Also stop telling the dialog that the secondary text contains pango markup as the command line and error message certainly isn't pango markup text. Bug 742741 - Nilfs2 file system is unusable on RHEL/CentOS 6
2015-01-10 09:00:11 -07:00
added submenu with mountpoints to 'mount' in partitionmenu. (see also * include/Win_GParted.h, src/Win_GParted.cc: added submenu with mountpoints to 'mount' in partitionmenu. (see also #330327)
2006-03-16 10:09:17 -07:00
dialog.run() ;
}
menu_gparted_refresh_devices() ;
}
added umount option. Also include unistd.h to solve some issues with gcc * include/Win_GParted.h, src/Win_GParted.cc: added umount option. Also include unistd.h to solve some issues with gcc 3.2.x
2004-11-06 12:48:24 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::activate_disklabel()
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
{
Prevent partition table creation if partitions are active Prevent creating new partition tables on devices that have mounted file systems, or enabled swap space. Closes Ubuntu launchpad bug #503125 - gparted allows user to overwrite active mounted partition https://bugs.launchpad.net/ubuntu/+source/gparted/+bug/503125
2010-08-10 12:59:26 -06:00
//If there are active mounted partitions on the device then warn
// the user that all partitions must be unactive before creating
// a new partition table
int active_count = active_partitions_on_device_count( devices[ current_device ] ) ;
if ( active_count > 0 )
{
Glib::ustring tmp_msg =
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
String::ucompose( /*TO TRANSLATORS: Singular case looks like 1 partition is currently active on device /dev/sda */
ngettext( "%1 partition is currently active on device %2"
/*TO TRANSLATORS: Plural case looks like 3 partitions are currently active on device /dev/sda */
, "%1 partitions are currently active on device %2"
Prevent partition table creation if partitions are active Prevent creating new partition tables on devices that have mounted file systems, or enabled swap space. Closes Ubuntu launchpad bug #503125 - gparted allows user to overwrite active mounted partition https://bugs.launchpad.net/ubuntu/+source/gparted/+bug/503125
2010-08-10 12:59:26 -06:00
, active_count
)
, active_count
, devices[ current_device ] .get_path()
) ;
Gtk::MessageDialog dialog( *this
, tmp_msg
, false
, Gtk::MESSAGE_INFO
, Gtk::BUTTONS_OK
, true
) ;
tmp_msg = _( "A new partition table cannot be created when there are active partitions." ) ;
tmp_msg += " " ;
tmp_msg += _( "Active partitions are those that are in use, such as a mounted file system, or enabled swap space." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "Use Partition menu options, such as unmount or swapoff, to deactivate all partitions on this device before creating a new partition table." ) ;
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
return ;
}
Ensure no pending operations before creating partition table (#583896) This fixes a situation where GParted would crash if a user queued up some operations, created a new partition table, and then applied the operations.
2009-10-25 14:33:36 -06:00
//If there are pending operations then warn the user that these
// operations must either be applied or cleared before creating
// a new partition table.
if ( operations .size() )
{
Glib::ustring tmp_msg =
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
String::ucompose( ngettext( "%1 operation is currently pending"
, "%1 operations are currently pending"
Ensure no pending operations before creating partition table (#583896) This fixes a situation where GParted would crash if a user queued up some operations, created a new partition table, and then applied the operations.
2009-10-25 14:33:36 -06:00
, operations .size()
)
, operations .size()
) ;
Gtk::MessageDialog dialog( *this
, tmp_msg
, false
, Gtk::MESSAGE_INFO
, Gtk::BUTTONS_OK
, true
) ;
tmp_msg = _( "A new partition table cannot be created when there are pending operations." ) ;
tmp_msg += "\n" ;
tmp_msg += _( "Use the Edit menu to either clear or apply all operations before creating a new partition table." ) ;
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
return ;
}
//Display dialog for creating a new partition table.
Display partition table types in order (#711098) In the Create Partition Table dialog display the entries in the combobox in order. Previously the default of MSDOS or GPT was moved to the first item in the combobox. Now the partition table types remain in order with just either MSDOS or GPT being selected as as the default as required. The partition table types are displayed in the order supplied by libparted, which is alphabetic except with "loop" last. Bug #711098 - Default partition table can not handle > 2 TiB disks
2014-01-03 13:56:57 -07:00
Dialog_Disklabel dialog( devices[ current_device ] ) ;
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
dialog .set_transient_for( *this );
Change button create to apply for partition table creation (#576374) To further minimize the chance of accidentally creating a new partition table, the following steps have been taken: 1) Rename non-standard Create button to stock Apply button. 2) Remove extra warning about erasing entire disk device. 3) Update GParted Manual accordingly. Closes GParted bug #576374
2009-07-06 15:58:08 -06:00
if ( dialog .run() == Gtk::RESPONSE_APPLY )
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
{
Erase file system signatures before creating a partition table (#743181) When writing "loop" partition table over the top of some whole disk device file system types GParted continued to show those whole disk device file systems rather than the virtual unknown partition from the "loop" partition table. This affected btrfs, jfs, reiser4 and reiserfs. It occurred because of several factors: 1) Libparted only zeroed the first and last 9.5 KiB (assuming 512 byte sectors) of the device before writing a new partition table. See ped_disk_clobber(). 2) These file systems have their super blocks and therefore signatures after the first 9.5 KiB. 3) Whole disk device file system detection is performed using blkid before checking for a libparted "loop" partition table. See GParted_Core::set_devices_thread(). Ref: libparted 3.2: disk.c:ped_disk_clobber() http://git.savannah.gnu.org/cgit/parted.git/tree/libparted/disk.c?id=v3.2#n302 Fix by always erasing any possible file system signatures on the device before creating a new "loop" partition table. NOTE: This is typically taking up to 0.5 seconds in my testing on a 5400 RPM hard drive, during which time the GParted UI is hung and the create partition table dialog shows the apply button pressed but no other progress indication. Bug 743181 - Add unpartitioned drive read-write support
2015-02-14 13:49:45 -07:00
if ( ! gparted_core.set_disklabel( devices[current_device], dialog.Get_Disklabel() ) )
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
{
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Gtk::MessageDialog dialog( *this,
Remove full stops from the end of primary text in dialogs The GNOME HIG, 3.4.1 "Alert Text" states: ... The primary text is punctuated in 'newspaper headline' style, that is, it has no terminating period, but it may have a terminating question mark. http://developer.gnome.org/hig-book/3.0/windows-alert.html.en#alert-text
2012-07-27 05:05:49 -06:00
_("Error while creating partition table"),
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
true,
Gtk::MESSAGE_ERROR,
Gtk::BUTTONS_OK,
true ) ;
dialog .run() ;
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
}
hide dialogs after setting new disklabel * src/Win_GParted.cc: hide dialogs after setting new disklabel
2006-04-15 06:42:57 -06:00
dialog .hide() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
menu_gparted_refresh_devices() ;
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
}
}
Added support to lost data recovery using gpart
2011-01-28 11:09:21 -07:00
//Runs when the Device->Attempt Rescue Data is clicked
void Win_GParted::activate_attempt_rescue_data()
{
if(Glib::find_program_in_path( "gpart" ) .empty()) //Gpart must be installed to continue
{
Gtk::MessageDialog errorDialog(*this, "", true, Gtk::MESSAGE_ERROR, Gtk::BUTTONS_OK, true);
errorDialog.set_message(_("Command gpart was not found"));
errorDialog.set_secondary_text(_("This feature uses gpart. Please install gpart and try again."));
errorDialog.run();
return;
}
//Dialog information
Glib::ustring sec_text = _( "A full disk scan is needed to find file systems." ) ;
sec_text += "\n" ;
sec_text +=_("The scan might take a very long time.");
sec_text += "\n" ;
sec_text += _("After the scan you can mount any discovered file systems and copy the data to other media.") ;
sec_text += "\n" ;
sec_text += _("Do you want to continue?");
Gtk::MessageDialog messageDialog(*this, "", true, Gtk::MESSAGE_WARNING, Gtk::BUTTONS_OK_CANCEL, true);
/*TO TRANSLATORS: looks like Search for file systems on /deb/sdb */
messageDialog.set_message(String::ucompose(_("Search for file systems on %1"), devices[ current_device ] .get_path()));
messageDialog.set_secondary_text(sec_text);
if(messageDialog.run()!=Gtk::RESPONSE_OK)
{
return;
}
messageDialog.hide();
/*TO TRANSLATORS: looks like Searching for file systems on /deb/sdb */
show_pulsebar(String::ucompose( _("Searching for file systems on %1"), devices[ current_device ] .get_path()));
Reduce threading (#685740) Win_Gparted and Dialog_Progress were creating threads to perform most functions in the background. Most of the time, the only reason the threads blocked was to execute an external command. The external command execution has been changed to spawn the command asynchronously and wait for completion with a nested main loop. While waiting for completion, the pipe output is captured via events. In the future, this will allow for it to be parsed in real time to obtain progress information. Those tasks in GParted_Core that still block now spawn a background thread and wait for it to complete with a nested main loop to avoid hanging the gui. Part of Bug #685740 - Refactor to use asynchronous command execution
2013-02-21 17:57:33 -07:00
gpart_output="";
gparted_core.guess_partition_table(devices[ current_device ], gpart_output);
hide_pulsebar();
Added support to lost data recovery using gpart
2011-01-28 11:09:21 -07:00
Dialog_Rescue_Data dialog;
dialog .set_transient_for( *this );
//Reads the output of gpart
dialog.init_partitions(&devices[ current_device ], this->gpart_output);
Stop returning vector of partitions from Dialog_Rescue_Data class (#759726) get_partitions() method was returning a vector of partitions. However the calling code only needed to know whether any partitions were found or not. Replace with found_partitions() method reporting the needed boolean. Now use of std::vector<Partition> partitions is hidden within the Dialog_Rescue_Data class implementation. Bug 759726 - Implement Partition object polymorphism
2015-11-22 08:33:24 -07:00
if ( ! dialog.found_partitions() )
Added support to lost data recovery using gpart
2011-01-28 11:09:21 -07:00
{
//Dialog information
Gtk::MessageDialog errorDialog(*this, "", true, Gtk::MESSAGE_ERROR, Gtk::BUTTONS_OK, true);
/*TO TRANSLATORS: looks like No file systems found on /deb/sdb */
errorDialog.set_message(String::ucompose(_("No file systems found on %1"), devices[ current_device ] .get_path()));
errorDialog.set_secondary_text(_("The disk scan by gpart did not find any recognizable file systems on this disk."));
errorDialog.run();
return;
}
dialog.run();
dialog.hide();
Glib::ustring commandUmount= "umount /tmp/gparted-roview*";
Utils::execute_command(commandUmount);
menu_gparted_refresh_devices() ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::activate_manage_flags()
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
improved behaviour of flagmanagementdialog. * include/DialogManageFlags.h, src/DialogManageFlags.cc, src/Win_GParted.cc: improved behaviour of flagmanagementdialog.
2006-04-02 05:18:34 -06:00
get_window() ->set_cursor( Gdk::Cursor( Gdk::WATCH ) ) ;
while ( Gtk::Main::events_pending() )
Gtk::Main::iteration() ;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
DialogManageFlags dialog( *selected_partition_ptr, gparted_core.get_available_flags( *selected_partition_ptr ) );
improved behaviour of flagmanagementdialog. * include/DialogManageFlags.h, src/DialogManageFlags.cc, src/Win_GParted.cc: improved behaviour of flagmanagementdialog.
2006-04-02 05:18:34 -06:00
dialog .set_transient_for( *this ) ;
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
dialog .signal_get_flags .connect(
sigc::mem_fun( &gparted_core, &GParted_Core::get_available_flags ) ) ;
dialog .signal_toggle_flag .connect(
sigc::mem_fun( &gparted_core, &GParted_Core::toggle_flag ) ) ;
improved behaviour of flagmanagementdialog. * include/DialogManageFlags.h, src/DialogManageFlags.cc, src/Win_GParted.cc: improved behaviour of flagmanagementdialog.
2006-04-02 05:18:34 -06:00
get_window() ->set_cursor() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
dialog .run() ;
dialog .hide() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
add 'flag management' (#330453) * include/DialogManageFlags.h, include/GParted_Core.h, include/Makefile.am, include/Utils.h, include/Win_GParted.h, src/DialogManageFlags.cc, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc: add 'flag management' (#330453)
2006-03-31 03:49:27 -07:00
if ( dialog .any_change )
menu_gparted_refresh_devices() ;
}
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::activate_check()
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Operation * operation = new OperationCheck( devices[current_device], *selected_partition_ptr );
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
operation ->icon = render_icon( Gtk::Stock::EXECUTE, Gtk::ICON_SIZE_MENU );
Add_Operation( operation ) ;
Better comment what each Merge_Operations() call is achieving (#755214) ... before refactoring the code. See the commit message from 2011-10-05 for details of what operations, available at that time, on the same partition can be merged and in what cases: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Bug 755214 - Refactor operation merging
2015-09-14 08:48:43 -06:00
// Try to merge this check operation with all previous operations.
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
merge_operations( MERGE_LAST_WITH_ANY );
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
}
Replaced menu "Operations" with "Device" and "Partition". Also implemented * include/Win_GParted.h, src/Win_GParted.cc: Replaced menu "Operations" with "Device" and "Partition". Also implemented a 'set-disklabel feature'. * src/Dialog_Disklabel.cc: changed title and header to be more generic (was specific for a new disk).
2005-01-30 07:31:29 -07:00
Rename methods in GParted_Core and Win_GParted classes (#741424) class GParted_Core: label_partition() -> label_filesystem() class Win_GParted: allow_label_partition() -> allow_label_filesystem() activate_label_partition() -> activate_label_filesystem() Bug 741424 - Add support for GPT partition names
2014-12-18 15:18:33 -07:00
void Win_GParted::activate_label_filesystem()
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Dialog_FileSystem_Label dialog( *selected_partition_ptr );
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
dialog .set_transient_for( *this );
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( dialog .run() == Gtk::RESPONSE_OK
&& dialog.get_new_label() != selected_partition_ptr->get_filesystem_label() )
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
{
dialog .hide() ;
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Make a duplicate of the selected partition (used in UNDO)
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
Partition * part_temp = selected_partition_ptr->clone();
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
part_temp->set_filesystem_label( dialog.get_new_label() );
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
Rename class to OperationLabelFileSystem (#741424) class OperationLabelPartition -> OperationLabelFileSystem file OperationLabelPartition.h -> OperationLabelFileSystem.h file OperationLabelPartition.cc -> OperationLabelFileSystem.cc Bug 741424 - Add support for GPT partition names
2014-12-19 13:41:08 -07:00
Operation * operation = new OperationLabelFileSystem( devices[current_device],
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
*selected_partition_ptr, *part_temp );
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
operation ->icon = render_icon( Gtk::Stock::EXECUTE, Gtk::ICON_SIZE_MENU );
Merge overlapping operations (#438573) When a new operation is added to operations list, check if a merge is possible depending on the operation type: OPERATION_RESIZE_MOVE: 2 consecutive "resize" operations on the same partition OPERATION_LABEL_PARTITION: 2 "label change" operations (need not be consecutive) on the same partition OPERATION_CHECK: 2 "check" operations (need not be consecutive) on the same partition OPERATION_FORMAT: 2 consecutive "format" operations on the same partition Closes Bug #438573 - Cancel out overlapping actions Also fix a bug when copying partition using the Partition::Set(...) method. This method did not initialize "sectors_used" and "sectors_unused" members.
2011-10-05 12:15:16 -06:00
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
delete part_temp;
part_temp = NULL;
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
Add_Operation( operation ) ;
Better comment what each Merge_Operations() call is achieving (#755214) ... before refactoring the code. See the commit message from 2011-10-05 for details of what operations, available at that time, on the same partition can be merged and in what cases: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Bug 755214 - Refactor operation merging
2015-09-14 08:48:43 -06:00
// Try to merge this label file system operation with all previous
// operations.
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
merge_operations( MERGE_LAST_WITH_ANY );
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
gparted-0.3.6 - code recreation from Source Forge svn path=/trunk/; revision=810
2008-04-07 13:41:18 -06:00
}
}
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
void Win_GParted::activate_name_partition()
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Dialog_Partition_Name dialog( *selected_partition_ptr,
Make support of naming for other partition table types possible (#746214) Previously partition naming had only been implemented for gpt. Make the code ready to support naming of the other partition table types for which libparted supports naming. Specifically: amiga, dvh, mac and pc98 in addition to gpt. Document issues found with some of these partition table types, which can relatively easily been worked around. Leave support of naming for partition table types other than gpt disabled, mostly just to reduce ongoing testing effort, at least until there is any user demand for it. Bug 746214 - Partition naming enhancements
2015-03-13 16:36:08 -06:00
devices[current_device].get_max_partition_name_length() );
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
dialog.set_transient_for( *this );
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
if ( dialog.run() == Gtk::RESPONSE_OK
&& dialog.get_new_name() != selected_partition_ptr->name )
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
{
dialog.hide();
// Make a duplicate of the selected partition (used in UNDO)
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
Partition * part_temp = selected_partition_ptr->clone();
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
part_temp->name = dialog.get_new_name();
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
Operation * operation = new OperationNamePartition( devices[current_device],
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
*selected_partition_ptr, *part_temp );
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
operation->icon = render_icon( Gtk::Stock::EXECUTE, Gtk::ICON_SIZE_MENU );
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
delete part_temp;
part_temp = NULL;
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
Add_Operation( operation );
Better comment what each Merge_Operations() call is achieving (#755214) ... before refactoring the code. See the commit message from 2011-10-05 for details of what operations, available at that time, on the same partition can be merged and in what cases: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Bug 755214 - Refactor operation merging
2015-09-14 08:48:43 -06:00
// Try to merge this name partition operation with all previous
// operations.
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
merge_operations( MERGE_LAST_WITH_ANY );
Add support for GPT partition names (#741424) Embedded devices (Android) use GPT partition names to identify partitions, instead of file system labels. Add support for viewing and changing them. As partition names are used to provide unique identification they are never copied when copying the contents of one partition to another. Note that GNU/Linux uses file system labels, UUIDs or device names for identification during the boot process and afterwards so while partition names can be used, they are optional and purely for user information. Bug 741424 - Add support for GPT partition names
2014-12-12 00:00:02 -07:00
show_operationslist();
}
}
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
void Win_GParted::activate_change_uuid()
{
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition
Assert selected_partition_ptr is valid before use (#750168) Further ensure that a bug doesn't get introduced with the use of selected_partition_ptr, by asserting that it points to a current partition object in the vector of display partitions. After deliberately breaking the code so that selected_partition_ptr points to some other partition object, trying to display the Information dialog causes this crash: ====================== libparted : 2.4 ====================== ** ERROR:Win_GParted.cc:989:void GParted::Win_GParted::set_valid_operations(): assertion failed: (valid_display_partition_ptr( selected_partition_ptr )) Aborted (core dumped) At this point in the code: 973 void Win_GParted::set_valid_operations() 974 { ... 986 // No partition selected ... 987 if ( ! selected_partition_ptr ) 988 return ; >> 989 g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object Bug 750168 - Reduce the amount of copying of partition objects
2015-05-31 09:32:23 -06:00
g_assert( valid_display_partition_ptr( selected_partition_ptr ) ); // Bug: Not pointing at a valid display partition object
Assert selected_partition_ptr is not NULL (#750168) Add Glib g_assert() to ensure that a bug doesn't get introduced which allows a partition callback to be called without a partition being selected first. After deliberately breaking the code so that selected_partition_ptr is not set, trying to display the Information dialog causes this crash: # ./gpartedbin ====================== libparted : 2.4 ====================== ERROR:Win_GParted.cc:1978:void GParted::Win_GParted::activate_info(): assertion failed: (selected_partition_ptr != NULL) Aborted (core dumped) At this point in the code: 1976 void Win_GParted::activate_info() 1977 { >> 1978 g_assert( selected_partition_ptr != NULL ); // Bug: Partition callback without a selected partition 1979 Bug 750168 - Reduce the amount of copying of partition objects
2015-06-03 14:33:21 -06:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
const FileSystem * filesystem_object = gparted_core.get_filesystem_object( selected_partition_ptr->filesystem );
Small simplification of Win_GParted code which calls get_custom_text() Avoid long lines, long statements and repeated calls to gparted_core.get_filesystem_object( selected_partition.filesystem ) by storing the returned pointer in a local variable. Needs the previous commit so that the the local variable can be a pointer to a const FileSystem object instead of a pointer to a (modifiable) FileSystem object.
2015-05-16 02:58:58 -06:00
if ( filesystem_object->get_custom_text( CTEXT_CHANGE_UUID_WARNING ) != "" )
{
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
int i ;
Small simplification of Win_GParted code which calls get_custom_text() Avoid long lines, long statements and repeated calls to gparted_core.get_filesystem_object( selected_partition.filesystem ) by storing the returned pointer in a local variable. Needs the previous commit so that the the local variable can be a pointer to a const FileSystem object instead of a pointer to a (modifiable) FileSystem object.
2015-05-16 02:58:58 -06:00
Gtk::MessageDialog dialog( *this,
filesystem_object->get_custom_text( CTEXT_CHANGE_UUID_WARNING, 0 ),
false,
Gtk::MESSAGE_WARNING,
Gtk::BUTTONS_OK,
true );
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
Glib::ustring tmp_msg = "" ;
Small simplification of Win_GParted code which calls get_custom_text() Avoid long lines, long statements and repeated calls to gparted_core.get_filesystem_object( selected_partition.filesystem ) by storing the returned pointer in a local variable. Needs the previous commit so that the the local variable can be a pointer to a const FileSystem object instead of a pointer to a (modifiable) FileSystem object.
2015-05-16 02:58:58 -06:00
for ( i = 1 ; filesystem_object->get_custom_text( CTEXT_CHANGE_UUID_WARNING, i ) != "" ; i++ )
{
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
if ( i > 1 )
tmp_msg += "\n\n" ;
Small simplification of Win_GParted code which calls get_custom_text() Avoid long lines, long statements and repeated calls to gparted_core.get_filesystem_object( selected_partition.filesystem ) by storing the returned pointer in a local variable. Needs the previous commit so that the the local variable can be a pointer to a const FileSystem object instead of a pointer to a (modifiable) FileSystem object.
2015-05-16 02:58:58 -06:00
tmp_msg += filesystem_object->get_custom_text( CTEXT_CHANGE_UUID_WARNING, i );
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
}
dialog .set_secondary_text( tmp_msg ) ;
dialog .run() ;
}
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
// Make a duplicate of the selected partition (used in UNDO)
Implement and use virtual Partition copy constructor clone() (#759726) Final step for full polymorphic handling of Partition objects is to implement a virtual copy constructor. C++ doesn't directly support virtual copy constructors, so instead use the virtual copy constructor idiom [1]. (Just a virtual method called clone() which is implemented in every polymorphic class and creates a clone of the current object and returns a pointer to it). Then replace all calls to the (monomorphic) Partition object copy constructor throughout the code, except in the clone() implementation itself, with calls to the new virtual clone() method "virtual copy constructor". Also have to make the Partition destructor virtual too [2][3] so that the derived class destructor is called when deleting using a base class pointer. C++ supports this directly. [1] Wikibooks: More C++ Idioms / Virtual Constructor https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor [2] When to use virtual destructors? http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors [3] Virtuality Guideline #4: A base class destructor should be either public and virtual, or protected and nonvirtual http://www.gotw.ca/publications/mill18.htm Bug 759726 - Implement Partition object polymorphism SQUASH: When first using pointers to Partition and calling delete
2015-12-05 09:26:30 -07:00
Partition * part_temp = selected_partition_ptr->clone();
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
if ( part_temp->filesystem == FS_NTFS )
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
//Explicitly ask for half, so that the user will be aware of it
//Also, keep this kind of policy out of the NTFS code.
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
part_temp->uuid = UUID_RANDOM_NTFS_HALF;
Implement changing UUID for NTFS (#667278) Part 4 of 4 to provide new UUID support for NTFS. Closes Bug #667278 - Add support for setting UUID
2012-01-30 11:33:33 -07:00
else
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
part_temp->uuid = UUID_RANDOM;
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
Operation * operation = new OperationChangeUUID( devices[current_device],
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
*selected_partition_ptr, *part_temp );
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
operation ->icon = render_icon( Gtk::Stock::EXECUTE, Gtk::ICON_SIZE_MENU );
Change methods to use Partition pointers locally (#759726) A number of methods in GParted_Core and Win_GParted were using local Partition objects. Change them into pointers so that Partition object polymorphism can be implemented. Bug 759726 - Implement Partition object polymorphism
2015-12-13 06:20:21 -07:00
delete part_temp;
part_temp = NULL;
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
Add_Operation( operation ) ;
Better comment what each Merge_Operations() call is achieving (#755214) ... before refactoring the code. See the commit message from 2011-10-05 for details of what operations, available at that time, on the same partition can be merged and in what cases: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Bug 755214 - Refactor operation merging
2015-09-14 08:48:43 -06:00
// Try to merge this change UUID operation with all previous operations.
Refactor merging rules into new merge_operations() (#755214) Creation of the various operations involved various implicit rules about how the different types of operations were merged in different cases. This was open coded in each ::activate_*() method. Abstract this into new merge_operations() method and make the merging rules explicitly specified. NOTE: The removal of operation type checking in the MERGE_LAST_WITH_ANY cases is not a problem because all the Operation*::merge_operations() methods ensure the operation types match as part of the merge attempt. Bug 755214 - Refactor operation merging
2015-09-15 08:34:12 -06:00
merge_operations( MERGE_LAST_WITH_ANY );
Only allow Undo and Apply after merging operations (#699452) It was possible to make GParted crash by adding a label, check or new UUID operation and then applying the operation before the view of pending operations had finished fully opening. The operation would be successfully applied but GParted would crash afterwards. The fault was that Add_Operation() still enabled the Undo and Apply buttons and processed the GTK event loop before merging the list of pending operations. Faulty code flow went like this: activate_*() Add_Operation() Add operation to the operations[] vector Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Merge operations in the operations[] vector << Core dump here >> Merge_Operations() Refresh_Visual() This faulty code flow came about when merging of operations was added and it didn't appreciate that the operations[] vector could have been processed and cleared by Add_Operations() before the merge step. Relevant commit: b10349ae37df06b7bf7de91ea93a3913535ade3a Merge overlapping operations (#438573) Fragment of code in the label operation case: 2454 void Win_GParted::activate_label_partition() 2455 { ... 2472 Add_Operation( operation ) ; 2473 2474 // Verify if the two operations can be merged 2475 for ( unsigned int t = 0 ; t < operations .size() - 1 ; t++ ) 2476 { 2477 if ( operations[ t ] ->type == OPERATION_LABEL_PARTITION ) 2478 { 2479 if ( Merge_Operations( t, operations .size() - 1 ) ) 2480 break; 2481 } 2482 } Commentary in the crashing label operation case: 2472 The pending operation was already applied when Add_Operation() returned resulting in the operations[] vector being cleared setting its size to 0. 2475 The return type of operations.size() is an unsigned integral, so the upper limit of the for loop is t < 0UL - 1. Assuming a 32-bit machine that's t < 4294967295. 2477 operations[] vector is access from out of bounds offset 0 upwards until unallocated memory is accessed resulting in a core dump. Fix this by not enabling the Undo and Apply buttons and processing the GTK event loop until after merging of operations has been performed. Fixed code flow goes like this: activate_*() Add_Operation() Add operation to the operations[] vector Merge operations in the operations[] vector Merge_Operations() show_operationslist() Enable Undo and Apply buttons Refresh_Visual() Process GTK event loop Process Apply button callback applying operations, refreshing display and clearing operations[] vector Not allowing the operations list to be process until after the merge step is the be correct ordering. This also prevents the new operation from flashing up in the operations list and then immediately disappearing if merged. In the case of adding the first operation, delaying enabling the Undo and Apply buttons is enough as the buttons were previously disabled preventing the operation being applied before the merge. In the case of adding further operations, processing of the GTK event loop must also be delayed until after the merge to prevent the operations being applied before the merge. Although that window of opportunity would only be microseconds. Bug #699452 - Crash when applying operations before pending operations fully displayed
2013-05-17 10:01:42 -06:00
show_operationslist() ;
Add support for setting UUID (#667278) Add the ability to set a new random UUID on file systems that provide the appropriate tools to perform this action. Update the help manual to include this new functionality. Also add reference links to "setting a partition label" and "changing a partition UUID" in the "copying and pasting a partition" section. This patch does not include setting the UUID on an NTFS file system. Bug #667278 - Add support for setting UUID Bug #608308 - fix documentation - Copying and Pasting a Partition
2012-01-22 13:49:52 -07:00
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::activate_undo()
Initial revision
2004-09-19 14:24:53 -06:00
{
added 'check' operation. The functionality was already there, but it was * include/Makefile.am, include/Operation.h, include/Win_GParted.h, src/GParted_Core.cc, src/Makefile.am, src/Win_GParted.cc, include/OperationCheck.h (new), src/OperationCheck.cc (new): added 'check' operation. The functionality was already there, but it was not possible yet to activate it from the gui.
2006-11-26 07:27:16 -07:00
//when undoing a creation it's safe to decrease the newcount by one
renamed some enums * renamed some enums
2006-07-29 09:20:32 -06:00
if ( operations .back() ->type == OPERATION_CREATE )
enabled support for reiserfs
2004-10-06 09:32:40 -06:00
new_count-- ;
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
remove_operation() ;
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
Refresh_Visual();
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
if ( ! operations .size() )
close_operationslist() ;
Prevent visual disk display area from disappearing Added a display refresh to the event queue to address this problem. Previously, the display area of the visual disk seemed to disappear when enough operations had been added to the queue so that a scrollbar was required (about 4 operations). If the three lines in HBoxOperations::load_operations method for "//make scrollwindow focus on the last operation in the list" were commented out then this also prevented the problem from occurring. Interestingly, if I changed the "set_cursor" method to a "scroll_to_row" method, then this problem does not occur for an additional 2 operations (about 6 operations total). Ubuntu launchpad bug 583746 - Partition graph disappears after a swap partition has been deleted https://bugs.launchpad.net/ubuntu/+source/gparted/+bug/583746
2011-01-19 15:32:56 -07:00
//FIXME: A slight flicker may be introduced by this extra display refresh.
//An extra display refresh seems to prevent the disk area visual disk from
// disappearing when there enough operations to require a scrollbar
// (about 4+ operations with default window size) and a user clicks on undo.
// See also Win_GParted::Add_operation().
drawingarea_visualdisk .queue_draw() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
Add new method partition_in_operation_queue_count
2010-08-09 13:33:28 -06:00
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
void Win_GParted::remove_operation( int index, bool remove_all )
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
{
if ( remove_all )
{
for ( unsigned int t = 0 ; t < operations .size() ; t++ )
delete operations[ t ] ;
operations .clear() ;
}
else if ( index == -1 && operations .size() > 0 )
{
delete operations .back() ;
operations .pop_back() ;
}
else if ( index > -1 && index < static_cast<int>( operations .size() ) )
{
delete operations[ index ] ;
operations .erase( operations .begin() + index ) ;
}
}
Initial revision
2004-09-19 14:24:53 -06:00
Move method to match header file Also update copyright year
2010-08-10 11:36:10 -06:00
int Win_GParted::partition_in_operation_queue_count( const Partition & partition )
{
int operation_count = 0 ;
for ( unsigned int t = 0 ; t < operations .size() ; t++ )
{
Protect partition members within Operation classes (#759726) The Operation classes contain partition objects which are copied by value. Need to replace these with pointers to Partition objects instead and manage their lifetimes so that they can be used polymorphically. First step is to protect the partition members partition_new, partition_original, and for OperationCopy class only, partition_copied within the Operation classes and provide accessor methods. get_partition_new() and get_partition_original() accessors are implemented in the Operation base class so all derived classes get an implementation. get_partition_new() is also virtual so that OperationCheck and OperationDelete can override the implementation and assert that they don't use partition_new. get_partition_copied() is provided for the OperationCopy class only so can only be accessed via an OperationCopy type variable. Bug 759726 - Implement Partition object polymorphism
2015-09-19 08:57:39 -06:00
if ( partition.get_path() == operations[t]->get_partition_original().get_path() )
Move method to match header file Also update copyright year
2010-08-10 11:36:10 -06:00
operation_count++ ;
}
return operation_count ;
}
Add new method active_partitions_on_device_count
2010-08-10 12:52:59 -06:00
int Win_GParted::active_partitions_on_device_count( const Device & device )
{
int active_count = 0 ;
//Count the active partitions on the device
for ( unsigned int k=0; k < device .partitions .size(); k++ )
{
//Count the active primary partitions
if ( device .partitions[ k ] .busy
&& device .partitions[ k ] .type != TYPE_EXTENDED
&& device .partitions[ k ] .type != TYPE_UNALLOCATED
)
active_count++ ;
//Count the active logical partitions
if ( device .partitions[ k ] .busy
&& device .partitions[ k ] .type == TYPE_EXTENDED
)
{
for ( unsigned int j=0; j < device .partitions[ k ] .logicals .size(); j++ )
{
if ( device .partitions[ k ] .logicals [ j ] .busy
&& device .partitions[ k ] .logicals [ j ] .type != TYPE_UNALLOCATED
)
active_count++ ;
}
}
}
return active_count ;
}
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
void Win_GParted::activate_apply()
Initial revision
2004-09-19 14:24:53 -06:00
{
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
Gtk::MessageDialog dialog( *this,
added FIXME cleanups (mostly messagebox related) added some more * include/Utils.h: added FIXME * include/Win_GParted.h, src/Win_GParted.cc: cleanups (mostly messagebox related) * src/GParted_Core.cc: added some more progressfeedback to create and resize
2006-02-17 14:18:07 -07:00
_("Are you sure you want to apply the pending operations?"),
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
false,
Gtk::MESSAGE_WARNING,
Gtk::BUTTONS_NONE,
true );
Reworded caution message when applying operations svn path=/trunk/; revision=1033
2009-01-19 13:38:22 -07:00
Glib::ustring temp;
temp = _( "Editing partitions has the potential to cause LOSS of DATA.") ;
temp += "\n" ;
temp += _( "You are advised to backup your data before proceeding." ) ;
dialog .set_secondary_text( temp ) ;
Fixed some spelling mistakes svn path=/trunk/; revision=951
2008-11-04 15:16:06 -07:00
dialog .set_title( _( "Apply operations to device" ) );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
P) It still needs a lot of love, but the foundations are laid =) * Rewrote a large part of gparteds internal code. Filesystemssupport is now much more separated from the rest of gparted and adding support for other filesystems should be a piece of cake now (hope that's true :P) It still needs a lot of love, but the foundations are laid =)
2004-11-17 06:00:25 -07:00
dialog .add_button( Gtk::Stock::CANCEL, Gtk::RESPONSE_CANCEL );
dialog .add_button( Gtk::Stock::APPLY, Gtk::RESPONSE_OK );
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
dialog .show_all_children() ;
if ( dialog.run() == Gtk::RESPONSE_OK )
Initial revision
2004-09-19 14:24:53 -06:00
{
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
dialog .hide() ; //hide confirmationdialog
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
Dialog_Progress dialog_progress( operations ) ;
made some changes to progressdialog behaviour. * include/Dialog_Progress.h, src/Dialog_Progress.cc, src/Win_GParted.cc: made some changes to progressdialog behaviour.
2006-01-26 08:54:44 -07:00
dialog_progress .set_transient_for( *this ) ;
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
dialog_progress .signal_apply_operation .connect(
sigc::mem_fun(gparted_core, &GParted_Core::apply_operation_to_disk) ) ;
added libparted version string to details export. * include/Dialog_Progress.h, include/GParted_Core.h, src/Dialog_Progress.cc, src/GParted_Core.cc, src/Win_GParted.cc: added libparted version string to details export.
2006-12-01 06:01:46 -07:00
dialog_progress .signal_get_libparted_version .connect(
sigc::mem_fun(gparted_core, &GParted_Core::get_libparted_version) ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
removed warning about busy device. It's not really needed and it confuses * src/Win_GParted.cc: removed warning about busy device. It's not really needed and it confuses people. * include/Operation.h: set default status of operationdetails to NONE * include/Dialog_Progress.h, src/Dialog_Progress.cc: implemented export of operationdetails to external file. This can be very usefull for debugging. (#329968)
2006-02-07 08:17:44 -07:00
int response ;
do
{
response = dialog_progress .run() ;
}
while ( response == Gtk::RESPONSE_CANCEL || response == Gtk::RESPONSE_OK ) ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
dialog_progress .hide() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//wipe operations...
lots of cleanups in operationhandling. This resulted in cleaner/less code * lots of cleanups in operationhandling. This resulted in cleaner/less code and the fixing of some longstanding issues.
2006-03-24 12:08:41 -07:00
remove_operation( -1, true ) ;
added popupmenu to operationslist and did some (higrelated) cleanups * added popupmenu to operationslist and did some (higrelated) cleanups
2006-09-17 07:23:47 -06:00
hbox_operations .clear() ;
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
close_operationslist() ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) * include/Device.h, src/Device.cc: made 'deep-scan' optional in Read_Disk_Layout. Removed obsolete (already) commented function. * include/Partition.h, src/Partition.cc: Took used sectors out of Set() and added a Set_Used() function instead. Also added Reset() . * src/Dialog_Partition_New.cc: minor change to make use of the new Set() in Partition.. * include/Win_GParted.h, src/Win_GParted.cc: show pulsing progressbar while refreshing devices.
2004-10-11 04:23:24 -06:00
//reset new_count to 1
First load gui and then scan devices, this resulted in way faster startup * include/Win_GParted.h, src/Win_GParted.cc: First load gui and then scan devices, this resulted in way faster startup and is more satisfactory (imho) Also did some minor code cleanups and rearranged some functions needed for applying operations. * src/Dialog_Progress.cc: few minor code cleanups.
2004-10-16 09:42:08 -06:00
new_count = 1 ;
Redo update copyright year range. Previous change removed trailing whitespace, and hence made for way to many differences that make diff comparisons difficult. svn path=/trunk/; revision=1023
2009-01-06 15:22:09 -07:00
Initial revision
2004-09-19 14:24:53 -06:00
//reread devices and their layouts...
p * added detailed progressfeedback. It still needs some polishing, but is already far better then the old situation. And what's more, it's finally threadsafe :p
2006-01-19 12:15:15 -07:00
menu_gparted_refresh_devices() ;
Initial revision
2004-09-19 14:24:53 -06:00
}
}
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
bool Win_GParted::remove_non_empty_lvm2_pv_dialog( const OperationType optype )
{
Glib::ustring tmp_msg ;
switch ( optype )
{
case OPERATION_DELETE:
tmp_msg = String::ucompose( _( "You are deleting non-empty LVM2 Physical Volume %1" ),
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_path() );
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
break ;
case OPERATION_FORMAT:
tmp_msg = String::ucompose( _( "You are formatting over non-empty LVM2 Physical Volume %1" ),
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_path() );
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
break ;
case OPERATION_COPY:
tmp_msg = String::ucompose( _( "You are pasting over non-empty LVM2 Physical Volume %1" ),
Change selected partition into a pointer (#750168) Now that TreeView_Details and DrawingAreaVisualDisk classes store and pass pointers to partition objects in the Gtk signal callbacks, change the selected partition into a pointer too. Bug 750168 - Reduce the amount of copying of partition objects
2015-05-17 07:01:48 -06:00
selected_partition_ptr->get_path() );
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
break ;
default:
break ;
}
Gtk::MessageDialog dialog( *this, tmp_msg,
false, Gtk::MESSAGE_WARNING, Gtk::BUTTONS_NONE, true ) ;
tmp_msg = _( "Deleting or overwriting the Physical Volume is irrecoverable and will destroy or damage the "
" Volume Group." ) ;
tmp_msg += "\n\n" ;
tmp_msg += _( "To avoid destroying or damaging the Volume Group, you are advised to cancel and use external "
"LVM commands to free the Physical Volume before attempting this operation." ) ;
tmp_msg += "\n\n" ;
tmp_msg += _( "Do you want to continue to forcibly delete the Physical Volume?" ) ;
Stop needing any LVM2_PV_Info objects (#750582) The LVM2_PV_Info cache had a pretend multi-object interface, yet all the data is static. An LVM2_PV_Info object doesn't contain any member variables, yet was needed just to call the member functions. Make all the member functions static removing the need to use any LVM2_PV_Info objects. Bug 750582 - Refactor the LVM2_PV_Info module object interface and internal cache representation
2015-06-05 13:54:37 -06:00
Glib::ustring vgname = LVM2_PV_Info::get_vg_name( selected_partition_ptr->get_path() );
Add fallback implementation to new delete LVM2 PV warning dialog (#670171) The new delete non-empty LVM2 Physical Volume warning dialog uses Gtk::MessageDialog::get_message_area() in the display of Volume Group members. This function was new in gtkmm 2.22, released September 2010, which is not available in a number of current distributions including: Unbuntu 10.04 LTS, RHEL 6.3, SLES 11-SP2, Debian 6.0. Implement fallback method to display the VG name and member PVs in the warning dialog for when get_message_area() is not available. Bug #670171 - Add LVM PV read-write support
2012-07-24 06:49:44 -06:00
std::vector<Glib::ustring> members ;
if ( ! vgname .empty() )
Stop needing any LVM2_PV_Info objects (#750582) The LVM2_PV_Info cache had a pretend multi-object interface, yet all the data is static. An LVM2_PV_Info object doesn't contain any member variables, yet was needed just to call the member functions. Make all the member functions static removing the need to use any LVM2_PV_Info objects. Bug 750582 - Refactor the LVM2_PV_Info module object interface and internal cache representation
2015-06-05 13:54:37 -06:00
members = LVM2_PV_Info::get_vg_members( vgname );
Add fallback implementation to new delete LVM2 PV warning dialog (#670171) The new delete non-empty LVM2 Physical Volume warning dialog uses Gtk::MessageDialog::get_message_area() in the display of Volume Group members. This function was new in gtkmm 2.22, released September 2010, which is not available in a number of current distributions including: Unbuntu 10.04 LTS, RHEL 6.3, SLES 11-SP2, Debian 6.0. Implement fallback method to display the VG name and member PVs in the warning dialog for when get_message_area() is not available. Bug #670171 - Add LVM PV read-write support
2012-07-24 06:49:44 -06:00
//Single copy of each string for translation purposes
const Glib::ustring vgname_label = _( "Volume Group:" ) ;
const Glib::ustring members_label = _( "Members:" ) ;
#ifndef HAVE_GET_MESSAGE_AREA
//Basic method of displaying VG members by appending it to the secondary text in the dialog.
tmp_msg += "\n____________________\n\n" ;
tmp_msg += "<b>" ;
tmp_msg += vgname_label ;
tmp_msg += "</b> " ;
tmp_msg += vgname ;
tmp_msg += "\n" ;
tmp_msg += "<b>" ;
tmp_msg += members_label ;
tmp_msg += "</b>" ;
if ( ! members .empty() )
{
tmp_msg += " " ;
tmp_msg += members [0] ;
for ( unsigned int i = 1 ; i < members .size() ; i ++ )
{
tmp_msg += " " ;
tmp_msg += members [i] ;
}
}
#endif /* ! HAVE_GET_MESSAGE_AREA */
dialog .set_secondary_text( tmp_msg, true ) ;
#ifdef HAVE_GET_MESSAGE_AREA
//Nicely formatted method of displaying VG members by using a table below the secondary text
// in the dialog. Uses Gtk::MessageDialog::get_message_area() which was new in gtkmm-2.22
// released September 2010.
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
Gtk::Box * msg_area = dialog .get_message_area() ;
Gtk::HSeparator * hsep( manage( new Gtk::HSeparator() ) ) ;
msg_area ->pack_start( * hsep ) ;
Gtk::Table * table( manage( new Gtk::Table() ) ) ;
table ->set_border_width( 0 ) ;
table ->set_col_spacings( 10 ) ;
msg_area ->pack_start( * table ) ;
int top = 0, bottom = 1 ;
//Volume Group
Add fallback implementation to new delete LVM2 PV warning dialog (#670171) The new delete non-empty LVM2 Physical Volume warning dialog uses Gtk::MessageDialog::get_message_area() in the display of Volume Group members. This function was new in gtkmm 2.22, released September 2010, which is not available in a number of current distributions including: Unbuntu 10.04 LTS, RHEL 6.3, SLES 11-SP2, Debian 6.0. Implement fallback method to display the VG name and member PVs in the warning dialog for when get_message_area() is not available. Bug #670171 - Add LVM PV read-write support
2012-07-24 06:49:44 -06:00
table ->attach( * Utils::mk_label( "<b>" + Glib::ustring( vgname_label ) + "</b>" ),
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
0, 1, top, bottom, Gtk::FILL ) ;
Stop using deprecated widget alignment enumerators (#652044) Step 3 of 3: Now that all label widgets are created with ALIGN_LEFT and ALIGN_CENTER alignment remove the x_align and y_align parameters from mk_label() and always use this alignment. Also specify this alignment via floats rather than enumerators, one of which was deprecated. Bug #652044 - uses deprecated APIs
2013-10-16 15:44:03 -06:00
table ->attach( * Utils::mk_label( vgname, true, false, true ),
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
1, 2, top++, bottom++, Gtk::FILL ) ;
//Members
Make LVM members selectable together in delete non-empty PV dialog Place the LVM2 member names in a single string, separated by new lines, so that they can be selected all together by the user. This was not previously possible when each member name was placed in a separate widget.
2014-04-27 03:10:05 -06:00
table ->attach( * Utils::mk_label( "<b>" + Glib::ustring( members_label ) + "</b>",
true, false, false, 0.0 /* ALIGN_TOP */ ),
0, 1, top, bottom, Gtk::FILL ) ;
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
Make LVM members selectable together in delete non-empty PV dialog Place the LVM2 member names in a single string, separated by new lines, so that they can be selected all together by the user. This was not previously possible when each member name was placed in a separate widget.
2014-04-27 03:10:05 -06:00
Glib::ustring members_str = "" ;
if ( ! members .empty() )
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
{
Make LVM members selectable together in delete non-empty PV dialog Place the LVM2 member names in a single string, separated by new lines, so that they can be selected all together by the user. This was not previously possible when each member name was placed in a separate widget.
2014-04-27 03:10:05 -06:00
for ( unsigned int i = 0 ; i < members .size() ; i ++ )
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
{
Make LVM members selectable together in delete non-empty PV dialog Place the LVM2 member names in a single string, separated by new lines, so that they can be selected all together by the user. This was not previously possible when each member name was placed in a separate widget.
2014-04-27 03:10:05 -06:00
if ( i > 0 )
members_str += "\n" ;
members_str += members[i] ;
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
}
}
Make LVM members selectable together in delete non-empty PV dialog Place the LVM2 member names in a single string, separated by new lines, so that they can be selected all together by the user. This was not previously possible when each member name was placed in a separate widget.
2014-04-27 03:10:05 -06:00
table ->attach( * Utils::mk_label( members_str, true, false, true, 0.0 /* ALIGN_TOP */ ),
1, 2, top++, bottom++, Gtk::FILL ) ;
Add fallback implementation to new delete LVM2 PV warning dialog (#670171) The new delete non-empty LVM2 Physical Volume warning dialog uses Gtk::MessageDialog::get_message_area() in the display of Volume Group members. This function was new in gtkmm 2.22, released September 2010, which is not available in a number of current distributions including: Unbuntu 10.04 LTS, RHEL 6.3, SLES 11-SP2, Debian 6.0. Implement fallback method to display the VG name and member PVs in the warning dialog for when get_message_area() is not available. Bug #670171 - Add LVM PV read-write support
2012-07-24 06:49:44 -06:00
#endif /* HAVE_GET_MESSAGE_AREA */
Add warning dialog when deleting non-empty LVM2 PVs (#670171) When attempting to delete a non-empty LVM2 Physical Volume (one which is still a member of a Volume Group) display a warning dialog which includes the VG name and a list of the PV members to allow the user to make an informed choice whether to go ahead and perform the deletion or cancel to the operation. This dialog is displayed when a partition containing a PV is being deleted or being overwritten by being reformatted or pasted into. Bug #670171 - Add LVM PV read-write support
2012-07-05 16:33:04 -06:00
dialog .add_button( Gtk::Stock::CANCEL, Gtk::RESPONSE_CANCEL );
dialog .add_button( Gtk::Stock::DELETE, Gtk::RESPONSE_OK );
dialog .show_all() ;
if ( dialog .run() == Gtk::RESPONSE_OK )
return true ;
return false ;
}
Initial revision
2004-09-19 14:24:53 -06:00
} // GParted