Mirrors
/
gparted
mirror of https://gitlab.gnome.org/GNOME/gparted.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use constant reference from LVM2_PV_Info::get_pv_cache_entry_by_name() (!94) 

Closes !94 - Make more getter methods use return-by-constant-reference
This commit is contained in:
Mike Fleetwood 2021-11-02 21:21:22 +00:00 committed by Curtis Gedak
parent 0a4761df46
commit 55a74645f6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/LVM2_PV_Info.cc
View File

@ -90,7 +90,7 @@ void LVM2_PV_Info::clear_cache()
Glib::ustring LVM2_PV_Info::get_vg_name( const Glib::ustring & path ) Glib::ustring LVM2_PV_Info::get_vg_name( const Glib::ustring & path )
{ {
initialize_if_required() ; initialize_if_required() ;
LVM2_PV pv = get_pv_cache_entry_by_name( path ); const LVM2_PV& pv = get_pv_cache_entry_by_name(path);
return pv.vg_name; return pv.vg_name;
} }
@ -98,7 +98,7 @@ Glib::ustring LVM2_PV_Info::get_vg_name( const Glib::ustring & path )
Byte_Value LVM2_PV_Info::get_size_bytes( const Glib::ustring & path ) Byte_Value LVM2_PV_Info::get_size_bytes( const Glib::ustring & path )
{ {
initialize_if_required() ; initialize_if_required() ;
LVM2_PV pv = get_pv_cache_entry_by_name( path ); const LVM2_PV& pv = get_pv_cache_entry_by_name(path);
return pv.pv_size; return pv.pv_size;
} }
@ -106,7 +106,7 @@ Byte_Value LVM2_PV_Info::get_size_bytes( const Glib::ustring & path )
Byte_Value LVM2_PV_Info::get_free_bytes( const Glib::ustring & path ) Byte_Value LVM2_PV_Info::get_free_bytes( const Glib::ustring & path )
{ {
initialize_if_required() ; initialize_if_required() ;
LVM2_PV pv = get_pv_cache_entry_by_name( path ); const LVM2_PV& pv = get_pv_cache_entry_by_name(path);
return pv.pv_free; return pv.pv_free;
} }
@ -114,7 +114,7 @@ Byte_Value LVM2_PV_Info::get_free_bytes( const Glib::ustring & path )
bool LVM2_PV_Info::has_active_lvs( const Glib::ustring & path ) bool LVM2_PV_Info::has_active_lvs( const Glib::ustring & path )
{ {
initialize_if_required() ; initialize_if_required() ;
LVM2_PV pv = get_pv_cache_entry_by_name( path ); const LVM2_PV& pv = get_pv_cache_entry_by_name(path);
if ( pv.vg_name == "" ) if ( pv.vg_name == "" )
// PV not yet included in any VG or PV not found in cache // PV not yet included in any VG or PV not found in cache
return false ; return false ;
@ -189,7 +189,7 @@ std::vector<Glib::ustring> LVM2_PV_Info::get_error_messages( const Glib::ustring
Glib::ustring temp ; Glib::ustring temp ;
//Check for partition specific message: partial VG //Check for partition specific message: partial VG
LVM2_PV pv = get_pv_cache_entry_by_name( path ); const LVM2_PV& pv = get_pv_cache_entry_by_name(path);
LVM2_VG vg = get_vg_cache_entry_by_name( pv.vg_name ); LVM2_VG vg = get_vg_cache_entry_by_name( pv.vg_name );
if ( bit_set( vg.vg_attr, VGBIT_PARTIAL ) ) if ( bit_set( vg.vg_attr, VGBIT_PARTIAL ) )
{ {