Mirrors
/
gparted
mirror of https://gitlab.gnome.org/GNOME/gparted.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Erase correct key in unit test PasswordRAMStoreTest.TooLongPassword 

Was attempting to erase the wrong key "key-long" for the test.  It
should be erasing "key-too-long".  Fix this.  Given that that line in
the test was to erase a non-existent key and confirm failure; the test
passed before with the wrong non-existent key, and still passes with the
right non-existent key.  Clearly a cut and paste error as a result of
copying the previous LongPassword test when initially added in:
    c6657aab9e
    Add unit tests for PasswordRAMStore module (#795617)
This commit is contained in:
Mike Fleetwood 2019-06-29 09:46:43 +01:00 committed by Curtis Gedak
parent a4c00e03e6
commit 7afc39a707
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_PasswordRAMStore.cc
View File

@ -272,7 +272,7 @@ TEST_F( PasswordRAMStoreTest, TooLongPassword )
looked_up_pw = PasswordRAMStore::lookup( "key-too-long" ); looked_up_pw = PasswordRAMStore::lookup( "key-too-long" );
EXPECT_TRUE( looked_up_pw == NULL ); EXPECT_TRUE( looked_up_pw == NULL );
EXPECT_FALSE( PasswordRAMStore::erase( "key-long" ) ); EXPECT_FALSE(PasswordRAMStore::erase("key-too-long"));
EXPECT_TRUE( mem_is_zero( protected_mem, ProtectedMemSize ) ); EXPECT_TRUE( mem_is_zero( protected_mem, ProtectedMemSize ) );
} }