Remove "Skip setting unsupported partition flag" message

This message would be displayed as part of the details for an operation
to create or format a partition as LVM2 PV on a disk using partition
table types dvh or pc98, which don't have an lvm flag.

 v Format /dev/sdb1 as lvm2 pv
   > calibrate /dev/sdb1
   > clear old file system signatures in /dev/sdb1
   > set partition type on /dev/sdb1
       Skip setting unsupported partition flag: lvm
   > create new lvm2 pv file system

Translators found this message difficult to translate, as reported in
bug 752901 - Add translator comment or fix string.  It is also only
standard practice to set the lvm flag on partitions containing LVM2 PVs,
and not required.  In hindsight reporting that an operation was skipped,
when the operation is not a necessity, is probably bad practice as it
could lead to uncertainty on behalf of the user and questions as to why
the flag isn't supported.  Just remove the message.
This commit is contained in:
Mike Fleetwood 2015-07-27 18:26:33 +01:00 committed by Curtis Gedak
parent 3276951ccd
commit 9f0b5ee633
1 changed files with 3 additions and 10 deletions

View File

@ -3318,16 +3318,9 @@ bool GParted_Core::set_partition_type( const Partition & partition, OperationDet
} }
else if ( ! supports_lvm_flag ) else if ( ! supports_lvm_flag )
{ {
operationdetail.get_last_child().add_child( // Skip setting the lvm flag because the partition
/* TO TRANSLATORS: looks like Skip setting unsupported partition flag: lvm // table type doesn't support it. Applies to dvh
* // and pc98 disk labels.
* Note that this means that this step is skipped because the type of partition
* table in use does not support the partition flag we would like to set.
*/
OperationDetail( String::ucompose( _("Skip setting unsupported partition flag: %1"),
ped_partition_flag_get_name( PED_PARTITION_LVM ) ),
STATUS_NONE,
FONT_ITALIC ) );
return_value = true; return_value = true;
} }
} }