Mirrors
/
gparted
mirror of https://gitlab.gnome.org/GNOME/gparted.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Accept reading shorter UUIDs from FAT16/32 file systems (!49) 

The tests were failing like this:

    $ ./test_SupportedFileSystems --gtest_filter='*CreateAndReadUUID/fat16'
....
    [ RUN      ] My/SupportedFileSystemsTest.CreateAndReadUUID/fat16
    test_SupportedFileSystems.cc:552: Failure
    Expected equality of these values:
      m_partition.uuid.size()
        Which is: 9
      36U
        Which is: 36
    [  FAILED  ] My/SupportedFileSystemsTest.CreateAndReadUUID/fat16, where GetParam() = 13 (45 ms)

This is because the test was expecting a full 36 character UUID as used
by Linux file systems.  Also accept shorter 9 character "UUID"s as used
by FAT16/32 file systems.

Closes !49 - Add file system interface tests
This commit is contained in:
Mike Fleetwood 2019-08-05 16:31:02 +01:00 committed by Curtis Gedak
parent 8d4f9eac99
commit c60f2e43a3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_SupportedFileSystems.cc
View File

@ -549,7 +549,7 @@ TEST_P(SupportedFileSystemsTest, CreateAndReadUUID)
// Test reading the UUID is successful. // Test reading the UUID is successful.
reload_partition(); reload_partition();
m_fs_object->read_uuid(m_partition); m_fs_object->read_uuid(m_partition);
EXPECT_EQ(m_partition.uuid.size(), 36U); EXPECT_GE(m_partition.uuid.size(), 9U);
// Test messages from read operation are empty or print them. // Test messages from read operation are empty or print them.
EXPECT_TRUE(m_partition.get_messages().empty()) << m_partition; EXPECT_TRUE(m_partition.get_messages().empty()) << m_partition;