Go to file
Mike Fleetwood 3d1b2921a6 Only explicitly flush devices when using libparted < 3.2 (#259)
During device probing GParted always explicitly calls ped_device_sync()
to flush the caches for coherency between the whole disk device and the
partition devices [1].  As the GParted_Core::flush_device() comment
explains, since v3.1.61-gfb99ba5 [2], libparted flushes the devices
every time a device is opened [3], so also explicitly doing this in
GParted is unnecessary.  Therefore stop explicitly flushing the devices
in GParted, except when using libparted 3.1 and older which doesn't do
it itself.

The ped_device_open() and ped_device_close() needed for the
ped_device_sync() is also a trigger of device changes and udev rule
execution performing LVM Volume Group activation, because libparted
opens the device read-write [4].  This is another reason to remove it
when possible.  However even when eliminated it does not solve the issue
of LVM VG activation because other triggers remain.  Do want this change
first though so that the sequence of libparted calls isn't changed
immediately after documenting them and fixing the issue and so that
there is no doubt that this change doesn't fix the issue.

Removing this extra device flush saves a little bit of time, depending
on the speed of the drive and number of partitions.  Sample savings on
my desktop:
    Drive type and partitions       Saving (seconds)
    -----------------------------   ----------------
    fast SSD with 3 partitions      0.05
    slow SSD with 12 partitions     0.27
    HDD with 1 partition            0.05
    VHDD in VM with 1 partition     0.14
    VHDD in VM with 10 partitions   0.58

Also the settle_device() call in flush_device() needs to be kept to wait
for device changes and udev rule execution whether it is GParted
explicitly flushing the device or just libparted automatically doing it
for cache coherency in ped_device_get().  This is because:
1.  Libparted <= 3.2 opens the whole disk device read-write for
    ped_device_get() [5].  (This was changed with parted
    v3.2.26-g44d5ae0 [6] to open the whole disk device read-only).
2.  Libparted up to and including the latest 3.6 release still opens all
    partition devices read-write for ped_device_get() [7].
3.  A whole disk device FAT32 file system looks enough like a partition
    table that both the Linux kernel and libparted think it is
    partitioned:
        # mkfs.fat -F32 /dev/sdb
        mkfs.fat 4.2 (2021-01-31)
        # grep sdb /proc/partitions
           8       16    8388608 sdb
           8       17    8388607 sdb1
        # parted /dev/sdb print
        Model: ATA VBOX HARDDISK (scsi)
        Disk /dev/sdb: 8590MB
        Sector size (logical/physical): 512B/512B
        Partition Table: loop
        Disk Flags:

        Number  Start  End        Size       File system  Flags
         1      0s     16777215s  16777216s  fat32

So the ped_device_get() call on a whole disk device FAT32 file system
still triggers device change and udev rule execution which needs to be
waited for, as this is exactly the case fixed previously by commit:
    1382e0b828
    Wait for udev change on /dev/DISK when querying whole device FS (!46)

[1] 3bea067596
    Flush devices when scanning to prevent reading stale signatures (#723842)
[2] Revert "linux-commit: do not unnecessarily open partition device nodes"
    http://git.savannah.gnu.org/cgit/parted.git/commit/?id=fb99ba5ebd0dc34204fc9f1014131d5d494805bc
[3] parted libparted/arch/linux.c:_device_open()
    https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6#n1752
        1709 static int
        1710 linux_open (PedDevice* dev)
        1711 {
        1712     return _device_open (dev, RW_MODE);
        1713 }
        1714
        1715 static int
        1716 _device_open (PedDevice* dev, int flags)
        ...
        1752     _flush_cache (dev);

[4] parted libparted/device.c:ped_device_open() v3.6
    https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/device.c?h=v3.6#n226
    parted libparted/arch/linux.c v3.6
    https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6
        ped_device_open(...)
            ped_architecture->dev_ops->open(...) = linux_open(...)
                _device_open(..., RW_MODE)
                    open(..., O_RDWR)

[5] parted libparted/device.c:ped_device_get() v3.2
    https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/device.c?h=v3.2#n149
    parted libparted/arch/linux.c v3.2
    https://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.2
        ped_device_get(...)
            ped_architecture->dev_ops->_new(...) = linux_new()
                init_ide(...)
                init_scsi(...)
                init_generic(...)
                    ped_device_open(...)
                        ped_architecture->dev_ops->open(...) = linux_open(...)
                            open(..., O_RDWR)
[6] libparted: Use read only when probing devices on linux (#1245144)
    http://git.savannah.gnu.org/cgit/parted.git/commit/?id=44d5ae0115c4ecfe3158748309e9912c5aede92d
[7] parted libparted/arch/linux.v v3.6
    http://git.savannah.gnu.org/cgit/parted.git/tree/libparted/arch/linux.c?h=v3.6#n1660
        1660 static void
        1661 _flush_cache (PedDevice* dev)
        ...
        1673     for (i = 1; i < lpn; i++) {
        ...
        1680         if (!_partition_is_mounted_by_path(name)) {
        1681             fd = open (name, WR_MODE, 0);

Closes #259 - Trying to deactivate LVM PV fails
2024-09-14 08:44:43 +00:00
data Increase minimum required gtkmm to 2.11.1 (#794253) 2018-03-26 10:16:45 -06:00
doc Update URLs in the remaining files to https://gparted.org (#796411) 2018-06-19 09:47:19 -06:00
help Update Romanian translation 2024-07-26 13:21:05 +00:00
include Only explicitly flush devices when using libparted < 3.2 (#259) 2024-09-14 08:44:43 +00:00
lib Update to Google Test 1.10.0 (!117) 2023-09-23 15:30:15 +00:00
m4 Update Autoconf macro AX_CXX_COMPILE_STDCXX_11 to latest serial 18 2018-08-01 19:03:01 +01:00
po Update Hungarian translation 2024-09-13 15:05:50 +00:00
src Only explicitly flush devices when using libparted < 3.2 (#259) 2024-09-14 08:44:43 +00:00
tests Add bcachefs creation (!123) 2024-09-11 15:25:17 +00:00
.gitignore Add missing .gitignore entry for test_EraseFileSystemSignatures 2023-08-15 17:04:30 +00:00
.gitlab-ci.yml Replace CentOS 7 with Rocky Linux 8 in the CI jobs (!124) 2024-08-07 15:20:45 +00:00
AUTHORS Update copyright years 2024-02-26 09:15:09 -07:00
COPYING Revert "Fixed FSF's address. Fixes #721565" 2014-01-31 14:39:20 +01:00
COPYING-DOCS Added COPYING-DOCS and removed help/C/legal.xml file. The GFDL license should be translated only once per language, and not for each and every project that uses the license. See GParted bug #550047 2008-09-01 17:01:14 +00:00
ChangeLog Correctly capitalise GNOME in the Manual and man page (#739805) 2014-12-20 10:02:55 -07:00
HACKING Update HACKING file with coding style hints and tips 2021-03-24 16:22:41 +00:00
Makefile.am Rename Makefile.am variables to APPSTREAM*/appstream* (#241) 2024-02-08 16:19:20 +00:00
NEWS ========== gparted-1.6.0 ========== 2024-02-26 09:18:39 -07:00
README Add bcachefs creation (!123) 2024-09-11 15:25:17 +00:00
autogen.sh Remove deprecated PKG_NAME from autogen.sh 2019-03-01 16:46:56 +00:00
configure.ac Only explicitly flush devices when using libparted < 3.2 (#259) 2024-09-14 08:44:43 +00:00
gparted.appdata.xml.in Add bcachefs creation (!123) 2024-09-11 15:25:17 +00:00
gparted.desktop.in.in Migrate build from intltool to gettext translation (!107) 2022-11-12 16:44:55 +00:00
gparted.doap Update bug links from Bugzilla to GitLab issues (!11) 2018-08-24 09:54:12 +01:00
gparted.in Also find system default udev rules in /usr/lib/udev/rules.d (!116) 2023-08-15 17:04:30 +00:00
logo.png Add logo.png for automatic GitLab/GitHub project avatar 2018-05-25 17:18:49 +01:00
org.gnome.gparted.policy.in.in Migrate build from intltool to gettext translation (!107) 2022-11-12 16:44:55 +00:00
testbuild.sh Add testbuild.sh script (#699881) 2013-05-27 11:08:39 -06:00

README

GPARTED
=======
Gparted is the GNOME Partition Editor for creating, reorganizing, and
deleting disk partitions.

A hard disk is usually subdivided into one or more partitions.  These
partitions are normally not re-sizable (making one smaller and the
adjacent one larger.)  Gparted makes it possible for you to take a
hard disk and change the partition organization, while preserving the
partition contents.

More specifically, Gparted enables you to create, destroy, resize,
move, check, label, and copy partitions, and the file systems
contained within.  This is useful for creating space for new operating
systems, reorganizing disk usage, and mirroring one partition with
another (disk imaging).

Gparted can also be used with storage devices other than hard disks,
such as USB flash drives, and memory cards.

Visit https://gparted.org for more information.


LICENSING
---------
GParted is released under the General Public License version 2, or (at
your option) any later version.  (GPLv2+).  All files are released under
the GPLv2+ unless explicitly licensed otherwise.

The GParted Manual is released under the GNU Free Documentation License
version 1.2 or any later version.  (GFDLv1.2+).

Google Test C++ test framework is released under the 3-Clause BSD
License.  (BSD-3-Clause).

See these files for more details:
   COPYING      - GNU General Public License version 2
   COPYING-DOCS - GNU Free Documentation License version 1.2
   lib/gtest/LICENSE
                - 3-Clause BSD License


NEWS
----
Information about changes to this release, and past releases can be
found in the file:
   NEWS


INSTALL
-------
a. Pre-built Binary

   Many GNU/Linux distributions already provide a pre-built binary
   package for GParted.  Instructions on how to install GParted on
   some distributions is given below:

      RHEL
      ----
      su -
      dnf install gparted

      Debian or Ubuntu
      ----------------
      sudo apt install gparted

      Fedora
      ------
      su -
      dnf install gparted

      OpenSUSE
      --------
      sudo zypper install gparted

b. Building from Source

   Briefly, build and install GParted into the default location of
   /usr/local using:
      ./configure
      make
      sudo make install
      sudo install -m 644 org.gnome.gparted.policy \
             /usr/share/polkit-1/actions/org.gnome.gparted.local.policy
   This assumes all the dependencies are already installed, builds the
   default configuration and polkit is being used as the graphical su
   program.

   The following dependencies are required to build GParted from source:
      g++
      make
      parted
      gnome-common
      gtkmm3
      gettext
      polkit
      yelp-tools         - required if help documentation is to be built

   On RHEL, these dependencies may be obtained by running the following
   command as root:
      dnf install gnome-common yelp-tools glib2-devel gcc-c++ \
                  libuuid-devel parted-devel gtkmm30-devel make \
                  polkit-devel gettext-devel

   On Debian or Ubuntu, these dependencies may be obtained by running
   one of the following commands:
     Either;
      sudo apt build-dep gparted
     Or;
      sudo apt install build-essential gnome-common yelp-tools \
                       libglib2.0-dev uuid-dev libparted-dev \
                       libgtkmm-3.0-dev

   Debian 13 and later and Ubuntu 24.04 LTS and later also require this
   dependency installing:
      sudo apt install libpolkit-gobject-1-dev

   On Fedora, these dependencies may be obtained by running the
   following command as root:
      dnf install gnome-common yelp-tools glib2-devel gcc-c++ \
                  libuuid-devel parted-devel gtkmm30-devel make \
                  polkit-devel gettext-devel

   On openSUSE, these dependencies may be obtained by running the
   following commands:
      sudo zypper install gnome-common gcc-c++ libuuid-devel \
                          parted-devel gtkmm3-devel make polkit-devel

   Again, build GParted with the default configuration and install into
   the default location of /usr/local using:
      ./configure
      make
      sudo make install

   If you wish to build this package without the help documentation use
   the --disable-doc flag:
      E.g., ./configure --disable-doc

   If you wish to build this package to use native libparted /dev/mapper
   dmraid support use the --enable-libparted-dmraid flag:
      E.g., ./configure --enable-libparted-dmraid

   If you wish to build this package with online resize support then
   the following is required:
      a)  Linux kernel version 3.6 or higher.
      b)  Libparted with online resize support.  Either:
          i)  Libparted version 3.2 or later which includes online
              resize support as standard.  In this case GParted is
              automatically built with online resize support.
          ii) Online resize support back ported into an earlier version
              of libparted.  This is only known to be included in Debian
              and derived distributions with parted version 2.3-14 and
              higher.  In this case online resize support must be
              specifically enabled with the --enable-online-resize flag:
                E.g., ./configure --enable-online-resize

   If you wish to build GParted to allow it to use xhost to grant root
   access to the X11 server use the --enable-xhost-root flag.  This is
   required to allow GParted to display under Wayland.
      ./configure --enable-xhost-root

   Please note that more than one configure flag can be used:
      E.g., ./configure --disable-doc --enable-libparted-dmraid

   The INSTALL file contains further GNU installation instructions.

c. Installing polkit's Action File

   GParted needs to run as root therefore it needs a graphical switch
   user program to allow normal users to run it.  Most desktops now use
   polkit as their preferred authorisation mechanism.  Therefore
   ./configure looks for polkit's pkexec as the first choice with
   fallbacks in order being: gksudo, gksu, kdesudo and finally xdg-su.
   Also polkit reads action files only from directory
   /usr/share/polkit-1/actions.  Therefore it is likely that a polkit
   action file will need to be installed into this directory.

   To determine if polkit's pkexec program is being used as the
   graphical privilege escalation program examine the output from
   ./configure.  These lines report that pkexec is being used:

      checking for pkexec >= 0.102... 0.112 found

   Where as either of these lines of ./configure output report that
   pkexec is not being used because either it was too old a version or
   it was not found:

      checking for pkexec >= 0.102... 0.96 found

      checking for pkexec >= 0.102... not found

   When GParted is configured with prefix /usr (using command
   ./configure --prefix=/usr) then make install will automatically
   install the polkit action file into the correct directory and no
   further steps need to be taken.  This is typically the case for
   distribution builds of GParted.

   However when GParted is configured with the default prefix of
   /usr/local, or any prefix other than /usr, then the polkit action
   file has to be manually installed into the correct directory.  Also
   it should have a unique file name to avoid overwriting the action
   file from the distribution's package.  Install the polkit action file
   with a unique name including an extra ".local" in the name:

      sudo install -m 644 org.gnome.gparted.policy \
             /usr/share/polkit-1/actions/org.gnome.gparted.local.policy

d. Building using a Specific (lib)parted Version

   1) Download the parted version you wish to use (e.g., 3.2) from:

      http://ftp.gnu.org/gnu/parted/

   2) Build and install parted.

      Extract parted tarball, configure, make, and sudo make install.
      Note that by default this will install into /usr/local.

   3) Set environment variables to inform the GParted build system to
      use libparted from /usr/local:

        export CPPFLAGS=-I/usr/local/include
        export LDFLAGS=-L/usr/local/lib
        export LD_RUN_PATH=/usr/local/lib
        export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig

   4) Build gparted using steps listed above in "Building from Source".

      Note that when you run ./configure you should see the specific
      version of parted listed in the check for libparted >= 1.7.1.

      You will also see the libparted version listed when running
      gparted from the command line.


DIRECTORIES
------------
data     - contains desktop icons

doc      - contains manual page documentation

help     - contains GParted Manual and international translations

include  - contains source header files

lib/gtest
         - contains Google Test C++ test framework libraries

m4       - contains macro files

po       - contains international language translations

src      - contains C++ source code


DISTRIBUTION NOTES
------------------
GParted uses GNU libparted to detect and manipulate devices and
partition tables.  The blkid command is also required to detect those
file systems which libparted doesn't detect.  (The blkid command should
be considered a mandatory requirement).

GParted also queries and manipulates the file systems within those
devices and partitions.  When available, it uses each file system's
specific commands.  The following optional file system specific packages
provide this support:

   bcachefs-tools
   btrfs-progs / btrfs-tools
   e2fsprogs
   exfatprogs
   f2fs-tools
   dosfstools
   mtools          - required to read and write FAT16/32 volume labels
                     and UUIDs
   hfsutils
   hfsprogs
   jfsutils
   nilfs-utils / nilfs-tools
   ntfs-3g / ntfsprogs
   reiser4progs
   reiserfsprogs / reiserfs-utils / reiserfs
   udftools
   util-linux      - required to create and check MINIX file systems
   xfsprogs, xfsdump


For dmraid support, the following packages are required:

   dmsetup         - removes /dev/mapper entries
   dmraid          - lists dmraid devices and creates /dev/mapper
                     entries

For GNU/Linux distribution dmraid support, the following are required:
   - kernel built with Device Mapping and Mirroring built.  From
     menuconfig, it is under Device Drivers -> <something> (RAID & LVM).
   - dmraid drive arrays activated on boot (e.g., dmraid -ay).


For LVM2 Physical Volume support the following command is required:
   lvm             - LVM2 administration tool
And device-mapper support in the kernel.


For accurate detection and reporting of Linux Software RAID Arrays the
following command is required:

   mdadm           - SWRaid administration tool


For LUKS support the following commands are required:
   cryptsetup      - LUKS volume administration tool
   dmsetup         - Device-mapper administration tool


Several more commands are optionally used by GParted if found on the
system.  These commands include:

   blkid           - [mandatory requirement] used to detect file systems
                     libparted doesn't, read UUIDs and volume labels
   udisks          - used to prevent automounting of file systems
   hal-lock        - used to prevent automounting of file systems
   pkexec          - used to acquire root privileges in gparted shell
                     script wrapper, but only if available when gparted
                     source is configured
   gksudo          - alternatively used to acquire root privileges in
                     gparted shell script wrapper, second choice if
                     available when gparted source is configured
   gksu            - alternatively used to acquire root privileges in
                     gparted shell script wrapper, third choice if
                     available when gparted source is configured
   kdesudo         - alternatively used to acquire root privileges in
                     gparted shell script wrapper, fourth choice if
                     available when gparted source is configured
   xdg-su          - alternatively used to acquire root privileges in
                     gparted shell script wrapper, last choice if
                     available when gparted source is configured
   udevadm         - used to wait for udev rule execution and querying
                     udev device properties
   yelp            - used to display help manual
                     (requires gvfs to be able to launch yelp)
   xhost           - used to grant root access to the X11 server, only
                     when configured to do so