Go to file
Mike Fleetwood 43e96e4c6a Skip BlockSpecial unit tests when devices don't exist, for CI test images (!113)
Since November 2022 test_BlockSpecial has been occasionally failing in
GNOME GitLab Docker CI test jobs like this:

    [ RUN      ] BlockSpecialTest.NamedBlockSpecialObjectBlockDevice
    test_BlockSpecial.cc:216: Failure
    Value of: bs.m_major > 0 || bs.m_minor > 0
      Actual: false
    Expected: true
    [  FAILED  ] BlockSpecialTest.NamedBlockSpecialObjectBlockDevice (0 ms)
    ...
    [ RUN      ] BlockSpecialTest.TwoNamedBlockSpecialObjectBlockDevices
    test_BlockSpecial.cc:244: Failure
    Value of: bs1.m_major != bs2.m_major || bs1.m_minor != bs2.m_minor
      Actual: false
    Expected: true
    [  FAILED  ] BlockSpecialTest.TwoNamedBlockSpecialObjectBlockDevices (0 ms)
    [ RUN      ] BlockSpecialTest.NamedBlockSpecialObjectBySymlinkMatches
    test_BlockSpecial.cc:170: Failure
    Failed
    follow_link_name(): Failed to resolve symbolic link '/dev/disk/by-id/gparted-sda'
    [  FAILED  ] BlockSpecialTest.NamedBlockSpecialObjectBySymlinkMatches (0 ms)
    ...
     3 FAILED TESTS
    FAIL test_BlockSpecial (exit status: 1)

As identified previously [1] the Docker CI images no longer have any
block devices in /dev.  test/makedev.sh script was added to create block
devices test_BlockSpecial needs for it's testing.  Now a subset of the
GNOME GitLab job runners additionally prevent creation of block special
device nodes.  test/makedev.sh reports this:

    $ tests/makedev.sh
    mknod -m 0660 /dev/sda b 8 0
    mknod: /dev/sda: Operation not permitted
    chown: cannot access '/dev/sda': No such file or directory
    mknod -m 0660 /dev/sda1 b 8 1
    mknod: /dev/sda1: Operation not permitted
    chown: cannot access '/dev/sda1': No such file or directory

Alternative rejected solutions:

1.  Use fakeroot [2].  Package is available for the 3 distributions used
    in CI jobs.  Does fake stat() call.  Works when run like this in the
    CI test jobs:
        fakeroot -s test/fakeroot.env tests/makedev.sh
        fakeroot -i test/fakeroot.env make check
        fakeroot -i test/fakeroot.env make distcheck
    But if you run fakeroot ... make check on our development machines
    as a non-root user it causes the test_SupportedFileSystems unit
    tests which use losetup to fail.  This is because
    test_SupportedFileSystems thinks it's root inside the fakeroot
    environment but fakeroot doesn't fake enough for losetup to work.
    This makes running tests in the GitLab CI jobs different from how we
    would have to run them on our development machines.  Prefer not to
    do that.

2.  Use GNU ld --wrap [3] to call our own __wrap_stat() allowing
    test_BlockSpecial to provide mocked results to the stat() call in
    constructor BlockSpecial::BlockSpecial().  This works with
    GNU C Library >= 2.33, released 01-Feb-2021, and musl libc,
    therefore it works on CI tested distributions Ubuntu LTS >= 22.04
    and Alpine Linux respectively.  However this fails on earlier glibc
    releases, so will fail on CentOS 7 CI image, as the compiler emits a
    call to __xstat() rather than stat().  This is something to do with
    how glibc's /usr/include/sys/stat.h supported multiple versions of
    stat().  Don't use this as it's doesn't work everywhere.

    Additional useful implementation hints.  [4][5]

Choose to fix by just skipping unit tests which need block special names
to exist in the file system, but don't exist.  This is the same
technique that test_SupportedFileSystems uses.  So tests/makedev.sh
creates block devices if it can in the GNOME GitLab CI test images [1]
and now if that fails the individual unit tests are skipped.

[1] 57983b9fc2
    Create block special devices needed by test_BlockSpecial in GitLab
    CI jobs (!59)

[2] FakeRoot
    https://wiki.debian.org/FakeRoot

[3] ld(1) - Linux manual page
    https://man7.org/linux/man-pages/man1/ld.1.html
        "--wrap=symbol
        Use a wrapper function for symbol.  Any undefined reference to
        symbol will be resolved to "__wrap_symbol".  Any undefined
        reference to "__real_symbol" will be resolved to symbol.

        This can be used to provide a wrapper for a system function.
        The wrapper function should be called "__wrap_symbol".  If it
        wishes to call the system function, it should call
        "__real_symbol".
        ...
        "

[4] gcc: error: unrecognized option --wrap
    https://stackoverflow.com/questions/33278164/gcc-error-unrecognized-option-wrap

[5] C++ ld linker --wrap option does not work for internal function calls
    https://stackoverflow.com/questions/44464961/c-ld-linker-wrap-option-does-not-work-for-internal-function-calls

Closed !113 - Fix occasional GitLab CI test jobs failures on
              BlockSpecial unit tests
2023-05-20 16:18:11 +00:00
data Increase minimum required gtkmm to 2.11.1 (#794253) 2018-03-26 10:16:45 -06:00
doc Update URLs in the remaining files to https://gparted.org (#796411) 2018-06-19 09:47:19 -06:00
help Update Indonesian translation 2022-03-31 03:26:23 +00:00
include Briefly comment STAT_* enumerators 2023-04-27 15:54:01 +00:00
lib Update to Google Test 1.8.1 2019-01-21 16:41:31 +00:00
m4 Update Autoconf macro AX_CXX_COMPILE_STDCXX_11 to latest serial 18 2018-08-01 19:03:01 +01:00
po Update Chinese (China) translation 2023-04-28 19:35:47 +00:00
src Remove superfluous STAT_FORMATTED 2023-04-27 15:54:01 +00:00
tests Skip BlockSpecial unit tests when devices don't exist, for CI test images (!113) 2023-05-20 16:18:11 +00:00
.gitignore Update .gitignore for intltool to gettext translation migration (!107) 2022-11-12 16:44:55 +00:00
.gitlab-ci.yml Cat /proc/partitions and list /dev in GitLab CI test jobs (!113) 2023-05-20 16:18:11 +00:00
AUTHORS Update copyright years 2023-02-21 10:07:52 -07:00
COPYING Revert "Fixed FSF's address. Fixes #721565" 2014-01-31 14:39:20 +01:00
COPYING-DOCS Added COPYING-DOCS and removed help/C/legal.xml file. The GFDL license should be translated only once per language, and not for each and every project that uses the license. See GParted bug #550047 2008-09-01 17:01:14 +00:00
ChangeLog Correctly capitalise GNOME in the Manual and man page (#739805) 2014-12-20 10:02:55 -07:00
HACKING Update HACKING file with coding style hints and tips 2021-03-24 16:22:41 +00:00
Makefile.am Migrate build from intltool to gettext translation (!107) 2022-11-12 16:44:55 +00:00
NEWS ========== gparted-1.5.0 ========== 2023-02-21 10:14:32 -07:00
README Remove mention of devkit-disks from README 2022-11-12 16:44:55 +00:00
autogen.sh Remove deprecated PKG_NAME from autogen.sh 2019-03-01 16:46:56 +00:00
configure.ac Append -git to version for continuing development 2023-02-21 10:40:48 -07:00
gparted.appdata.xml.in Migrate build from intltool to gettext translation (!107) 2022-11-12 16:44:55 +00:00
gparted.desktop.in.in Migrate build from intltool to gettext translation (!107) 2022-11-12 16:44:55 +00:00
gparted.doap Update bug links from Bugzilla to GitLab issues (!11) 2018-08-24 09:54:12 +01:00
gparted.in Remove support for old volatile udev rules below /dev/.udev 2022-03-01 16:58:46 +00:00
logo.png Add logo.png for automatic GitLab/GitHub project avatar 2018-05-25 17:18:49 +01:00
org.gnome.gparted.policy.in.in Migrate build from intltool to gettext translation (!107) 2022-11-12 16:44:55 +00:00
testbuild.sh Add testbuild.sh script (#699881) 2013-05-27 11:08:39 -06:00

README

GPARTED
=======
Gparted is the GNOME Partition Editor for creating, reorganizing, and
deleting disk partitions.

A hard disk is usually subdivided into one or more partitions.  These
partitions are normally not re-sizable (making one smaller and the
adjacent one larger.)  Gparted makes it possible for you to take a
hard disk and change the partition organization, while preserving the
partition contents.

More specifically, Gparted enables you to create, destroy, resize,
move, check, label, and copy partitions, and the file systems
contained within.  This is useful for creating space for new operating
systems, reorganizing disk usage, and mirroring one partition with
another (disk imaging).

Gparted can also be used with storage devices other than hard disks,
such as USB flash drives, and memory cards.

Visit https://gparted.org for more information.


LICENSING
---------
GParted is released under the General Public License version 2, or (at
your option) any later version.  (GPLv2+).  All files are released under
the GPLv2+ unless explicitly licensed otherwise.

The GParted Manual is released under the GNU Free Documentation License
version 1.2 or any later version.  (GFDLv1.2+).

Google Test C++ test framework is released under the 3-Clause BSD
License.  (BSD-3-Clause).

See these files for more details:
   COPYING      - GNU General Public License version 2
   COPYING-DOCS - GNU Free Documentation License version 1.2
   lib/gtest/LICENSE
                - 3-Clause BSD License


NEWS
----
Information about changes to this release, and past releases can be
found in the file:
   NEWS


INSTALL
-------
a. Pre-built Binary

   Many GNU/Linux distributions already provide a pre-built binary
   package for GParted.  Instructions on how to install GParted on
   some distributions is given below:

      CentOS/RHEL
      -----------
      su -
      yum install gparted

      Debian or Ubuntu
      ----------------
      sudo apt install gparted

      Fedora
      ------
      su -
      dnf install gparted

      OpenSUSE
      --------
      sudo zypper install gparted

b. Building from Source

   Briefly, build and install GParted into the default location of
   /usr/local using:
      ./configure
      make
      sudo make install
      sudo install -m 644 org.gnome.gparted.policy \
             /usr/share/polkit-1/actions/org.gnome.gparted.local.policy
   This assumes all the dependencies are already installed, builds the
   default configuration and polkit is being used as the graphical su
   program.

   The following dependencies are required to build GParted from source:
      g++
      make
      parted
      gnome-common
      gtkmm3
      gettext
      polkit
      yelp-tools          - required if help documentation is to be built

   On CentOS/RHEL, these dependencies may be obtained by running the
   following command as root:
      yum install gnome-common yelp-tools glib2-devel gcc-c++ \
                  libuuid-devel parted-devel gtkmm30-devel make \
                  polkit-devel gettext-devel

   On Debian or Ubuntu, these dependencies may be obtained by running
   one of the following commands:
     Either;
      sudo apt build-dep gparted
     Or;
      sudo apt install build-essential gnome-common yelp-tools \
                       libglib2.0-dev uuid-dev libparted-dev \
                       libgtkmm-3.0-dev

   On Fedora, these dependencies may be obtained by running the
   following command as root:
      dnf install gnome-common yelp-tools glib2-devel gcc-c++ \
                  libuuid-devel parted-devel gtkmm30-devel make \
                  polkit-devel gettext-devel

   On openSUSE, these dependencies may be obtained by running the
   following commands:
      sudo zypper install gnome-common gcc-c++ libuuid-devel \
                          parted-devel gtkmm3-devel make polkit-devel

   Again, build GParted with the default configuration and install into
   the default location of /usr/local using:
      ./configure
      make
      sudo make install

   If you wish to build this package without the help documentation use
   the --disable-doc flag:
      E.g., ./configure --disable-doc

   If you wish to build this package to use native libparted /dev/mapper
   dmraid support use the --enable-libparted-dmraid flag:
      E.g., ./configure --enable-libparted-dmraid

   If you wish to build this package with online resize support then
   the following is required:
      a)  Linux kernel version 3.6 or higher.
      b)  Libparted with online resize support.  Either:
          i)  Libparted version 3.2 or later which includes online
              resize support as standard.  In this case GParted is
              automatically built with online resize support.
          ii) Online resize support back ported into an earlier version
              of libparted.  This is only known to be included in Debian
              and derived distributions with parted version 2.3-14 and
              higher.  In this case online resize support must be
              specifically enabled with the --enable-online-resize flag:
                E.g., ./configure --enable-online-resize

   If you wish to build GParted to allow it to use xhost to grant root
   access to the X11 server use the --enable-xhost-root flag.  This is
   required to allow GParted to display under Wayland.
      ./configure --enable-xhost-root

   Please note that more than one configure flag can be used:
      E.g., ./configure --disable-doc --enable-libparted-dmraid

   The INSTALL file contains further GNU installation instructions.

c. Installing polkit's Action File

   GParted needs to run as root therefore it needs a graphical switch
   user program to allow normal users to run it.  Most desktops now use
   polkit as their preferred authorisation mechanism.  Therefore
   ./configure looks for polkit's pkexec as the first choice with
   fallbacks in order being: gksudo, gksu, kdesudo and finally xdg-su.
   Also polkit reads action files only from directory
   /usr/share/polkit-1/actions.  Therefore it is likely that a polkit
   action file will need to be installed into this directory.

   To determine if polkit's pkexec program is being used as the
   graphical privilege escalation program examine the output from
   ./configure.  These lines report that pkexec is being used:

      checking for pkexec >= 0.102... 0.112 found

   Where as either of these lines of ./configure output report that
   pkexec is not being used because either it was too old a version or
   it was not found:

      checking for pkexec >= 0.102... 0.96 found

      checking for pkexec >= 0.102... not found

   When GParted is configured with prefix /usr (using command
   ./configure --prefix=/usr) then make install will automatically
   install the polkit action file into the correct directory and no
   further steps need to be taken.  This is typically the case for
   distribution builds of GParted.

   However when GParted is configured with the default prefix of
   /usr/local, or any prefix other than /usr, then the polkit action
   file has to be manually installed into the correct directory.  Also
   it should have a unique file name to avoid overwriting the action
   file from the distribution's package.  Install the polkit action file
   with a unique name including an extra ".local" in the name:

      sudo install -m 644 org.gnome.gparted.policy \
             /usr/share/polkit-1/actions/org.gnome.gparted.local.policy

d. Building using a Specific (lib)parted Version

   1) Download the parted version you wish to use (e.g., 3.2) from:

      http://ftp.gnu.org/gnu/parted/

   2) Build and install parted.

      Extract parted tarball, configure, make, and sudo make install.
      Note that by default this will install into /usr/local.

   3) Set environment variables to inform the GParted build system to
      use libparted from /usr/local:

        export CPPFLAGS=-I/usr/local/include
        export LDFLAGS=-L/usr/local/lib
        export LD_RUN_PATH=/usr/local/lib
        export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig

   4) Build gparted using steps listed above in "Building from Source".

      Note that when you run ./configure you should see the specific
      version of parted listed in the check for libparted >= 1.7.1.

      You will also see the libparted version listed when running
      gparted from the command line.


DIRECTORIES
------------
data     - contains desktop icons

doc      - contains manual page documentation

help     - contains GParted Manual and international translations

include  - contains source header files

lib/gtest
         - contains Google Test C++ test framework libraries

m4       - contains macro files

po       - contains international language translations

src      - contains C++ source code


DISTRIBUTION NOTES
------------------
GParted uses GNU libparted to detect and manipulate devices and
partition tables.  The blkid command is also required to detect those
file systems which libparted doesn't detect.  (The blkid command should
be considered a mandatory requirement).

GParted also queries and manipulates the file systems within those
devices and partitions.  When available, it uses each file system's
specific commands.  The following optional file system specific packages
provide this support:

   btrfs-progs / btrfs-tools
   e2fsprogs
   exfatprogs
   f2fs-tools
   dosfstools
   mtools          - required to read and write FAT16/32 volume labels
                     and UUIDs
   hfsutils
   hfsprogs
   jfsutils
   nilfs-utils / nilfs-tools
   ntfs-3g / ntfsprogs
   reiser4progs
   reiserfsprogs / reiserfs-utils / reiserfs
   udftools
   util-linux      - required to create and check MINIX file systems
   xfsprogs, xfsdump


For dmraid support, the following packages are required:

   dmsetup         - removes /dev/mapper entries
   dmraid          - lists dmraid devices and creates /dev/mapper
                     entries

For GNU/Linux distribution dmraid support, the following are required:
   - kernel built with Device Mapping and Mirroring built.  From
     menuconfig, it is under Device Drivers -> <something> (RAID & LVM).
   - dmraid drive arrays activated on boot (e.g., dmraid -ay).


For LVM2 Physical Volume support the following command is required:
   lvm             - LVM2 administration tool
And device-mapper support in the kernel.


For accurate detection and reporting of Linux Software RAID Arrays the
following command is required:

   mdadm           - SWRaid administration tool


For LUKS support the following commands are required:
   cryptsetup      - LUKS volume administration tool
   dmsetup         - Device-mapper administration tool


For attempt data rescue for lost partitions, the following package
is required:
   gpart           - guesses PC-type hard disk partitions


Several more commands are optionally used by GParted if found on the
system.  These commands include:

   blkid           - [mandatory requirement] used to detect file systems
                     libparted doesn't, read UUIDs and volume labels
   hdparm          - used to query disk device serial numbers
   udisks          - used to prevent automounting of file systems
   {filemanager}   - used in attempt data rescue to display discovered
                     file systems.  (e.g., nautilus, pcmanfm)
   hal-lock        - used to prevent automounting of file systems
   pkexec          - used to acquire root privileges in gparted shell
                     script wrapper, but only if available when gparted
                     source is configured
   gksudo          - alternatively used to acquire root privileges in
                     gparted shell script wrapper, second choice if
                     available when gparted source is configured
   gksu            - alternatively used to acquire root privileges in
                     gparted shell script wrapper, third choice if
                     available when gparted source is configured
   kdesudo         - alternatively used to acquire root privileges in
                     gparted shell script wrapper, fourth choice if
                     available when gparted source is configured
   xdg-su          - alternatively used to acquire root privileges in
                     gparted shell script wrapper, last choice if
                     available when gparted source is configured
   udevadm         - used in dmraid to query udev name
   yelp            - used to display help manual
                     (requires gvfs to be able to launch yelp)
   xhost           - used to grant root access to the X11 server, only
                     when configured to do so