From 8a5bcba227fcddff40385e8707ef94c7d6b3b561 Mon Sep 17 00:00:00 2001 From: yuanwu2017 Date: Tue, 12 Mar 2024 20:37:33 +0800 Subject: [PATCH] Upgrade nix version from 0.27.1 to 0.28.0 (#1638) # What does this PR do? Fix the following carsh when build the docker on Ubuntu22.04 ``` error[E0432]: unresolved import `nix::sys::signal::Signal` --> launcher/src/main.rs:2:30 | 2 | use nix::sys::signal::{self, Signal}; | ^^^^^^ no `Signal` in `sys::signal` | = help: consider importing this type alias instead: ctrlc::Signal error[E0432]: unresolved import `nix::unistd::Pid` --> launcher/src/main.rs:3:5 | 3 | use nix::unistd::Pid; | ^^^^^^^^^^^^^^^^ no `Pid` in `unistd` | note: found an item that was configured out --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/nix-0.27.1/src/unistd.rs:183:12 | 183 | pub struct Pid(pid_t); | ^^^ = note: the item is gated behind the `process` feature error[E0425]: cannot find function `kill` in module `signal` ``` Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. --------- Signed-off-by: yuanwu Co-authored-by: drbh --- launcher/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/launcher/Cargo.toml b/launcher/Cargo.toml index 77fb5ee0..7c598c37 100644 --- a/launcher/Cargo.toml +++ b/launcher/Cargo.toml @@ -9,7 +9,7 @@ homepage.workspace = true [dependencies] clap = { version = "4.4.5", features = ["derive", "env"] } ctrlc = { version = "3.4.1", features = ["termination"] } -nix = "0.27.1" +nix = { version = "0.28.0", features = ["signal"] } serde = { version = "1.0.188", features = ["derive"] } serde_json = "1.0.107" tracing = "0.1.37"