From da644c21e535dadfb9842d6dd3b2d8748c4e5dc7 Mon Sep 17 00:00:00 2001
From: Miquel Farre <miquel.farre@huggingface.co>
Date: Wed, 13 Nov 2024 13:37:17 +0000
Subject: [PATCH] adopting video url

---
 backends/client/src/lib.rs    | 3 +++
 backends/v3/src/client/mod.rs | 2 +-
 backends/v3/src/queue.rs      | 1 +
 proto/v3/generate.proto       | 3 +++
 router/src/lib.rs             | 3 ++-
 router/src/validation.rs      | 8 --------
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/backends/client/src/lib.rs b/backends/client/src/lib.rs
index 45bee10c..4fdd8f56 100644
--- a/backends/client/src/lib.rs
+++ b/backends/client/src/lib.rs
@@ -79,6 +79,9 @@ impl ChunksToString for Vec<InputChunk> {
                 let encoded = STANDARD.encode(data);
                 output.push_str(&format!("![](data:{};base64,{})", mimetype, encoded))
             }
+            Some(Chunk::Video(url)) => {
+                output.push_str(&format!("<video>({})", url))
+            }
             // We don't create empty chunks, so this should be unreachable.
             None => unreachable!("Chunks should never be empty"),
         });
diff --git a/backends/v3/src/client/mod.rs b/backends/v3/src/client/mod.rs
index d4ac50c9..22a24be4 100644
--- a/backends/v3/src/client/mod.rs
+++ b/backends/v3/src/client/mod.rs
@@ -15,7 +15,7 @@ pub use grpc_client::Client;
 pub use pb::generate::v3::{
     input_chunk::Chunk, Batch, CachedBatch, FinishReason, GeneratedText, Generation, GrammarType,
     HealthResponse, Image, InfoResponse, Input, InputChunk, NextTokenChooserParameters, Request,
-    StoppingCriteriaParameters,
+    StoppingCriteriaParameters, 
 };
 pub use sharded_client::ShardedClient;
 
diff --git a/backends/v3/src/queue.rs b/backends/v3/src/queue.rs
index 6662b8de..10d1563c 100644
--- a/backends/v3/src/queue.rs
+++ b/backends/v3/src/queue.rs
@@ -439,6 +439,7 @@ impl State {
                                     data: image.data,
                                     mimetype: image.mimetype,
                                 }),
+                                Chunk::Video(url) => client::Chunk::Video(url),
                             }),
                         })
                         .collect(),
diff --git a/proto/v3/generate.proto b/proto/v3/generate.proto
index 02980b6f..2f91ef86 100644
--- a/proto/v3/generate.proto
+++ b/proto/v3/generate.proto
@@ -70,6 +70,9 @@ message InputChunk {
     string text = 1;
     /// Image data
     Image image = 2;
+    /// Video URLs
+    string video = 3;
+
   }
 }
 
diff --git a/router/src/lib.rs b/router/src/lib.rs
index 80daadde..45695b4c 100644
--- a/router/src/lib.rs
+++ b/router/src/lib.rs
@@ -1134,7 +1134,7 @@ pub struct Url {
 pub enum MessageChunk {
     Text { text: String },
     ImageUrl { image_url: Url },
-    Video { video_url: Url },
+    VideoUrl { video_url: Url },
 }
 
 #[derive(Clone, Deserialize, ToSchema, Serialize, Debug, PartialEq)]
@@ -1191,6 +1191,7 @@ impl From<Message> for TextMessage {
                     .map(|chunk| match chunk {
                         MessageChunk::Text { text } => text,
                         MessageChunk::ImageUrl { image_url } => format!("![]({})", image_url.url),
+                        MessageChunk::VideoUrl { video_url } => format!("![]({})", video_url.url),
                     })
                     .collect::<Vec<_>>()
                     .join(""),
diff --git a/router/src/validation.rs b/router/src/validation.rs
index 7896f9f8..4443b17c 100644
--- a/router/src/validation.rs
+++ b/router/src/validation.rs
@@ -560,14 +560,6 @@ fn fetch_image(input: &str) -> Result<(Vec<u8>, String, usize, usize), Validatio
     }
 }
 
-fn fetch_video(input: &str) -> Result<String, ValidationError> {
-    if input.starts_with("http://") || input.starts_with("https://") {
-        Ok(input.to_string())
-    } else {
-        Err(ValidationError::InvalidVideoContent(input.to_string()))
-    }
-}
-
 fn image_tokens(
     config: &Config,
     preprocessor_config: Option<&HubPreprocessorConfig>,