From b39d7caf312f4032bd88f117999a4d6957c3dd34 Mon Sep 17 00:00:00 2001
From: Eric Eastwood <contact@ericeastwood.com>
Date: Tue, 27 Sep 2022 22:21:00 -0500
Subject: [PATCH] Add linting to CI (#74)

 - Prettier
 - ESLint
---
 .github/workflows/linting.yml                 | 40 +++++++++++++++++++
 .github/workflows/tests.yaml                  |  1 +
 .prettierignore                               |  2 +
 .../NotEnoughEventsFromDaySummaryTileView.js  |  4 +-
 shared/views/RoomCardView.js                  |  2 +-
 5 files changed, 46 insertions(+), 3 deletions(-)
 create mode 100644 .github/workflows/linting.yml
 create mode 100644 .prettierignore

diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
new file mode 100644
index 0000000..664d712
--- /dev/null
+++ b/.github/workflows/linting.yml
@@ -0,0 +1,40 @@
+name: Linting
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  lint-eslint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run ESLint
+        run: npm run eslint -- "**/*.js"
+
+  lint-prettier:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run Prettier
+        run: npm run prettier -- --check "**/*.{js,css,md}"
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
index 84189b5..0796580 100644
--- a/.github/workflows/tests.yaml
+++ b/.github/workflows/tests.yaml
@@ -110,6 +110,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
+          cache: 'npm'
 
       - name: Install dependencies
         run: npm ci
diff --git a/.prettierignore b/.prettierignore
new file mode 100644
index 0000000..b947077
--- /dev/null
+++ b/.prettierignore
@@ -0,0 +1,2 @@
+node_modules/
+dist/
diff --git a/shared/views/NotEnoughEventsFromDaySummaryTileView.js b/shared/views/NotEnoughEventsFromDaySummaryTileView.js
index 1aebb56..69b0a4f 100644
--- a/shared/views/NotEnoughEventsFromDaySummaryTileView.js
+++ b/shared/views/NotEnoughEventsFromDaySummaryTileView.js
@@ -28,8 +28,8 @@ class NotEnoughEventsFromDaySummaryTileView extends TemplateView {
       },
       [
         t.if(
-          (vm) => !!daySummaryMessage,
-          (t, vm) =>
+          (/*vm*/) => !!daySummaryMessage,
+          (t /*, vm*/) =>
             t.p(
               {
                 className: 'NotEnoughEventsFromDaySummaryTileView_summaryMessage',
diff --git a/shared/views/RoomCardView.js b/shared/views/RoomCardView.js
index 38fa0bb..5b73697 100644
--- a/shared/views/RoomCardView.js
+++ b/shared/views/RoomCardView.js
@@ -48,7 +48,7 @@ class RoomCardView extends TemplateView {
             t.view(new AvatarView(avatarViewModel, 24)),
             t.if(
               (vm) => vm.name,
-              (t, vm) =>
+              (t /*, vm*/) =>
                 t.h4(
                   {
                     className: 'RoomCardView_headerTitle',