From b3c553a863c7a84b8c1f4755fe7252193100e27c Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Tue, 8 Nov 2022 22:35:28 -0600 Subject: [PATCH] Add comment reference to issue about adding hour chunk time slices (#126) --- server/routes/room-routes.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/server/routes/room-routes.js b/server/routes/room-routes.js index 000c696..ee9cd2a 100644 --- a/server/routes/room-routes.js +++ b/server/routes/room-routes.js @@ -214,11 +214,13 @@ router.get( // any messages in the gap. // // XXX: This date boundary logic may need to change once we introduce hour - // chunks or time slices. For example if we reached into the next day but it has - // too many messages to show for a given page, we would want to back track until - // a suitable time slice boundary. Maybe we need to add a new URL parameter here - // `?time-slice=true` to indicate that it's okay to break it up by time slice - // based on previously having to view by time slice. We wouldn't want to give + // chunks or time slices + // (https://github.com/matrix-org/matrix-public-archive/issues/7). For example + // if we reached into the next day but it has too many messages to show for a + // given page, we would want to back track until a suitable time slice boundary. + // Maybe we need to add a new URL parameter here `?time-slice=true` to indicate + // that it's okay to break it up by time slice based on previously having to + // view by time slice. We wouldn't want to give const utcMidnightOfDayBefore = Date.UTC( dateOfLastMessage.getUTCFullYear(), dateOfLastMessage.getUTCMonth(),