Mirrors
/
matrix-public-archive
mirror of https://github.com/matrix-org/matrix-public-archive.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix checkbox being checked by default when the value was actually `null` (#221) 

Fix `debugActiveDateIntersectionObserver` checkbox being checked by default when the value was actually `null`.
Now we properly only care about explicit `'true'`, `'false'` from local storage.

Before:
```
<input id="debugActiveDateIntersectionObserver" type="checkbox" checked="null">
```

After:
```
<input id="debugActiveDateIntersectionObserver" type="checkbox">
```
This commit is contained in:
Eric Eastwood 2023-05-05 19:44:49 -05:00 committed by GitHub
parent ed3fde7845
commit bf8040f48e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
shared/viewmodels/DeveloperOptionsContentViewModel.js
View File

@ -14,16 +14,24 @@ class DeveloperOptionsContentViewModel extends ViewModel {
}
loadValuesFromPersistence() {
// Debugging is disabled by default and only enabled with the correct 'true' value
let debugActiveDateIntersectionObserver = false;
if (window.localStorage) {
this._debugActiveDateIntersectionObserver = JSON.parse(
window.localStorage.getItem(LOCAL_STORAGE_KEYS.debugActiveDateIntersectionObserver)
const debugActiveDateIntersectionObserverFromPersistence = window.localStorage.getItem(
LOCAL_STORAGE_KEYS.debugActiveDateIntersectionObserver
);
this.emitChange('debugActiveDateIntersectionObserver');
if (debugActiveDateIntersectionObserverFromPersistence === 'true') {
debugActiveDateIntersectionObserver = true;
}
} else {
console.warn(
`Skipping \`${LOCAL_STORAGE_KEYS.debugActiveDateIntersectionObserver}\` read from LocalStorage since LocalStorage is not available`
);
}
this.toggleDebugActiveDateIntersectionObserver(debugActiveDateIntersectionObserver);
}
get debugActiveDateIntersectionObserver() {
@ -32,10 +40,17 @@ class DeveloperOptionsContentViewModel extends ViewModel {
toggleDebugActiveDateIntersectionObserver(checkedValue) {
this._debugActiveDateIntersectionObserver = checkedValue;
window.localStorage.setItem(
LOCAL_STORAGE_KEYS.debugActiveDateIntersectionObserver,
this._debugActiveDateIntersectionObserver
);
if (window.localStorage) {
window.localStorage.setItem(
LOCAL_STORAGE_KEYS.debugActiveDateIntersectionObserver,
this._debugActiveDateIntersectionObserver ? 'true' : 'false'
);
} else {
console.warn(
`Skipping \`${LOCAL_STORAGE_KEYS.debugActiveDateIntersectionObserver}\` write to LocalStorage since LocalStorage is not available`
);
}
this.emitChange('debugActiveDateIntersectionObserver');
}