Link prior art and reasoning why we still always join before (#190)
See https://github.com/matrix-org/matrix-public-archive/issues/50
This commit is contained in:
parent
e20a67d2ba
commit
c297270f39
|
@ -772,7 +772,10 @@ router.get(
|
||||||
//
|
//
|
||||||
// XXX: It would be better if we just tried fetching first and assume that we are
|
// XXX: It would be better if we just tried fetching first and assume that we are
|
||||||
// already joined and only join after we see a 403 Forbidden error (we should do
|
// already joined and only join after we see a 403 Forbidden error (we should do
|
||||||
// this for all places we `ensureRoomJoined`)
|
// this for all places we `ensureRoomJoined`). But we need the `roomId` for use with
|
||||||
|
// the various Matrix API's anyway and `/join/{roomIdOrAlias}` -> `{ room_id }` is a
|
||||||
|
// great way to get it (see
|
||||||
|
// https://github.com/matrix-org/matrix-public-archive/issues/50).
|
||||||
const viaServers = parseViaServersFromUserInput(req.query.via);
|
const viaServers = parseViaServersFromUserInput(req.query.via);
|
||||||
const roomId = await ensureRoomJoined(matrixAccessToken, roomIdOrAlias, viaServers);
|
const roomId = await ensureRoomJoined(matrixAccessToken, roomIdOrAlias, viaServers);
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue