Try and make the seamless pagination test more robust (wait for Synapse to settle) (#281)

Previously was seeing some failures like this locally
```
  1 failing

  1) matrix-viewer
       Matrix Viewer
         Room directory
           pagination is seamless:

      AssertionError [ERR_ASSERTION]: Make sure we saw all visible rooms paginating through the directory
      + expected - actual

         "planet-1689366398300-room-29"
         "planet-1689366398300-room-31"
         "planet-1689366398300-room-32"
         "planet-1689366398300-room-34"
      -  "planet-1689366398300-room-34"
         "planet-1689366398300-room-35"
         "planet-1689366398300-room-37"
         "planet-1689366398300-room-38"
         "planet-1689366398300-room-4"

      at Context.<anonymous> (test/e2e-tests.js:2835:16)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
```
pull/282/head
Eric Eastwood 7 months ago committed by GitHub
parent 5d444d5044
commit f91b8f07f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -2735,10 +2735,13 @@ describe('matrix-viewer', () => {
// doing them serially and the room directory doesn't return the rooms in any
// particular order so it doesn't make the test any more clear doing them
// serially anyway.
let lastCreatedRoomId;
const createdRoomsIds = await Promise.all(
roomsConfigurationsToCreate.map((roomCreateOptions) =>
createTestRoom(client, roomCreateOptions)
)
roomsConfigurationsToCreate.map(async (roomCreateOptions) => {
const roomId = await createTestRoom(client, roomCreateOptions);
lastCreatedRoomId = roomId;
return roomId;
})
);
function roomIdToRoomName(expectedRoomId) {
@ -2822,6 +2825,11 @@ describe('matrix-viewer', () => {
client,
searchTerm: visibleRoomConfigurations[visibleRoomConfigurations.length - 1].name,
});
// Also check for the room that we last saw created as an extra measure
await waitForResultsInHomeserverRoomDirectory({
client,
searchTerm: roomIdToRoomName(lastCreatedRoomId),
});
// Visit a sequence of pages using the pagination links: 1 -> 2 -> 3 -> 2 -> 1
const firstPage = await checkRoomsOnPage(testUrl);

Loading…
Cancel
Save