matrix-public-archive

Author SHA1 Message Date

Author	SHA1	Message	Date
Eric Eastwood	13eb92b067	Make sure we finish sending the HTML payload before we exit the process (#38 ) I encountered a page which responded successfully but all of the Hydrogen HTML was missing. It just had the boilerplate around it. What I am guessing happened is that since `process.send` is async, with a sufficiently large payload and race condition, `process.exit(0)` was being called before it finished sending. Related: - https://stackoverflow.com/questions/34627546/process-send-is-sync-async-on-nix-windows - `56d9584a0e` - https://github.com/nodejs/node/issues/6767	2022-07-06 19:24:29 -05:00
Eric Eastwood	7eaa103a28	Fix large option payloads throwing E2BIG and ENAMETOOLONG (#37 ) Follow-up to https://github.com/matrix-org/matrix-public-archive/pull/36	2022-07-05 18:00:29 -05:00
Eric Eastwood	f738dbc1da	Stop Hydrogen from running in the background after we get our SSR HTML render data (#36 ) We now run the Hydrogen render in a `child_process` so we can exit the whole render process. We still use the `vm` to setup the browser-like globals. With a `vm`, everything continues to run even after it returns and there isn't a way to clean up, stop, kill, terminate the vm script or context so we need this extra `child_process` now to clean up. I don't like the complexity necessary for this though. I wish the `vm` API allowed for this use case. The only way to stop a `vm` is the `timeout` and we want to stop as soon as we return. Fix https://github.com/matrix-org/matrix-public-archive/issues/34	2022-07-05 17:30:52 -05:00

Eric Eastwood

13eb92b067

Make sure we finish sending the HTML payload before we exit the process (#38 )

I encountered a page which responded successfully but all of the Hydrogen HTML was missing. It just had the boilerplate around it.

What I am guessing happened is that since `process.send` is async, with a sufficiently large
payload and race condition, `process.exit(0)` was being called before it finished sending.

Related:
 - https://stackoverflow.com/questions/34627546/process-send-is-sync-async-on-nix-windows
 - 56d9584a0e
 - https://github.com/nodejs/node/issues/6767

2022-07-06 19:24:29 -05:00

Eric Eastwood

7eaa103a28

Fix large option payloads throwing E2BIG and ENAMETOOLONG (#37 )

Follow-up to https://github.com/matrix-org/matrix-public-archive/pull/36

2022-07-05 18:00:29 -05:00

Eric Eastwood

f738dbc1da

Stop Hydrogen from running in the background after we get our SSR HTML render data (#36 )

We now run the Hydrogen render in a `child_process` so we can exit the whole render process. We still use the `vm` to setup the browser-like globals. With a `vm`, everything continues to run even after it returns and there isn't a way to clean up, stop, kill, terminate the vm script or context so we need this extra `child_process` now to clean up. I don't like the complexity necessary for this though. I wish the `vm` API allowed for this use case. The only way to stop a `vm` is the `timeout` and we want to stop as soon as we return.

Fix https://github.com/matrix-org/matrix-public-archive/issues/34

2022-07-05 17:30:52 -05:00

3 Commits