From 4ef0da184d18f15e1a16c34f898483dc50b125d7 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Thu, 27 Aug 2015 22:21:07 +0100 Subject: [PATCH] dns_utils: simplify string handling and fix leak --- src/common/dns_utils.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/common/dns_utils.cpp b/src/common/dns_utils.cpp index d8b3c5308..33e71c79d 100644 --- a/src/common/dns_utils.cpp +++ b/src/common/dns_utils.cpp @@ -301,11 +301,7 @@ std::vector DNSResolver::get_txt_record(const std::string& url, boo { for (size_t i=0; result->data[i] != NULL; i++) { - // plz fix this, but this does NOT work and spills over into parts of memory it shouldn't: records.push_back(result.ptr->data[i]); - char *restxt; - restxt = (char*) calloc(result->len[i]+1, 1); - memcpy(restxt, result->data[i]+1, result->len[i]-1); - records.push_back(restxt); + records.push_back(std::string(result->data[i]+1, result->len[i]-1)); } } }