From 73e8a76d86f75363197d5ae9f384e0606ad47a19 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Sun, 20 Nov 2016 17:25:21 +0000 Subject: [PATCH 1/2] tests: fix uninitialized data valgrind reports in serialization tests --- tests/unit_tests/serialization.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/unit_tests/serialization.cpp b/tests/unit_tests/serialization.cpp index dc7f7cb06..b592f456b 100644 --- a/tests/unit_tests/serialization.cpp +++ b/tests/unit_tests/serialization.cpp @@ -395,7 +395,10 @@ TEST(Serialization, serializes_transacion_signatures_correctly) // Not enough signature vectors for all inputs txin_to_key txin_to_key1; - txin_to_key1.key_offsets.resize(2); + txin_to_key1.amount = 1; + memset(&txin_to_key1.k_image, 0x42, sizeof(crypto::key_image)); + txin_to_key1.key_offsets.push_back(12); + txin_to_key1.key_offsets.push_back(3453); tx.vin.clear(); tx.vin.push_back(txin_to_key1); tx.vin.push_back(txin_to_key1); From ab7b56e0e2d164e7ad2f5579cb5380019ec1d928 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Sun, 20 Nov 2016 17:51:17 +0000 Subject: [PATCH 2/2] tests: fix uninitialized data valgrind reports in levin tests --- tests/unit_tests/epee_levin_protocol_handler_async.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit_tests/epee_levin_protocol_handler_async.cpp b/tests/unit_tests/epee_levin_protocol_handler_async.cpp index ca110eb59..2dd3ffe29 100644 --- a/tests/unit_tests/epee_levin_protocol_handler_async.cpp +++ b/tests/unit_tests/epee_levin_protocol_handler_async.cpp @@ -242,6 +242,7 @@ namespace m_req_head.m_cb = m_in_data.size(); m_req_head.m_have_to_return_data = true; m_req_head.m_command = expected_command; + m_req_head.m_return_code = LEVIN_OK; m_req_head.m_flags = LEVIN_PACKET_REQUEST; m_req_head.m_protocol_version = LEVIN_PROTOCOL_VER_1;