From 8eaf0e189fdd9ae5d338a38e4fec9cdc743f0952 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Thu, 23 Apr 2020 14:39:54 +0000 Subject: [PATCH] epee: fix array underflow in unicode parsing Reported by minerscan Also independently found by OSS-Fuzz just recently --- contrib/epee/include/storages/parserse_base_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/epee/include/storages/parserse_base_utils.h b/contrib/epee/include/storages/parserse_base_utils.h index 2256f6b83..5a6cc0b51 100644 --- a/contrib/epee/include/storages/parserse_base_utils.h +++ b/contrib/epee/include/storages/parserse_base_utils.h @@ -196,7 +196,7 @@ namespace misc_utils uint32_t dst = 0; for (int i = 0; i < 4; ++i) { - const unsigned char tmp = isx[(int)*++it]; + const unsigned char tmp = isx[(unsigned char)*++it]; CHECK_AND_ASSERT_THROW_MES(tmp != 0xff, "Bad Unicode encoding"); dst = dst << 4 | tmp; }