Mirrors
/
monero
mirror of https://github.com/monero-project/monero.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,057 Commits 9 Branches 69 Tags 230 MiB
Commit Graph

6267 Commits

Author SHA1 Message Date
luigi1111 e4f11a68fe
Merge pull request #5819 
07cb087 blockchain: Fix alt chain generated coins overflow (iamamyth)
 2019-09-04 09:37:32 -05:00
luigi1111 902e4b6ebf
Merge pull request #5806 
69465e3 cryptonote_protocol: fix '--no-sync', ignore new blocks and txes (xiphon)
 2019-09-04 09:28:22 -05:00
luigi1111 0198b76217
Merge pull request #5799 
082730b daemon: automatic public nodes discovering and bootstrap daemon switching (xiphon)
 2019-09-04 09:27:02 -05:00
luigi1111 23547e6ed6
Merge pull request #5536 
1a367d6 simplewallet: lock console on inactivity (moneromooo-monero)
 2019-09-04 09:18:38 -05:00
Lev Sizov 4ad191ffa9 Removed unused boost/value_init header 2019-09-02 14:38:29 +02:00
Jesus Ramirez 2cd4fd8972 Changed the use of boost:value_initialized for C++ list initializer 2019-09-02 14:16:29 +02:00
luigi1111 98af2e954b
Merge pull request #5793 
bdfc63a Add ref-counted buffer byte_slice. Currently used for sending TCP data. (vtnerd)
3b24b1d Added support for 'noise' over I1P/Tor to mask Tx transmission. (vtnerd)
 2019-08-29 14:36:41 -05:00
stoffu f380f69c69
simplewallet: warn if invalid default ring size is set and actually ignore the setting 2019-08-29 15:55:53 +09:00
moneromooo-monero 1a367d6a22
simplewallet: lock console on inactivity 2019-08-28 19:01:48 +00:00
moneromooo-monero 495a7e5b97
rpc: don't include an address in mining_status when not mining 
Best case is an address mined previously and it'll get returned,
worst case it was never initialized in the first place
 2019-08-28 16:02:37 +00:00
moneromooo-monero 83ca76435b
wallet_rpc_server: call deinit on exit 2019-08-28 15:59:33 +00:00
moneromooo-monero 1f1fff2679
daemon: print mining algorithm in mining_status even when not mining 2019-08-28 15:55:31 +00:00
moneromooo-monero 21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC 2019-08-28 15:51:28 +00:00
moneromooo-monero 19bfe7e5ab
simplewallet: fix warnings about useless std::move 2019-08-28 15:13:50 +00:00
moneromooo-monero 11f13da8b4
blockchain: fix logging bad number of blocks if first one fails 2019-08-28 14:53:29 +00:00
Tom Smeding 6bbc646e6f Fix bug in mempool get_transaction_stats histogram calculation 
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.

This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
 2019-08-28 16:46:31 +02:00
luigi1111 85014813cf
Merge pull request #5707 
3a0451a MLSAG speedup and additional checks (SarangNoether)
 2019-08-28 02:22:00 -05:00
Sarang Noether 3a0451a8be MLSAG speedup and additional checks 2019-08-27 16:22:44 -04:00
luigi1111 f68512e9e4
Merge pull request #5729 
7c894fc device_ledger: add paranoid buffer overflow check (moneromooo-monero)
f07524b device_ledger: fix uninitialized additional_key (moneromooo-monero)
 2019-08-27 15:19:47 -05:00
luigi1111 8f6f674753
Merge pull request #5609 
1dc3b1a wallet: add --extra-entropy command line flag (moneromooo-monero)
 2019-08-27 15:14:15 -05:00
luigi1111 3e80f44503
Merge pull request #5559 
33e91e1 wallet, rpc: add a release field to get_version (moneromooo-monero)
 2019-08-27 15:09:37 -05:00
xiphon 082730b6e5 daemon: automatic public nodes discovering and bootstrap daemon switching 2019-08-27 12:01:49 +00:00
moneromooo-monero 33e91e1a1e
wallet, rpc: add a release field to get_version 
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
 2019-08-26 19:28:25 +00:00
moneromooo-monero f07524b56b
device_ledger: fix uninitialized additional_key 
Coverity 200185
 2019-08-26 12:50:29 +00:00
moneromooo-monero 7c894fc7fd
device_ledger: add paranoid buffer overflow check 
Coverity 200183
 2019-08-26 12:50:26 +00:00
moneromooo-monero 2cb22d4071
core: make the "update probably needed soon" message less scary 2019-08-26 07:56:55 +00:00
moneromooo-monero c4da1a25c3
wallet2: fix unset_ring tx retrieval checks 2019-08-24 14:46:31 +00:00
moneromooo-monero 87d2f063af
simplewallet: moan harder about untrusted nodes 2019-08-24 12:36:10 +00:00
moneromooo-monero b51f4cdcaf
daemon: add pruned and publicrpc flags to print_pl 2019-08-23 19:15:45 +00:00
moneromooo-monero 894cc81e83
wallet2: fix cold signing losing tx keys 2019-08-23 16:38:20 +00:00
xiphon 063eebbd43 daemon: implement 'set_bootstrap_daemon' command 2019-08-23 12:09:02 +00:00
moneromooo-monero cae488dc9b
p2p: reject incoming connections to self 2019-08-22 17:08:29 +00:00
Tadeas Moravec 63186a01ce
Wallet: Option to export data to ASCII 
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.

Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).

Implements https://github.com/monero-project/monero/issues/2859
 2019-08-22 16:03:22 +02:00
stoffu 50813c103e
ringdb: fix bug in blackballing 2019-08-22 21:34:48 +09:00
stoffu 2425f27acd
blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test 2019-08-22 21:34:47 +09:00
stoffu 9f68669503
blockchain_blackball: add --historical-stat which prints historical stats of spent ratio 2019-08-22 21:34:40 +09:00
moneromooo-monero 1dc3b1a516
wallet: add --extra-entropy command line flag 
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
 2019-08-22 11:12:57 +00:00
luigi1111 cdfa2e58df
Merge pull request #5827 
30779de fix feature not introduced until boost 1.66 (jtgrassie)
 2019-08-21 15:54:10 -05:00
luigi1111 2be47ae02a
Merge pull request #5817 
50ec40e Increase max_dbs from 20 to 32 (hyc)
 2019-08-21 15:49:51 -05:00
luigi1111 7bdff6005f
Merge pull request #5815 
adc16d2 Fix check for disconnecting peers when syncing (jagerman)
 2019-08-21 15:48:09 -05:00
luigi1111 d8244eb39c
Merge pull request #5808 
5a91b83 simplewallet: add a few missing settings help text (stoffu)
ae7bf37 simplewallet: fix arg indexing bug in set_device_name (stoffu)
 2019-08-21 15:41:42 -05:00
luigi1111 0a42fddde4
Merge pull request #5807 
4b1df4e Fix for biased signature nonce (SarangNoether)
 2019-08-21 15:38:35 -05:00
luigi1111 28e0a28b96
Merge pull request #5800 
6ca033d hid_error() could return a null, which causes the program to crash with (TheQuantumPhysicist)
 2019-08-21 15:36:05 -05:00
luigi1111 11ab328ce3
Merge pull request #5778 
8703aa5 MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
 2019-08-21 15:31:11 -05:00
luigi1111 eea0123de4
Merge pull request #5755 
7a3e458 improve tx_sanity_check clarification (vicsn)
 2019-08-21 15:23:58 -05:00
luigi1111 1bd3f1a1fb
Merge pull request #5750 
884df82 wallet: provide original address for outgoing transfers (xiphon)
 2019-08-21 15:20:51 -05:00
luigi1111 de30131abd
Merge pull request #5743 
65f29a8 simplewallet: add restore_height command (tobtoht)
 2019-08-21 15:17:26 -05:00
luigi1111 b488ee8188
Merge pull request #5742 
0d916a6 Fix incorrectly named binding for MMS send_signer_config command (tobtoht)
 2019-08-21 15:13:16 -05:00
luigi1111 9e8179ca84
Merge pull request #5740 
256d286 Minor formatting fix in help set command (tobtoht)
 2019-08-21 15:11:32 -05:00
luigi1111 8956e90c63
Merge pull request #5731 
c393e82 CryptonightR_JIT: fix return value on error (selene-kovri)
 2019-08-21 15:09:48 -05:00
luigi1111 65e937168e
Merge pull request #5722 
8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
 2019-08-21 15:08:10 -05:00
moneromooo-monero e353e3d757
p2p: sanitize peer lists 
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
 2019-08-21 15:54:27 +00:00
moneromooo-monero 2e2653602f
p2p: move log away from global 
It was here while debugging, and I forgot to move it away
 2019-08-21 14:00:43 +00:00
rbrunner7 8703aa59db MMS: Use chans instead of normal addresses for auto-config 2019-08-20 19:55:31 +02:00
xiphon 26f7a26ee3 device: fix ledger requesting secret keys export twice 2019-08-20 16:08:09 +00:00
xiphon 289d21500c rpc: fix unitialized 'core_rpc_server::m_was_bootstrap_ever_used' 2019-08-20 15:08:48 +00:00
moneromooo-monero 5a4c6cc3a8
daemon: fix merge error removing the "never seen before" timestamp check 2019-08-20 12:48:55 +00:00
luigi1111 c9df9d683a
Merge pull request #5696 
fd60d05 daemon: fix print_pl only printing public zone peers (moneromooo-monero)
 2019-08-20 01:50:10 -05:00
Jethro Grassie 30779de39d
fix feature not introduced until boost 1.66 2019-08-20 01:06:59 -04:00
moneromooo-monero fd60d05d5d
daemon: fix print_pl only printing public zone peers 2019-08-19 23:39:51 +00:00
luigi1111 4947f3bdba
Merge pull request #5636 
b712ae0 rpc: work around a GCC 7.4.0 (at least) bug (moneromooo-monero)
 2019-08-19 17:37:37 -05:00
luigi1111 56b98c7003
Merge pull request #5728 
6560bfa rpc: get_block_template add optional extra_nonce (jtgrassie)
 2019-08-19 17:33:08 -05:00
luigi1111 f205d28e96
Merge pull request #5727 
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
 2019-08-19 17:31:39 -05:00
luigi1111 4baec08d5c
Merge pull request #5725 
dc8b7a8 zmq: MacPorts latest fix (jtgrassie)
 2019-08-19 17:29:38 -05:00
luigi1111 1010a6503e
Merge pull request #5721 
c164f90 Remove unnecessary m_check_txin_table, fix const correctness (omartijn)
 2019-08-19 17:25:52 -05:00
luigi1111 1499caf596
Merge pull request #5720 
bcd2da7 miner: fix --bg-mining-enable description (moneromooo-monero)
 2019-08-19 17:18:04 -05:00
luigi1111 2da11baecc
Merge pull request #5718 
c8709fe wallet: do not print log settings when unset (moneromooo-monero)
7b18e83 unit_tests: check return values on test data parsing (moneromooo-monero)
 2019-08-19 17:17:11 -05:00
moneromooo-monero d22dfb7594
blockchain: reject rct signatures in coinbase txes from v12 2019-08-19 16:43:53 +00:00
moneromooo-monero 555dc7c394
core: from v12, require consistent ring size for mixable txes 
We're supposed to have a fixed ring size now

Already checked by MLSAG verification, but here seems more intuitive
 2019-08-19 16:43:53 +00:00
moneromooo-monero 26072f1393
blockchain: forbid v1 coinbase from v12 2019-08-19 16:43:52 +00:00
moneromooo-monero 839fc6256b
reject setting lookahead major or minor to 0 2019-08-19 15:35:12 +00:00
iamamyth 07cb087e5d blockchain: Fix alt chain generated coins overflow 
Apply the overflow logic used for computing already_generated_coins in
the main chain to alternative chains.
 2019-08-18 17:26:58 -07:00
Howard Chu 50ec40ea16
Increase max_dbs from 20 to 32 
We've added a lot of new indices recently, and 20 isn't enough for them plus
new DBs opened during format migrations.
 2019-08-18 17:10:45 +01:00
luigi1111 459beb50d4
Merge pull request #5685 
a604241 simplewallet: don't ask about mining when running a command line (moneromooo-monero)
 2019-08-17 15:27:21 -05:00
luigi1111 12d08dcbf5
Merge pull request #5518 
def703a wallet_api: add multi destination tx support (selsta)
 2019-08-17 15:24:02 -05:00
Jason Rhinelander adc16d2504 Fix check for disconnecting peers when syncing 
The check added here (in #5732/#5733) is supposed to disconnect behind
peers when the current node is syncing, but actually disconnects behind
peers always.

We are syncing when `target > our_height`, but the check here triggers
when `target > remote_height`, which is basically always true when the
preceding `m_core.have_block(hshd.top_id)` check is true.
 2019-08-16 21:16:33 -03:00
selsta def703abec
wallet_api: add multi destination tx support 2019-08-16 16:23:12 +02:00
luigi1111 399a847cfc
Merge pull request #5689 
1db5357 rpc headers fix (malbit)
 2019-08-15 17:29:34 -05:00
luigi1111 017162b5b2
Merge pull request #5682 
3768db2 p2p: add a reference to Cao, Tong et al. for the last_seen changes (moneromooo-monero)
 2019-08-15 17:27:30 -05:00
luigi1111 8a0711f2f2
Merge pull request #5674 
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero)
098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
 2019-08-15 17:22:39 -05:00
luigi1111 6b6593dad9
Merge pull request #5673 
097cca5 wallet_api: catch getTxKey exception (ph4r05)
 2019-08-15 17:21:26 -05:00
luigi1111 1a259a1c70
Merge pull request #5672 
b2bfcab wallet2: fix change subaddress mixup when sending pre rct outputs (moneromooo-monero)
 2019-08-15 17:20:18 -05:00
luigi1111 739b02ef38
Merge pull request #5662 
64fb0f8 device: tx_key caching fixed, store recovered txkey (ph4r05)
 2019-08-15 17:19:12 -05:00
luigi1111 48229234a9
Merge pull request #5659 
6bb2797 daemon: print 128bit diff properly (stoffu)
 2019-08-15 17:17:36 -05:00
luigi1111 c5e926676a
Merge pull request #5656 
8ccc30b Fix --restore-date usage (hyc)
 2019-08-15 17:14:58 -05:00
luigi1111 df064eaa36
Merge pull request #5649 
a182df2 Bans for RPC connections (hyc)
 2019-08-15 17:10:49 -05:00
luigi1111 1167370239
Merge pull request #5637 
69f9420 core: do not complain about low block rate if disconnected (moneromooo-monero)
 2019-08-15 17:09:15 -05:00
Tom Smeding 7b9a420787 Replace std::random_shuffle with std::shuffle 
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.

A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.

[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
 2019-08-15 16:33:15 +02:00
luigi1111 0ba675622f
Merge pull request #5634 
1488109 rpc: fix get_transactions getting v1 txes from the txpool (moneromooo-monero)
 2019-08-14 15:35:24 -05:00
luigi1111 0e986a86d5
Merge pull request #5607 
52cd2fa rpc: implement get_public_nodes command (xiphon)
 2019-08-14 15:34:14 -05:00
luigi1111 564bb1da3a
Merge pull request #5525 
0605406 daemon: sort alt chains by height (moneromooo-monero)
4228ee0  daemon: add optional arguments to alt_chain_info (moneromooo-monero)
880ebfd daemon: add more chain specific info in alt_chain_info (moneromooo-monero)
 2019-08-14 15:31:52 -05:00
luigi1111 2258551ef9
Merge pull request #5487 
df83ed7 consensus: from v12, enforce >= 2 outputs (moneromooo-monero)
 2019-08-14 15:26:55 -05:00
luigi1111 dd3b5ecb98
Merge pull request #5478 
7d9b7fe functional_tests: add validate_address tests (moneromooo-monero)
 2019-08-14 15:23:31 -05:00
luigi1111 e37e263fcd
Merge pull request #4851 
155475d Add IPv6 support (KeeJef/tewinget)
 2019-08-14 15:21:47 -05:00
stoffu ae7bf37ed6
simplewallet: fix arg indexing bug in set_device_name 2019-08-13 18:10:32 +09:00
stoffu 5a91b83cb4
simplewallet: add a few missing settings help text 2019-08-13 17:55:41 +09:00
Sarang Noether 4b1df4e50f Fix for biased signature nonce 2019-08-12 15:58:15 -04:00
xiphon 69465e3d83 cryptonote_protocol: fix '--no-sync', ignore new blocks and txes 2019-08-11 20:56:30 +00:00
TheQuantumPhysicist 6ca033d278 hid_error() could return a null, which causes the program to crash with 
std::logic_error()
 2019-08-09 21:24:48 +02:00
Thomas Winget 155475d971
Add IPv6 support 
new cli options (RPC ones also apply to wallet):
  --p2p-bind-ipv6-address (default = "::")
  --p2p-bind-port-ipv6    (default same as ipv4 port for given nettype)
  --rpc-bind-ipv6-address (default = "::1")

  --p2p-use-ipv6          (default false)
  --rpc-use-ipv6          (default false)

  --p2p-require-ipv4      (default true, if ipv4 bind fails and this is
                           true, will not continue even if ipv6 bind
                           successful)
  --rpc-require-ipv4      (default true, description as above)

ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address.  For those the square
braces can be omitted.
 2019-07-31 20:04:57 -04:00
stoffu 6bb279710c
daemon: print 128bit diff properly 2019-07-30 05:37:38 -07:00
moneromooo-monero 7d9b7fee43
functional_tests: add validate_address tests 2019-07-29 14:29:20 +00:00
Lee Clagett 2a7d91523b Fixed i2p/tor tx flooding bug (white noise disabled) 2019-07-29 12:27:00 +00:00
xiphon 52cd2fa0af rpc: implement get_public_nodes command 2019-07-29 10:51:15 +00:00
Nejcraft 6da3561e2a
Fixed error preventing build of monero-gui 
get_attribute expects 2 values instead of 1
 2019-07-28 16:03:45 +02:00
luigi1111 8adde33e01
Merge pull request #5635 
03aa14e tx_sanity_check: don't print an error when not enough outs to check (monermooo-monero)
 2019-07-24 14:43:00 -05:00
luigi1111 bb37e434fc
Merge pull request #5624 
6b41bd8 Delete more include string.h (wepeng)
 2019-07-24 14:39:40 -05:00
luigi1111 d4d5a4433d
Merge pull request #5623 
b8cfa92 rpc: implement set_bootstrap_daemon method (xiphon)
 2019-07-24 14:38:15 -05:00
luigi1111 61512cf798
Merge pull request #5610 
068fa1c p2p: delay IGP probing on startup (moneromooo-monero)
 2019-07-24 14:35:11 -05:00
luigi1111 5030b8e8aa
Merge pull request #5608 
c820e18 simplewallet: print errors on exceptions creating wallets (moneromooo-monero)
 2019-07-24 14:33:36 -05:00
luigi1111 e05873d873
Merge pull request #5606 
cf8cb68 rpc: use ip address string representation for peer::host field (xiphon)
 2019-07-24 14:31:59 -05:00
luigi1111 c4071a00fb
Merge pull request #5600 
dd58057 Remember RPC version on initial connect (hyc)
 2019-07-24 14:29:10 -05:00
luigi1111 015c1792c0
Merge pull request #5597 
343c0b4 add a command line option to disable ZMQ server (jtgrassie)
 2019-07-24 14:26:59 -05:00
luigi1111 8774555d29
Merge pull request #5595 
2aa1134 daemon: display peer address type in print_cn (moneromooo-monero)
 2019-07-24 14:25:51 -05:00
luigi1111 8ae2681e08
Merge pull request #5594 
f074b6b device: show address on device display (ph4r05)
 2019-07-24 14:24:40 -05:00
luigi1111 c62ba1d08f
Merge pull request #5591 
f17dcde Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT (Doy-lee)
 2019-07-24 14:23:11 -05:00
luigi1111 96cda93a93
Merge pull request #5588 
cd720c7 add cumulative difficulty to diff command (wowario)
 2019-07-24 14:20:12 -05:00
luigi1111 9f746b72e2
Merge pull request #5585 
270a3ae Unused private member m_miner_address (JesusRami)
 2019-07-24 14:19:15 -05:00
luigi1111 e241a6280d
Merge pull request #5582 
fcfcc3a rpc: in/out peers can now return the setting's value (moneromooo-monero)
 2019-07-24 14:18:09 -05:00
luigi1111 8600b3c69d
Merge pull request #5576 
577324a wallet_manager: omit redundant disconnect, drop unused variable (xiphon)
 2019-07-24 14:16:00 -05:00
luigi1111 f1427568dc
Merge pull request #5574 
162c3e1 blockchain_export: allow exporting blocks.dat format from pruned (moneromooo-monero)
 2019-07-24 14:14:35 -05:00
luigi1111 5cecf4138b
Merge pull request #5573 
c07bbd5 daemon: fix 'never seen before' time span display for peers (moneromooo-monero)
 2019-07-24 14:13:33 -05:00
luigi1111 b333513db7
Merge pull request #5534 
4c66614 expose set/get walletcache attribute functionality in wallet api (selsta)
 2019-07-24 14:09:58 -05:00
luigi1111 e579fe4ae0
Merge pull request #5530 
6abaaaa remove obsolete save_graph skeleton code (moneromooo-monero)
 2019-07-24 14:07:29 -05:00
luigi1111 4b76656f5c
Merge pull request #5524 
06b8f29 blockchain: keep alternative blocks in LMDB (moneromooo-monero)
 2019-07-24 14:04:16 -05:00
luigi1111 7138f9d347
Merge pull request #5514 
e4d100b wallet2: don't wait a day before using new version fees (moneromooo-monero)
 2019-07-24 14:00:54 -05:00
luigi1111 407683a38c
Merge pull request #5513 
bc94ba4 wallet: distinguish between empty and absent attributes (moneromooo-monero)
 2019-07-24 13:59:19 -05:00
luigi1111 e3de4aa68b
Merge pull request #5502 
25a7cfd add a few checks where it seems appropriate (moneromooo-monero)
1a66a86 remove unused code (moneromooo-monero)
 2019-07-24 13:57:06 -05:00
luigi1111 d433abfe01
Merge pull request #5460 
a23dbe6 simplewallet: prompt when spending more than one old out in one tx (moneromooo-monero)
 2019-07-24 13:52:29 -05:00
luigi1111 705fbcfda4
Merge pull request #5457 
3b9ce45 wallet_rpc_server: remove unused variable (moneromooo-monero)
 2019-07-24 13:51:18 -05:00
luigi1111 e8da2f35ad
Merge pull request #5451 
6aa3c2f dns_checks: new helper program to check on DNSSEC lookups (moneromooo-monero)
 2019-07-24 13:49:57 -05:00
luigi1111 1880c1a582
Merge pull request #5363 
515ac29 p2p: store network address directly in blocked host list (moneromooo-monero)
65c4004 allow blocking whole subnets (moneromooo-monero)
 2019-07-24 13:47:41 -05:00
Lee Clagett f91a06c6d7 Dropping cppzmq dependency; adding some zmq utils 2019-07-22 06:37:16 +00:00
Riccardo Spagni de970334f5
bump version to 0.14.1.2 2019-07-18 16:57:30 +02:00
Riccardo Spagni 4850520b6a
update checkpoints.dat hash 2019-07-18 16:54:43 +02:00
Riccardo Spagni a69dc81844
prep for 0.14.1.1 2019-07-17 22:25:53 +02:00
Riccardo Spagni 8eb075e789
Merge pull request #5732 
a96c1a46 cryptonote_protocol: drop peers we can't download from when syncing (moneromooo-monero)
ab361df2 p2p: add a few missing connection close calls (moneromooo-monero)
 2019-07-17 21:18:20 +02:00
Lee Clagett 3b24b1d082 Added support for "noise" over I1P/Tor to mask Tx transmission. 2019-07-17 14:22:37 +00:00
moneromooo-monero 65c4004963
allow blocking whole subnets 2019-07-16 11:35:53 +00:00
moneromooo-monero 515ac2951d
p2p: store network address directly in blocked host list 
rather than their string representation
 2019-07-16 11:35:52 +00:00
vicsn 7a3e458881 improve tx_sanity_check clarification 2019-07-15 15:19:14 +02:00
Doyle f17dcde451 Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT 2019-07-15 13:27:06 +10:00
luigi1111 fd3ff74164
Merge pull request #5746 
3140a37 wallet_rpc_server: fix get_bulk_payments with short payment ids (moneromooo-monero)
 2019-07-12 20:28:15 -05:00
luigi1111 309f2def9e
Merge pull request #5738 
4ee095c p2p: don't connect to more than one IP per class B if we can (moneromooo-monero)
 2019-07-12 20:26:43 -05:00
luigi1111 e4e8954c04
Merge pull request #5724 
c223832 keccak: guard against misaligned memory accesses on ARM (moneromooo-monero)
 2019-07-12 20:23:08 -05:00
xiphon 884df82db3 wallet: provide original address for outgoing transfers 2019-07-10 13:39:18 +00:00
moneromooo-monero 3140a378da
wallet_rpc_server: fix get_bulk_payments with short payment ids 2019-07-09 14:39:44 +00:00
thotbot 65f29a83c8 simplewallet: add restore_height command 2019-07-08 13:51:50 +00:00
tobtoht 0d916a667c
Fix incorrectly named binding for MMS send_signer_config command 
send_message_config isn't used anywhere else in the code, and it is clear from the help command that it should be named send_signer_config.
 2019-07-08 09:53:07 +00:00
tobtoht 256d286215
Minor formatting fix in help set command 2019-07-06 10:12:32 +00:00
moneromooo-monero 4ee095c200
p2p: don't connect to more than one IP per class B if we can 2019-07-05 18:25:52 +00:00
moneromooo-monero c2238327d0
keccak: guard against misaligned memory accesses on ARM 
The code generated is exactly the same as the direct access
one on x86_64
 2019-07-04 22:13:16 +00:00
moneromooo-monero a96c1a46d4
cryptonote_protocol: drop peers we can't download from when syncing 
Any peer that's behind us while syncing is useless to us (though
not to them). This ensures that we don't get our peer slots filled
with peers that we can't use. Once we've synced, we can connect
to them and they can then sync off us if they want.
 2019-07-04 21:56:10 +00:00
moneromooo-monero ab361df2cd
p2p: add a few missing connection close calls 2019-07-04 21:56:10 +00:00
luigi1111 9d7107c870
Merge pull request #5663 
5d6b43b core: fix --prune-blockchain not pruning if no blockchain exists (moneromooo-monero)
 2019-07-04 14:46:37 -05:00
luigi1111 59ba0eee69
Merge pull request #5650 
3c071d2 blockchain: silence an error getting blocks for pruned nodes (moneromooo-monero)
 2019-07-04 14:44:05 -05:00
luigi1111 591c72613b
Merge pull request #5647 
2ff99fb db_lmdb: commit pruning txn at checkpoints (moneromooo-monero)
 2019-07-04 14:41:36 -05:00
selene c393e824d6 CryptonightR_JIT: fix return value on error 
The value was positive rather than zero, but the caller only
checks for negative errors
 2019-07-04 12:49:54 +01:00
Martijn Otto c164f9037e
Remove unnecessary m_check_txin_table, fix const correctness 2019-07-03 14:39:52 +02:00
Jethro Grassie 6560bfa64c
rpc: get_block_template add optional extra_nonce 
Circumvents the need to create a new blockhashing blob when you already
know the data you want to set in the extra_nonce (so use this instead of
reserve_size).
 2019-07-03 07:57:36 -04:00
moneromooo-monero 8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images 2019-07-02 19:42:28 +00:00
moneromooo-monero bcd2da76cd
miner: fix --bg-mining-enable description 2019-07-02 17:43:36 +00:00
Jethro Grassie dc8b7a88bd
zmq: MacPorts latest fix 2019-07-01 23:13:55 -04:00
moneromooo-monero c8709fe52f
wallet: do not print log settings when unset 
Coverity 199721
 2019-07-01 15:17:30 +00:00
luigi1111 633f14b976
Merge pull request #5681 
037f94c Remove Xiala.net from the list of dns resolvers (tobtoht)
 2019-07-01 01:12:23 -05:00
luigi1111 2db997828a
Merge pull request #5678 
15c699f rpc: set sanity_check_failed to false when successful (stoffu)
 2019-07-01 00:22:07 -05:00
luigi1111 393c33f86c
Merge pull request #5675 
da3e20e tx_sanity_check: relax the median check a lot (moneromooo-monero)
 2019-07-01 00:18:40 -05:00
moneromooo-monero 4237707d3e
p2p: don't forget pruning seed or public RPC port when updating peers 
Older nodes don't pass that information around
 2019-06-26 10:20:19 +00:00
Michal vel m@lbit 1db5357c7b rpc headers fix 2019-06-25 01:49:04 +01:00
moneromooo-monero a604241ef6
simplewallet: don't ask about mining when running a command line 
This is likely to be done via a script
 2019-06-22 10:50:20 +00:00
moneromooo-monero 3768db227c
p2p: add a reference to Cao, Tong et al. for the last_seen changes 
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
 2019-06-21 10:34:33 +00:00
tobtoht 037f94c54e
Remove Xiala.net from the list of dns resolvers 
It is down permanently. See: https://xiala.net/
"Ende November 2018 werden alle Dienste von xiala.net abgeschaltet."
 2019-06-21 09:40:10 +00:00
stoffu 15c699f0a6
rpc: set sanity_check_failed to false when successful 2019-06-20 14:32:49 +09:00
moneromooo-monero da3e20ee01
tx_sanity_check: relax the median check a lot 
we don't want to prevent bona fide txes, just obvious bad ones
 2019-06-19 23:31:38 +00:00
moneromooo-monero 098aadf084
p2p: close the right number of connections on setting max in/out peers 2019-06-19 11:49:36 +00:00
moneromooo-monero fcbf7b3f74
p2p: propagate out peers limit to payload handler 2019-06-19 11:49:36 +00:00
Dusan Klinec 097cca59c1
wallet_api: catch getTxKey exception 
- getTxKey method throws an exception, e.g., when user declines txKey export
 2019-06-19 12:09:49 +02:00
moneromooo-monero b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs 2019-06-19 09:39:16 +00:00
moneromooo-monero 5d6b43b672
core: fix --prune-blockchain not pruning if no blockchain exists 2019-06-17 16:26:43 +00:00
Dusan Klinec f074b6b571
device: show address on device display 
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
  - address device [<index>]
  - address new <label>  // shows address on device also
  - integrated_address [device] <payment_id|address>  // new optional "device" arg to display also on the device
 2019-06-17 16:49:04 +02:00
Dusan Klinec 64fb0f872a
device: tx_key caching fixed, store recovered txkey 2019-06-17 14:53:39 +02:00
Howard Chu 8ccc30b163
Fix --restore-date usage 
The wallet was ignoring --restore-height and --restore-date params and
prompting for them again.
 2019-06-16 21:11:33 +01:00
moneromooo-monero 3c071d203f
blockchain: silence an error getting blocks for pruned nodes 
This happens often when a pre-pruning node asks a pruned node
for data it does not have
 2019-06-16 11:03:41 +00:00
Howard Chu a182df21d0
Bans for RPC connections 
Make bans control RPC sessions too. And auto-ban some bad requests.
Drops HTTP connections whenever response code is 500.
 2019-06-16 11:38:08 +01:00
moneromooo-monero 2ff99fb47f
db_lmdb: commit pruning txn at checkpoints 
to avoid errors when the txn is too large
 2019-06-15 09:50:54 +00:00
Riccardo Spagni 6335509727
Merge pull request #5641 
633f1542 prep for 0.14.1 release (Riccardo Spagni)
 2019-06-14 16:20:02 +02:00
Riccardo Spagni 633f1542e2
prep for 0.14.1 release 2019-06-14 16:16:52 +02:00
moneromooo-monero 2eef90d6ef
rpc: restrict the recent cutoff size in restricted RPC mode 2019-06-14 08:47:33 +00:00
moneromooo-monero 0564da5fdc
ensure no NULL is passed to memcpy 
NULL is valid when size is 0, but memcpy uses nonnull attributes,
so let's not poke the bear
 2019-06-14 08:47:29 +00:00
moneromooo-monero 1387549e90
serialization: check stream good flag at the end 
just in case
 2019-06-14 08:47:23 +00:00
moneromooo-monero a00cabd4f3
tree-hash: allocate variable memory on heap, not stack 
Large amounts might run out of stack

Reported by guidov
 2019-06-14 08:47:20 +00:00
moneromooo-monero f215219252
cryptonote: throw on tx hash calculation error 2019-06-14 08:47:17 +00:00
moneromooo-monero db2b9fba65
serialization: fail on read_varint error 2019-06-14 08:47:14 +00:00
moneromooo-monero 68ad548193
cryptonote_protocol: fix another potential P2P DoS 
When asking for txes in a fluffy transaction, one might ask
for the same (large) tx many times
 2019-06-14 08:47:11 +00:00
moneromooo-monero 1cc61018e5
cryptonote_protocol: expand basic DoS protection 
Count transactions as well
 2019-06-14 08:47:08 +00:00
anonimal 8f66b7053a
cryptonote_protocol_handler: prevent potential DoS 
Essentially, one can send such a large amount of IDs that core exhausts
all free memory. This issue can theoretically be exploited using very
large CN blockchains, such as Monero.

This is a partial fix. Thanks and credit given to CryptoNote author
'cryptozoidberg' for collaboration and the fix. Also thanks to
'moneromooo'. Referencing HackerOne report #506595.
 2019-06-14 08:47:05 +00:00
moneromooo-monero 69f9420489
core: do not complain about low block rate if disconnected 
In that case, we'll still keep the "Monero is now disconnected
from the network" near the end of the log
 2019-06-13 10:25:30 +00:00
moneromooo-monero b712ae0af2
rpc: work around a GCC 7.4.0 (at least) bug 
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’:
cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 2019-06-12 22:27:07 +00:00
moneromooo-monero 03aa14ec87
tx_sanity_check: don't print an error when not enough outs to check 2019-06-12 12:06:14 +00:00
moneromooo-monero 14881094af
rpc: fix get_transactions getting v1 txes from the txpool 
It would try to get their prunable hash, but v1 txes don't have one
 2019-06-12 11:59:13 +00:00
luigi1111 fd0cf689dd
Merge pull request #5619 
f2f207d miner: fix double free of thread attributes (ston1th)
 2019-06-11 18:17:11 -05:00
Your Name 6b41bd8eb5 Delete more include string.h 2019-06-11 16:08:42 +08:00
xiphon b8cfa92b7e rpc: implement set_bootstrap_daemon method 2019-06-10 21:10:08 +00:00
moneromooo-monero 35c20c4332
Fix GCC 9.1 build warnings 
GCC wants operator= aand copy ctor to be both defined, or neither
 2019-06-09 09:39:18 +00:00
ston1th f2f207d635 miner: fix double free of thread attributes 
issue: #5568
 2019-06-09 10:51:18 +02:00
moneromooo-monero 2cbe75661c
p2p: fix GCC 9.1 crash 2019-06-08 17:52:53 +00:00
moneromooo-monero 068fa1ca5c
p2p: delay IGP probing on startup 
We might have external access without having to do this
 2019-06-06 10:33:02 +00:00
moneromooo-monero c820e1839f
simplewallet: print errors on exceptions creating wallets 
Exceptions would otherwise terminate the process silently
 2019-06-06 09:49:47 +00:00
xiphon cf8cb6873a rpc: use ip address string representation for peer::host field 2019-06-04 19:33:35 +00:00
Howard Chu dd58057126
Remember RPC version on initial connect 
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
 2019-06-02 09:31:50 +01:00
Riccardo Spagni 62d32e955a
Merge pull request #5577 
f950517a core: update pruning if using --prune-blockchain on a pruned blockchain (moneromooo-monero)
 2019-06-01 20:25:19 +02:00
Riccardo Spagni 7e417dd408
Merge pull request #5571 
35da33be blockchain: do not try to pop blocks down to the genesis block (moneromooo-monero)
4b51f9a3 core: do not commit half constructed batch db txn (moneromooo-monero)
 2019-06-01 20:22:19 +02:00
Riccardo Spagni 14d3295649
Merge pull request #5561 
9bfa4c20 Fix allow any cert mode in wallet rpc when configured over rpc (Lee Clagett)
3544596f Add ssl_options support to monerod's rpc mode. (Lee Clagett)
c9aaccf3 Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. (Lee Clagett)
 2019-06-01 20:21:45 +02:00
Riccardo Spagni fccfc1aa25
Merge pull request #5555 
b6830db2 Fix #5553 (Howard Chu)
 2019-06-01 20:20:39 +02:00
Jethro Grassie 343c0b4255
add a command line option to disable ZMQ server 2019-06-01 13:03:37 -04:00
moneromooo-monero 880ebfdeea
daemon: add more chain specific info in alt_chain_info 2019-06-01 15:43:52 +00:00
moneromooo-monero 2aa11341fc
daemon: display peer address type in print_cn 2019-05-31 09:10:05 +00:00
moneromooo-monero fcfcc3ac86
rpc: in/out peers can now return the setting's value 2019-05-30 12:13:31 +00:00
wowario cd720c7e0b
add cumulative difficulty to diff command 2019-05-30 11:57:21 +03:00
Jesus Ramirez 270a3ae58b Unused private member m_miner_address 2019-05-29 10:12:47 -04:00
moneromooo-monero f950517a08
core: update pruning if using --prune-blockchain on a pruned blockchain 
Avoids a massive amount of spurious warnings if the last update before
the daemon exited was a while ago and the daemon was syncing
 2019-05-28 09:12:11 +00:00
xiphon 577324a954 wallet_manager: omit redundant disconnect, drop unused variable 2019-05-27 14:40:29 +00:00
moneromooo-monero 35da33bea9
blockchain: do not try to pop blocks down to the genesis block 2019-05-26 17:11:32 +00:00
moneromooo-monero 4b51f9a34f
core: do not commit half constructed batch db txn 2019-05-25 16:24:56 +00:00
moneromooo-monero 162c3e18ec
blockchain_export: allow exporting blocks.dat format from pruned 
We don't need any of the pruned data for this
 2019-05-24 14:12:45 +00:00
moneromooo-monero c07bbd5c04
daemon: fix "never seen before" time span display for peers 2019-05-24 10:47:36 +00:00
Lee Clagett 9bfa4c20ca Fix allow any cert mode in wallet rpc when configured over rpc 2019-05-22 00:15:14 -04:00
Lee Clagett 3544596f9f Add ssl_options support to monerod's rpc mode. 2019-05-22 00:09:11 -04:00
Lee Clagett c9aaccf346 Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. 2019-05-21 15:43:27 -04:00
Howard Chu b6830db2d4
Fix #5553 
Make sure the tip hash still matches the cached block
 2019-05-19 03:02:33 +01:00
moneromooo-monero 915f59e3c0
wallet: add unlock_time details to show_transfers 
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
 2019-05-16 21:37:05 +00:00
Riccardo Spagni e8487fa46b
Merge pull request #5539 
3f612cda Changed odd bullet point to low level header (Rohaq)
af9bc4ec Used subeaders to avoid slightly wonky looking formatting (Rohaq)
1873af35 Made code block usage consistent across all .md files (Rohaq)
68103075 Updated Copyright notice (Rohaq)
39bd157f Added Table of Contents to main README.md (Rohaq)
 2019-05-15 16:10:41 +02:00
Riccardo Spagni 5e80b3c3ef
Merge pull request #5535 
e1016bce password: do not use line input on windows (moneromooo-monero)
 2019-05-15 16:06:58 +02:00
luigi1111 1607419e38
Merge pull request #5538 
615f287 wallet: fix certificate fingerprint length check (moneromooo-monero)
 2019-05-14 16:02:59 -05:00
luigi1111 eedf5106f5
Merge pull request #5532 
46244dd wallet_rpc_server: use original addresses in destinations in get_transfers (moneromooo-monero)
 2019-05-14 15:59:34 -05:00
luigi1111 5a67ff2b32
Merge pull request #5526 
1e8f3f6 rpc: fail update RPC when running offline (moneromooo-monero)
 2019-05-14 15:54:10 -05:00
luigi1111 266f68be32
Merge pull request #5512 
d47292e error: fix compile error on windows with depends (moneromooo-monero)
 2019-05-14 15:51:14 -05:00
Rohaq 1873af35bf Made code block usage consistent across all .md files 2019-05-12 05:16:26 +01:00
moneromooo-monero 615f287aec
wallet: fix certificate fingerprint length check 
Fixed by crCr62U0
 2019-05-11 13:05:06 +00:00
moneromooo-monero e1016bce14
password: do not use line input on windows 
This keeps its builtin command editing away

Thanks iDunk for testing on Windows
 2019-05-10 18:56:50 +00:00
dsc 4c666141e3 expose set/get walletcache attribute functionality in wallet api 2019-05-10 19:24:45 +02:00
moneromooo-monero 46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers 
And add them for pending transfers, where they were missing
 2019-05-10 14:44:13 +00:00
moneromooo-monero 6abaaaa994
remove obsolete save_graph skeleton code 2019-05-10 14:17:18 +00:00
moneromooo-monero 1e8f3f66bf
rpc: fail update RPC when running offline 2019-05-09 19:14:49 +00:00
moneromooo-monero 4228ee0b9e
daemon: add optional arguments to alt_chain_info 
>N limits display to alt chains with more than N blocks
-N limits display to alt chains younger than N blocks
 2019-05-09 09:13:11 +00:00
moneromooo-monero 0605406714
daemon: sort alt chains by height 2019-05-09 09:12:49 +00:00
moneromooo-monero 06b8f29992
blockchain: keep alternative blocks in LMDB 
Alternative blocks are cleared on startup unless --keep-alt-blocks
is passed on the command line
 2019-05-08 17:36:52 +00:00
Riccardo Spagni f64f59627d
Merge pull request #5510 
e9809382 fix wide difficulty conversion with some versions of boost (moneromooo-monero)
 2019-05-07 17:36:27 +02:00
Riccardo Spagni 97cb1c9436
Merge pull request #5508 
1c44e658 wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
 2019-05-07 17:35:28 +02:00
Riccardo Spagni a22a8b0f2b
Merge pull request #5505 
7e5158aa mnemonics: fix 4 byte UTF-8 rewriting (moneromooo-monero)
 2019-05-07 17:34:53 +02:00