fde7c96b5c
wallet2: fix spurious reorg detection with untrusted nodes
...
When forced to deal with an untrusted node, a wallet will quantize
its current height to disguise the real height to the adversary, to
try and minimize the daemon's ability to distinguish returning
wallets.
Daemons will thus return more blocks than the wallet needs, starting
from earlier in the chain. These extra blocks will be disregarded
by the wallet, which had already scanned them.
However, for the purposes of reorg size detection, the wallet assumes
all blocks the daemon sends are different, which is only correct if
the wallet hasn't been coy, which is only the case for trusted
daemons (which you should use). This causes an issue when the size
of this "fake reorg" is above the sanity check threshold at which
the wallet refuses a reorg.
To fix this, the reorg size check is moved later on, when the reorg
is about to actually happen, after the wallet has checked which
blocks are actually different from the ones it expects.
2022-05-15 11:57:37 +00:00
df2e680825
wallet2: speedup large tx construction: reserve vector memory
...
2.8 seconds -> 2.6 seconds on a test case
2022-05-13 17:43:22 +00:00
38cdf01c64
wallet2: speedup large tx construction: batch ringdb lookups
...
3.3 seconds -> 2.8 seconds on a test case
2022-05-13 17:43:22 +00:00
353cd5355e
wallet2: speedup large tx construction: no pointless clsag generation
...
4.1 seconds -> 3.3 seconds on a test case
2022-05-13 17:43:21 +00:00
2b95178897
wallet2: speedup large tx construction: batch ringdb updates
...
5.2 seconds -> 4.1 seconds on a test case
2022-05-13 17:43:20 +00:00
c9cf0b78f8
wallet2: speedup large tx construction: cache public key validity
...
5.9 second -> 5.2 seconds on a test case
2022-05-13 17:43:16 +00:00
b9d2c788bc
fix backoff delay logic when re-relaying txs
2022-05-12 08:39:51 -07:00
bae4a1ad8f
Don't send peerlist larger than max allowed
2022-05-11 18:41:24 -07:00
8349cfe4a6
Merge pull request #8321
...
7d6c748
2022-05-10 16:57:53 -05:00
d58ea37a8d
Merge pull request #8302
...
41da2fe
2022-05-10 16:56:39 -05:00
8480575cec
Merge pull request #8300
...
070e41d
2022-05-10 16:53:48 -05:00
fbd1f1e476
Merge pull request #8293
...
4f08bcd
2022-05-10 16:51:59 -05:00
436ca13722
Merge pull request #8277
...
baee2c0
2022-05-10 16:49:13 -05:00
156151396e
Merge pull request #8262
...
268a039
2022-05-10 16:47:13 -05:00
c1625a8928
Merge pull request #8220
...
0d6ecb1
2022-05-10 16:41:02 -05:00
7d6c7489a7
Set hf v15 testnet fork heights
2022-05-09 14:38:54 -07:00
1ddb1ee819
Give better error messages when missing SSL files
...
While copying my data dir to another drive, I missed copying the rpc_ssl.key file b/c of the file permissions.
This change will give a much more clear, descriptive error in that scenario.
2022-05-05 21:48:19 -05:00
f63f7dc7e2
wallet2: fix a couple unused variable warnings
2022-05-02 21:28:40 +02:00
b7978cfd4e
Remove src/serialization/list.h
...
Unused ;)
Also a comment from serialization.h
2022-05-02 12:08:05 -05:00
0d6ecb1136
multisig: add post-kex verification round to check that all participants have completed the multisig address
2022-04-29 14:04:59 -05:00
41da2fe6f3
Update copyright to 2022 for Hardfork files
...
Update Makefile and LICENSE
2022-04-29 11:12:36 +02:00
070e41d88b
Change "Github" to "GitHub"
2022-04-27 18:53:03 +01:00
4f08bcd800
refactor(bp+): save one inversion, use sc_muladd
2022-04-26 13:37:11 +02:00
67e5ca9ad6
Merge pull request #8275
...
9209880
2022-04-25 10:22:03 -05:00
a092b943d5
Merge pull request #8249
...
a14fdf8
2022-04-25 10:20:10 -05:00
e13244ea9c
Merge pull request #8178
...
5d388eb
2022-04-25 10:18:26 -05:00
baee2c06ec
Preserve commitment format inside transactions
2022-04-21 18:58:47 -04:00
9209880e9c
add a sanity check to RPC input data size
...
reported by m31007
2022-04-21 22:22:56 +00:00
9f814edbd7
Merge pull request #8254
...
9df7179
2022-04-19 22:21:21 -05:00
4abbf442b4
Merge pull request #8245
...
3593a98
2022-04-19 22:18:42 -05:00
8ddbe18277
Merge pull request #8232
...
0f7b20a
2022-04-19 22:15:10 -05:00
96758a7d05
Merge pull request #8061
...
ea87b30
2022-04-19 22:14:03 -05:00
5d388eb74d
Bump ring size to 16 for v15 & remove set default in wallet cli
2022-04-18 14:36:28 -07:00
11371425f5
"Change C-cast to static_cast in net_peerlist.h"
...
Thanks @mj-xmr: https://github.com/monero-project/monero/pull/8211#discussion_r823870855
2022-04-18 09:55:21 -05:00
1f25aa27c5
Factor out move_it_backward from misc_language.h
...
Relevant commit from old PR:
330df2952c
2022-04-18 09:55:21 -05:00
7764d69782
Move copyable_atomic into connection_context
...
Relevant commit from old PR:
bd0a511995
2022-04-18 09:55:21 -05:00
441c860738
Merge functionality of misc_os_dependent into time_helper.h
...
Actions:
1. Remove unused functions from misc_os_dependent.h
2. Move three remaining functions, get_gmt_time, get_ns_count, and get_tick_count into time_helper.h
3. Remove unused functions from time_helper.h
4. Refactor get_ns_count and get_internet_time_str and get_time_interval_string
5. Remove/add includes as needed
Relevant commits on the old PR:
a9fbe52b029a59b131c47fa9e2817d
2022-04-18 09:55:21 -05:00
40f02f9d73
Add Include statements
2022-04-18 09:55:20 -05:00
12b1b74d32
Trimming Fat
...
Remove unused include statements or unused definitions.
2022-04-18 09:55:20 -05:00
690ce560b0
Boring Old Deletes
...
Here lies dozens of unused files. This commit is ONLY file deletions except
for the removing of a couple of #includes and removing filenames from CmakeLists
where appropriate.
2022-04-18 09:55:20 -05:00
268a0393e9
Optimized keccak implementation
...
All tests were conducted on the same PC (Ryzen 5 5600X running at fixed 4.65 GHz).
Before:
test_cn_fast_hash<32> (100000 calls) - OK: 1 us/call
test_cn_fast_hash<16384> (1000 calls) - OK: 164 us/call
After:
test_cn_fast_hash<32> (100000 calls) - OK: 0 us/call
test_cn_fast_hash<16384> (1000 calls) - OK: 31 us/call
More than 5 times speedup for cn_fast_hash.
Also noticed consistent 1-2% improvement in test_construct_tx results.
2022-04-18 10:01:13 +02:00
ea87b30f89
Add view tags to outputs to reduce wallet scanning time
...
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73
At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
2022-04-18 00:49:53 -07:00
6694597974
Merge pull request #8207
...
4db6aed
2022-04-18 02:14:04 -05:00
9df7179aaf
wallet2: use BP+ for cold signing
...
reported by ukoehb
2022-04-10 21:03:09 +00:00
b030f20751
Fee changes from ArticMine
...
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf
with a change to use 1.7 instead of 2.0 for the max long term increase rate
2022-04-10 18:13:34 +00:00
a14fdf8d5a
Remove /include
...
* `IWallet.h` hasn't been touched since 2014, and has been replaced by `src/wallet/api/wallet2_api.h`
* `INode.h` is in a similar situation with `src/p2p/net_node.h`
2022-04-09 23:47:02 -05:00
3593a986d8
simplewallet: fix integrated_address output string
2022-04-08 16:20:37 +02:00
4db6aed98c
CMake: Add missing headers via monero_find_all_headers macro
2022-04-06 08:12:44 +02:00
bb093ec9a8
Merge pull request #8223
...
17772ef#8223 (Jeffrey)
2022-04-06 00:19:59 -04:00
f096ac1349
Merge pull request #8215
...
d1f1947
2022-04-06 00:16:20 -04:00
9a124f6811
Merge pull request #8213
...
7dcfccb
2022-04-06 00:15:40 -04:00
627f04c19a
Merge pull request #8212
...
591c174
2022-04-06 00:14:44 -04:00
04e490c8da
Merge pull request #8205
...
0d6fce8
2022-04-06 00:11:14 -04:00
0eb1b570b6
Merge pull request #8197
...
da9aa1f
2022-04-06 00:08:53 -04:00
88a5606795
Merge pull request #8195
...
3c82958
2022-04-06 00:07:36 -04:00
ffe439d38a
Merge pull request #8180
...
3f88fdd
2022-04-06 00:06:58 -04:00
0285c07d7d
Merge pull request #8179
...
ae0a840
2022-04-06 00:06:20 -04:00
922acb05fd
Merge pull request #8053
...
cf44349
2022-04-06 00:03:41 -04:00
50410d1f7d
Merge pull request #7937
...
83bb027
2022-04-06 00:02:47 -04:00
d054def63f
Merge pull request #7170
...
bd27debb7713ccb535d66a0d80b175bd004a3450604c94cfe5acdd0e
2022-04-05 23:56:09 -04:00
fb2f822c52
Merge pull request #7153
...
354e1d9
2022-04-05 23:48:18 -04:00
83bb02745a
Make RPC server functions that read db thread safe
...
- grab an lmdb db_rtxn_guard to ensure consistent data from the db
- fixed on_getblockhash error resp when requested height >= blockchain height
- left functions that read shared memory untouched for now
2022-04-05 20:20:12 -07:00
5acdd0e2cb
bulletproofs+: some minor cleanup from vtnerd's review
2022-04-05 18:50:23 +00:00
4c94cfecfc
store outPk/8 in the tx for speed
...
It avoids dividing by 8 when deserializing a tx, which is a slow
operation, and multiplies by 8 when verifying and extracing the
amount, which is much faster as well as less frequent
2022-04-05 18:50:22 +00:00
a345060ace
ringct: port some of vtnerd's review changes from BP+ to BP
2022-04-05 18:50:21 +00:00
75bd004f4e
ringct: a few minor optimizations from review
2022-04-05 18:50:21 +00:00
a0d80b1f95
plug bulletproofs plus into consensus
2022-04-05 18:50:17 +00:00
b535d662b9
Updates from security audit
...
https://suyash67.github.io/homepage/assets/pdfs/bulletproofs_plus_audit_report_v1.1.pdf
2022-04-04 08:23:21 +00:00
b7713cce26
Precompute initial transcript hash
2022-04-04 08:23:21 +00:00
bd27debb2d
Bulletproofs+
2022-04-04 08:23:21 +00:00
0f7b20a1ce
Added support for Ledger Nano S Plus
2022-03-31 18:25:09 +02:00
17772ef53e
Eliminate dependence on boost::interprocess #8223
...
In this repo, `boost::interprocess` was being used soley to make `uint32_t` operations atomic. So I replaced each instance of
`boost::interprocess::ipcdetail::atomic(...)32` with `std::atomic` methods. I replaced member declarations as applicable. For example,
when I needed to change a `volatile uint32_t` into a `std::atomic<uint32_t>`. Sometimes, a member was being used a boolean flag, so
I replaced it with `std::atomic<bool>`.
You may notice that I didn't touch `levin_client_async.h`. That is because this file is entirely unused and will be deleted in PR monero-project#8211.
Additional changes from review:
* Make some local variables const
* Change postfix operators to prefix operators where value was not need
2022-03-30 13:18:32 -05:00
ae0a840fda
wallet2: decrease the amount of data exchanged for output export
2022-03-29 08:40:32 +00:00
70ceab6c10
Merge pull request #8216
...
f22051d
2022-03-18 16:34:16 -05:00
427bd85893
Merge pull request #8187
...
9bde2db#8168 (Jeffrey)
2022-03-18 16:32:25 -05:00
0ea8519895
Merge pull request #8169
...
5e201fe
2022-03-18 16:30:00 -05:00
d9e6baac42
Merge pull request #8158
...
e5000a9
2022-03-18 16:28:16 -05:00
d1f1947995
wallet_rpc_server: support regex for get_accounts tag
...
This commit adds a 'regexp' boolean field to the get_accounts
request. The flag is set to false by default and maintains backwards
compatibility. When set to true the user can search tags by regular
expression filters. An additional error message was added for failed
regular expression searches. Bump minor version to 25.
2022-03-13 11:30:48 -04:00
f22051d382
replace erciccione's seednode with one on haveno's infrastructure
2022-03-13 13:15:01 +01:00
7dcfccbaaf
wallet_rpc_server: fix make_integrated_address with no payment id
2022-03-11 17:23:19 +00:00
591c174235
Remove footgun doc comment in miner TX validation
...
This comment suggests this check is unnecessary, when it is completely necessary as miner TXs can have multiple outputs *which is a statement directly, and incorrectly, contradicted by this comment*. While I don't ever see someone removing this code and getting their edits merged into Monero, someone inexperienced who thinks they're cleaning old code may break their own work, and then there's really just zero benefit to keeping this around.
2022-03-10 14:08:30 -06:00
354e1d9c65
Make the wallet name optional when locked.
2022-03-10 08:16:14 +00:00
0d6fce8995
Compil. time: cryptonote_core minus portable_storage header
2022-03-04 12:48:35 +01:00
da9aa1f7f8
Copyright: Update to 2022
2022-03-04 06:59:20 +01:00
27f1d43547
Merge pull request #8145
...
fb5b2b3
2022-03-02 18:53:34 -05:00
abae63c37d
Merge pull request #8052
...
c36ea26
2022-03-02 18:52:51 -05:00
5eaa4434e8
Merge pull request #7877
...
e08abaa
2022-03-02 18:51:54 -05:00
3c829586be
wallet2: update stagenet rollback blocks
2022-03-01 00:25:41 +01:00
3f88fddbfa
simplewallet: add option for exporting tx keys
...
This commit adds an option to export transaction
keys when performing export_transfers all. By passing
option=with_keys a new column 'tx key' will be
populated with respective keys.
2022-02-24 22:22:35 -05:00
e08abaa43f
multisig key exchange update and refactor
2022-02-22 16:37:42 -06:00
9bde2dbfed
Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168
...
This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is.
This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with
--rpc-access-control-origins, but it is no longer mandatory.
Original Issue: #8168
2022-02-19 13:49:38 -06:00
06e6c8bf4a
crypto: fix constant randomx exceptions in large page allocator
...
If allocating large pages fails, we don't try again.
This has the obvious drawback of not being able to use large pages
if they fail once.
2022-02-19 13:15:10 +00:00
5e201fedc5
rpc: add explicit restricted flag to /get_info
2022-02-07 17:59:22 +01:00
e5000a9f0c
Balance includes unconfirmed transfers to self
2022-01-31 07:52:38 -05:00
c36ea26e5c
fix ge_p3_is_point_at_infinity(), which is evaluating field elements that haven't been reduced by the field order
2022-01-25 07:14:46 -06:00
357dbd2032
Merge pull request #8130
...
1051276
2022-01-24 15:16:52 -05:00
d94715fd71
Merge pull request #8123
...
4446cc8
2022-01-24 15:15:11 -05:00
5283cf51ef
Merge pull request #8044
...
a02b342
2022-01-24 15:10:55 -05:00
fb5b2b352a
support authentication in monero-wallet-rpc set_daemon
2022-01-17 17:03:56 -05:00
1051276425
Update net_node.inl
2022-01-04 16:31:59 -05:00
4446cc88c3
wallet inits cache if file and blob missing
2021-12-24 09:22:57 -05:00
3ed0cc6e20
Merge pull request #8067
...
53be72c
2021-11-30 17:05:48 -05:00
c0cf5bb339
Merge pull request #8057
...
1efe624
2021-11-30 17:03:46 -05:00
55fc2335a4
Merge pull request #7943
...
3a90be4
2021-11-30 17:00:20 -05:00
53be72c08a
`make_uri` disallows standalone payment ids
2021-11-30 09:28:45 -05:00
105e2304a2
Merge pull request #8083
...
e8e507f
2021-11-26 23:05:31 -06:00
9a17f53489
Merge pull request #8070
...
a4ebec90221b01
2021-11-26 23:01:08 -06:00
0221b01519
Add calcpow RPC
...
Calculate PoW hash for a block candidate
2021-11-20 18:52:05 +00:00
82828bfcb6
cryptonote_core: fix unused lambda warning
2021-11-16 05:21:56 +01:00
1efe624e30
device_ledger: fix incorrect macro
...
The current code does work by accident, but it might break if
someone uses ASSERT_SW in a different place, or if variables
get renamed.
2021-11-12 02:56:20 +01:00
97ff1938a3
Merge pull request #8038
...
fbe8358
2021-11-09 22:53:47 -06:00
2844b5b8db
Merge pull request #8031
...
187633c
2021-11-09 22:50:36 -06:00
c3b1b94453
Merge pull request #7169
...
bbe3b27
2021-11-09 22:44:39 -06:00
cf44349a86
account info text alignment
2021-11-10 02:27:14 +08:00
a02b342347
Avoid unnecessary 'Invalid hashing blob' error message
2021-11-05 14:19:21 +01:00
fbe8358c9f
device: fix ledger error strings, add human friendly messages
2021-11-03 00:10:12 +01:00
bbe3b276b8
tx_pool: full tx revalidation on fork boundaries
...
avoids mining txes after a fork that are invalid by this fork's
rules, but were valid by the previous fork rules at the time
they were verified and added to the txpool.
2021-11-01 20:56:38 +00:00
e22ec26be4
Merge pull request #8029
...
548cfc8
2021-11-01 12:32:24 -05:00
d573b3d76c
Merge pull request #8020
...
47e7a43
2021-11-01 12:31:32 -05:00
ff4ede9356
Merge pull request #8017
...
a15466d
2021-11-01 12:29:22 -05:00
f405bf3d58
Merge pull request #8013
...
2cad563
2021-11-01 12:25:20 -05:00
187633c0ca
slow_hash: don't blow out Mac stack on ARM64
2021-10-30 22:24:55 +01:00
548cfc8d68
crypto: fix typo in ifdef
2021-10-29 17:55:51 +02:00
b328fbecc2
Merge pull request #8019
...
e106bdc
2021-10-25 19:02:49 -05:00
ff96482e38
Merge pull request #8018
...
1f81f5f
2021-10-25 19:02:22 -05:00
e5710b1898
Merge pull request #8004
...
ace4669
2021-10-25 18:59:54 -05:00
e7d571c526
Merge pull request #8003
...
75d05b9
2021-10-25 18:59:18 -05:00
00ac048958
Merge pull request #7995
...
797ca97
2021-10-25 18:53:34 -05:00
e8e507f36f
rpc: fix DoS vector in get_output_distribution
...
This will prevent people spending old pre-rct outputs using a
stranger's node, which may be a good thing
2021-10-24 17:17:12 +00:00
797ca974ab
socks: ignore any exceptions in shutdown/close
2021-10-22 22:00:29 +02:00
47e7a43270
wallet_api: enable set_strict_default_file_permissions
2021-10-22 05:40:23 +02:00
e106bdc1fc
epee: add missing header
2021-10-22 04:14:25 +02:00
1f81f5f5c1
protocol: fix spurious rejection of downloaded blocks
...
when kicking a peer for inactivity, clear the set of requested blocks,
or next time we requests blocks from it, we'll probably reject the
incoming blocks due to missing the previous requested blocks
2021-10-21 20:34:06 +00:00
a15466d850
wallet2: remove 2 unused variables
2021-10-20 22:19:15 +02:00
2cad563060
wallet2: fix key encryption when changing ask-password from 0/1 to 2
...
we reuse the wallet_keys_unlocker object, which does the right thing
in conjunction with other users of decrypt/encrypt (ie, refresh).
2021-10-19 22:01:45 +00:00
753dc901a1
Merge pull request #8001
...
9973edd
2021-10-17 23:39:50 -05:00
99507da993
Merge pull request #7994
...
84c5257
2021-10-17 23:38:47 -05:00
adb2542a6c
Merge pull request #7876
...
5e63f6c
2021-10-17 23:29:17 -05:00
ebc655c6ad
Merge pull request #7869
...
ad9fde4
2021-10-17 23:28:04 -05:00
19a6cc26fc
Merge pull request #7867
...
eed7e79
2021-10-17 23:26:50 -05:00
e165fdb27c
Merge pull request #7859
...
514f8fa
2021-10-17 23:25:34 -05:00
308e601966
Merge pull request #7799
...
76542ea
2021-10-17 23:23:15 -05:00
3d9c805e23
Merge pull request #7975
...
48a0997
2021-10-11 13:00:27 -05:00
a6367693c7
Merge pull request #7960
...
2e8936f
2021-10-11 12:59:32 -05:00
872d6f86bc
Merge pull request #7958
...
5f54dea
2021-10-11 12:57:53 -05:00
45920c36f1
Merge pull request #7874
...
91548838922f96
2021-10-11 12:56:14 -05:00
7f477c1902
Merge pull request #7793
...
13a8a57
2021-10-11 12:54:17 -05:00
48a0997d8c
blockchain: fix pedantic assert
2021-10-11 19:09:45 +02:00
ace4669543
simplewallet: fix incoming_transfers index error
2021-10-10 23:17:16 +02:00
75d05b9448
download: fix leak
...
A shared_ptr as by value capture will keep the object alive
2021-10-10 19:14:17 +00:00
moneromooo-monero