Mirrors
/
monero
mirror of https://github.com/monero-project/monero.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,983 Commits 9 Branches 69 Tags 223 MiB
Commit Graph

765 Commits

Author SHA1 Message Date
luigi1111 b12e195fba
Merge pull request #7620 
fe63256 cryptonote_protocol_handler: fix race condition (anon)
ded2f3a cryptonote_protocol_handler: add race condition demo (anon)
 2021-03-29 21:55:11 -04:00
luigi1111 a2b046dafc
Merge pull request #7460 
2935a0c async_protocol_handler_config: fix deadlock (anon)
c877705 async_protocol_handler_config: add deadlock demo (anon)
 2021-03-29 21:46:29 -04:00
mj-xmr 53683d7f90 Warnings: fix ut/levin.cpp missing braces 2021-03-27 09:26:44 +01:00
anon ded2f3aa85
cryptonote_protocol_handler: add race condition demo 2021-03-22 19:42:46 +00:00
luigi1111 7bf89dcbd3
Merge pull request #7005 
249eae5 Allow byte_stream->byte_slice conversion to shrink unused buffer space (Lee Clagett)
 2021-03-20 01:35:13 -04:00
luigi1111 8d7c1135b8
Merge pull request #6810 
19b2283 New add_aux_pow RPC to support merge mining (moneromooo-monero)
 2021-03-20 01:33:10 -04:00
anon c877705a53
async_protocol_handler_config: add deadlock demo 2021-03-12 11:59:06 +00:00
anon 1b51d398fb
async_protocol_handler_config: add segfault demo 2021-02-19 22:27:28 +00:00
luigi1111 6556c33f13
Merge pull request #7355 
bd12984 Remove copies from foreach loops (thanks to Clang) (Lee Clagett)
1572df9 Removing unused namespace alias (Lee Clagett)
 2021-02-18 14:06:47 -05:00
luigi1111 906a62c6b2
Merge pull request #7352 
a60d3d8 unit_tests: fix wipeable_string parse_hexstr test with latest gtest (xiphon)
 2021-02-18 14:05:58 -05:00
luigi1111 ce5800a225
Merge pull request #7346 
85db173 Remove unused variables in monero codebase (Kevin Barbour)
 2021-02-18 14:03:31 -05:00
luigi1111 9f6dcbd568
Merge pull request #7308 
df2f00f boosted_tcp_server: fix connection lifetime (anon)
3833624 boosted_tcp_server: add segfault demo (anon)
 2021-02-15 21:53:43 -05:00
moneromooo-monero 19b228393f
New add_aux_pow RPC to support merge mining 2021-02-09 11:58:21 +00:00
Kevin Barbour 85db1734e7
Remove unused variables in monero codebase 
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.

In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
 2021-02-09 08:05:05 +01:00
mj-xmr dc48de74e8 Reduce compilation time of epee/portable_storage.h 2021-02-06 08:18:42 +01:00
Lee Clagett bd129849f0 Remove copies from foreach loops (thanks to Clang) 2021-01-28 23:42:40 -05:00
xiphon a60d3d8ff7 unit_tests: fix wipeable_string parse_hexstr test with latest gtest 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973196
 2021-01-27 13:04:08 +00:00
Lee Clagett 08e4497c6e Improve cryptonote (block and tx) binary read performance 2021-01-23 06:23:39 +00:00
anon 3833624ab1 boosted_tcp_server: add segfault demo 2021-01-19 18:15:30 +01:00
Lee Clagett 679d05567d Remove payload copy in all outgoing p2p messages 2021-01-19 02:22:32 +00:00
Lee Clagett 23aae5571b Remove payload copy in all outgoing p2p messages 2021-01-16 22:53:28 +00:00
Alexander Blair 747699541e
Merge pull request #7285 
927141bcc Command max_bytes moved from dynamic map to static switch (Lee Clagett)
 2021-01-07 17:54:02 -08:00
Lee Clagett 927141bcc4 Command max_bytes moved from dynamic map to static switch 2020-12-22 20:54:16 +00:00
moneromooo-monero b652d598d1
add a max levin packet size by command type 2021-01-03 14:07:45 +00:00
Alexander Blair 16c780d568
Merge pull request #7250 
61b6e4cc6 Add aggressive restrictions to pre-handshake p2p buffer limit (Lee Clagett)
 2021-01-01 22:35:59 -08:00
moneromooo-monero 0aa541b361
protocol: more sanity checks in new chain block hashes 2020-12-31 23:33:18 +00:00
moneromooo-monero bcdc6c62b7
protocol: fix false positives dropping peers 
it'd trigger on reorgs
 2020-12-27 14:41:19 +00:00
luigi1111 025db3d2b4
Revert "Reject existing claimed blocks in sync mode" 2020-12-27 00:18:05 -05:00
Alexander Blair 609dbe6b92
Merge pull request #7154 
cf7e1571d protocol: reject claimed block hashes that already are in the chain (moneromooo-monero)
af0a25544 protocol: drop peers we can't download anything from in sync mode (moneromooo-monero)
 2020-12-26 13:40:36 -08:00
Lee Clagett 187b4d7521 Restrict duplicate keys in epee binary format 2020-12-20 03:47:32 +00:00
moneromooo-monero cf7e1571d3
protocol: reject claimed block hashes that already are in the chain 2020-12-17 02:54:02 +00:00
Lee Clagett 61b6e4cc67 Add aggressive restrictions to pre-handshake p2p buffer limit 2020-12-17 00:36:10 +00:00
Lee Clagett 4978f69d7a Fix byte_stream::put_n 2020-12-14 14:45:24 -05:00
Alexander Blair 28e5e42986
Merge pull request #7110 
d660f22ed protocol: drop origin IP if a block fails to verify in sync mode (moneromooo-monero)
 2020-12-10 17:41:59 -08:00
Alexander Blair 1e9483a2d5
Merge pull request #7009 
7414e2bac Change epee binary output from std::stringstream to byte_stream (Lee Clagett)
 2020-12-10 17:34:50 -08:00
Alexander Blair 6bddd54f9d
Merge pull request #7003 
08eb0949f Change to more efficient allocation strategy in byte_stream (Lee Clagett)
 2020-12-10 17:33:50 -08:00
moneromooo-monero d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode 
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
 2020-12-10 21:59:18 +00:00
luigi1111 36d31ba0be
Merge pull request #7018 
a9cd5d9 cryptonote_core: dandelion - use local height or median height if syncing (xiphon)
 2020-11-29 01:58:13 -06:00
luigi1111 c041550ffa
Merge pull request #6973 
be84f67 Switch to Dandelion++ fluff mode if no out connections for stem mode (Lee Clagett)
 2020-11-29 01:54:43 -06:00
luigi1111 7a0334742a
Merge pull request #6937 
8a282f6 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) Add monero_add_minimal_executable and use in tests (mj-xmr)
 2020-11-29 01:49:39 -06:00
luigi1111 450f1325ab
Merge pull request #6856 
db70af1 Unit Tests: Remove block reward upper bound size checks (TheCharlatan)
 2020-11-28 22:35:07 -06:00
xiphon a9cd5d914e cryptonote_core: dandelion - use local height or median height if syncing 2020-11-25 01:27:42 +00:00
Howard Chu 91fd634768
Better log message for unusable anon networks 2020-11-16 12:36:37 +00:00
Lee Clagett be84f678b9 Switch to Dandelion++ fluff mode if no out connections for stem mode 2020-11-03 13:58:14 -05:00
mj-xmr 8a282f64c9 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) 
Add monero_add_minimal_executable and use in tests

This is done in order not to have to relink targets, when just an .so changed, but not its interface.
 2020-10-28 20:08:26 +01:00
Lee Clagett 08eb0949f3 Change to more efficient allocation strategy in byte_stream 2020-10-13 15:10:54 +00:00
Lee Clagett 249eae5f4a Allow byte_stream->byte_slice conversion to shrink unused buffer space 2020-10-13 15:09:18 +00:00
xiphon a12a8174e0 Dandelion++: skip desynced peers in stem phase 2020-10-12 13:44:06 +00:00
Lee Clagett 7414e2bac1 Change epee binary output from std::stringstream to byte_stream 2020-10-10 15:28:40 +00:00
TheCharlatan db70af1bbc
Unit Tests: Remove block reward upper bound size checks 
Tests running after being compiled with `make debug-test` failed with
```
[  FAILED  ] block_reward_and_current_block_weight.fails_on_huge_median_size
[  FAILED  ] block_reward_and_current_block_weight.fails_on_huge_block_weight
```

With the introduction of the patch in
be82c40703 (diff-1a57d4e6013984c420da98d1adde0eafL113)
the assertions checking the weight of the median and current block
against a size limit were removed. Since the limit is now enforced by a
long divisor and a uint64_t type, checking in a separate test makes
little sense, so they are removed here.
 2020-10-03 02:32:17 +02:00
luigi1111 ee0b02d0db
Merge pull request #6757 
6a37da8 threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
 2020-09-03 12:25:59 -05:00
moneromooo-monero 6a37da837e
threadpool: guard against exceptions in jobs, and armour plating 
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
 2020-09-01 14:33:33 +00:00
Alexander Blair 44cd8a13ec
Merge pull request #6769 
b641e0a2c Add clear method to byte_stream (Lee Clagett)
 2020-08-27 12:05:16 -07:00
Sarang Noether 641b08c920 CLSAG optimizations 2020-08-27 12:44:04 +00:00
moneromooo-monero 82ee01699c
Integrate CLSAGs into monero 
They are allowed from v12, and MLSAGs are rejected from v13.
 2020-08-27 12:44:04 +00:00
moneromooo-monero 8cd1d6df8f
unit_tests: add ge_triple_scalarmult_base_vartime test 2020-08-27 12:44:01 +00:00
Alexander Blair bad5d8d6f0
Merge pull request #6690 
7175dcb10 replace most boost serialization with existing monero serialization (moneromooo-monero)
 2020-08-27 02:54:30 -07:00
Lee Clagett b641e0a2c0 Add clear method to byte_stream 2020-08-17 21:30:34 -04:00
luigi1111 765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption" 
This reverts commit 921dd8dde5.
 2020-08-17 14:08:59 -05:00
moneromooo-monero 7175dcb107
replace most boost serialization with existing monero serialization 
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.

For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.

Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.

Some tests and tools also do, this will stay as is for now.
 2020-08-17 16:23:58 +00:00
Alexander Blair 10ad0d7eb2
Merge pull request #6718 
85efc88c1 Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test (koe)
 2020-08-16 12:53:50 -07:00
Alexander Blair 01b512f3a9
Merge pull request #6716 
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
 2020-08-16 12:52:21 -07:00
Alexander Blair a08df6eb1b
Merge pull request #6603 
4e2377995 Change ZMQ-JSON txextra to hex and remove unnecessary base fields (Lee Clagett)
 2020-08-16 12:43:38 -07:00
Alexander Blair 009ca6fcd3
Merge pull request #6601 
98c151ecb Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster (Lee Clagett)
60627c9f2 Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster (Lee Clagett)
fe96e66eb Fix pruned tx for ZMQ's GetBlocksFast (Lee Clagett)
 2020-08-16 12:43:11 -07:00
Alexander Blair 6d29ee6c52
Merge pull request #6493 
921dd8dde Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)
 2020-08-16 12:39:59 -07:00
Alexander Blair 13549d590e
Merge pull request #6329 
6bfcd3101 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. (Sarang Noether)
 2020-08-16 12:37:43 -07:00
Lee Clagett 4e2377995d Change ZMQ-JSON txextra to hex and remove unnecessary base fields 2020-08-14 23:01:00 +00:00
Lee Clagett fe96e66ebe Fix pruned tx for ZMQ's GetBlocksFast 2020-08-14 19:46:33 +00:00
Sarang Noether 921dd8dde5 Use domain-separated ChaCha20 for in-memory key encryption 2020-08-09 19:11:54 -04:00
Sarang Noether 6bfcd31015 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. 2020-08-09 18:42:15 -04:00
Alexander Blair c108c5e2f0
Merge pull request #6354 
67ade8005 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 (Lee Clagett)
 2020-08-09 06:42:49 -07:00
koe 85efc88c1e Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test 2020-07-23 03:36:05 -05:00
xiphon 76c16822d0 wallet2_api: implement runtime proxy configuration 2020-07-20 13:45:12 +00:00
Alexander Blair 3ba6c7fd30
Merge pull request #6516 
8656a8c9f remove double includes (sumogr)
 2020-07-19 03:34:28 -07:00
Alexander Blair a0d179e528
Merge pull request #6512 
5ef0607da Update copyright year to 2020 (SomaticFanatic)
 2020-07-19 03:32:59 -07:00
luigi1111 35e2520115
Merge pull request #6559 
15538f7 ByteSlice: Fix persisting ptr to std::moved SSO buffer (Doy-lee)
 2020-07-08 17:07:50 -05:00
Doyle 15538f7e3f ByteSlice: Fix persisting ptr to std::moved SSO buffer 
The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
 2020-05-20 10:13:58 +10:00
Lee Clagett 67ade80055 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 2020-05-15 07:57:35 +00:00
Lee Clagett 29e563bb1e Fixed bugs for take_slice and byte_stream->byte_slice 2020-05-12 01:26:37 -04:00
sumogr 8656a8c9ff remove double includes 2020-05-11 13:53:17 +00:00
SomaticFanatic 5ef0607da6 Update copyright year to 2020 
Update copyright year to 2020
 2020-05-06 22:36:54 -04:00
Lee Clagett e5214a2ca2 Adding ZMQ/Pub support for txpool_add and chain_main events 2020-05-04 02:06:35 +00:00
luigi1111 06c81b6527
Merge pull request #6359 
f9441c5 Fixed string_ref usage bug in epee::from_hex::vector (vtnerd)
 2020-04-21 08:38:21 -05:00
Lee Clagett c26c93019a Add byte_stream for zero-copy serialization, and add support in ZMQ-JSON. 2020-04-11 04:12:11 +00:00
luigi1111 8185054db7
Merge pull request #6451 
4ed60b6 Bulletproofs: verification speedup (SarangNoether)
 2020-05-02 15:14:41 -05:00
luigi1111 a5cc613a68
Merge pull request #6460 
f8b1480 unit_tests: fix gcc+ warning (sumogr)
 2020-05-01 15:50:19 -05:00
Sumo Gr f8b1480f95
unit_tests: fix gcc+ warning 2020-04-18 18:04:20 +03:00
Sarang Noether 4ed60b626a Bulletproofs: verification speedup 2020-04-14 20:31:30 -04:00
luigi1111 d1f3d3376d
Merge pull request #6381 
e719760 Fix receive order leakage with tx fluffing (vtnerd)
 2020-04-04 13:12:31 -05:00
luigi1111 5757d99208
Merge pull request #6361 
68a6507 Fixed bug in ZMQ JSON-RPC method field (vtnerd)
 2020-04-04 13:01:15 -05:00
luigi1111 0150a480fd
Merge pull request #6357 
42a7a4d daemon: auto public nodes - cache and prioritize most stable nodes (xiphon)
 2020-04-04 12:59:23 -05:00
luigi1111 cfc0f4a7fa
Merge pull request #6351 
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
 2020-04-04 12:55:02 -05:00
luigi1111 bf70696a85
Merge pull request #6346 
dbfa4f8 unit_tests: fix missing test names (xiphon)
 2020-04-04 12:50:17 -05:00
luigi1111 c4f75fe898
Merge pull request #6339 
c61abf8 remove empty statements (shopglobal)
 2020-04-04 12:47:31 -05:00
luigi1111 292e2d8f28
Merge pull request #6335 
0078ce7 wipeable_string: split - treat CR, LF and Tabs as separators (xiphon)
 2020-04-04 12:42:50 -05:00
Lee Clagett da99157462 Use byte_slice for sending zmq messages - removes data copy within zmq 2020-04-03 01:56:17 +00:00
luigi1111 096e2135dd
Merge pull request #6214 
054b4c7 protocol: request txpool contents when synced (moneromooo-monero)
 2020-03-31 13:32:55 -05:00
Lee Clagett f9441c5759 Fixed string_ref usage bug in epee::from_hex::vector 2020-03-30 16:53:34 +00:00
Lee Clagett 0c29e17581 Fix network unit tests after epee changes 2020-03-28 13:30:22 -04:00
Alexander Blair 7d4a93fab3
Merge pull request #6285 
d0641b42 net: fix incorrect less operator for top/i2p addresses (Aaron Hook)
 2020-03-27 12:23:00 -07:00