5956beaa15
wallet2: fix is_synced checking target height, not height
...
Target height would be appropriate for the daemon, which syncs
off other daemons, but the wallet syncs off the daemon it's
connected to, and its target is the daemon's current height.
2019-11-01 18:59:39 +00:00
fd35e2304a
wallet: fix another facet of "did I get some monero" information leak
...
We get new pool txes before processing any tx, pool or not.
This ensures that if we're asked for a password, this does not
cause a measurable delay in the txpool query after the last
block query.
2019-11-01 18:59:38 +00:00
d5472bd87b
wallet2: do not send an unnecessary last getblocks.bin call on refresh
...
The "everything refreshed" state was detected when a refresh call did
not return any new blocks. This can be detected without that extra
"empty" call by comparing the claimed node height to the height of
the last block retrieved. Doing this avoids that last call, saves
some bandwidth, and makes the common refresh case use only one call
rather than two.
As a side effect, it prevents an information leak reported by
Tramèr et al: if the wallet retrieves a set of blocks which includes
an output sent to the refreshing wallet, the wallet will prompt the
user for the password to decode the amount and calculate the key
image for the new output, and this will delay subsequent calls to
getblocks.bin, allowing a passive adversary to note the delay and
deduce when the wallet receives at least one output.
This can still happen if the wallet downloads more than 1000 blocks,
since this will be split in several calls, but then the most the
adversary can tell is which 1000 block section the user received
some monero (the adversary can estimate the heights of the blocks
by calculating how many "large" transfers are done, which will be
sections of blocks, the last of which will usually be below 1000,
but the size of the data should allow the actual number of blocks
sent to be determined fairly accurately).
This timing trick still be used via the subsequent scan for incoming
txes in the txpool, which will be fixed later.
2019-11-01 18:59:37 +00:00
22d30866ca
simplewallet: add missing inactivity-lock-timeout to set help blurb
2019-11-01 15:37:55 +00:00
d8d5749b46
Merge pull request #6067
...
5ae029881
2019-11-01 17:05:13 +02:00
8cc7d5b6c0
Merge pull request #6066
...
d31024c2e
2019-11-01 17:03:58 +02:00
d4b5ba88df
Merge pull request #6064
...
0e3b823a1
2019-11-01 17:03:44 +02:00
646a7a2800
Merge pull request #6062
...
508dcfada
2019-11-01 17:03:22 +02:00
78e59f531e
Merge pull request #6059
...
45b6b6038
2019-11-01 16:59:20 +02:00
5068793036
Merge pull request #6059
...
45b6b6038
2019-11-01 16:53:11 +02:00
9f57f0df92
simplewallet: do not mention inactivity if a lock was manual
2019-11-01 14:36:57 +00:00
97ae7bb5cb
wallet2: do not repeatedly ask for pool txes sent to us
...
This lets a passive attacker with access to the network link
between node and wallet perform traffic analysis to deduce
when an idle wallet receives a transaction.
Reported by Tramèr et al.
2019-11-01 10:42:01 +00:00
fb9b741bf0
README update upgrade table
...
with details for nov 30th network upgrade
2019-10-31 15:44:55 -04:00
f89ea437d0
README update upgrade table with details
...
of the november 30th fork
2019-10-31 15:43:05 -04:00
45b6b60385
Updating gitian yml files for v0.15
2019-10-31 17:36:47 +01:00
5ae0298818
unit_tests: fix use after free
2019-10-31 12:03:22 +00:00
d31024c2e1
cryptonote: untangle dependency from miner to blockchain
...
It causes link errors at least on mac
2019-10-31 01:25:07 +00:00
ebc6ce44f4
cryptonote: untangle dependency from miner to blockchain
...
It causes link errors at least on mac
2019-10-31 01:06:42 +00:00
f498dfc158
README: add Void Linux package dependencies
...
see also https://github.com/void-linux/void-packages/blob/master/srcpkgs/monero/template
2019-10-30 21:39:29 +00:00
0e3b823a15
daemon: always use bootstrap daemon (if set) in '--no-sync' mode
2019-10-30 19:45:23 +00:00
2efc6acdb2
RandomX: Update to v1.1.6
2019-10-30 20:25:10 +01:00
508dcfadac
RandomX: Update to v1.1.6
2019-10-30 20:23:45 +01:00
f1091c410f
core_tests: remove some useless verbose logs
2019-10-30 18:41:31 +00:00
1554a7768b
unit_tests: fix use after free
2019-10-30 18:40:20 +00:00
3b8dcc290d
wallet2: make keys unlocker reentrant
...
protects against having your keys mangled
2019-10-29 13:53:57 +00:00
5a44893a71
python-rpc: add missing strict_balances parameter for get_accounts
2019-10-29 11:52:43 +00:00
886ed25055
blockchain: fix comment wrongly refering to SHA-3 rather than Keccak
2019-10-29 11:37:08 +00:00
017f816897
daemon: handle printing higher hash rates
2019-10-29 11:33:15 +00:00
deb350b783
always print peer IDs in the same format
2019-10-29 11:30:20 +00:00
c96b7ee619
tx_pool: fix error message assuming incorrectly
2019-10-29 10:43:59 +00:00
2e2bf8a207
daemon: always use bootstrap daemon (if set) in '--no-sync' mode
2019-10-28 21:52:19 +00:00
45fd72b0d7
Updated paper references
2019-10-28 12:34:44 -04:00
65301c406e
core: point out when we hit the block rate visibility limit
2019-10-28 16:06:15 +00:00
277003f145
Minor prover simplification
2019-10-28 09:34:49 -04:00
4c9fd8d86d
Merge pull request #6044
...
eb16755
2019-10-27 16:28:33 -05:00
f9ddda75a2
Merge pull request #6038
...
e8964c2
2019-10-27 16:27:31 -05:00
bb04201505
Merge pull request #6045
...
86ac20f
2019-10-27 16:26:25 -05:00
e59639addc
Merge pull request #6039
...
8ff9e6b
2019-10-27 16:25:03 -05:00
86ac20f64e
blockchain: fix unwanted error when probing the pool for a tx
2019-10-27 19:23:36 +00:00
eb16755083
blockchain: fix unwanted error when probing the pool for a tx
2019-10-27 19:23:25 +00:00
261abf79e1
functional_tests: ensure mining stops on error in mining test
...
this prevents messing up any subsequent test too
2019-10-27 16:21:30 +00:00
2f8f3a9432
rpc: base flush_cache request/response on the new base structs
2019-10-27 16:14:28 +00:00
8ff9e6bc32
wallet: do not warn if the rpc cost was free
2019-10-27 11:12:14 +00:00
e8964c26cc
wallet: do not warn if the rpc cost was free
2019-10-27 10:59:31 +00:00
f49a8cad23
easylogging++: add screen.xterm-256color to the "allow colour" TERM list
2019-10-26 20:16:19 +00:00
b928ead30e
Merge pull request #6036
...
7bca3e0
2019-10-26 12:23:28 -05:00
7bca3e069f
CMake build out of source
2019-10-26 15:10:23 +02:00
3b0a43a8d4
Merge pull request #6033
...
da2ffd6
2019-10-25 20:51:04 -05:00
ef8b3a15b4
Merge pull request #6017
...
5734686
2019-10-25 20:48:04 -05:00
bae2d00ec4
Merge pull request #6025
...
aceb1dc
2019-10-25 20:46:38 -05:00
moneromooo-monero