SChernykh
9ca9f1214a
Fixed issues found by static analysis
...
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
2021-03-18 21:57:13 +01:00
anon
d5b78c08b6
async_protocol_handler_config: fix deadlock
2021-03-12 11:59:05 +00:00
anon
f59b1d5fb5
async_protocol_handler_config: add deadlock demo
2021-03-12 11:59:05 +00:00
moneromooo-monero
4a9ae3eb8b
fix serialization being different on mac
...
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.
There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:41:19 +00:00
luigi1111
837c9aec22
Merge pull request #7390
...
7fd140e
async_protocol_handler_config: remove connection correctly (anon)
c1776be
async_protocol_handler_config: add segfault demo (anon)
2021-03-05 13:56:12 -05:00
luigi1111
af46a291ad
Merge pull request #7336
...
d8137dc
device_trezor: add redundant check (anon)
c6e1d7b
device_trezor: wipe string fields properly (anon)
2021-03-05 13:53:00 -05:00
Dusan Klinec
25588de40c
trezor: simplify recognition of integrated addresses
...
now it is possible to simplify integrated addresses recognition using transaction destination info directly
fixes https://github.com/monero-project/monero-gui/issues/3346
2021-03-03 15:39:12 +01:00
anon
7fd140e4f7
async_protocol_handler_config: remove connection correctly
2021-02-19 22:27:28 +00:00
anon
c1776be54f
async_protocol_handler_config: add segfault demo
2021-02-19 22:27:28 +00:00
luigi1111
30bc575505
Merge pull request #7362
...
332b973
ITS#9007 don't free loose writemap pages (Kris Zyp)
2021-02-18 14:08:58 -05:00
luigi1111
aa408d1c72
Merge pull request #7333
...
b5667c9
p2p: allow CIDR notation in DNS blocklist (moneromooo-monero)
2021-02-16 11:45:38 -05:00
luigi1111
c8895ccbb7
Merge pull request #7309
...
6d5e210
boosted_tcp_server: fix connection lifetime (anon)
afec439
boosted_tcp_server: add segfault demo (anon)
2021-02-15 21:56:07 -05:00
luigi1111
975d390d00
Merge pull request #7284
...
32ab89a
docs: Remove outdated bits about anonymity network seed nodes (Nathan Dorfman)
2021-02-15 21:49:50 -05:00
Kris Zyp
332b9734ff
ITS#9007 don't free loose writemap pages
...
Broken in ITS#8756
2021-02-01 16:10:09 +00:00
moneromooo-monero
b5667c9f6c
p2p: allow CIDR notation in DNS blocklist
2021-01-21 01:41:31 +00:00
anon
d8137dc523
device_trezor: add redundant check
2021-01-20 22:07:13 +01:00
anon
c6e1d7bcdf
device_trezor: wipe string fields properly
2021-01-20 22:07:13 +01:00
anon
6d5e2106b3
boosted_tcp_server: fix connection lifetime
2021-01-19 18:16:01 +01:00
anon
afec439953
boosted_tcp_server: add segfault demo
2021-01-19 18:16:01 +01:00
luigi1111
25670398b1
Merge pull request #7295
...
fe6dda9
p2p: only log to global when a blocked IP is not already blocked (moneromooo-monero)
2021-01-15 23:53:40 -05:00
moneromooo-monero
fe6dda9453
p2p: only log to global when a blocked IP is not already blocked
2021-01-08 15:50:10 +00:00
Alexander Blair
8fef32e45c
Merge pull request #7292
...
ba3c627c5
Command max_bytes moved from dynamic map to static switch (Lee Clagett)
2021-01-07 17:55:23 -08:00
Alexander Blair
7f1a83b852
Merge pull request #7287
...
89fe0e1c8
storages: overridable limits for loading portable_storage from binary (moneromooo-monero)
2021-01-07 17:55:13 -08:00
moneromooo-monero
89fe0e1c81
storages: overridable limits for loading portable_storage from binary
2021-01-07 20:24:51 +00:00
luigi1111
b06ccc0416
Merge pull request #7282
...
5d2dd7a
epee: also limit number of strings in portable_storage (moneromooo-monero)
2021-01-06 21:11:53 -05:00
luigi1111
83fa752a84
Merge pull request #7267
...
c2295f5
protocol: handle receiving a block hash we've not added yet (moneromooo-monero)
2021-01-06 21:09:36 -05:00
luigi1111
7ecdc53e11
Merge pull request #7248
...
3c7eec1
add a max levin packet size by command type (moneromooo-monero)
2021-01-06 21:08:11 -05:00
Nathan Dorfman
32ab89aa86
docs: Remove outdated bits about anonymity network seed nodes
2021-01-05 23:05:05 -07:00
moneromooo-monero
5d2dd7a328
epee: also limit number of strings in portable_storage
...
They require at least 24 bytes
2021-01-05 17:56:11 +00:00
Alexander Blair
f3de67bc21
Merge pull request #7269
...
1128146c4
blockchain: lock access to m_blocks_hash_of_hashes (moneromooo-monero)
2021-01-03 18:29:39 -08:00
Alexander Blair
51057105b9
Merge pull request #7264
...
31b2572ec
build: prepare v0.17.1.9 (selsta)
2021-01-03 18:29:19 -08:00
Alexander Blair
54cf799f0f
Merge pull request #7262
...
0add7ec1c
portable_storage: better sanity checking (moneromooo-monero)
2021-01-03 18:28:50 -08:00
moneromooo-monero
3c7eec152c
add a max levin packet size by command type
2021-01-03 14:07:58 +00:00
moneromooo-monero
1128146c49
blockchain: lock access to m_blocks_hash_of_hashes
...
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
2021-01-02 22:20:24 +00:00
moneromooo-monero
c2295f55b8
protocol: handle receiving a block hash we've not added yet
2021-01-02 22:10:44 +00:00
selsta
31b2572ec7
build: prepare v0.17.1.9
2021-01-02 18:13:47 +01:00
moneromooo-monero
0add7ec1cd
portable_storage: better sanity checking
2021-01-02 12:36:42 +00:00
Alexander Blair
2107337999
Merge pull request #7251
...
f0b867b13
Restrict duplicate keys in epee binary format (Lee Clagett)
2021-01-01 22:44:24 -08:00
Alexander Blair
f4e34d50cf
Merge pull request #7249
...
cb296b39b
portable_storage: forbid unnamed sections (xiphon)
2021-01-01 22:44:02 -08:00
Alexander Blair
a4ffad75ac
Merge pull request #7247
...
57f7c2e53
protocol: more sanity checks in new chain block hashes (moneromooo-monero)
2021-01-01 22:43:46 -08:00
Alexander Blair
024783f73a
Merge pull request #7244
...
531069859
portable_storage: check object limit where appropriate (moneromooo)
2021-01-01 22:42:43 -08:00
Alexander Blair
db686707cb
Merge pull request #7239
...
e685f52e2
p2p: fix deadlock banning while updating peer lists (moneromooo)
2021-01-01 22:42:17 -08:00
Alexander Blair
5767e6db90
Merge pull request #7235
...
00253b717
protocol: don't reset last request time on an idle timer (moneromooo-monero)
2021-01-01 22:41:54 -08:00
xiphon
cb296b39bd
portable_storage: forbid unnamed sections
2021-01-01 02:06:39 +01:00
moneromooo-monero
57f7c2e53f
protocol: more sanity checks in new chain block hashes
2020-12-31 23:34:26 +00:00
moneromooo
531069859f
portable_storage: check object limit where appropriate
...
also fix pedantic off by one in check
2020-12-31 22:35:32 +00:00
binaryFate
00b3502749
Merge pull request #7228 from vtnerd/fix/p2p_memory_usage_017
...
Add aggressive restrictions to pre-handshake p2p buffer limit
2020-12-31 21:35:00 +01:00
moneromooo
e685f52e25
p2p: fix deadlock banning while updating peer lists
2020-12-31 03:15:11 +00:00
moneromooo-monero
00253b717c
protocol: don't reset last request time on an idle timer
...
this prevents losing time of "idle time" for a peer, which could
otherwise be reset by another timed sync command from the peer
2020-12-30 14:21:57 +00:00
Lee Clagett
7d67a2dde0
Add aggressive restrictions to pre-handshake p2p buffer limit
2020-12-29 19:58:53 -05:00