515ac2951d
p2p: store network address directly in blocked host list
...
rather than their string representation
2019-07-16 11:35:52 +00:00
7a3e458881
improve tx_sanity_check clarification
2019-07-15 15:19:14 +02:00
f17dcde451
Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT
2019-07-15 13:27:06 +10:00
fd3ff74164
Merge pull request #5746
...
3140a37
2019-07-12 20:28:15 -05:00
309f2def9e
Merge pull request #5738
...
4ee095c
2019-07-12 20:26:43 -05:00
e4e8954c04
Merge pull request #5724
...
c223832
2019-07-12 20:23:08 -05:00
884df82db3
wallet: provide original address for outgoing transfers
2019-07-10 13:39:18 +00:00
3140a378da
wallet_rpc_server: fix get_bulk_payments with short payment ids
2019-07-09 14:39:44 +00:00
65f29a83c8
simplewallet: add restore_height command
2019-07-08 13:51:50 +00:00
0d916a667c
Fix incorrectly named binding for MMS send_signer_config command
...
send_message_config isn't used anywhere else in the code, and it is clear from the help command that it should be named send_signer_config.
2019-07-08 09:53:07 +00:00
256d286215
Minor formatting fix in help set command
2019-07-06 10:12:32 +00:00
4ee095c200
p2p: don't connect to more than one IP per class B if we can
2019-07-05 18:25:52 +00:00
c2238327d0
keccak: guard against misaligned memory accesses on ARM
...
The code generated is exactly the same as the direct access
one on x86_64
2019-07-04 22:13:16 +00:00
a96c1a46d4
cryptonote_protocol: drop peers we can't download from when syncing
...
Any peer that's behind us while syncing is useless to us (though
not to them). This ensures that we don't get our peer slots filled
with peers that we can't use. Once we've synced, we can connect
to them and they can then sync off us if they want.
2019-07-04 21:56:10 +00:00
ab361df2cd
p2p: add a few missing connection close calls
2019-07-04 21:56:10 +00:00
9d7107c870
Merge pull request #5663
...
5d6b43b
2019-07-04 14:46:37 -05:00
59ba0eee69
Merge pull request #5650
...
3c071d2
2019-07-04 14:44:05 -05:00
591c72613b
Merge pull request #5647
...
2ff99fb
2019-07-04 14:41:36 -05:00
c393e824d6
CryptonightR_JIT: fix return value on error
...
The value was positive rather than zero, but the caller only
checks for negative errors
2019-07-04 12:49:54 +01:00
c164f9037e
Remove unnecessary m_check_txin_table, fix const correctness
2019-07-03 14:39:52 +02:00
6560bfa64c
rpc: get_block_template add optional extra_nonce
...
Circumvents the need to create a new blockhashing blob when you already
know the data you want to set in the extra_nonce (so use this instead of
reserve_size).
2019-07-03 07:57:36 -04:00
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images
2019-07-02 19:42:28 +00:00
bcd2da76cd
miner: fix --bg-mining-enable description
2019-07-02 17:43:36 +00:00
dc8b7a88bd
zmq: MacPorts latest fix
2019-07-01 23:13:55 -04:00
c8709fe52f
wallet: do not print log settings when unset
...
Coverity 199721
2019-07-01 15:17:30 +00:00
633f14b976
Merge pull request #5681
...
037f94c
2019-07-01 01:12:23 -05:00
2db997828a
Merge pull request #5678
...
15c699f
2019-07-01 00:22:07 -05:00
393c33f86c
Merge pull request #5675
...
da3e20e
2019-07-01 00:18:40 -05:00
4237707d3e
p2p: don't forget pruning seed or public RPC port when updating peers
...
Older nodes don't pass that information around
2019-06-26 10:20:19 +00:00
1db5357c7b
rpc headers fix
2019-06-25 01:49:04 +01:00
a604241ef6
simplewallet: don't ask about mining when running a command line
...
This is likely to be done via a script
2019-06-22 10:50:20 +00:00
3768db227c
p2p: add a reference to Cao, Tong et al. for the last_seen changes
...
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
2019-06-21 10:34:33 +00:00
037f94c54e
Remove Xiala.net from the list of dns resolvers
...
It is down permanently. See: https://xiala.net/
"Ende November 2018 werden alle Dienste von xiala.net abgeschaltet."
2019-06-21 09:40:10 +00:00
15c699f0a6
rpc: set sanity_check_failed to false when successful
2019-06-20 14:32:49 +09:00
da3e20ee01
tx_sanity_check: relax the median check a lot
...
we don't want to prevent bona fide txes, just obvious bad ones
2019-06-19 23:31:38 +00:00
098aadf084
p2p: close the right number of connections on setting max in/out peers
2019-06-19 11:49:36 +00:00
fcbf7b3f74
p2p: propagate out peers limit to payload handler
2019-06-19 11:49:36 +00:00
097cca59c1
wallet_api: catch getTxKey exception
...
- getTxKey method throws an exception, e.g., when user declines txKey export
2019-06-19 12:09:49 +02:00
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs
2019-06-19 09:39:16 +00:00
5d6b43b672
core: fix --prune-blockchain not pruning if no blockchain exists
2019-06-17 16:26:43 +00:00
f074b6b571
device: show address on device display
...
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
- address device [<index>]
- address new <label> // shows address on device also
- integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
2019-06-17 16:49:04 +02:00
64fb0f872a
device: tx_key caching fixed, store recovered txkey
2019-06-17 14:53:39 +02:00
8ccc30b163
Fix --restore-date usage
...
The wallet was ignoring --restore-height and --restore-date params and
prompting for them again.
2019-06-16 21:11:33 +01:00
3c071d203f
blockchain: silence an error getting blocks for pruned nodes
...
This happens often when a pre-pruning node asks a pruned node
for data it does not have
2019-06-16 11:03:41 +00:00
a182df21d0
Bans for RPC connections
...
Make bans control RPC sessions too. And auto-ban some bad requests.
Drops HTTP connections whenever response code is 500.
2019-06-16 11:38:08 +01:00
2ff99fb47f
db_lmdb: commit pruning txn at checkpoints
...
to avoid errors when the txn is too large
2019-06-15 09:50:54 +00:00
6335509727
Merge pull request #5641
...
633f1542
2019-06-14 16:20:02 +02:00
633f1542e2
prep for 0.14.1 release
2019-06-14 16:16:52 +02:00
2eef90d6ef
rpc: restrict the recent cutoff size in restricted RPC mode
2019-06-14 08:47:33 +00:00
0564da5fdc
ensure no NULL is passed to memcpy
...
NULL is valid when size is 0, but memcpy uses nonnull attributes,
so let's not poke the bear
2019-06-14 08:47:29 +00:00
1387549e90
serialization: check stream good flag at the end
...
just in case
2019-06-14 08:47:23 +00:00
a00cabd4f3
tree-hash: allocate variable memory on heap, not stack
...
Large amounts might run out of stack
Reported by guidov
2019-06-14 08:47:20 +00:00
f215219252
cryptonote: throw on tx hash calculation error
2019-06-14 08:47:17 +00:00
db2b9fba65
serialization: fail on read_varint error
2019-06-14 08:47:14 +00:00
68ad548193
cryptonote_protocol: fix another potential P2P DoS
...
When asking for txes in a fluffy transaction, one might ask
for the same (large) tx many times
2019-06-14 08:47:11 +00:00
1cc61018e5
cryptonote_protocol: expand basic DoS protection
...
Count transactions as well
2019-06-14 08:47:08 +00:00
8f66b7053a
cryptonote_protocol_handler: prevent potential DoS
...
Essentially, one can send such a large amount of IDs that core exhausts
all free memory. This issue can theoretically be exploited using very
large CN blockchains, such as Monero.
This is a partial fix. Thanks and credit given to CryptoNote author
'cryptozoidberg' for collaboration and the fix. Also thanks to
'moneromooo'. Referencing HackerOne report #506595 .
2019-06-14 08:47:05 +00:00
69f9420489
core: do not complain about low block rate if disconnected
...
In that case, we'll still keep the "Monero is now disconnected
from the network" near the end of the log
2019-06-13 10:25:30 +00:00
b712ae0af2
rpc: work around a GCC 7.4.0 (at least) bug
...
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’:
cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
2019-06-12 22:27:07 +00:00
03aa14ec87
tx_sanity_check: don't print an error when not enough outs to check
2019-06-12 12:06:14 +00:00
14881094af
rpc: fix get_transactions getting v1 txes from the txpool
...
It would try to get their prunable hash, but v1 txes don't have one
2019-06-12 11:59:13 +00:00
fd0cf689dd
Merge pull request #5619
...
f2f207d
2019-06-11 18:17:11 -05:00
6b41bd8eb5
Delete more include string.h
2019-06-11 16:08:42 +08:00
b8cfa92b7e
rpc: implement set_bootstrap_daemon method
2019-06-10 21:10:08 +00:00
35c20c4332
Fix GCC 9.1 build warnings
...
GCC wants operator= aand copy ctor to be both defined, or neither
2019-06-09 09:39:18 +00:00
f2f207d635
miner: fix double free of thread attributes
...
issue: #5568
2019-06-09 10:51:18 +02:00
2cbe75661c
p2p: fix GCC 9.1 crash
2019-06-08 17:52:53 +00:00
068fa1ca5c
p2p: delay IGP probing on startup
...
We might have external access without having to do this
2019-06-06 10:33:02 +00:00
c820e1839f
simplewallet: print errors on exceptions creating wallets
...
Exceptions would otherwise terminate the process silently
2019-06-06 09:49:47 +00:00
cf8cb6873a
rpc: use ip address string representation for peer::host field
2019-06-04 19:33:35 +00:00
dd58057126
Remember RPC version on initial connect
...
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
2019-06-02 09:31:50 +01:00
62d32e955a
Merge pull request #5577
...
f950517a
2019-06-01 20:25:19 +02:00
7e417dd408
Merge pull request #5571
...
35da33be4b51f9a3
2019-06-01 20:22:19 +02:00
14d3295649
Merge pull request #5561
...
9bfa4c203544596fc9aaccf3
2019-06-01 20:21:45 +02:00
fccfc1aa25
Merge pull request #5555
...
b6830db2Fix #5553 (Howard Chu)
2019-06-01 20:20:39 +02:00
343c0b4255
add a command line option to disable ZMQ server
2019-06-01 13:03:37 -04:00
880ebfdeea
daemon: add more chain specific info in alt_chain_info
2019-06-01 15:43:52 +00:00
2aa11341fc
daemon: display peer address type in print_cn
2019-05-31 09:10:05 +00:00
fcfcc3ac86
rpc: in/out peers can now return the setting's value
2019-05-30 12:13:31 +00:00
cd720c7e0b
add cumulative difficulty to diff command
2019-05-30 11:57:21 +03:00
270a3ae58b
Unused private member m_miner_address
2019-05-29 10:12:47 -04:00
f950517a08
core: update pruning if using --prune-blockchain on a pruned blockchain
...
Avoids a massive amount of spurious warnings if the last update before
the daemon exited was a while ago and the daemon was syncing
2019-05-28 09:12:11 +00:00
577324a954
wallet_manager: omit redundant disconnect, drop unused variable
2019-05-27 14:40:29 +00:00
35da33bea9
blockchain: do not try to pop blocks down to the genesis block
2019-05-26 17:11:32 +00:00
4b51f9a34f
core: do not commit half constructed batch db txn
2019-05-25 16:24:56 +00:00
162c3e18ec
blockchain_export: allow exporting blocks.dat format from pruned
...
We don't need any of the pruned data for this
2019-05-24 14:12:45 +00:00
c07bbd5c04
daemon: fix "never seen before" time span display for peers
2019-05-24 10:47:36 +00:00
9bfa4c20ca
Fix allow any cert mode in wallet rpc when configured over rpc
2019-05-22 00:15:14 -04:00
3544596f9f
Add ssl_options support to monerod's rpc mode.
2019-05-22 00:09:11 -04:00
c9aaccf346
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works.
2019-05-21 15:43:27 -04:00
b6830db2d4
Fix #5553
...
Make sure the tip hash still matches the cached block
2019-05-19 03:02:33 +01:00
915f59e3c0
wallet: add unlock_time details to show_transfers
...
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
2019-05-16 21:37:05 +00:00
e8487fa46b
Merge pull request #5539
...
3f612cdaaf9bc4ec1873af356810307539bd157f
2019-05-15 16:10:41 +02:00
5e80b3c3ef
Merge pull request #5535
...
e1016bce
2019-05-15 16:06:58 +02:00
1607419e38
Merge pull request #5538
...
615f287
2019-05-14 16:02:59 -05:00
eedf5106f5
Merge pull request #5532
...
46244dd
2019-05-14 15:59:34 -05:00
5a67ff2b32
Merge pull request #5526
...
1e8f3f6
2019-05-14 15:54:10 -05:00
266f68be32
Merge pull request #5512
...
d47292e
2019-05-14 15:51:14 -05:00
1873af35bf
Made code block usage consistent across all .md files
2019-05-12 05:16:26 +01:00
615f287aec
wallet: fix certificate fingerprint length check
...
Fixed by crCr62U0
2019-05-11 13:05:06 +00:00
e1016bce14
password: do not use line input on windows
...
This keeps its builtin command editing away
Thanks iDunk for testing on Windows
2019-05-10 18:56:50 +00:00
4c666141e3
expose set/get walletcache attribute functionality in wallet api
2019-05-10 19:24:45 +02:00
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers
...
And add them for pending transfers, where they were missing
2019-05-10 14:44:13 +00:00
6abaaaa994
remove obsolete save_graph skeleton code
2019-05-10 14:17:18 +00:00
1e8f3f66bf
rpc: fail update RPC when running offline
2019-05-09 19:14:49 +00:00
4228ee0b9e
daemon: add optional arguments to alt_chain_info
...
>N limits display to alt chains with more than N blocks
-N limits display to alt chains younger than N blocks
2019-05-09 09:13:11 +00:00
0605406714
daemon: sort alt chains by height
2019-05-09 09:12:49 +00:00
06b8f29992
blockchain: keep alternative blocks in LMDB
...
Alternative blocks are cleared on startup unless --keep-alt-blocks
is passed on the command line
2019-05-08 17:36:52 +00:00
f64f59627d
Merge pull request #5510
...
e9809382
2019-05-07 17:36:27 +02:00
97cb1c9436
Merge pull request #5508
...
1c44e658
2019-05-07 17:35:28 +02:00
a22a8b0f2b
Merge pull request #5505
...
7e5158aa
2019-05-07 17:34:53 +02:00
c20221f290
Merge pull request #5503
...
ccc1e311
2019-05-07 17:34:16 +02:00
ebb1c03e8c
Merge pull request #5501
...
b4ca72dd
2019-05-07 17:32:33 +02:00
2d04b0e500
Merge pull request #5499
...
a4c4a2d8
2019-05-07 17:31:45 +02:00
9d91301faa
Merge pull request #5496
...
0eb0d6b8
2019-05-07 17:30:27 +02:00
cf8319602d
Merge pull request #5481
...
28a7d315
2019-05-07 17:29:42 +02:00
e4d100b062
wallet2: don't wait a day before using new version fees
...
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
2019-05-02 18:00:25 +00:00
bc94ba4d14
wallet: distinguish between empty and absent attributes
2019-05-02 13:00:08 +00:00
d47292eb3d
error: fix compile error on windows with depends
...
state_not_recoverable is not defined there
2019-05-02 10:14:09 +00:00
a4c4a2d8aa
blockchain: keep a rolling long term block weight median
2019-05-02 09:47:01 +00:00
77f9bfa4d5
Merge pull request #5493
...
5e0da6fb
2019-05-02 11:30:28 +02:00
52eb454d7b
Merge pull request #5491
...
98fb98f99074c0d8968848a7
2019-05-02 11:30:11 +02:00
efd2412e77
Merge pull request #5489
...
64983fce
2019-05-02 11:29:25 +02:00
08ab0cbdda
Merge pull request #5476
...
0aaf5e2a
2019-05-02 11:28:51 +02:00
e980938210
fix wide difficulty conversion with some versions of boost
2019-05-01 19:58:09 +00:00
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API
2019-05-01 18:41:39 +00:00
7e5158aa97
mnemonics: fix 4 byte UTF-8 rewriting
2019-04-30 21:10:54 +00:00
ccc1e311dc
wallet_rpc_server: reject standalone short payment id in address book
2019-04-30 21:07:37 +00:00
1a66a86f94
remove unused code
2019-04-29 20:52:40 +00:00
25a7cfdb4a
add a few checks where it seems appropriate
2019-04-29 20:52:40 +00:00
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case
...
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
2019-04-29 10:02:20 +00:00
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256
...
SHA1 is too close to bruteforceable
2019-04-26 11:37:15 +00:00
98fb98f93f
wallet_rpc_server: adding missing return on error in set_daemon
2019-04-25 23:35:37 +00:00
9074c0d8cf
wallet_rpc_server: return false on error in set_log_categories
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
968848a77b
wallet_rpc_server: fix crash in validate_address if no wallet is loaded
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
0eb0d6b802
rpc: improve get_output_distribution
...
It can now handle small reorgs without having to rescan the
whole blockchain.
Also add a test for it.
2019-04-25 16:49:29 +00:00
0aaf5e2ac8
device/trezor: device sorting and filtering improved
...
- Trezor type detection refactored, T1 disabled (was enabled before which was a bug)
- Sort connected devices by env TREZOR_PATH
- Compatibility with Trezor ecosystem using TREZOR_PATH env var
- Enables to pick particular Trezor to use in GUI as we don't have the multi-device selection yet
- Dump all detected devices to log for better debugging / troubleshooting
2019-04-25 00:31:10 +02:00
581994b61c
Merge pull request #5486
...
4be18df3b386ae57
2019-04-24 22:41:40 +02:00
2e2ee3d823
Merge pull request #5485
...
c519d1df
2019-04-24 22:41:18 +02:00
2aa7fbd1d6
Merge pull request #5480
...
7af49ef0
2019-04-24 22:39:50 +02:00
edcb0cfff2
Merge pull request #5477
...
97e1c927
2019-04-24 22:38:36 +02:00
fd7ed93526
Merge pull request #5470
...
31a9aa83
2019-04-24 22:37:43 +02:00
28a7d31565
p2p: do not send last_seen timestamp to peers
...
This can be used for fingerprinting and working out the
network topology.
Instead of sending the first N (which are sorted by last
seen time), we sent a random subset of the first N+N/5,
which ensures reasonably recent peers are used, while
preventing repeated calls from deducing new entries are
peers the target node just connected to.
The list is also randomly shuffled so the original set of
timestamps cannot be approximated.
2019-04-24 17:56:12 +00:00
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero
...
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
2019-04-24 12:25:43 +00:00
df83ed74e4
consensus: from v12, enforce >= 2 outputs
2019-04-23 22:09:35 +00:00
4be18df32a
tx_sanity_check: relax uniqueness check a bit
...
It triggers easily on testnet
2019-04-23 21:59:57 +00:00
b386ae5725
wallet2: add missing "sanity check failed" reason message
2019-04-23 21:59:57 +00:00
c519d1df34
wallet2: fix wrong change being recorded in sweep_all
...
leading to the sanity check triggering
2019-04-23 21:58:55 +00:00
6aa3c2f303
dns_checks: new helper program to check on DNSSEC lookups
2019-04-23 15:20:45 +00:00
7af49ef0c2
daemonizer: add --non-interactive for windows
...
The RPC functional tests need it
Thanks to iDunk for debugging/testing
2019-04-23 00:26:51 +00:00
moneromooo-monero