Mirrors
/
monero
mirror of https://github.com/monero-project/monero.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
11,664 Commits 9 Branches 69 Tags 223 MiB
Commit Graph

855 Commits

Author SHA1 Message Date
luigi1111 ce5800a225
Merge pull request #7346 
85db173 Remove unused variables in monero codebase (Kevin Barbour)
 2021-02-18 14:03:31 -05:00
luigi1111 9f6dcbd568
Merge pull request #7308 
df2f00f boosted_tcp_server: fix connection lifetime (anon)
3833624 boosted_tcp_server: add segfault demo (anon)
 2021-02-15 21:53:43 -05:00
moneromooo-monero 19b228393f
New add_aux_pow RPC to support merge mining 2021-02-09 11:58:21 +00:00
Kevin Barbour 85db1734e7
Remove unused variables in monero codebase 
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.

In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
 2021-02-09 08:05:05 +01:00
mj-xmr dc48de74e8 Reduce compilation time of epee/portable_storage.h 2021-02-06 08:18:42 +01:00
Lee Clagett bd129849f0 Remove copies from foreach loops (thanks to Clang) 2021-01-28 23:42:40 -05:00
xiphon a60d3d8ff7 unit_tests: fix wipeable_string parse_hexstr test with latest gtest 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973196
 2021-01-27 13:04:08 +00:00
Lee Clagett 08e4497c6e Improve cryptonote (block and tx) binary read performance 2021-01-23 06:23:39 +00:00
anon 3833624ab1 boosted_tcp_server: add segfault demo 2021-01-19 18:15:30 +01:00
Lee Clagett 679d05567d Remove payload copy in all outgoing p2p messages 2021-01-19 02:22:32 +00:00
Lee Clagett 23aae5571b Remove payload copy in all outgoing p2p messages 2021-01-16 22:53:28 +00:00
Alexander Blair 747699541e
Merge pull request #7285 
927141bcc Command max_bytes moved from dynamic map to static switch (Lee Clagett)
 2021-01-07 17:54:02 -08:00
Lee Clagett 927141bcc4 Command max_bytes moved from dynamic map to static switch 2020-12-22 20:54:16 +00:00
moneromooo-monero b652d598d1
add a max levin packet size by command type 2021-01-03 14:07:45 +00:00
Alexander Blair 16c780d568
Merge pull request #7250 
61b6e4cc6 Add aggressive restrictions to pre-handshake p2p buffer limit (Lee Clagett)
 2021-01-01 22:35:59 -08:00
moneromooo-monero 0aa541b361
protocol: more sanity checks in new chain block hashes 2020-12-31 23:33:18 +00:00
moneromooo-monero bcdc6c62b7
protocol: fix false positives dropping peers 
it'd trigger on reorgs
 2020-12-27 14:41:19 +00:00
luigi1111 025db3d2b4
Revert "Reject existing claimed blocks in sync mode" 2020-12-27 00:18:05 -05:00
Alexander Blair 609dbe6b92
Merge pull request #7154 
cf7e1571d protocol: reject claimed block hashes that already are in the chain (moneromooo-monero)
af0a25544 protocol: drop peers we can't download anything from in sync mode (moneromooo-monero)
 2020-12-26 13:40:36 -08:00
Lee Clagett 187b4d7521 Restrict duplicate keys in epee binary format 2020-12-20 03:47:32 +00:00
moneromooo-monero cf7e1571d3
protocol: reject claimed block hashes that already are in the chain 2020-12-17 02:54:02 +00:00
Lee Clagett 61b6e4cc67 Add aggressive restrictions to pre-handshake p2p buffer limit 2020-12-17 00:36:10 +00:00
Lee Clagett 4978f69d7a Fix byte_stream::put_n 2020-12-14 14:45:24 -05:00
Alexander Blair 28e5e42986
Merge pull request #7110 
d660f22ed protocol: drop origin IP if a block fails to verify in sync mode (moneromooo-monero)
 2020-12-10 17:41:59 -08:00
Alexander Blair 1e9483a2d5
Merge pull request #7009 
7414e2bac Change epee binary output from std::stringstream to byte_stream (Lee Clagett)
 2020-12-10 17:34:50 -08:00
Alexander Blair 6bddd54f9d
Merge pull request #7003 
08eb0949f Change to more efficient allocation strategy in byte_stream (Lee Clagett)
 2020-12-10 17:33:50 -08:00
moneromooo-monero d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode 
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
 2020-12-10 21:59:18 +00:00
luigi1111 36d31ba0be
Merge pull request #7018 
a9cd5d9 cryptonote_core: dandelion - use local height or median height if syncing (xiphon)
 2020-11-29 01:58:13 -06:00
luigi1111 c041550ffa
Merge pull request #6973 
be84f67 Switch to Dandelion++ fluff mode if no out connections for stem mode (Lee Clagett)
 2020-11-29 01:54:43 -06:00
luigi1111 7a0334742a
Merge pull request #6937 
8a282f6 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) Add monero_add_minimal_executable and use in tests (mj-xmr)
 2020-11-29 01:49:39 -06:00
luigi1111 450f1325ab
Merge pull request #6856 
db70af1 Unit Tests: Remove block reward upper bound size checks (TheCharlatan)
 2020-11-28 22:35:07 -06:00
xiphon a9cd5d914e cryptonote_core: dandelion - use local height or median height if syncing 2020-11-25 01:27:42 +00:00
Howard Chu 91fd634768
Better log message for unusable anon networks 2020-11-16 12:36:37 +00:00
Lee Clagett be84f678b9 Switch to Dandelion++ fluff mode if no out connections for stem mode 2020-11-03 13:58:14 -05:00
mj-xmr 8a282f64c9 Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr) 
Add monero_add_minimal_executable and use in tests

This is done in order not to have to relink targets, when just an .so changed, but not its interface.
 2020-10-28 20:08:26 +01:00
Lee Clagett 08eb0949f3 Change to more efficient allocation strategy in byte_stream 2020-10-13 15:10:54 +00:00
Lee Clagett 249eae5f4a Allow byte_stream->byte_slice conversion to shrink unused buffer space 2020-10-13 15:09:18 +00:00
xiphon a12a8174e0 Dandelion++: skip desynced peers in stem phase 2020-10-12 13:44:06 +00:00
Lee Clagett 7414e2bac1 Change epee binary output from std::stringstream to byte_stream 2020-10-10 15:28:40 +00:00
TheCharlatan db70af1bbc
Unit Tests: Remove block reward upper bound size checks 
Tests running after being compiled with `make debug-test` failed with
```
[  FAILED  ] block_reward_and_current_block_weight.fails_on_huge_median_size
[  FAILED  ] block_reward_and_current_block_weight.fails_on_huge_block_weight
```

With the introduction of the patch in
be82c40703 (diff-1a57d4e6013984c420da98d1adde0eafL113)
the assertions checking the weight of the median and current block
against a size limit were removed. Since the limit is now enforced by a
long divisor and a uint64_t type, checking in a separate test makes
little sense, so they are removed here.
 2020-10-03 02:32:17 +02:00
luigi1111 ee0b02d0db
Merge pull request #6757 
6a37da8 threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
 2020-09-03 12:25:59 -05:00
moneromooo-monero 6a37da837e
threadpool: guard against exceptions in jobs, and armour plating 
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
 2020-09-01 14:33:33 +00:00
Alexander Blair 44cd8a13ec
Merge pull request #6769 
b641e0a2c Add clear method to byte_stream (Lee Clagett)
 2020-08-27 12:05:16 -07:00
Sarang Noether 641b08c920 CLSAG optimizations 2020-08-27 12:44:04 +00:00
moneromooo-monero 82ee01699c
Integrate CLSAGs into monero 
They are allowed from v12, and MLSAGs are rejected from v13.
 2020-08-27 12:44:04 +00:00
moneromooo-monero 8cd1d6df8f
unit_tests: add ge_triple_scalarmult_base_vartime test 2020-08-27 12:44:01 +00:00
Alexander Blair bad5d8d6f0
Merge pull request #6690 
7175dcb10 replace most boost serialization with existing monero serialization (moneromooo-monero)
 2020-08-27 02:54:30 -07:00
Lee Clagett b641e0a2c0 Add clear method to byte_stream 2020-08-17 21:30:34 -04:00
luigi1111 765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption" 
This reverts commit 921dd8dde5.
 2020-08-17 14:08:59 -05:00
moneromooo-monero 7175dcb107
replace most boost serialization with existing monero serialization 
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.

For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.

Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.

Some tests and tools also do, this will stay as is for now.
 2020-08-17 16:23:58 +00:00
Alexander Blair 10ad0d7eb2
Merge pull request #6718 
85efc88c1 Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test (koe)
 2020-08-16 12:53:50 -07:00
Alexander Blair 01b512f3a9
Merge pull request #6716 
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
 2020-08-16 12:52:21 -07:00
Alexander Blair a08df6eb1b
Merge pull request #6603 
4e2377995 Change ZMQ-JSON txextra to hex and remove unnecessary base fields (Lee Clagett)
 2020-08-16 12:43:38 -07:00
Alexander Blair 009ca6fcd3
Merge pull request #6601 
98c151ecb Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster (Lee Clagett)
60627c9f2 Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster (Lee Clagett)
fe96e66eb Fix pruned tx for ZMQ's GetBlocksFast (Lee Clagett)
 2020-08-16 12:43:11 -07:00
Alexander Blair 6d29ee6c52
Merge pull request #6493 
921dd8dde Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)
 2020-08-16 12:39:59 -07:00
Alexander Blair 13549d590e
Merge pull request #6329 
6bfcd3101 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. (Sarang Noether)
 2020-08-16 12:37:43 -07:00
Lee Clagett 4e2377995d Change ZMQ-JSON txextra to hex and remove unnecessary base fields 2020-08-14 23:01:00 +00:00
Lee Clagett fe96e66ebe Fix pruned tx for ZMQ's GetBlocksFast 2020-08-14 19:46:33 +00:00
Sarang Noether 921dd8dde5 Use domain-separated ChaCha20 for in-memory key encryption 2020-08-09 19:11:54 -04:00
Sarang Noether 6bfcd31015 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. 2020-08-09 18:42:15 -04:00
Alexander Blair c108c5e2f0
Merge pull request #6354 
67ade8005 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 (Lee Clagett)
 2020-08-09 06:42:49 -07:00
koe 85efc88c1e Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test 2020-07-23 03:36:05 -05:00
xiphon 76c16822d0 wallet2_api: implement runtime proxy configuration 2020-07-20 13:45:12 +00:00
Alexander Blair 3ba6c7fd30
Merge pull request #6516 
8656a8c9f remove double includes (sumogr)
 2020-07-19 03:34:28 -07:00
Alexander Blair a0d179e528
Merge pull request #6512 
5ef0607da Update copyright year to 2020 (SomaticFanatic)
 2020-07-19 03:32:59 -07:00
luigi1111 35e2520115
Merge pull request #6559 
15538f7 ByteSlice: Fix persisting ptr to std::moved SSO buffer (Doy-lee)
 2020-07-08 17:07:50 -05:00
Doyle 15538f7e3f ByteSlice: Fix persisting ptr to std::moved SSO buffer 
The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
 2020-05-20 10:13:58 +10:00
Lee Clagett 67ade80055 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 2020-05-15 07:57:35 +00:00
Lee Clagett 29e563bb1e Fixed bugs for take_slice and byte_stream->byte_slice 2020-05-12 01:26:37 -04:00
sumogr 8656a8c9ff remove double includes 2020-05-11 13:53:17 +00:00
SomaticFanatic 5ef0607da6 Update copyright year to 2020 
Update copyright year to 2020
 2020-05-06 22:36:54 -04:00
Lee Clagett e5214a2ca2 Adding ZMQ/Pub support for txpool_add and chain_main events 2020-05-04 02:06:35 +00:00
luigi1111 06c81b6527
Merge pull request #6359 
f9441c5 Fixed string_ref usage bug in epee::from_hex::vector (vtnerd)
 2020-04-21 08:38:21 -05:00
Lee Clagett c26c93019a Add byte_stream for zero-copy serialization, and add support in ZMQ-JSON. 2020-04-11 04:12:11 +00:00
luigi1111 8185054db7
Merge pull request #6451 
4ed60b6 Bulletproofs: verification speedup (SarangNoether)
 2020-05-02 15:14:41 -05:00
luigi1111 a5cc613a68
Merge pull request #6460 
f8b1480 unit_tests: fix gcc+ warning (sumogr)
 2020-05-01 15:50:19 -05:00
Sumo Gr f8b1480f95
unit_tests: fix gcc+ warning 2020-04-18 18:04:20 +03:00
Sarang Noether 4ed60b626a Bulletproofs: verification speedup 2020-04-14 20:31:30 -04:00
luigi1111 d1f3d3376d
Merge pull request #6381 
e719760 Fix receive order leakage with tx fluffing (vtnerd)
 2020-04-04 13:12:31 -05:00
luigi1111 5757d99208
Merge pull request #6361 
68a6507 Fixed bug in ZMQ JSON-RPC method field (vtnerd)
 2020-04-04 13:01:15 -05:00
luigi1111 0150a480fd
Merge pull request #6357 
42a7a4d daemon: auto public nodes - cache and prioritize most stable nodes (xiphon)
 2020-04-04 12:59:23 -05:00
luigi1111 cfc0f4a7fa
Merge pull request #6351 
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
 2020-04-04 12:55:02 -05:00
luigi1111 bf70696a85
Merge pull request #6346 
dbfa4f8 unit_tests: fix missing test names (xiphon)
 2020-04-04 12:50:17 -05:00
luigi1111 c4f75fe898
Merge pull request #6339 
c61abf8 remove empty statements (shopglobal)
 2020-04-04 12:47:31 -05:00
luigi1111 292e2d8f28
Merge pull request #6335 
0078ce7 wipeable_string: split - treat CR, LF and Tabs as separators (xiphon)
 2020-04-04 12:42:50 -05:00
Lee Clagett da99157462 Use byte_slice for sending zmq messages - removes data copy within zmq 2020-04-03 01:56:17 +00:00
luigi1111 096e2135dd
Merge pull request #6214 
054b4c7 protocol: request txpool contents when synced (moneromooo-monero)
 2020-03-31 13:32:55 -05:00
Lee Clagett f9441c5759 Fixed string_ref usage bug in epee::from_hex::vector 2020-03-30 16:53:34 +00:00
Lee Clagett 0c29e17581 Fix network unit tests after epee changes 2020-03-28 13:30:22 -04:00
Alexander Blair 7d4a93fab3
Merge pull request #6285 
d0641b42 net: fix incorrect less operator for top/i2p addresses (Aaron Hook)
 2020-03-27 12:23:00 -07:00
Lee Clagett 02d887c2e5 Adding Dandelion++ support to public networks: 
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
  - Stem loops detected in tx_pool.cpp
  - Embargo timeout for a blackhole attack during stem phase
 2020-03-26 15:01:30 +00:00
moneromooo-monero 054b4c7f41
protocol: request txpool contents when synced 
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
 2020-03-22 16:03:31 +00:00
Aaron Hook aa93e38862 p2p: remove old debug commands 2020-03-20 22:09:44 -07:00
Alexander Blair 820ab9fdea
Merge pull request #6273 
0f78b06e Various improvements to the ZMQ JSON-RPC handling: (Lee Clagett)
 2020-03-12 01:13:49 -07:00
Lee Clagett e719760253 Fix receive order leakage with tx fluffing 2020-03-10 22:30:07 -04:00
Lee Clagett 5fcc23ae0a Move hex->bin conversion to monero copyright files and with less includes 2020-03-09 05:23:59 +00:00
Lee Clagett 0f78b06e8c Various improvements to the ZMQ JSON-RPC handling: 
- Finding handling function in ZMQ JSON-RPC now uses binary search
  - Temporary `std::vector`s in JSON output now use `epee::span` to
    prevent allocations.
  - Binary -> hex in JSON output no longer allocates temporary buffer
  - C++ structs -> JSON skips intermediate DOM creation, and instead
    write directly to an output stream.
 2020-03-05 14:20:56 +00:00
Alexander Blair 944e8a4542
Merge pull request #6220 
a9bdc6e4 Improved performance for epee serialization: (Lee Clagett)
 2020-02-28 19:45:31 -08:00
Alexander Blair e7997cd62a
Merge pull request #6202 
02b80513 unit_tests: remove invalid bulletproofs unit test (moneromooo-monero)
 2020-02-28 19:33:21 -08:00
xiphon 42a7a4dd32 daemon: auto public nodes - cache and prioritize most stable nodes 2020-02-28 08:06:43 +00:00
xiphon dbfa4f84ee unit_tests: fix missing test names 2020-02-18 23:56:21 +00:00
Interchained c61abf87c0 remove empty statements 
Cleaning up a little around the code base.
 2020-02-17 11:55:15 -05:00
xiphon 0078ce7fac wipeable_string: split - treat CR, LF and Tabs as separators 2020-02-12 21:16:07 +00:00
moneromooo-monero dd8c6b1703
wallet: do not split integrated addresses in address book api 2020-01-26 00:03:53 +00:00
Aaron Hook d0641b42fe net: fix incorrect less operator for top/i2p addresses 2020-01-18 19:18:56 -08:00
luigi1111 dad4cf121e
Merge pull request #6018 
dce6f05 rpc: Only show version string if it matches expected pattern (ndorf)
3293780 daemon: Use rpc for 'version' command (ndorf)
 2019-12-12 13:36:05 -06:00
moneromooo-monero 02b8051339
unit_tests: remove invalid bulletproofs unit test 
It was intended to check a case which is actually valid (0 gamma),
but was actually duplicating the bad amount test.

Reported by WhatDo_ on IRC.
 2019-12-01 15:40:59 +00:00
Lee Clagett 68a6507c3f Fixed bug in ZMQ JSON-RPC method field 2019-11-18 12:59:41 +00:00
Nathan Dorfman dce6f055f9 rpc: Only show version string if it matches expected pattern 2019-11-12 18:19:24 -07:00
Lee Clagett 70c9cd3c9c Change to Tx diffusion (Dandelion++ fluff) instead of flooding 2019-11-04 09:23:20 +00:00
Lee Clagett a9bdc6e4c4 Improved performance for epee serialization: 
- Removed copy of field names in binary deserialization
  - Removed copy of array values in binary deserialization
  - Removed copy of string values in json deserialization
  - Removed unhelpful allocation in json string value parsing
  - Removed copy of blob data on binary and json serialization
 2019-11-04 01:46:41 +00:00
Lee Clagett 5d7ae2d279 Adding support for hidden (anonymity) txpool 2019-11-02 20:36:03 +00:00
moneromooo-monero 1554a7768b
unit_tests: fix use after free 2019-10-30 18:40:20 +00:00
luigi1111 bb2bcf3521
Merge pull request #5972 
9447e72 cryptonote: add function to get weight from a pruned tx (moneromooo-monero)
 2019-10-22 10:52:14 -05:00
luigi1111 84ce43a239
Merge pull request #5966 
be82c40 Support median block size > 4 GB (moneromooo-monero)
 2019-10-22 10:08:32 -05:00
moneromooo-monero be82c40703
Support median block size > 4 GB 
add a 128/64 division routine so we can use a > 32 bit median block
size in calculations
 2019-10-21 10:41:07 +00:00
moneromooo-monero c65a221549
unit_tests: fix build after rename 2019-10-15 13:15:19 +00:00
xiphon d4d2b5c79a p2p+rpc: don't skip p2p or rpc port bind failure by default 2019-10-13 13:27:46 +00:00
moneromooo-monero 9447e7276d
cryptonote: add function to get weight from a pruned tx 
The weight of the prunable data is deterministic from the
unpruned data, so it can be determined from a pruned tx
 2019-10-11 12:08:36 +00:00
moneromooo-monero 77afe91db6
unit_tests: fix build with boost 1.69 2019-10-11 01:16:03 +00:00
luigi1111 bf525793c7
Merge pull request #5915 
8330e77 monerod can now sync from pruned blocks (moneromooo-monero)
 2019-10-08 15:55:03 -05:00
luigi1111 0e4ab6091c
Merge pull request #5960 
ae34e1b unit_tests: fix ringdb unit tests (moneromooo-monero)
 2019-10-08 14:49:57 -05:00
luigi1111 342e7f844f
Merge pull request #5921 
2a7d915 Fixed i2p/tor tx flooding bug (white noise disabled) (vtnerd)
 2019-10-08 14:31:53 -05:00
moneromooo-monero ae34e1ba1c
unit_tests: fix ringdb unit tests 2019-10-04 21:11:46 +00:00
luigi1111 40501cc131
Merge pull request #5895 
fdc00d0 unit tests: replace global var with lambda returning static local var (stoffu)
 2019-09-30 18:46:34 -05:00
moneromooo-monero 8330e772f1
monerod can now sync from pruned blocks 
If the peer (whether pruned or not itself) supports sending pruned blocks
to syncing nodes, the pruned version will be sent along with the hash
of the pruned data and the block weight. The original tx hashes can be
reconstructed from the pruned txes and theur prunable data hash. Those
hashes and the block weights are hashes and checked against the set of
precompiled hashes, ensuring the data we received is the original data.
It is currently not possible to use this system when not using the set
of precompiled hashes, since block weights can not otherwise be checked
for validity.

This is off by default for now, and is enabled by --sync-pruned-blocks
 2019-09-27 00:10:37 +00:00
luigi1111 3f6096867d
Merge pull request #5916 
7b076d5 p2p: fix bans taking port into account (moneromooo-monero)
 2019-09-24 10:42:29 -05:00
luigi1111 06bee964a8
Merge pull request #5878 
f9b3f6e Removed Berkeley DB and db switching logic (JesusRami)
 2019-09-24 10:10:28 -05:00
luigi1111 ee6e849627
Merge pull request #5877 
2cd4fd8 Changed the use of boost:value_initialized for C++ list initializer (JesusRami)
4ad191f Removed unused boost/value_init header (whyamiroot)
928f4be Make null hash constants constexpr (whyamiroot)
 2019-09-24 10:08:44 -05:00
moneromooo-monero 7b076d5170
p2p: fix bans taking port into account 2019-09-16 22:45:45 +00:00
moneromooo-monero 32f725d32f
Properly format multiline logs 
As a side effect, colouring on Windows should now work
regardless of version
 2019-09-16 16:58:01 +00:00
Jesus Ramirez f9b3f6ef3b Removed Berkeley DB and db switching logic 2019-09-16 16:18:05 +02:00
luigi1111 d663e1e3db
Merge pull request #5818 
f91a06c Dropping cppzmq dependency; adding some zmq utils (vtnerd)
 2019-09-14 13:25:14 -05:00
stoffu fdc00d0906
unit tests: replace global var with lambda returning static local var 
Fixes assertion failure (curstate == 1) in random.c in debug mode
 2019-09-09 11:44:06 +09:00
luigi1111 d0d76f771a
Merge pull request #5876 
a5c7eeb unit_tests: fix build with CLANG 8 and boost 1.69 (moneromooo-monero)
 2019-09-08 20:10:44 -05:00
luigi1111 d91393daaf
Merge pull request #5856 
f56e160 unit_tests: Fix uninitialized values (liptakmatyas)
 2019-09-08 20:06:04 -05:00
moneromooo-monero 0e2fda5bf0
unit_tests: fix levin unit test on big endian 2019-09-04 14:53:58 +00:00
moneromooo-monero d046ca1db0
difficulty: fix check_hash on big endian 2019-09-04 14:53:53 +00:00
Jesus Ramirez 2cd4fd8972 Changed the use of boost:value_initialized for C++ list initializer 2019-09-02 14:16:29 +02:00
moneromooo-monero a5c7eebaea
unit_tests: fix build with CLANG 8 and boost 1.69 2019-08-30 11:43:03 +00:00
luigi1111 98af2e954b
Merge pull request #5793 
bdfc63a Add ref-counted buffer byte_slice. Currently used for sending TCP data. (vtnerd)
3b24b1d Added support for 'noise' over I1P/Tor to mask Tx transmission. (vtnerd)
 2019-08-29 14:36:41 -05:00
luigi1111 85014813cf
Merge pull request #5707 
3a0451a MLSAG speedup and additional checks (SarangNoether)
 2019-08-28 02:22:00 -05:00
Sarang Noether 3a0451a8be MLSAG speedup and additional checks 2019-08-27 16:22:44 -04:00
Matyas Liptak f56e160217
unit_tests: Fix uninitialized values 
-   Initialize the `hash` in the `get_block_hash()` function of the
    `output_distribution` unit test explicitly, to silence `valgrind`
    warnings.
 2019-08-27 09:17:34 +02:00
luigi1111 a8e99198bf
Merge pull request #5748 
b350726 boost: update obsolete usage of endian API (moneromooo-monero)
 2019-08-21 15:18:38 -05:00
luigi1111 f205d28e96
Merge pull request #5727 
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
 2019-08-19 17:31:39 -05:00
luigi1111 2da11baecc
Merge pull request #5718 
c8709fe wallet: do not print log settings when unset (moneromooo-monero)
7b18e83 unit_tests: check return values on test data parsing (moneromooo-monero)
 2019-08-19 17:17:11 -05:00
moneromooo-monero eeca5ca0c8
epee: support unicode in parsed strings 2019-08-16 17:06:03 +00:00
luigi1111 86ee631212
Merge pull request #5652 
f81cb4f unit_tests: add more leeway to the 'same distribution' check (moneromooo-monero)
 2019-08-15 17:13:18 -05:00
Tom Smeding 7b9a420787 Replace std::random_shuffle with std::shuffle 
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.

A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.

[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
 2019-08-15 16:33:15 +02:00
Lee Clagett 2a7d91523b Fixed i2p/tor tx flooding bug (white noise disabled) 2019-07-29 12:27:00 +00:00
luigi1111 7fc76451a5
Merge pull request #5529 
de27651 use crypto::rand instead of libc rand in a few tests (moneromooo-monero)
 2019-07-24 14:06:11 -05:00
luigi1111 e3de4aa68b
Merge pull request #5502 
25a7cfd add a few checks where it seems appropriate (moneromooo-monero)
1a66a86 remove unused code (moneromooo-monero)
 2019-07-24 13:57:06 -05:00
Lee Clagett f91a06c6d7 Dropping cppzmq dependency; adding some zmq utils 2019-07-22 06:37:16 +00:00
Lee Clagett 3b24b1d082 Added support for "noise" over I1P/Tor to mask Tx transmission. 2019-07-17 14:22:37 +00:00
Lee Clagett bdfc63ae4d Add ref-counted buffer byte_slice. Currently used for sending TCP data. 2019-07-16 16:30:35 +00:00
moneromooo-monero 65c4004963
allow blocking whole subnets 2019-07-16 11:35:53 +00:00
moneromooo-monero b350726a5a
boost: update obsolete usage of endian API 2019-07-09 15:07:13 +00:00
moneromooo-monero c2238327d0
keccak: guard against misaligned memory accesses on ARM 
The code generated is exactly the same as the direct access
one on x86_64
 2019-07-04 22:13:16 +00:00
moneromooo-monero 7b18e838ea
unit_tests: check return values on test data parsing 
Won't trigger in practice, but you never know when that code changes

Coverity 199723, 199685
 2019-07-01 15:17:30 +00:00
moneromooo-monero f81cb4f24b
unit_tests: add more leeway to the "same distribution" check 
This is an inherently probabilistic check, which occasionally fails
for a matching distribution
 2019-06-16 12:18:28 +00:00
moneromooo-monero dbecfe7d5d
unit_tests: make the density test a bit less stringent 
It's an inherently random test
 2019-05-20 10:42:50 +00:00
moneromooo-monero de27651f80
use crypto::rand instead of libc rand in a few tests 
We don't need secure randomness here, but it should shut coverity up
 2019-05-10 14:15:35 +00:00
Riccardo Spagni f64f59627d
Merge pull request #5510 
e9809382 fix wide difficulty conversion with some versions of boost (moneromooo-monero)
 2019-05-07 17:36:27 +02:00
Riccardo Spagni 97cb1c9436
Merge pull request #5508 
1c44e658 wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
 2019-05-07 17:35:28 +02:00
Riccardo Spagni 2d04b0e500
Merge pull request #5499 
a4c4a2d8 blockchain: keep a rolling long term block weight median (moneromooo-monero)
 2019-05-07 17:31:45 +02:00
Riccardo Spagni 9d91301faa
Merge pull request #5496 
0eb0d6b8 rpc: improve get_output_distribution (moneromooo-monero)
 2019-05-07 17:30:27 +02:00
moneromooo-monero a4c4a2d8aa
blockchain: keep a rolling long term block weight median 2019-05-02 09:47:01 +00:00
moneromooo-monero e980938210
fix wide difficulty conversion with some versions of boost 2019-05-01 19:58:09 +00:00
moneromooo-monero 1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API 2019-05-01 18:41:39 +00:00
moneromooo-monero 1a66a86f94
remove unused code 2019-04-29 20:52:40 +00:00
moneromooo-monero 25a7cfdb4a
add a few checks where it seems appropriate 2019-04-29 20:52:40 +00:00
moneromooo-monero a59c27465b
unit_tests: fix crash in debug in output_distribution test 
updating the block size limit needs recent block sizes,
so we feed it dummy ones
 2019-04-25 22:49:10 +00:00
moneromooo-monero 0eb0d6b802
rpc: improve get_output_distribution 
It can now handle small reorgs without having to rescan the
whole blockchain.

Also add a test for it.
 2019-04-25 16:49:29 +00:00
moneromooo-monero c07366430a
unit_tests: don't delete log file on windows, it will fail 2019-04-23 15:27:54 +00:00
Lee Clagett 55aae6a9a3 Fix socks tests in windows and handle errors better 2019-04-19 01:10:02 -04:00
moneromooo-monero 35e0a968bd
wallet2: "output lineup" fake out selection 
Based on python code by sarang:
https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
 2019-04-18 15:14:38 +00:00
Riccardo Spagni e9464eb5e3
Merge pull request #5413 
5fafb90e testdb: add override keyword where missing (stoffu)
 2019-04-17 08:27:36 +02:00
stoffu 5fafb90e91
testdb: add override keyword where missing 
and delete obsolete BlockchainBDB::get_tx_output_indices along the way
 2019-04-17 10:26:25 +09:00
moneromooo-monero e3dea47859
unit_tests: undo is_blocked implementation factoring 
The is_host_blocked method is not on master yet
 2019-04-16 22:23:15 +00:00
Riccardo Spagni 8d16e92dcb
Merge pull request #5425 
58585986 p2p: fix integer overflow in host bans (moneromooo-monero)
 2019-04-16 22:38:56 +02:00
Riccardo Spagni a1ea611e24
Merge pull request #5424 
93bb2f48 ringct: prevent use of full ringct signatures for more than one input (moneromooo-monero)
 2019-04-16 22:38:32 +02:00
Riccardo Spagni 0d2aaac15b
Merge pull request #5414 
e9fac29a unit_tests/long_term_block_weight: some tweaks that seem to make more sense (stoffu)
467f4c7e tests/block_weight: use integer division when computing median (stoffu)
815d08dc tests/block_weight: remove unused MULTIPLIER_SMALL (stoffu)
661f1fb8 blockchain: remove unused calc of short_term_constraint (stoffu)
 2019-04-16 22:37:02 +02:00
moneromooo-monero 5e673c03fe
blockchain_db: fix db txn ending too early 
The db txn in add_block ending caused the entire overarching
batch txn to stop.
Also add a new guard class so a db txn can be stopped in the
face of exceptions.

Also use a read only db txn in init when the db itself is
read only, and do not save the max tx size in that case.
 2019-04-14 08:35:38 +00:00
moneromooo-monero 5858598604
p2p: fix integer overflow in host bans 2019-04-11 21:59:27 +00:00
moneromooo-monero 93bb2f48f7
ringct: prevent use of full ringct signatures for more than one input 2019-04-11 19:44:06 +00:00
stoffu e9fac29a4b
unit_tests/long_term_block_weight: some tweaks that seem to make more sense 2019-04-09 20:21:45 +09:00
Riccardo Spagni c34930c207
Merge pull request #5391 
71907980 unit_tests: fix long term block weight test after cache change (moneromooo-monero)
 2019-04-06 16:04:27 +02:00
Riccardo Spagni c96fc4bf59
Merge pull request #5341 
0218bc49 test: hmac_keccak - fix number of chunks counting (Dusan Klinec)
 2019-04-06 15:57:28 +02:00
moneromooo-monero 7190798049
unit_tests: fix long term block weight test after cache change 2019-04-03 00:10:48 +00:00
Riccardo Spagni e55b3f9dda
Merge pull request #5239 
91f4c7f4 Make difficulty 128 bit instead of 64 bit (moneromooo-monero)
 2019-04-01 17:19:10 +02:00
Lee Clagett 7acfa9f3cc Added socks proxy (tor/i2pd/kovri) support to wallet 2019-03-25 01:35:13 +00:00
moneromooo-monero 91f4c7f45f
Make difficulty 128 bit instead of 64 bit 
Based on Boolberry work by:
  jahrsg <jahr@jahr.me>
  cr.zoidberg <crypto.zoidberg@gmail.com>
 2019-03-24 21:03:19 +00:00
Dusan Klinec 0218bc497d
test: hmac_keccak - fix number of chunks counting 2019-03-24 20:24:28 +01:00
Riccardo Spagni 37ee4acf48
Merge pull request #5274 
dc0c0c91 tests: disable wallet SSL init for tests involving wallet2 (moneromooo-monero)
 2019-03-24 19:35:11 +02:00
Riccardo Spagni 5ac46c5310
Merge pull request #5256 
4b21d38d blockchain: speed up getting N blocks weights/long term weights (moneromooo-monero)
 2019-03-21 14:48:40 +02:00
Riccardo Spagni 48e3a341f8
Merge pull request #5211 
c9b13fbb tests/trezor: HF9 and HF10 tests (Dusan Klinec)
a1fd1d49 device/trezor: HF10 support added, wallet::API (Dusan Klinec)
d74d26f2 crypto: hmac_keccak added (Dusan Klinec)
 2019-03-21 14:44:04 +02:00
Dusan Klinec d74d26f2c9
crypto: hmac_keccak added 2019-03-20 21:11:01 +01:00
Lee Clagett 0c7e7bce18 Adding classes, functions, and utilities for common LMDB operations. 2019-03-19 17:52:26 +00:00
moneromooo-monero dc0c0c91c5
tests: disable wallet SSL init for tests involving wallet2 2019-03-12 20:43:02 +00:00