From 7ac51c1af21b71e1136cc90ee7d52b4a1d0dbd0a Mon Sep 17 00:00:00 2001 From: Wade Simmons Date: Wed, 2 Oct 2024 10:46:34 -0400 Subject: [PATCH] fix roaming check We need to compare just the IPs here and not the IP+Port This is a regression with the merge of v1.9.4 and the change to netip.AddrPort - https://github.com/slackhq/nebula/pull/768/commits/dabce8a1b416e1c0a70ba1254597a31b0d555c79 --- outside.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/outside.go b/outside.go index 2746004..538e3e8 100644 --- a/outside.go +++ b/outside.go @@ -268,7 +268,7 @@ func (f *Interface) handleHostRoaming(hostinfo *HostInfo, ip netip.AddrPort) { if hostinfo.multiportRx { // If the remote is sending with multiport, we aren't roaming unless // the IP has changed - if hostinfo.remote.Compare(ip) == 0 { + if hostinfo.remote.Addr().Compare(ip.Addr()) == 0 { return } // Keep the port from the original hostinfo, because the remote is transmitting from multiport ports