Mirrors
/
noscript
mirror of https://github.com/hackademix/noscript.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Better timing feedback for permissions changes in the popup UI.

This commit is contained in:
hackademix 2018-08-28 23:40:20 +02:00
parent 5c3d5354f2
commit 22df979973
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/ui/popup.js
View File

@ -77,9 +77,10 @@ addEventListener("unload", e => {
let button = document.getElementById("enforce"); let button = document.getElementById("enforce");
button.setAttribute("aria-pressed", pressed); button.setAttribute("aria-pressed", pressed);
button.textContent = button.title = _(pressed ? "NoEnforcement" : "Enforce"); button.textContent = button.title = _(pressed ? "NoEnforcement" : "Enforce");
button.onclick = () => { button.onclick = async () => {
this.disabled = true;
policy.enforced = !pressed; policy.enforced = !pressed;
UI.updateSettings({policy, reloadAffected: true}); await UI.updateSettings({policy, reloadAffected: true});
close(); close();
} }
} }
@ -89,8 +90,9 @@ addEventListener("unload", e => {
button.setAttribute("aria-pressed", pressed); button.setAttribute("aria-pressed", pressed);
button.textContent = button.title = _(pressed ? "NoEnforcementForTab" : "EnforceForTab"); button.textContent = button.title = _(pressed ? "NoEnforcementForTab" : "EnforceForTab");
if (UI.policy.enforced) { if (UI.policy.enforced) {
button.onclick = () => { button.onclick = async () => {
UI.updateSettings({ this.disabled = true;
await UI.updateSettings({
unrestrictedTab: pressed, unrestrictedTab: pressed,
reloadAffected: true, reloadAffected: true,
}); });
@ -129,7 +131,7 @@ addEventListener("unload", e => {
error(e, "Could not run scripts on %s: privileged page?", tab.url); error(e, "Could not run scripts on %s: privileged page?", tab.url);
} }
await include("/lib/restricted.js"); await include("/lib/close\(ricted.js");
let isRestricted = isRestrictedURL(tab.url); let isRestricted = isRestrictedURL(tab.url);
if (!isHttp || isRestricted) { if (!isHttp || isRestricted) {
showMessage("warning", _("privilegedPage")); showMessage("warning", _("privilegedPage"));