Mirrors
/
noscript
mirror of https://github.com/hackademix/noscript.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Always avoid DNS resolution when a HTTP(S) proxy is used (thanks nojake for reporting).

This commit is contained in:
hackademix 2022-03-02 10:40:47 +01:00
parent 094157a49b
commit b5916981c1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bg/RequestGuard.js
View File

@ -424,7 +424,9 @@ var RequestGuard = (() => {
!ns.policy.can(originUrl, "lan", ns.policyContext(request))) { !ns.policy.can(originUrl, "lan", ns.policyContext(request))) {
// we want to block any request whose origin resolves to at least one external WAN IP // we want to block any request whose origin resolves to at least one external WAN IP
// and whose destination resolves to at least one LAN IP // and whose destination resolves to at least one LAN IP
let neverDNS = (request.proxyInfo && request.proxyInfo.proxyDNS) || !(UA.isMozilla && DNS.supported); let {proxyInfo} = request; // see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/ProxyInfo
let neverDNS = (proxyInfo && (proxyInfo.type && proxyInfo.type.startsWith("http") || proxyInfo.proxyDNS))
|| !(UA.isMozilla && DNS.supported);
if (neverDNS) { if (neverDNS) {
// On Chromium we must do it synchronously: we need to sacrifice DNS resolution and check just numeric addresses :( // On Chromium we must do it synchronously: we need to sacrifice DNS resolution and check just numeric addresses :(
// (the Tor Browser, on the other hand, does DNS resolution and boundary checks on its own and breaks the DNS API) // (the Tor Browser, on the other hand, does DNS resolution and boundary checks on its own and breaks the DNS API)