From 67d4360453e0316b494a43320e2e5df53a93d5ea Mon Sep 17 00:00:00 2001 From: Aarni Koskela Date: Fri, 19 May 2023 13:06:12 +0300 Subject: [PATCH] get_tab_index(): use a for loop with early-exit for performance --- javascript/ui.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/javascript/ui.js b/javascript/ui.js index f13e7b6c1..648a5290e 100644 --- a/javascript/ui.js +++ b/javascript/ui.js @@ -100,15 +100,13 @@ function switch_to_extras() { } function get_tab_index(tabId) { - var res = 0; - - gradioApp().getElementById(tabId).querySelector('div').querySelectorAll('button').forEach(function(button, i) { - if (button.className.indexOf('selected') != -1) { - res = i; + let buttons = gradioApp().getElementById(tabId).querySelector('div').querySelectorAll('button'); + for (let i = 0; i < buttons.length; i++) { + if (buttons[i].classList.contains('selected')) { + return i; } - }); - - return res; + } + return 0; } function create_tab_index_args(tabId, args) {