From 7b61acbd35e9db43a5279a42afad3f3dc68462c9 Mon Sep 17 00:00:00 2001
From: Thottyottyotty <thot@thiic.cc>
Date: Thu, 18 May 2023 23:43:01 -0700
Subject: [PATCH] split visibility method and sort instead

split out the visibility method for pasting and use a sort inside the paste handler to prioritize on-screen fields rather than targeting ONLY on screen fields
---
 javascript/dragdrop.js |  5 ++++-
 script.js              | 14 +++++++++-----
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/javascript/dragdrop.js b/javascript/dragdrop.js
index e316a3650..398a33f9e 100644
--- a/javascript/dragdrop.js
+++ b/javascript/dragdrop.js
@@ -81,7 +81,10 @@ window.addEventListener('paste', e => {
     }
 
     const visibleImageFields = [...gradioApp().querySelectorAll('[data-testid="image"]')]
-        .filter(el => uiElementIsVisible(el));
+        .filter(el => uiElementIsVisible(el))
+        .sort((a,b) => uiElementInSight(b) - uiElementInSight(a));
+
+
     if (!visibleImageFields.length) {
         return;
     }
diff --git a/script.js b/script.js
index 53390be32..f76127799 100644
--- a/script.js
+++ b/script.js
@@ -99,10 +99,14 @@ function uiElementIsVisible(el) {
     const computedStyle = getComputedStyle(el);
     const isVisible = computedStyle.display !== 'none';
 
-    const clRect = el.getBoundingClientRect();
-    const windowHeight = window.innerHeight;
-    const onScreen = clRect.bottom > 0 && clRect.top < windowHeight;
-
-    if (!isVisible || !onScreen) return false;
+    if (!isVisible) return false;
     return uiElementIsVisible(el.parentNode);
 }
+
+function uiElementInSight(el) {
+    const clRect = el.getBoundingClientRect();
+    const windowHeight = window.innerHeight;
+    const isOnScreen = clRect.bottom > 0 && clRect.top < windowHeight;
+
+    return isOnScreen;
+}