Mirrors/synapse-old - synapse-old - EVULID GITSERVER

1 line

105 B

Plaintext

Raw Normal View History

Remove cache for get_shared_rooms_for_users (#9416) This PR remove the cache for the `get_shared_rooms_for_users` storage method (the db method driving the experimental "what rooms do I share with this user?" feature: [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)). Currently subsequent requests to the endpoint will return the same result, even if your shared rooms with that user have changed. The cache was added in https://github.com/matrix-org/synapse/pull/7785, but we forgot to ensure it was invalidated appropriately. Upon attempting to invalidate it, I found that the cache had to be entirely invalidated whenever a user (remote or local) joined or left a room. This didn't make for a very useful cache, especially for a function that may or may not be called very often. Thus, I've opted to remove it instead of invalidating it.

2021-02-22 09:52:45 -07:00

Fix a bug that caused multiple calls to the experimental `shared_rooms` endpoint to return stale results.