Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4133 from matrix-org/travis/fix-terms-auth 

Fix logic error that prevented guests from seeing the privacy policy
This commit is contained in:
Richard van der Hoff 2018-11-02 10:50:43 +00:00 committed by GitHub
parent b199534518 552f090f62
commit 00f12e00f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/4133.feature Normal file
View File

@ -0,0 +1 @@
Add `m.login.terms` to the registration flow when consent tracking is enabled. **This makes the template arguments conditionally optional on a new `public_version` variable - update your privacy templates to support this.**

2
synapse/rest/consent/consent_resource.py
View File

@ -141,7 +141,7 @@ class ConsentResource(Resource):
username = parse_string(request, "u", required=False, default="")
userhmac = None
has_consented = False
public_version = username != ""
public_version = username == ""
if not public_version:
userhmac = parse_string(request, "h", required=True, encoding=None)