Fix exit condition

2019-10-31 23:01:26 +00:00 · 2019-10-31 23:01:26 +00:00 · 1586f2c7e7
parent 1c1268245d
commit 1586f2c7e7
1 changed files with 3 additions and 1 deletions
--- a/synapse/storage/data_stores/main/events_bg_updates.py
+++ b/synapse/storage/data_stores/main/events_bg_updates.py
@ -546,7 +546,9 @@ class EventsBackgroundUpdatesStore(BackgroundUpdateStore):
                txn, "event_store_labels", {"last_event_id": event_id}
            )

-            return len(rows) == batch_size
+            # We want to return true (to end the background update) only when
+            # the query returned with less rows than we asked for.
+            return len(rows) != batch_size

        end = yield self.runInteraction(
            desc="event_store_labels", func=_event_store_labels_txn