Merge pull request #2576 from maximevaillancourt/exclude-noscript-url-preview

Ignore <noscript> tags when generating URL preview descriptions
2017-11-07 11:09:22 +00:00 · 2017-11-07 11:09:22 +00:00 · 3db5ff69b2
parent ec12e7eada 5287e57c86
commit 3db5ff69b2
1 changed files with 8 additions and 1 deletions
--- a/synapse/rest/media/v1/preview_url_resource.py
+++ b/synapse/rest/media/v1/preview_url_resource.py
@ -520,7 +520,14 @@ def _calc_og(tree, media_uri):
            from lxml import etree

            TAGS_TO_REMOVE = (
-                "header", "nav", "aside", "footer", "script", "style", etree.Comment
+                "header",
+                "nav",
+                "aside",
+                "footer",
+                "script",
+                "noscript",
+                "style",
+                etree.Comment
            )

            # Split all the text nodes into paragraphs (by splitting on new