Mirrors
/
synapse-old
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary sets

This commit is contained in:
Erik Johnston 2016-06-01 15:45:37 +01:00
parent 9c26b390a2
commit 59f2d73522
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
synapse/push/bulk_push_rule_evaluator.py
View File

@ -79,25 +79,24 @@ def evaluator_for_event(event, hs, store, current_state):
# generating them for bot / AS users etc, we only do so for people who've # generating them for bot / AS users etc, we only do so for people who've
# sent a read receipt into the room. # sent a read receipt into the room.
all_in_room = set( local_users_in_room = set(
e.state_key for e in current_state.values() e.state_key for e in current_state.values()
if e.type == EventTypes.Member and e.membership == Membership.JOIN if e.type == EventTypes.Member and e.membership == Membership.JOIN
and hs.is_mine_id(e.state_key)
) )
local_users_in_room = set(uid for uid in all_in_room if hs.is_mine_id(uid))
# users in the room who have pushers need to get push rules run because # users in the room who have pushers need to get push rules run because
# that's how their pushers work # that's how their pushers work
if_users_with_pushers = yield store.get_if_users_have_pushers( if_users_with_pushers = yield store.get_if_users_have_pushers(
local_users_in_room local_users_in_room
) )
users_with_pushers = set( user_ids = set(
uid for uid, have_pusher in if_users_with_pushers.items() if have_pusher uid for uid, have_pusher in if_users_with_pushers.items() if have_pusher
) )
users_with_receipts = yield store.get_users_with_read_receipts_in_room(room_id) users_with_receipts = yield store.get_users_with_read_receipts_in_room(room_id)
# any users with pushers must be ours: they have pushers # any users with pushers must be ours: they have pushers
user_ids = set(users_with_pushers)
for uid in users_with_receipts: for uid in users_with_receipts:
if uid in local_users_in_room: if uid in local_users_in_room:
user_ids.add(uid) user_ids.add(uid)
@ -111,8 +110,6 @@ def evaluator_for_event(event, hs, store, current_state):
if has_pusher: if has_pusher:
user_ids.add(invited_user) user_ids.add(invited_user)
user_ids = list(user_ids)
rules_by_user = yield _get_rules(room_id, user_ids, store) rules_by_user = yield _get_rules(room_id, user_ids, store)
defer.returnValue(BulkPushRuleEvaluator( defer.returnValue(BulkPushRuleEvaluator(